[jira] [Assigned] (PROTON-1898) Memory leak related to sending
[ https://issues.apache.org/jira/browse/PROTON-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1898: --- Assignee: (was: Alan Conway) > Memory leak related to sending > -- > > Key: PROTON-1898 > URL: https://issues.apache.org/jira/browse/PROTON-1898 > Project: Qpid Proton > Issue Type: Bug > Components: go-binding >Affects Versions: proton-c-0.24.0 >Reporter: Christoph Scheiber >Priority: Major > > I started implementing a GO application using qpid electron. There is one > connection used to receive messages (at-least-once). It works nicely with low > memory consumption, multiple links and multiple go routines, 50 bytes > payload, up to 3000 msg/s > But as soon as the application starts sending messages (to reply over the > same connection) memory consumption is continuously growing up to 2GB where I > stopped. > Even if electron does not leave many options for wrong usage there might be > an issue in the application. > So I tried the qpid electron example > "https://github.com/apache/qpid-proton/blob/master/go/examples/electron/send.go;, > the same issue. > To reproduce it: > * use the sample program, I just added connection options for SASL PLAIN > * let it send 10 messages or more to one destination > My setup: > * windows 10 pro > * go1.10.2 windows/amd64 > * qpid 0.24.0-rc1 > * go files and lib build from same git repository clone and branch > * visual studio 2015, release build, no errors > * Broker: Solace VMR 8.11.0.1029 with different durable queues as source and > target > I tried also qpid proton 0.23.0 earlier, but saw the same problem. > I tried SendAsync and SendSync, both in 10-50 go routines in > parallel.Finally, with SendForget my worker routines were soon blocked and > did not come back. > Best regards > Christoph > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-447) Ruby types returned from Data should carry their AMQP type
[ https://issues.apache.org/jira/browse/PROTON-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-447: -- Assignee: (was: Alan Conway) > Ruby types returned from Data should carry their AMQP type > -- > > Key: PROTON-447 > URL: https://issues.apache.org/jira/browse/PROTON-447 > Project: Qpid Proton > Issue Type: Improvement > Components: ruby-binding >Reporter: Darryl L. Pierce >Priority: Minor > > When a value is pulled out of a Qpid::Proton::Data type, such as a float or > integer, it should somehow carry with it its AMQP type. So, for example, if > the value returned is a ulong (represented as a Fixnum) then that should be > attached to the Fixnum so that it can potentially be put back into another > Data instance without losing that detail. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1871) Ruby leaks memory sending messages
[ https://issues.apache.org/jira/browse/PROTON-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1871: --- Assignee: (was: Alan Conway) > Ruby leaks memory sending messages > -- > > Key: PROTON-1871 > URL: https://issues.apache.org/jira/browse/PROTON-1871 > Project: Qpid Proton > Issue Type: Bug > Components: ruby-binding >Affects Versions: proton-c-0.23.0 >Reporter: roi costas >Priority: Major > Attachments: out_amq.rb, valgrind.txt > > > We have developed a simple fluentd output plugin which only sends messages to > AMQ. Sending messages with sender.send, memory increases continuously and it > is never released, not even when message processing is stopped. > The qpid-proton code is really simple and we have checked that it is > sender.send the one that leaks memory. > I have run memory_profiler, and the leak does not seem to by in ruby but in > C++ code because both the number of objects and bytes remain between constant > values. I have tried to debug it with valgrind but I cannot find the source > class of the leak. > I have attached the ruby code, ruby version 2.3.4. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-768) DECIMAL32 values are not consistent in Ruby
[ https://issues.apache.org/jira/browse/PROTON-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-768: -- Assignee: (was: Alan Conway) > DECIMAL32 values are not consistent in Ruby > --- > > Key: PROTON-768 > URL: https://issues.apache.org/jira/browse/PROTON-768 > Project: Qpid Proton > Issue Type: Bug > Components: ruby-binding >Reporter: Darryl L. Pierce >Priority: Minor > Fix For: proton-c-future > > > On 32-bit EL6 running Ruby 1.8.7, DECIMAL32 values change. For example, the > following happened during running the rspec tests: > 2) A data object can hold a decimal32 >Failure/Error: expect(@data.decimal32).to eq(value) > > expected: 1161181977 > got: 1536795250 > > (compared using ==) ># ./spec/qpid/proton/data_spec.rb:304 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (PROTON-1643) [FreeBSD] ruby-old-example-test hangs
[
https://issues.apache.org/jira/browse/PROTON-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway closed PROTON-1643.
---
Resolution: Won't Fix
Those tests are outdated and have been removed.
> [FreeBSD] ruby-old-example-test hangs
> -
>
> Key: PROTON-1643
> URL: https://issues.apache.org/jira/browse/PROTON-1643
> Project: Qpid Proton
> Issue Type: Bug
> Components: ruby-binding
>Affects Versions: proton-c-0.18.0
> Environment: FreeBSD 10.3-RELEASE-p20
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
>Priority: Major
> Labels: freebsd
>
> When running ctest ruby-example-test hangs.
> If you examine the process list there is a process {{/usr/local/bin/ruby23
> reactor/broker.rb -a :26780}} that has not exited. If you kill that process
> the test fails but the test run carries on.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1643) [FreeBSD] ruby-old-example-test hangs
[
https://issues.apache.org/jira/browse/PROTON-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784959#comment-16784959
]
ASF subversion and git services commented on PROTON-1643:
-
Commit 34cc8bf85979187721223dbce579fc36eda29e6f in qpid-proton's branch
refs/heads/master from Alan Conway
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=34cc8bf ]
PROTON-1643: [ruby] remove outdated old-example-tests
> [FreeBSD] ruby-old-example-test hangs
> -
>
> Key: PROTON-1643
> URL: https://issues.apache.org/jira/browse/PROTON-1643
> Project: Qpid Proton
> Issue Type: Bug
> Components: ruby-binding
>Affects Versions: proton-c-0.18.0
> Environment: FreeBSD 10.3-RELEASE-p20
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
>Priority: Major
> Labels: freebsd
>
> When running ctest ruby-example-test hangs.
> If you examine the process list there is a process {{/usr/local/bin/ruby23
> reactor/broker.rb -a :26780}} that has not exited. If you kill that process
> the test fails but the test run carries on.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-227) Independent filtering of logging to consoles and log files.
[ https://issues.apache.org/jira/browse/DISPATCH-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned DISPATCH-227: Assignee: (was: Alan Conway) > Independent filtering of logging to consoles and log files. > --- > > Key: DISPATCH-227 > URL: https://issues.apache.org/jira/browse/DISPATCH-227 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Management Agent >Affects Versions: 0.5 >Reporter: Alan Conway >Priority: Minor > Fix For: Backlog > > > Currently the log filter settings are global, the same settings apply to > every log destination (files, consoles etc.) We need to be able to configure > different log filters on a per-console or per-file basis. We also need a new > log output type which sends log messges to an address that a console can > subscribe to. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1795) [cpp] imporved documentation for complex type mapping
[ https://issues.apache.org/jira/browse/PROTON-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1795: --- Assignee: (was: Alan Conway) > [cpp] imporved documentation for complex type mapping > - > > Key: PROTON-1795 > URL: https://issues.apache.org/jira/browse/PROTON-1795 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.21.0 >Reporter: Alan Conway >Priority: Major > > The complex type mapping section of the doc is brief and cryptic: > > [http://qpid.apache.org/releases/qpid-proton-0.21.0/proton/cpp/api/types_page.html] > > Needs review and improvement, including (but not limited to) > * explain why we allow conversion of AMQP maps to/from sequences: > order-preserving > * clarify use of #include files to enable all or selected conversions. > * include example code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1594) Expose remote host and port on transport
[ https://issues.apache.org/jira/browse/PROTON-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1594: --- Assignee: (was: Alan Conway) > Expose remote host and port on transport > > > Key: PROTON-1594 > URL: https://issues.apache.org/jira/browse/PROTON-1594 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: proton-c-0.18.0 >Reporter: Justin Ross >Priority: Major > Fix For: proton-c-future > > > So you can, for instance, log where you are connected to. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (PROTON-1688) [go] support encoding/decoding described arrays
[ https://issues.apache.org/jira/browse/PROTON-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway closed PROTON-1688. --- Resolution: Fixed Will be implemented as part of PROTON-2008 > [go] support encoding/decoding described arrays > --- > > Key: PROTON-1688 > URL: https://issues.apache.org/jira/browse/PROTON-1688 > Project: Qpid Proton > Issue Type: Bug > Components: go-binding >Affects Versions: proton-c-0.18.1 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-future > > > Add support for AMQP described arrays. > Most described types are already covered by amqp.Described, but arrays are a > special case. > An array of described values has the descriptor and type encoded only once, > followed by the undecorated values. Proton-C has a special API for this, it > is not the same as starting an array and then encoding each value with the > description. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1765) [ruby] auto-test of installed gem
[
https://issues.apache.org/jira/browse/PROTON-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway reassigned PROTON-1765:
---
Assignee: (was: Alan Conway)
> [ruby] auto-test of installed gem
> -
>
> Key: PROTON-1765
> URL: https://issues.apache.org/jira/browse/PROTON-1765
> Project: Qpid Proton
> Issue Type: Improvement
>Reporter: Alan Conway
>Priority: Trivial
>
> Restore the following tests to the ruby/CMakeLists.txt section that builds a
> gem:
> {code:java}
> # Test installing the gem.
> to_native_path("${bin}/install" gem_home)
> set(gem_env ${env_py} -- "GEM_HOME=${gem_home}"
> "LD_LIBRARY_PATH=${c_lib_dir}")
> add_test(
> NAME ruby-gem-install
> COMMAND ${gem_env} ${GEM_EXE} install "${GEM_FILE}" --
> "--with-qpid-proton-include=${CMAKE_SOURCE_DIR}/proton-c/include"
> "--with-qpid-proton-lib=${c_lib_dir}"
> )
> # Test running examples against the installed gem
> add_test(
> NAME ruby-gem-examples
> COMMAND ${gem_env} ${RUBY_EXECUTABLE} example_test.rb -v
> WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/examples/ruby
> )
> SET_TESTS_PROPERTIES(ruby-gem-examples PROPERTIES DEPENDS ruby-gem-install) #
> Run after install{code}
> This works on some platforms (fedora 26) but fails on Travis CI builds in
> the ruby-gem-examples test, e.g.
> [https://travis-ci.org/alanconway/qpid-proton/jobs/342502018]
> Doesn't seem to indicate a problem with the Gem, but rather with the test
> setup. The error is like this:
> {code:java}
> 2: Test command: /opt/pyenv/shims/python
> "/home/travis/build/alanconway/qpid-proton/proton-c/env.py" "--"
> "GEM_HOME=/home/travis/build/alanconway/qpid-proton/build/proton-c/bindings/ruby/install"
> "LD_LIBRARY_PATH=/home/travis/build/alanconway/qpid-proton/build/proton-c"
> "/home/travis/.rvm/rubies/ruby-2.4.1/bin/ruby" "example_test.rb" "-v"
> 2: Test timeout computed to be: 1500
> 2:
> /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in
> `require': incompatible library version -
> /home/travis/build/alanconway/qpid-proton/build/proton-c/bindings/ruby/install/gems/qpid_proton-0.21.0/lib/cproton.so
> (LoadError)
> 2:from
> /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in
> `require'
> 2:from
> /home/travis/build/alanconway/qpid-proton/build/proton-c/bindings/ruby/install/gems/qpid_proton-0.21.0/lib/qpid_proton.rb:19:in
> `'
> 2:from
> /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:133:in
> `require'
> 2:from
> /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:133:in
> `rescue in require'
> 2:from
> /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:40:in
> `require'
> 2:from example_test.rb:22:in `'
> 2/32 Test #2: ruby-gem-examples ***Failed0.15 sec{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1988) [cpp] streamable message support
[ https://issues.apache.org/jira/browse/PROTON-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1988: --- Assignee: (was: Alan Conway) > [cpp] streamable message support > > > Key: PROTON-1988 > URL: https://issues.apache.org/jira/browse/PROTON-1988 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: proton-c-0.26.0 >Reporter: Alan Conway >Priority: Major > > C++ API support for streaming large messages in chunks (too large to fit > entire message in memory) > The C link-level API does support streaming messages in chunks, but the C > message encoder/decoder and the proton::message type do. Provide an > alternative (or extended) C++ message type with a byte-stream API to > send/receive the body data in chunks, without every requiring the entire body > to be held in memory. > Use cases: > # Only the message body need be streamed. Properties are encoded/decode as a > unit before sending/receiving any of the body. Most client/endpoint > applications would work this way. > # The entire message, headers, properties and all, need to be streamed, with > support for partial decoding of an incoming message and efficient pass thru > (incoming to outgoing without decode/re-encode). Only advanced intermediaries > are likely to need this (e.g. this is what dispatch router does.) > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-855) Add axTLS (embedded SSL) support to proton-c
[ https://issues.apache.org/jira/browse/PROTON-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-855: -- Assignee: (was: Alan Conway) > Add axTLS (embedded SSL) support to proton-c > > > Key: PROTON-855 > URL: https://issues.apache.org/jira/browse/PROTON-855 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-c >Affects Versions: proton-0.9, proton-0.9.1, proton-0.10 > Environment: Platform independent >Reporter: Tomasz Nowicki >Priority: Major > Labels: features, patch > Fix For: proton-c-future > > Attachments: axtls.c, axtls_proton_example.c, qpidproton-AXTLS.patch, > ssl_io.h > > Original Estimate: 0h > Remaining Estimate: 0h > > The axTLS embedded SSL project is a highly configurable client/server > TLSv1 SSL library designed for platforms with small memory requirements. > It comes with a small HTTP/HTTPS server and additional test tools. > axTLS It's free! (BSD style licensing) > http://axtls.sourceforge.net/ > axTLS integration with proton is done on socket layer(posix layer). On the > other hand OpenSSL integration with proton is done on the transport layer. To > use both solutions we had to add two methods pn_ssl_recv i pn_ssl_send > (daclared in include/ssl_io.h) which in openssl mode, without crypting, > invoke native proton "pn_send" and "pn_receive (io.c)". In axTLS mode, those > methods are replaced with proper axtls comunication methods. Those are > defined in openssl.c, ssl_stub.c, axtls.c and located in src/ssl. > Methods pn_ssl_recv and pn_ssl_send replace original pn_send and pn_recv used > in pni_connection_writable(pn_selectable_t *sel), > pni_connection_readable(pn_selectable_t *sel) (connection.c). > Moreover we introduced new file axtls.c located in src/ssl. The file is an > equivalent of openssl.c, implementing base ssl methods: PN_EXTERN > pn_ssl_domain_t *pn_ssl_domain( pn_ssl_mode_t mode); > PN_EXTERN void pn_ssl_domain_free( pn_ssl_domain_t *domain ); etc > Example of axTLS integration with ex ActiveMQ > atatched(axtls_proton_example.c): > It's based on > http://mail-archives.us.apache.org/mod_mbox/qpid-proton/201501.mbox/%3ccacl1bnc5jerbnikd_4fgkjqh13h5nl_2z-sszp3jg2t+ywa...@mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1837) [c] client generates invalid attach/detach sequence
[
https://issues.apache.org/jira/browse/PROTON-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway reassigned PROTON-1837:
---
Assignee: (was: Alan Conway)
> [c] client generates invalid attach/detach sequence
> ---
>
> Key: PROTON-1837
> URL: https://issues.apache.org/jira/browse/PROTON-1837
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.22.0
>Reporter: Alan Conway
>Priority: Minor
>
> There is a disabled test to reproduce this problem, see
> test_duplicate_link_client() in
> [https://github.com/alanconway/qpid-proton/blob/master/c/tests/connection_driver.c#L498]
> pni_process does all pending link opens before all pending link closes, it
> does not respect the order of individual open/close calls in the code. This
> doesn't cause a problem for distinct links but if a link of the same name is
> opened/closed/reopened very quickly it can cause a problem:
> For example if l1 and l2 are both pn_links with name "x" then this sequence:
> {code:java}
> open(l1); close(l1); open(l2){code}
> generates this illegal protocol sequence:
> {code:java}
> attach("x"); attach("x"); detach(0) // 0 is the handle assigned to "x"{code}
> instead of the intended legal sequence:
> {code:java}
> attach("x"); detach(0); attach("x") // detach(0) detaches the first "x" so
> second "x" is allowed{code}
> NOTE: This applies to all endpoints, not just links but since connections and
> sessions don't have client-assignable names that can clash, the problem only
> shows up for links and only if the detach/attach for the same name is
> processed in the same transport batch. This is unlikely in practice and was
> discovered only because of investigation of PROTON-1832.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1258) Crash executing http test
[
https://issues.apache.org/jira/browse/DISPATCH-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway reassigned DISPATCH-1258:
-
Assignee: (was: Alan Conway)
> Crash executing http test
> -
>
> Key: DISPATCH-1258
> URL: https://issues.apache.org/jira/browse/DISPATCH-1258
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Routing Engine
>Affects Versions: 1.5.0
>Reporter: Chuck Rolke
>Priority: Major
> Attachments: DISPATCH-1258-ctest.txt
>
>
> Ctest fails with a router core. Text of ctest run posted separately.
> h3. Ctest command line
> ctest -VV -R system_tests_http
> h3. LibWebSockets version info
> libwebsockets-3.0.1-2.fc29.x86_64
> libwebsockets-devel-3.0.1-2.fc29.x86_64
> libwebsockets-debuginfo-3.0.1-2.fc29.x86_64
> libwebp-1.0.0-2.fc29.x86_64
> libwebsockets-debugsource-3.0.1-2.fc29.x86_64
> h3. GDB Backtrace
> {{gdb) bt}}
> {{#0 SSL_get0_alpn_selected (ssl=0x0, data=data@entry=0x7f064f343f20,
> len=len@entry=0x7f064f343f1c) at ssl/ssl_lib.c:2802}}
> {{#1 0x7f065dca5f3c in lws_tls_server_conn_alpn
> (wsi=wsi@entry=0x7f0640245ad0)}}
> {{ at
> /usr/src/debug/libwebsockets-3.0.1-2.fc29.x86_64/lib/tls/tls-server.c:76}}
> {{#2 0x7f065dca63b5 in lws_server_socket_service_ssl
> (wsi=wsi@entry=0x7f0640245ad0, accept_fd=accept_fd@entry=15)}}
> {{ at
> /usr/src/debug/libwebsockets-3.0.1-2.fc29.x86_64/lib/tls/tls-server.c:368}}
> {{#3 0x7f065dcaa21e in lws_adopt_descriptor_vhost (vh=,
> type=, fd=fd@entry=..., }}
> {{ vh_prot_name=vh_prot_name@entry=0x0, parent=parent@entry=0x0)}}
> {{ at
> /usr/src/debug/libwebsockets-3.0.1-2.fc29.x86_64/lib/roles/http/server/server.c:2036}}
> {{#4 0x7f065dca4547 in rops_handle_POLLIN_listen (pt=0x23f7830,
> wsi=0x7f0640086660, pollfd=0x23f9528)}}
> {{ at
> /usr/src/debug/libwebsockets-3.0.1-2.fc29.x86_64/lib/roles/listen/ops-listen.c:126}}
> {{#5 0x7f065dc9739b in lws_service_fd_tsi
> (context=context@entry=0x23f7790, pollfd=0x23f9528, tsi=tsi@entry=0)}}
> {{ at
> /usr/src/debug/libwebsockets-3.0.1-2.fc29.x86_64/lib/core/service.c:891}}
> {{#6 0x7f065dca81b0 in _lws_plat_service_tsi (context=0x23f7790,
> timeout_ms=, tsi=0)}}
> {{ at
> /usr/src/debug/libwebsockets-3.0.1-2.fc29.x86_64/lib/plat/lws-plat-unix.c:300}}
> {{#7 0x7f065dc97485 in lws_service (context=0x23f7790,
> timeout_ms=)}}
> {{ at
> /usr/src/debug/libwebsockets-3.0.1-2.fc29.x86_64/lib/core/service.c:958}}
> {{#8 0x7f065e1785dc in http_thread_run (v=0x241b9e0) at
> /home/chug/git/qpid-dispatch/src/http-libwebsockets.c:481}}
> {{#9 0x7f065e05058e in start_thread (arg=) at
> pthread_create.c:486}}
> {{#10 0x7f065dbbe6a3 in clone () at
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:95}}
> {{(gdb) }}{{}}{{}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1593) Add timestamps to trace output
[ https://issues.apache.org/jira/browse/PROTON-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1593: --- Assignee: (was: Alan Conway) > Add timestamps to trace output > -- > > Key: PROTON-1593 > URL: https://issues.apache.org/jira/browse/PROTON-1593 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.18.0 >Reporter: Justin Ross >Priority: Major > Labels: logging > Fix For: proton-c-future > > > The timestamps need not be wall clock time. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1883) add interop smoke test for examples
[ https://issues.apache.org/jira/browse/PROTON-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1883: --- Assignee: (was: Alan Conway) > add interop smoke test for examples > --- > > Key: PROTON-1883 > URL: https://issues.apache.org/jira/browse/PROTON-1883 > Project: Qpid Proton > Issue Type: Bug > Components: examples >Affects Versions: proton-c-0.23.0 >Reporter: Alan Conway >Priority: Major > > Add a simple interop smoke-test for the examples: run simple_send and > simple_receive against example brokers to verify that each language pair can > interoperate. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1840) [cpp] Nested complex types fail compilation with "incomplete type" error
[
https://issues.apache.org/jira/browse/PROTON-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway reassigned PROTON-1840:
---
Assignee: (was: Alan Conway)
> [cpp] Nested complex types fail compilation with "incomplete type" error
>
>
> Key: PROTON-1840
> URL: https://issues.apache.org/jira/browse/PROTON-1840
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
>Reporter: Kim van der Riet
>Priority: Major
> Labels: codec
>
> When using nested complex types (for example, a list of maps or an array of
> lists), the compiler fails to compile. For example, the following code
> snippet (saved as {{ctt.cpp}}):
> {noformat}
> #include
> #include
> #include
> int main(int, char**) {
> std::map m1 = {{uint8_t(0), "zero"},
> {uint8_t(1), "one"}};
> std::map m2 = {{true, "true"}, {false,
> "false"}};
> std::vector > am = {m1, m2};
> proton::value pv = am;
> }{noformat}
> fails compilation with the following error:
> {noformat}
> In file included from install/include/proton/types.hpp:47:0,
> from ctt.cpp:3:
> install/include/proton/./codec/vector.hpp: In instantiation of
> ‘proton::codec::encoder& proton::codec::operator<<(proton::codec::encoder&,
> const std::vector<_Tp, _Alloc>&) [with T = std::map proton::value>; A = std::allocator >]’:
> install/include/proton/./value.hpp:84:11: required from ‘typename
> proton::value::assignable::type
> proton::value::operator=(const T&) [with T =
> std::vector >; typename
> proton::value::assignable::type = proton::value&]’
> install/include/proton/./value.hpp:79:85: required from
> ‘proton::value::value(const T&, typename proton::value::assignable::type*)
> [with T = std::vector >; typename
> proton::value::assignable::type = void]’
> ctt.cpp:9:24: required from here
> install/include/proton/./codec/vector.hpp:39:31: error: incomplete type
> ‘proton::internal::type_id_of >’ used
> in nested name specifier
> return e << encoder::array(x, internal::type_id_of::value);
> ~~^~~
> {noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1987) [cpp] Encode/decode all legal message body types.
[ https://issues.apache.org/jira/browse/PROTON-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1987: --- Assignee: (was: Alan Conway) > [cpp] Encode/decode all legal message body types. > - > > Key: PROTON-1987 > URL: https://issues.apache.org/jira/browse/PROTON-1987 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: proton-c-0.26.0 >Reporter: Alan Conway >Priority: Major > > From AMQP spec > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#section-message-format] > _The body consists of one of the following three choices:_ > # _one or more > [data|http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-data] > sections,_ > # _one or more > [amqp-sequence|http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-amqp-sequence] > sections,_ > # _or a single > [amqp-value|http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-amqp-value] > section._ > It actually *is* currently possible to encode and decode all these body > formats using a combination of AMQP value types and the message::inferred() > flag. However, they way it works is not intuitive, and it is easy to encode > an illegal body format (e.g. mix section types) which won't be detected till > runtime. > A better API should: > * Make it easy to set/determine the body encoding style. > * Type safe API that can only encode legal body formats. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1665) Review locking - TLS / SSL thread safety with proactor
[ https://issues.apache.org/jira/browse/PROTON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1665: --- Assignee: (was: Alan Conway) > Review locking - TLS / SSL thread safety with proactor > -- > > Key: PROTON-1665 > URL: https://issues.apache.org/jira/browse/PROTON-1665 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.18.0 >Reporter: Alan Conway >Priority: Major > Labels: tls > Fix For: proton-c-future > > > ssl_domain objects are semi-global. > For example two connections simultaneously creating or releasing their own > private pn_ssl_t objects may mess up the refcount of the shared > pn_ssl_domain_t object leading to memory corruption or leaks. > Windows schannel is further complicated by the OS internal refcounting of its > security context thingies. That may get automatically solved by the above, > or may require a separate JIRA to track. The same may apply to openssl. > The obvious thread-safety issues were addressed by PROTON-1620 and the use > of per-transport SSL objects appears to be correct and safe. However we need > a careful review of the use of shared OpenSSL objects (related to SSL domains > and certificate stores) to ensure they are being used safely and no > additional locks are needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-778) [c] Optimize de-duplication of PN_LINK_FLOW events
[ https://issues.apache.org/jira/browse/PROTON-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-778: -- Assignee: (was: Alan Conway) > [c] Optimize de-duplication of PN_LINK_FLOW events > -- > > Key: PROTON-778 > URL: https://issues.apache.org/jira/browse/PROTON-778 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-0.8 >Reporter: Ken Giusti >Priority: Major > Labels: perf > > As per Rafi's suggestion on the proton mailing list: > http://mail-archives.apache.org/mod_mbox/qpid-proton/201412.mbox/%3CCACL1BnB5s6hTVA7KpjHKE02d1sLZb=PZPOQqpjUUeeaVk=g...@mail.gmail.com%3E > To summarize: emit the PN_LINK_FLOW event for local credit change only once > after all pending messages for a given link have been written to the > transport. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1615) c++: container leaks if exception thrown by handler.
[
https://issues.apache.org/jira/browse/PROTON-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway reassigned PROTON-1615:
---
Assignee: (was: Alan Conway)
> c++: container leaks if exception thrown by handler.
>
>
> Key: PROTON-1615
> URL: https://issues.apache.org/jira/browse/PROTON-1615
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
>Reporter: Alan Conway
>Priority: Major
> Labels: leak
>
> An exception throw by a handler is re-thrown out of container.run() as
> expected, however
> the container does not shut down cleanly and many leaks are reported by
> valgrind or asan. The container should be exception-safe.
> To demonstrate the problem apply this small patch to the helloworld_direct
> example.
> examples/cpp/helloworld_direct.cpp | 1 +
> modified examples/cpp/helloworld_direct.cpp
> @@ -53,6 +53,7 @@ class hello_world_direct : public proton::messaging_handler
> {
>
> // Receive one message and stop listener
> void on_message(proton::delivery &, proton::message ) OVERRIDE {
> +throw std::runtime_error("thrown from on_message");
> std::cout << m.body() << std::endl;
> listener.stop();
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-244) SASL library generates un-necessary DNS and LDAP requests
[
https://issues.apache.org/jira/browse/DISPATCH-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway reassigned DISPATCH-244:
Assignee: (was: Alan Conway)
> SASL library generates un-necessary DNS and LDAP requests
> -
>
> Key: DISPATCH-244
> URL: https://issues.apache.org/jira/browse/DISPATCH-244
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 0.5
>Reporter: Alan Conway
>Priority: Major
> Fix For: Backlog
>
> Attachments: A-perf-flamegraph-3075-work.svg,
> dispatch-244-gdb-backtrace.txt
>
>
> The dispatch system tests (e.g. system_tests_management) run very slowly when
> connected to a VPN.
> - about 10x slower on VPN configured to use TCP connection
> - about 5x slower on VPN configured for UDP connection
> Wireshark shows unexpected LDAP and DNS queries on the VPN interface.
> `wallace` below is the local host name, but is not mentioned in any tests so
> must be picked up by proton or dispatch at runtime:
> {code}
> 1 0.0 10.3.113.10810.11.6.1 LDAP242
> searchRequest(11) "dc=redhat,dc=com" wholeSubtree
> 2 0.035161000 10.3.113.10810.5.30.160 DNS 72
> Standard query 0xd03f A wallace.lab.bos.redhat.com
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1964) [c] pn_proactor_wait() can return empty event batches.
[
https://issues.apache.org/jira/browse/PROTON-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway reassigned PROTON-1964:
---
Assignee: (was: Alan Conway)
> [c] pn_proactor_wait() can return empty event batches.
> --
>
> Key: PROTON-1964
> URL: https://issues.apache.org/jira/browse/PROTON-1964
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Reporter: Alan Conway
>Priority: Major
> Fix For: proton-c-0.18.0
>
>
> The bug PROTON-1586 had events returned after a connection was
> TRANSPORT_CLOSED and no longer existed (original reproducer below) The bug
> still exists in a more subtle form - the proactor can return an *empty* event
> batch after TRANSPORT_CLOSED. This does not cause segfaults but is incorrect
> behavior according to the proactor documentation.
> To reproduce the problem see the comments in c/tests/pn_test_proactor.cpp in
> function proactor::wait_next().
> The fix to PROTON-1586 was to have the connection_driver batch to hide events
> after TRANSPORT_CLOSE by returning NULL as if the batch were empty. However,
> that is too late to prevent the batch being returned by the proactor - from
> the proactors perspective it is not empty, it contains
> CONNECTION_LOCAL_CLOSE but it looks empty to the user.
> This is really a bug in the pn_connection_driver, not the proactor, and it
> should be fixed there so that all proactors and non-proactor applications
> will benefit.
>
> Original reproducer:
> Run the send examples code with an invalid hostname like shown in the
> following -
> {noformat}
> [gmurthy@localhost build]$ pwd
> /home/gmurthy/opensource/qpid-proton/build
> [gmurthy@localhost build]$
> [gmurthy@localhost build]$
> [gmurthy@localhost build]$ examples/c/send nosuchhost
> PN_TRANSPORT_CLOSED: proton:io: No address associated with hostname - connect
> to nosuchhost:5672
> epoll proactor failure in
> /home/gmurthy/opensource/qpid-proton/proton-c/src/proactor/epoll.c:648:
> "arming polled file descriptor": No such file or directory
> Aborted (core dumped)
> [gmurthy@localhost build]$
> {noformat}
> The proactor code coredumps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1637) C++ binding relies on private symbols from proton-core library
[
https://issues.apache.org/jira/browse/PROTON-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway reassigned PROTON-1637:
---
Assignee: Andrew Stitcher (was: Alan Conway)
> C++ binding relies on private symbols from proton-core library
> --
>
> Key: PROTON-1637
> URL: https://issues.apache.org/jira/browse/PROTON-1637
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding, proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>
> The C++ binding relies on some "internal" symbols or the proton-core library
> Notably {{pni_message_with_extra()}} &{{pni_message_get_extra()}}. But also
> {{pni_log_enabled()}} etc. too
> The proton-core library is supposed to export everything needed by bindings
> publically so that there is no "under-the-covers" private agreement between
> them.
> There isn't really any other way to allow bindings to be generally written.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (PROTON-1577) c++ add uncounted wrapper for pn_xxx types
[ https://issues.apache.org/jira/browse/PROTON-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway closed PROTON-1577. --- Resolution: Won't Fix > c++ add uncounted wrapper for pn_xxx types > -- > > Key: PROTON-1577 > URL: https://issues.apache.org/jira/browse/PROTON-1577 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > > Proton refcounting is not thread safe, so it is important internally to avoid > accidental decref at an unsafe moment by the wrapper destructors. Provide an > uncounted wrapper template for internal use only, provides the same > functions as the normal wrapper class but with no automatic refcounting -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-448) Ruby bindings need to have their set calls updated to properly map values to pn_data_t*
[ https://issues.apache.org/jira/browse/PROTON-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved PROTON-448. Resolution: Fixed > Ruby bindings need to have their set calls updated to properly map values to > pn_data_t* > --- > > Key: PROTON-448 > URL: https://issues.apache.org/jira/browse/PROTON-448 > Project: Qpid Proton > Issue Type: Bug > Components: ruby-binding >Affects Versions: proton-0.5 >Reporter: Darryl L. Pierce >Assignee: Alan Conway >Priority: Major > > When using the APIs in Qpid::Proton::Data I'm seeing: > irb(main):001:0> require 'qpid_proton' > => true > irb(main):002:0> data = Qpid::Proton::Data.new > => # > irb(main):003:0> data.ubyte = 3 > value=3 > TypeError: Expected argument 0 of type pn_data_t *, but got Fixnum 16 > in SWIG method 'pn_data_put_ubyte' > from > /home/mcpierce/Programming/Proton/proton-c/bindings/ruby/lib/qpid_proton/data.rb:437:in > `pn_data_put_ubyte' > from > /home/mcpierce/Programming/Proton/proton-c/bindings/ruby/lib/qpid_proton/data.rb:437:in > `ubyte=' > from (irb):3 > from /usr/bin/irb:12:in `' -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-638) links never shrink the number of pooled delivery objects
[ https://issues.apache.org/jira/browse/PROTON-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-638: -- Assignee: (was: Alan Conway) > links never shrink the number of pooled delivery objects > > > Key: PROTON-638 > URL: https://issues.apache.org/jira/browse/PROTON-638 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: Rafael H. Schloming >Priority: Major > Labels: perf > Fix For: proton-c-future > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-6676) QPID 0.32 throughput drop sharply with HA module
[ https://issues.apache.org/jira/browse/QPID-6676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned QPID-6676: - Assignee: (was: Alan Conway) > QPID 0.32 throughput drop sharply with HA module > > > Key: QPID-6676 > URL: https://issues.apache.org/jira/browse/QPID-6676 > Project: Qpid > Issue Type: Bug > Components: C++ Broker, C++ Clustering >Affects Versions: 0.32, qpid-cpp-0.34 > Environment: CentOS6.5 X86_64 >Reporter: Robert Lee >Priority: Critical > > I build QPID 0.32 C++ broker with HA module on CentOS6.5 and run a cluster of > 2 nodes with --ha-replicate=all, Then send messages using QPID Messaging API > continuously with protocol AMQP0-10 and I meet a strange problem,If I purge > all of messages in a queue and continue to send messages,The throughput drop > sharply. And the same problem seen on QPID 0.34 > Steps to reproduce: > 1: > qpid-config add exchange direct testHA.exchange > qpid-config add queue testHA.queue --max-queue-size 1048576000 > qpid-config bind testHA.exchange testHA.queue testHA.binding > 2: > Run "qpid-queue-stats -f testHA.queue" on a console > 3: > Send 10 messages to testHA.exchange with routingkey testHA.binding > 4: > Purge queue use the QPID manager tool (qpid-tool) > 5: > Repeat step 3 > In the step 3, I can send about 8000 messages per second one producer, and In > step 4, I purge all messages in the queue, then send messages continue, I can > only send about 300 messages per second, But when I shutdown the backup node > the throughput back to normal -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1496) C epoll proactor needs better timer implementation for connections
[ https://issues.apache.org/jira/browse/PROTON-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1496: --- Assignee: Cliff Jansen (was: Alan Conway) > C epoll proactor needs better timer implementation for connections > -- > > Key: PROTON-1496 > URL: https://issues.apache.org/jira/browse/PROTON-1496 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.18.0 > Environment: Linux environments with epoll support >Reporter: Cliff Jansen >Assignee: Cliff Jansen >Priority: Major > > The epoll proactor allocates a timerfd per connection. This is a convenience > for the initial implementation and may surprise some applications running > into system limits on file descriptors twice as fast as expected. > The timer is used for heartbeats. It should be possible to write a > per-proactor heartbeat timer that is shared among the connections -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-584) Proton-c transport reserves large buffers for brief use
[ https://issues.apache.org/jira/browse/PROTON-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-584: -- Assignee: Andrew Stitcher (was: Alan Conway) > Proton-c transport reserves large buffers for brief use > --- > > Key: PROTON-584 > URL: https://issues.apache.org/jira/browse/PROTON-584 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-0.8 >Reporter: Cliff Jansen >Assignee: Andrew Stitcher >Priority: Major > Labels: perf > Fix For: proton-c-future > > > When processing transfer frames for incoming messages, Proton requires a > temporary buffer holding the whole transfer frame briefly in contiguous space > in the transport before moving it to the engine proper which holds the > content in a separate memory area. > pn_transport_capacity grows the buffer in the non-ssl case > (transport->input_buf), and openssl.c largely duplicates the code (including > the comment about "no limit") for ssl->inbuf for ssl connections. > Either way, a large message will trigger reserving a similarly large buffer > for the rest of the life of the connection. > Is it necessary for the transport to buffer the whole message body and hang > on to that memory? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1274) Optimize qd_timer_schedule(0)
[ https://issues.apache.org/jira/browse/DISPATCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784915#comment-16784915 ] ASF subversion and git services commented on DISPATCH-1274: --- Commit 48e62a11e67cf3a37b5e1f9862d07a939101cdb4 in qpid-dispatch's branch refs/heads/master from Alan Conway [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=48e62a1 ] DISPATCH-1274: Optimize qd_timer_schedule(0) Introduced pn_immediate_t, a simpler schedule for immediate requests. qd_timer_schedule delegates schedule(0) requests. > Optimize qd_timer_schedule(0) > -- > > Key: DISPATCH-1274 > URL: https://issues.apache.org/jira/browse/DISPATCH-1274 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.5.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > > qd_timer_schedule() uses the general timeout mechanisms which includes > checking system time (on schedule and on PN_PROACTOR_TIMEOUT wakeup) and > adding/removing work items from sorted list. Optimize the schedule(0) case as > a simple work_list using pn_proactor_interrupt() for wakeups. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1274) Optimize qd_timer_schedule(0)
[ https://issues.apache.org/jira/browse/DISPATCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784916#comment-16784916 ] ASF subversion and git services commented on DISPATCH-1274: --- Commit 077710c72a20f854e9fe0cbcd983ba68c4d72d10 in qpid-dispatch's branch refs/heads/master from Alan Conway [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=077710c ] DISPATCH-1274: Separate qd_timer_t lock from server qd_timer_t was sharing a lock with qd_server_t for historical reasons. Code inspection shows there is no need for the sharing. - timer.c calls qd_server_timeout() which is thread-safe, and no other server functions. - timer calls handlers outside the lock so it doesn't mater what lock is used. > Optimize qd_timer_schedule(0) > -- > > Key: DISPATCH-1274 > URL: https://issues.apache.org/jira/browse/DISPATCH-1274 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.5.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > > qd_timer_schedule() uses the general timeout mechanisms which includes > checking system time (on schedule and on PN_PROACTOR_TIMEOUT wakeup) and > adding/removing work items from sorted list. Optimize the schedule(0) case as > a simple work_list using pn_proactor_interrupt() for wakeups. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1274) Optimize qd_timer_schedule(0)
[ https://issues.apache.org/jira/browse/DISPATCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved DISPATCH-1274. --- Resolution: Fixed Fix Version/s: 1.6.0 > Optimize qd_timer_schedule(0) > -- > > Key: DISPATCH-1274 > URL: https://issues.apache.org/jira/browse/DISPATCH-1274 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.5.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: 1.6.0 > > > qd_timer_schedule() uses the general timeout mechanisms which includes > checking system time (on schedule and on PN_PROACTOR_TIMEOUT wakeup) and > adding/removing work items from sorted list. Optimize the schedule(0) case as > a simple work_list using pn_proactor_interrupt() for wakeups. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1277) max-frame-size defaults to 2147483647 if it is not specified in the policy
[
https://issues.apache.org/jira/browse/DISPATCH-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784855#comment-16784855
]
ASF subversion and git services commented on DISPATCH-1277:
---
Commit fb7731ba0f73b88f741002c440837cee9ac3afe8 in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=fb7731b ]
DISPATCH-1277 - Removed accidental inclusion of property allowAdminStatusUpdate
> max-frame-size defaults to 2147483647 if it is not specified in the policy
> --
>
> Key: DISPATCH-1277
> URL: https://issues.apache.org/jira/browse/DISPATCH-1277
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.6.0
>
>
> Start a router with the following policy
> {noformat}
> ##
> ## Licensed to the Apache Software Foundation (ASF) under one
> ## or more contributor license agreements. See the NOTICE file
> ## distributed with this work for additional information
> ## regarding copyright ownership. The ASF licenses this file
> ## to you under the Apache License, Version 2.0 (the
> ## "License"); you may not use this file except in compliance
> ## with the License. You may obtain a copy of the License at
> ##
> ## http://www.apache.org/licenses/LICENSE-2.0
> ##
> ## Unless required by applicable law or agreed to in writing,
> ## software distributed under the License is distributed on an
> ## "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> ## KIND, either express or implied. See the License for the
> ## specific language governing permissions and limitations
> ## under the License
> ##
> [
> ["vhost", {
> "hostname": "$default",
> "allowUnknownUser": true,
> "groups" : {
> "$default": {
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "allowAdminStatusUpdate": true,
> "targets": "*",
> "sources": "*"
> }
> }
> }
> ]
> ]{noformat}
> Notice that the above policy does not specify a maxFrameSize.
> According to the router schema documentation seen here -
> [https://github.com/apache/qpid-dispatch/blob/master/python/qpid_dispatch/management/qdrouter.json#L1815]
> - the maxFrameSize must default to 16k
> {noformat}
> "maxFrameSize": {
> "type": "integer",
> "description": "The largest frame, in bytes, that may be sent on this
> connection. Non-zero policy values overwrite values specified for a listener
> object (AMQP Open, max-frame-size).",
> "default": 16384,
> "required": false,
> "create": true
> },{noformat}
> Instead it is defaulting to 2147483647 as seen here -
> {noformat}
> [0x5650918bfc90]:0 <- @open(16) [container-id="QDR",
> max-frame-size=2147483647, channel-max=32767, idle-time-out=6,
> offered-capabilities=:"ANONYMOUS-RELAY",
> properties={:product="qpid-dispatch-router", :version="1.6.0-SNAPSHOT",
> :"qd.conn-id"=6}]{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1277) max-frame-size defaults to 2147483647 if it is not specified in the policy
[
https://issues.apache.org/jira/browse/DISPATCH-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1277.
-
Resolution: Fixed
> max-frame-size defaults to 2147483647 if it is not specified in the policy
> --
>
> Key: DISPATCH-1277
> URL: https://issues.apache.org/jira/browse/DISPATCH-1277
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.6.0
>
>
> Start a router with the following policy
> {noformat}
> ##
> ## Licensed to the Apache Software Foundation (ASF) under one
> ## or more contributor license agreements. See the NOTICE file
> ## distributed with this work for additional information
> ## regarding copyright ownership. The ASF licenses this file
> ## to you under the Apache License, Version 2.0 (the
> ## "License"); you may not use this file except in compliance
> ## with the License. You may obtain a copy of the License at
> ##
> ## http://www.apache.org/licenses/LICENSE-2.0
> ##
> ## Unless required by applicable law or agreed to in writing,
> ## software distributed under the License is distributed on an
> ## "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> ## KIND, either express or implied. See the License for the
> ## specific language governing permissions and limitations
> ## under the License
> ##
> [
> ["vhost", {
> "hostname": "$default",
> "allowUnknownUser": true,
> "groups" : {
> "$default": {
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "allowAdminStatusUpdate": true,
> "targets": "*",
> "sources": "*"
> }
> }
> }
> ]
> ]{noformat}
> Notice that the above policy does not specify a maxFrameSize.
> According to the router schema documentation seen here -
> [https://github.com/apache/qpid-dispatch/blob/master/python/qpid_dispatch/management/qdrouter.json#L1815]
> - the maxFrameSize must default to 16k
> {noformat}
> "maxFrameSize": {
> "type": "integer",
> "description": "The largest frame, in bytes, that may be sent on this
> connection. Non-zero policy values overwrite values specified for a listener
> object (AMQP Open, max-frame-size).",
> "default": 16384,
> "required": false,
> "create": true
> },{noformat}
> Instead it is defaulting to 2147483647 as seen here -
> {noformat}
> [0x5650918bfc90]:0 <- @open(16) [container-id="QDR",
> max-frame-size=2147483647, channel-max=32767, idle-time-out=6,
> offered-capabilities=:"ANONYMOUS-RELAY",
> properties={:product="qpid-dispatch-router", :version="1.6.0-SNAPSHOT",
> :"qd.conn-id"=6}]{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1277) max-frame-size defaults to 2147483647 if it is not specified in the policy
[
https://issues.apache.org/jira/browse/DISPATCH-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784850#comment-16784850
]
ASF subversion and git services commented on DISPATCH-1277:
---
Commit 055ac6b05086cd12e843c25ff691271047da5a4c in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=055ac6b ]
DISPATCH-1277 - Defaulted the policy max-frame-size default to 16384 to comply
with the maxFrameSize default in vhostUserGroupSettings
> max-frame-size defaults to 2147483647 if it is not specified in the policy
> --
>
> Key: DISPATCH-1277
> URL: https://issues.apache.org/jira/browse/DISPATCH-1277
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.6.0
>
>
> Start a router with the following policy
> {noformat}
> ##
> ## Licensed to the Apache Software Foundation (ASF) under one
> ## or more contributor license agreements. See the NOTICE file
> ## distributed with this work for additional information
> ## regarding copyright ownership. The ASF licenses this file
> ## to you under the Apache License, Version 2.0 (the
> ## "License"); you may not use this file except in compliance
> ## with the License. You may obtain a copy of the License at
> ##
> ## http://www.apache.org/licenses/LICENSE-2.0
> ##
> ## Unless required by applicable law or agreed to in writing,
> ## software distributed under the License is distributed on an
> ## "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> ## KIND, either express or implied. See the License for the
> ## specific language governing permissions and limitations
> ## under the License
> ##
> [
> ["vhost", {
> "hostname": "$default",
> "allowUnknownUser": true,
> "groups" : {
> "$default": {
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "allowAdminStatusUpdate": true,
> "targets": "*",
> "sources": "*"
> }
> }
> }
> ]
> ]{noformat}
> Notice that the above policy does not specify a maxFrameSize.
> According to the router schema documentation seen here -
> [https://github.com/apache/qpid-dispatch/blob/master/python/qpid_dispatch/management/qdrouter.json#L1815]
> - the maxFrameSize must default to 16k
> {noformat}
> "maxFrameSize": {
> "type": "integer",
> "description": "The largest frame, in bytes, that may be sent on this
> connection. Non-zero policy values overwrite values specified for a listener
> object (AMQP Open, max-frame-size).",
> "default": 16384,
> "required": false,
> "create": true
> },{noformat}
> Instead it is defaulting to 2147483647 as seen here -
> {noformat}
> [0x5650918bfc90]:0 <- @open(16) [container-id="QDR",
> max-frame-size=2147483647, channel-max=32767, idle-time-out=6,
> offered-capabilities=:"ANONYMOUS-RELAY",
> properties={:product="qpid-dispatch-router", :version="1.6.0-SNAPSHOT",
> :"qd.conn-id"=6}]{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher merged pull request #178: NO-JIRA: [c] Fix two warnings from clang-analyzer
astitcher merged pull request #178: NO-JIRA: [c] Fix two warnings from clang-analyzer URL: https://github.com/apache/qpid-proton/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on issue #179: NO-JIRA: [c] missing break in send-ssl.c example
astitcher commented on issue #179: NO-JIRA: [c] missing break in send-ssl.c example URL: https://github.com/apache/qpid-proton/pull/179#issuecomment-469820797 I agree it's wrong (although actually harmless) . It's fairly harmless because the event will have no link and pn_link_credit will return 0 if it is called with no link - although maybe it should just error! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784579#comment-16784579
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 4e8de69b6c3e69caa585c679de680d223bbbe90c in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4e8de69 ]
DISPATCH-1268 - Set cmake_minimum_required to VERSION 2.8.12
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784580#comment-16784580
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 7987437dbe321a0a604767d39e8c13b180278860 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7987437 ]
DISPATCH-1268 - Use a "Generator expression" to get .so file name
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784581#comment-16784581
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 04a3ffb36e984eb13a9638e7d05872350ee44a66 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=04a3ffb ]
DISPATCH-1268 - Use find_library wherever possible
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784578#comment-16784578
]
ASF GitHub Bot commented on DISPATCH-1268:
--
jdanekrh commented on pull request #449: DISPATCH-1268 - Set
cmake_minimum_required to VERSION 2.8.12
URL: https://github.com/apache/qpid-dispatch/pull/449
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784582#comment-16784582
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 8a47be06341624aeb8f98738e24c8cc9ef7f4481 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8a47be0 ]
DISPATCH-1268 - Create cmake/RuntimeChecks.cmake to separate this configuration
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784583#comment-16784583
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 39c7fb3e5a99045fdce5c314bd44e37f9b265191 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=39c7fb3 ]
DISPATCH-1268 - Assorted small tweaks
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh merged pull request #449: DISPATCH-1268 - Set cmake_minimum_required to VERSION 2.8.12
jdanekrh merged pull request #449: DISPATCH-1268 - Set cmake_minimum_required to VERSION 2.8.12 URL: https://github.com/apache/qpid-dispatch/pull/449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8282) [JMS AMQP 0-x] Java 11 build/runtime failure due to use of javax.xml.bind.DatatypeConverter
Robbie Gemmell created QPID-8282: Summary: [JMS AMQP 0-x] Java 11 build/runtime failure due to use of javax.xml.bind.DatatypeConverter Key: QPID-8282 URL: https://issues.apache.org/jira/browse/QPID-8282 Project: Qpid Issue Type: Bug Components: JMS AMQP 0-x Affects Versions: qpid-java-client-0-x-6.3.3 Reporter: Robbie Gemmell In setting up a new system, I happened to make attempt to build the JMS AMQP 0-x client using Java 11. It failed to compile due to use of javax.xml.bind.DatatypeConverter for Base64 handling in the SCRAM-SHA mechanisms. This prevents building on Java 11, and would break use of SCRAM-SHA while running on Java 11 assuming nothing else stopped things working. Although the 0-x client is essentially in maintenance/legacy mode at this point, blockers as trivial as Base 64 handling would be nice to resolved if it made using Java 11 possible, if only to simplify migrations later. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1276) Spontaneous drop of client connection causes crash on edge router
[ https://issues.apache.org/jira/browse/DISPATCH-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reassigned DISPATCH-1276: --- Assignee: Ganesh Murthy > Spontaneous drop of client connection causes crash on edge router > - > > Key: DISPATCH-1276 > URL: https://issues.apache.org/jira/browse/DISPATCH-1276 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.5.0 > Environment: Proton version 0.28.0 >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Blocker > Fix For: 1.6.0 > > Attachments: 0001-delete-me.patch > > > I can cause the router to crash by applying the attached patch, rebuilding > with CMAKE_BUILD_TYPE=Debug, and running cmake -VV -R tests_edge_router > This will cause a bunch of tests to fail, but then a crash will occur with > the following traceback (on current master): > #0 0x7f4dbc571e82 in qdr_forward_deliver_CT (core=0x2202e60, > out_link=0x, out_dlv=0x7f4d9034de68) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:201 > #1 0x7f4dbc568d98 in qdrc_endpoint_send_CT (core=0x2202e60, > ep=0x7f4da009f168, dlv=0x7f4d9034de68, presettled=true) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_link_endpoint.c:126 > #2 0x7f4dbc591364 in qdrc_send_message (core=0x2202e60, > addr=0x7f4da0031f68, endpoint=0x7f4da009f168, insert_addr=false) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:181 > #3 0x7f4dbc5916d0 in on_addr_event (context=0x7f4da0050050, > event=524288, addr=0x7f4da0031f68) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:249 > #4 0x7f4dbc5686b6 in qdrc_event_addr_raise (core=0x2202e60, > event=524288, addr=0x7f4da0031f68) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_events.c:114 > #5 0x7f4dbc57c325 in qdr_core_unbind_address_link_CT (core=0x2202e60, > addr=0x7f4da0031f68, link=0x22c49a8) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:562 > #6 0x7f4dbc567932 in qdr_link_inbound_detach_CT (core=0x2202e60, > action=0x7f4d9003e268, discard=false) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:1660 > #7 0x7f4dbc57e179 in router_core_thread (arg=0x2202e60) at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:148 > #8 0x7f4dbbe84594 in start_thread () from /lib64/libpthread.so.0 > #9 0x7f4dbb133f4f in clone () from /lib64/libc.so.6 > And on 1.5.0: > #0 0x7f30e6bc55dc in qdrc_endpoint_delivery_CT (core=0x14219a0, > endpoint=0x, message=0x7f30c4226468) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_link_endpoint.c:137 > #1 0x7f30e6bed632 in qdrc_send_message (core=0x14219a0, > addr=0x7f30cc031f68, endpoint=0x, insert_addr=false) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:179 > #2 0x7f30e6bed9c4 in on_addr_event (context=0x7f30cc050050, > event=524288, addr=0x7f30cc031f68) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:249 > #3 0x7f30e6bc4e8d in qdrc_event_addr_raise (core=0x14219a0, > event=524288, addr=0x7f30cc031f68) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_events.c:114 > #4 0x7f30e6bd868a in qdr_core_unbind_address_link_CT (core=0x14219a0, > addr=0x7f30cc031f68, link=0x7f30c80ac568) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:504 > #5 0x7f30e6bc40c5 in qdr_link_inbound_detach_CT (core=0x14219a0, > action=0x161bba8, discard=false) > at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:1657 > #6 0x7f30e6bda368 in router_core_thread (arg=0x14219a0) at > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:124 > #7 0x7f30e64e1594 in start_thread () from /lib64/libpthread.so.0 > #8 0x7f30e5790f4f in clone () from /lib64/libc.so.6 > It appears as though a endpoint context for the edge_addr_tracking module has > been referenced after it has been freed. > On further testing it appears as if the endpoint context is being referenced > by multiple qdr_link_t which should not happen. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands,
[jira] [Created] (DISPATCH-1276) Spontaneous drop of client connection causes crash on edge router
Ken Giusti created DISPATCH-1276: Summary: Spontaneous drop of client connection causes crash on edge router Key: DISPATCH-1276 URL: https://issues.apache.org/jira/browse/DISPATCH-1276 Project: Qpid Dispatch Issue Type: Bug Components: Routing Engine Affects Versions: 1.5.0 Environment: Proton version 0.28.0 Reporter: Ken Giusti Fix For: 1.6.0 Attachments: 0001-delete-me.patch I can cause the router to crash by applying the attached patch, rebuilding with CMAKE_BUILD_TYPE=Debug, and running cmake -VV -R tests_edge_router This will cause a bunch of tests to fail, but then a crash will occur with the following traceback (on current master): #0 0x7f4dbc571e82 in qdr_forward_deliver_CT (core=0x2202e60, out_link=0x, out_dlv=0x7f4d9034de68) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:201 #1 0x7f4dbc568d98 in qdrc_endpoint_send_CT (core=0x2202e60, ep=0x7f4da009f168, dlv=0x7f4d9034de68, presettled=true) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_link_endpoint.c:126 #2 0x7f4dbc591364 in qdrc_send_message (core=0x2202e60, addr=0x7f4da0031f68, endpoint=0x7f4da009f168, insert_addr=false) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:181 #3 0x7f4dbc5916d0 in on_addr_event (context=0x7f4da0050050, event=524288, addr=0x7f4da0031f68) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:249 #4 0x7f4dbc5686b6 in qdrc_event_addr_raise (core=0x2202e60, event=524288, addr=0x7f4da0031f68) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_events.c:114 #5 0x7f4dbc57c325 in qdr_core_unbind_address_link_CT (core=0x2202e60, addr=0x7f4da0031f68, link=0x22c49a8) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:562 #6 0x7f4dbc567932 in qdr_link_inbound_detach_CT (core=0x2202e60, action=0x7f4d9003e268, discard=false) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:1660 #7 0x7f4dbc57e179 in router_core_thread (arg=0x2202e60) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:148 #8 0x7f4dbbe84594 in start_thread () from /lib64/libpthread.so.0 #9 0x7f4dbb133f4f in clone () from /lib64/libc.so.6 And on 1.5.0: #0 0x7f30e6bc55dc in qdrc_endpoint_delivery_CT (core=0x14219a0, endpoint=0x, message=0x7f30c4226468) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_link_endpoint.c:137 #1 0x7f30e6bed632 in qdrc_send_message (core=0x14219a0, addr=0x7f30cc031f68, endpoint=0x, insert_addr=false) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:179 #2 0x7f30e6bed9c4 in on_addr_event (context=0x7f30cc050050, event=524288, addr=0x7f30cc031f68) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:249 #3 0x7f30e6bc4e8d in qdrc_event_addr_raise (core=0x14219a0, event=524288, addr=0x7f30cc031f68) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_events.c:114 #4 0x7f30e6bd868a in qdr_core_unbind_address_link_CT (core=0x14219a0, addr=0x7f30cc031f68, link=0x7f30c80ac568) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:504 #5 0x7f30e6bc40c5 in qdr_link_inbound_detach_CT (core=0x14219a0, action=0x161bba8, discard=false) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:1657 #6 0x7f30e6bda368 in router_core_thread (arg=0x14219a0) at /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:124 #7 0x7f30e64e1594 in start_thread () from /lib64/libpthread.so.0 #8 0x7f30e5790f4f in clone () from /lib64/libc.so.6 It appears as though a endpoint context for the edge_addr_tracking module has been referenced after it has been freed. On further testing it appears as if the endpoint context is being referenced by multiple qdr_link_t which should not happen. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784341#comment-16784341
]
ASF GitHub Bot commented on DISPATCH-1268:
--
jdanekrh commented on issue #449: DISPATCH-1268 - Set cmake_minimum_required to
VERSION 2.8.12
URL: https://github.com/apache/qpid-dispatch/pull/449#issuecomment-469646008
I'll merge this later today if no one objects. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
