[jira] [Created] (DISPATCH-1295) reduce cpu and locking in timer/immediate code.
Cliff Jansen created DISPATCH-1295: -- Summary: reduce cpu and locking in timer/immediate code. Key: DISPATCH-1295 URL: https://issues.apache.org/jira/browse/DISPATCH-1295 Project: Qpid Dispatch Issue Type: Improvement Components: Container Affects Versions: 1.6.0 Reporter: Cliff Jansen Follow on to DISPATCH-1274. Locks held for longer time than necessary (through system calls). Spurious calls to timer_visit() that should be restricted to immediate_visit(). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #472: Dispatch 1288 1 - policy for outbound connectors
codecov-io commented on issue #472: Dispatch 1288 1 - policy for outbound connectors URL: https://github.com/apache/qpid-dispatch/pull/472#issuecomment-474588568 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr&el=h1) Report > Merging [#472](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/bdafbbe02f2762ec3c38bc254e59c3efa9b23c9e?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `97.36%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #472 +/- ## == + Coverage 86.68% 86.73% +0.04% == Files 86 86 Lines 1908819127 +39 == + Hits1654716590 +43 + Misses 2541 2537 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `79.43% <100%> (+0.56%)` | :arrow_up: | | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `89.36% <100%> (+0.04%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.87% <100%> (+0.17%)` | :arrow_up: | | [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree#diff-c3JjL3BvbGljeS5j) | `85.73% <97.1%> (+0.44%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `88.29% <0%> (-0.26%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `93.45% <0%> (-0.22%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.67% <0%> (+0.12%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `91.11% <0%> (+0.14%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `76.92% <0%> (+0.24%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr&el=footer). Last update [bdafbbe...1ac0944](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR opened a new pull request #472: Dispatch 1288 1 - policy for outbound connectors
ChugR opened a new pull request #472: Dispatch 1288 1 - policy for outbound connectors URL: https://github.com/apache/qpid-dispatch/pull/472 This PR includes the mission code and supporting self test. This PR does not include docs/book writeup for the feature This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on issue #470: [dummy] Dispatch 1288 policy for router-initiated connector connections
ChugR commented on issue #470: [dummy] Dispatch 1288 policy for router-initiated connector connections URL: https://github.com/apache/qpid-dispatch/pull/470#issuecomment-474572797 Dummy PR closed as better PR is available This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR closed pull request #470: [dummy] Dispatch 1288 policy for router-initiated connector connections
ChugR closed pull request #470: [dummy] Dispatch 1288 policy for router-initiated connector connections URL: https://github.com/apache/qpid-dispatch/pull/470 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1256) Throughput gets worse as more routers are added
[
https://issues.apache.org/jira/browse/DISPATCH-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796428#comment-16796428
]
Jiri Daněk commented on DISPATCH-1256:
--
This throughput degradation has apparently been present since at least QDR
1.0.0 release. See the following quote from PERFORMANCE TESTING AND ANALYSIS OF
QPID DISPATCH ROUTER thesis at
https://www.vutbr.cz/www_base/zav_prace_soubor_verejne.php?file_id=181688 which
used that version of qdrouterd. Page 54.
{quote}
[...] the topology consisting only of the routers shows significant performance
degradation. The throughput falls from the 90,000 messages per second to the
approximately 23,000 messages per second. This degradation is caused by the
interior flow-control mechanism, which should prevent the overload of the
network. However, in this case study we can see that the performance
degradation is too high and the mechanism used in the Qpid Dispatch should be
reimplemented.
{quote}
> Throughput gets worse as more routers are added
> ---
>
> Key: DISPATCH-1256
> URL: https://issues.apache.org/jira/browse/DISPATCH-1256
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Alan Conway
>Assignee: Ted Ross
>Priority: Major
> Attachments: reproducer.tgz
>
>
> Creating a chain of routers gives worse throughput as the chain gets longer.
> Reproducer:
> Install quiver from here: https://github.com/alanconway/quiver (extened with
> --send-url)
> Run the attached script like this:
> qdr-chain.sh quiver --arrow c --count 1000 --send-url //:10001/testme
> //:10004/testme
> Sets up a chain of 4 routers, each connected to the previous. Waits for
> qdstat -nv at router 1 to show 4 routers in the topology. Receive messages
> from address 'testme' at router 4, send to address 'testme' at router 1.
> This runs the routers with enough tracing to run the dispatch scraper tool,
> which may affect the results. However 1 million message runs without tracing
> show a drop-off in throughput going from 1m0 (no router) up to 1m4 (4-router
> chain) - the more routers the worse it gets. This seems consistent with the
> credit delays seen in the traced case.
> 1m0/out.txt:End-to-end rate . 296,824
> messages/s
> 1m0/out.txt: 50% 2 ms 99.90% 6 ms
> 1m1/out.txt:End-to-end rate . 133,851
> messages/s
> 1m1/out.txt: 50% 1 ms 99.90% 3 ms
> 1m2/out.txt:End-to-end rate .. 59,011
> messages/s
> 1m2/out.txt: 50% 2 ms 99.90% 8 ms
> 1m3/out.txt:End-to-end rate .. 42,146
> messages/s
> 1m3/out.txt: 50% 3 ms 99.90% ... 11 ms
> 1m4/out.txt:End-to-end rate .. 32,415
> messages/s
> 1m4/out.txt: 50% 4 ms 99.90% ... 13 ms
> The output (config, logs and scrapes) from a 1000-message, 4-router tracing
> run is included, as well as the script to generate new data. Runs of 10k
> messages are feasible, but the HTML gets large and slow to view. From my
> experiments the results are similar.
> From file:scrape.html#c_connections the sender connection is starved of
> credit far more than any other connection: 20x more starvation instances, 40x
> longer total starvation and 100x longer wait for initial credit.
> Overall the flow of credit is slower than the flow of messages, and each
> additional router is reducing the throughput of credits, which reduces
> message throughput.
> Observations:
> - initial credit delay is excessive (100ms in this case when worst-case
> message latency is 33ms), something is wrong there.
> - inter-router link credit is small (250) compared to application credit
> (1000). Giving full credit to a sender creates a credit sharing problem,
> but we could give full credit to the inter-router links.
> - re-evaluate our credit sharing strategy to perform better in the common
> unshared case.
> Extracts from scrape:
> ◊ 2019-01-23 13:55:16.524477 D0#141 4 [D0_3] <- [] quiver-receiver-2ebb30e5
> flow [0,0] (0,1000)
> ◊ 2019-01-23 13:55:16.633700 A0#287 1 [A0_6] -> [] quiver-sender-3db6ad3f
> flow [0,0] (0,250)
> Initial delay 109ms, much worse than worst-case message latency of 33ms
> ◊ 2019-01-23 13:55:16.639758 D0#153 4 [D0_3] <- [] quiver-receiver-2ebb30e5
> flow [0,0] (3,1000)
> ◊ 2019-01-23 13:55:16.642682 A0#543 1 [A0_6] -> [] quiver-sender-3db6ad3f
> flow [0,0] (168,85)
> ◊ 2019-01-23 13:55:16.645205 D0#163 4 [D0_3] <- [] quiver-receiver-2ebb30e5
> flow [0,0] (5,1000)
> ◊ 2019-01-23 13:55:16.645448 D0#167 4 [D0_3] <- [] quiver-receiver-2ebb30e5
> flow [0,0] (6,1000)
> ◊ 2019-01-23 13:55:16.646510 A0#713 1 [A0_6] <- [] quiver-sender-3db6ad3f
> transf
[jira] [Commented] (DISPATCH-1285) Router crashes occasionally on system_tests_delivery_abort
[
https://issues.apache.org/jira/browse/DISPATCH-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796429#comment-16796429
]
ASF GitHub Bot commented on DISPATCH-1285:
--
ganeshmurthy commented on pull request #471: DISPATCH-1285 - Added a deferred
call count and detached flag on qd_l…
URL: https://github.com/apache/qpid-dispatch/pull/471
…ink_t and used it to free the object
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Router crashes occasionally on system_tests_delivery_abort
> --
>
> Key: DISPATCH-1285
> URL: https://issues.apache.org/jira/browse/DISPATCH-1285
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.6.0
>
>
> The router occasionally crashes with the following backtrace when running
> system_tests_delivery_abort. Dont run the test independently, run it as part
> of the test suite using ctest -VV
>
> {noformat}
> (gdb) bt
> #0 0x7f3f763d8aaf in qd_link_get_node_context (link=0x7f3f580b40e8) at
> /home/gmurthy/opensource/qpid-dispatch/src/container.c:1053
> #1 0x7f3f7642595f in deferred_AMQP_rx_handler (context=0x7f3f580b40e8,
> discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/router_node.c:640
> #2 0x7f3f7642bf02 in invoke_deferred_calls (conn=0x1b5a568,
> discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/server.c:728
> #3 0x7f3f7642c9c2 in handle (qd_server=0x1a0f5b0, e=0x7f3f58093520,
> pn_conn=0x1bf4e40, ctx=0x1b5a568) at
> /home/gmurthy/opensource/qpid-dispatch/src/server.c:961
> #4 0x7f3f7642cd2a in thread_run (arg=0x1a0f5b0) at
> /home/gmurthy/opensource/qpid-dispatch/src/server.c:1017
> #5 0x7f3f7632258e in start_thread () from /lib64/libpthread.so.0
> #6 0x7f3f75dca6a3 in clone () from /lib64/libc.so.6
> (gdb){noformat}
>
> Here is the output from the test -
> {noformat}
> 40: Test command: /usr/bin/python
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "unit2" "-v"
> "system_tests_delivery_abort"
> 40: Test timeout computed to be: 1500
> 40: test_01_message_route_truncated_one_router
> (system_tests_delivery_abort.RouterTest) ... ok
> 40: test_02_message_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest) ... ok
> 40: test_03_link_route_truncated_one_router
> (system_tests_delivery_abort.RouterTest) ... ok
> 40: test_04_link_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest) ... ERROR
> 40: test_05_message_route_abort_one_router
> (system_tests_delivery_abort.RouterTest) ... ERROR
> 40: test_06_message_route_abort_two_routers
> (system_tests_delivery_abort.RouterTest) ... ERROR
> 40: test_07_multicast_truncate_one_router
> (system_tests_delivery_abort.RouterTest) ... ERROR
> 40: ERROR
> 40:
> 40: ==
> 40: ERROR: test_04_link_route_truncated_two_routers
> (system_tests_delivery_abort.RouterTest)
> 40: --
> 40: Traceback (most recent call last):
> 40: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_delivery_abort.py",
> line 101, in test_04_link_route_truncated_two_routers
> 40: test.run()
> 40: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_delivery_abort.py",
> line 390, in run
> 40: container.run()
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py",
> line 181, in run
> 40: while self.process(): pass
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py",
> line 240, in process
> 40: event.dispatch(self._global_handler)
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 135, in dispatch
> 40: _dispatch(handler, type.method, self)
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 117, in _dispatch
> 40: handler.on_unhandled(method, *args)
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py",
> line 665, in on_unhandled
> 40: event.dispatch(self.base)
> 40: File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 135, in dispatch
> 40: _dispatch(handler, type.method, self)
> 40: File
> "/opt/qpid-proton/qpid-proton/
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #471: DISPATCH-1285 - Added a deferred call count and detached flag on qd_l…
ganeshmurthy opened a new pull request #471: DISPATCH-1285 - Added a deferred call count and detached flag on qd_l… URL: https://github.com/apache/qpid-dispatch/pull/471 …ink_t and used it to free the object This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1292) Coverity issues on master branch
[
https://issues.apache.org/jira/browse/DISPATCH-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1292.
-
Resolution: Fixed
> Coverity issues on master branch
>
>
> Key: DISPATCH-1292
> URL: https://issues.apache.org/jira/browse/DISPATCH-1292
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.6.0
>
>
> {noformat}
> 10 of 17,133
> New Defects reported by Coverity Scan for Apache Qpid dispatch-router
> Inbox
> x
> scan-ad...@coverity.com
>
> 12:31 AM (7 hours ago)
>
> to me
> Hi,
> Please find the latest report on new defect(s) introduced to Apache Qpid
> dispatch-router found with Coverity Scan.
> 11 new defect(s) introduced to Apache Qpid dispatch-router found with
> Coverity Scan.
> 55 defect(s), reported by Coverity Scan earlier, were marked fixed in the
> recent build analyzed by Coverity Scan.
> New defect(s) Reported-by: Coverity Scan
> Showing 11 of 11 defect(s)
> ** CID 336749: Control flow issues (MISSING_BREAK)
> /home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle()
>
> *** CID 336749: Control flow issues (MISSING_BREAK)
> /home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle()
> 903 qdr_handle_authentication_service_connection_event(e);
> 904 return true;
> 905 }
> 906
> 907 switch (pn_event_type(e)) {
> 908
> >>> CID 336749: Control flow issues (MISSING_BREAK)
> >>> The case for value "PN_PROACTOR_INTERRUPT" is not terminated by a
> >>>'break' statement.
> 909 case PN_PROACTOR_INTERRUPT:
> 910 if (qd_server->stopping) {
> 911 /* Interrupt the next thread */
> 912 pn_proactor_interrupt(qd_server->proactor);
> 913 /* Stop the current thread */
> 914 return false;
> ** CID 336748: Resource leaks (RESOURCE_LEAK)
> /home/gmurthy/opensource/qpid-dispatch/src/router_node.c: 567 in
> AMQP_rx_handler()
>
> *** CID 336748: Resource leaks (RESOURCE_LEAK)
> /home/gmurthy/opensource/qpid-dispatch/src/router_node.c: 567 in
> AMQP_rx_handler()
> 561 qd_log(router->log_source, QD_LOG_DEBUG, "Message
> rejected due to policy violation on target. User:%s", conn->user_id);
> 562 pn_link_flow(pn_link, 1);
> 563 pn_delivery_update(pnd, PN_REJECTED);
> 564 pn_delivery_settle(pnd);
> 565 qd_message_free(msg);
> 566 qd_iterator_free(addr_iter);
> >>> CID 336748: Resource leaks (RESOURCE_LEAK)
> >>> Variable "link_exclusions" going out of scope leaks the storage it
> >>>points to.
> 567 return next_delivery;
> 568 }
> 569 }
> 570 } else {
> 571 //
> 572 // This is a targeted link, not anonymous.
> ** CID 336747: (RESOURCE_LEAK)
> /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 81 in
> test_send_to_messenger()
> /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 86 in
> test_send_to_messenger()
>
> *** CID 336747: (RESOURCE_LEAK)
> /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 81 in
> test_send_to_messenger()
> 75 static char* test_send_to_messenger(void *context)
> 76 {
> 77 qd_message_t *msg = qd_message();
> 78 qd_message_content_t *content = MSG_CONTENT(msg);
> 79 qd_message_compose_1(msg, "test_addr_0", 0);
> 80 qd_buffer_t *buf = DEQ_HEAD(content->buffers);
> >>> CID 336747: (RESOURCE_LEAK)
> >>> Variable "msg" going out of scope leaks the storage it points to.
> 81 if (buf == 0) return "Expected a buffer in the test message";
> 82
> 83 pn_message_t *pn_msg = pn_message();
> 84 size_t len = flatten_bufs(content);
> 85 int result = pn_message_decode(pn_msg, buffer, len);
> 86 if (result != 0) return "Error in pn_message_decode";
> /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 86 in
> test_send_to_messenger()
> 80 qd_buffer_t *buf = DEQ_HEAD(content->buffers);
> 81 if (buf == 0) return "Expected a buffer in the test message";
> 82
> 83 pn_message_t *pn_msg = pn_message();
> 84 size_t len = flatten_bufs(content);
> 85 i
[jira] [Commented] (DISPATCH-1292) Coverity issues on master branch
[
https://issues.apache.org/jira/browse/DISPATCH-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796255#comment-16796255
]
ASF subversion and git services commented on DISPATCH-1292:
---
Commit bdafbbe02f2762ec3c38bc254e59c3efa9b23c9e in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=bdafbbe ]
DISPATCH-1292 - Fixes to coverity issues
> Coverity issues on master branch
>
>
> Key: DISPATCH-1292
> URL: https://issues.apache.org/jira/browse/DISPATCH-1292
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.5.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.6.0
>
>
> {noformat}
> 10 of 17,133
> New Defects reported by Coverity Scan for Apache Qpid dispatch-router
> Inbox
> x
> scan-ad...@coverity.com
>
> 12:31 AM (7 hours ago)
>
> to me
> Hi,
> Please find the latest report on new defect(s) introduced to Apache Qpid
> dispatch-router found with Coverity Scan.
> 11 new defect(s) introduced to Apache Qpid dispatch-router found with
> Coverity Scan.
> 55 defect(s), reported by Coverity Scan earlier, were marked fixed in the
> recent build analyzed by Coverity Scan.
> New defect(s) Reported-by: Coverity Scan
> Showing 11 of 11 defect(s)
> ** CID 336749: Control flow issues (MISSING_BREAK)
> /home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle()
>
> *** CID 336749: Control flow issues (MISSING_BREAK)
> /home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle()
> 903 qdr_handle_authentication_service_connection_event(e);
> 904 return true;
> 905 }
> 906
> 907 switch (pn_event_type(e)) {
> 908
> >>> CID 336749: Control flow issues (MISSING_BREAK)
> >>> The case for value "PN_PROACTOR_INTERRUPT" is not terminated by a
> >>>'break' statement.
> 909 case PN_PROACTOR_INTERRUPT:
> 910 if (qd_server->stopping) {
> 911 /* Interrupt the next thread */
> 912 pn_proactor_interrupt(qd_server->proactor);
> 913 /* Stop the current thread */
> 914 return false;
> ** CID 336748: Resource leaks (RESOURCE_LEAK)
> /home/gmurthy/opensource/qpid-dispatch/src/router_node.c: 567 in
> AMQP_rx_handler()
>
> *** CID 336748: Resource leaks (RESOURCE_LEAK)
> /home/gmurthy/opensource/qpid-dispatch/src/router_node.c: 567 in
> AMQP_rx_handler()
> 561 qd_log(router->log_source, QD_LOG_DEBUG, "Message
> rejected due to policy violation on target. User:%s", conn->user_id);
> 562 pn_link_flow(pn_link, 1);
> 563 pn_delivery_update(pnd, PN_REJECTED);
> 564 pn_delivery_settle(pnd);
> 565 qd_message_free(msg);
> 566 qd_iterator_free(addr_iter);
> >>> CID 336748: Resource leaks (RESOURCE_LEAK)
> >>> Variable "link_exclusions" going out of scope leaks the storage it
> >>>points to.
> 567 return next_delivery;
> 568 }
> 569 }
> 570 } else {
> 571 //
> 572 // This is a targeted link, not anonymous.
> ** CID 336747: (RESOURCE_LEAK)
> /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 81 in
> test_send_to_messenger()
> /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 86 in
> test_send_to_messenger()
>
> *** CID 336747: (RESOURCE_LEAK)
> /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 81 in
> test_send_to_messenger()
> 75 static char* test_send_to_messenger(void *context)
> 76 {
> 77 qd_message_t *msg = qd_message();
> 78 qd_message_content_t *content = MSG_CONTENT(msg);
> 79 qd_message_compose_1(msg, "test_addr_0", 0);
> 80 qd_buffer_t *buf = DEQ_HEAD(content->buffers);
> >>> CID 336747: (RESOURCE_LEAK)
> >>> Variable "msg" going out of scope leaks the storage it points to.
> 81 if (buf == 0) return "Expected a buffer in the test message";
> 82
> 83 pn_message_t *pn_msg = pn_message();
> 84 size_t len = flatten_bufs(content);
> 85 int result = pn_message_decode(pn_msg, buffer, len);
> 86 if (result != 0) return "Error in pn_message_decode";
> /home/gmurthy/opensource/qpid-dispatch/tests/message_test.
[jira] [Created] (DISPATCH-1294) Handling TTL in Dispatch Router
Ali Hadi created DISPATCH-1294: -- Summary: Handling TTL in Dispatch Router Key: DISPATCH-1294 URL: https://issues.apache.org/jira/browse/DISPATCH-1294 Project: Qpid Dispatch Issue Type: New Feature Reporter: Ali Hadi See [http://mail-archives.apache.org/mod_mbox/qpid-users/201903.mbox/browser]. The usage of TTL in a cluster including a Dispatch Router with autolinks is not currently possible since the dispatch is prefetching messages from the broker. The aim of this feature is to handle a TTL logic on the dispatch router side. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1291) Update console to use router-generated link settlement rates
[ https://issues.apache.org/jira/browse/DISPATCH-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1291. Resolution: Fixed > Update console to use router-generated link settlement rates > > > Key: DISPATCH-1291 > URL: https://issues.apache.org/jira/browse/DISPATCH-1291 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > The console currently computes rates locally based on changes in link > counters. With DISPATCH-1289, these rates are now computed inside the router. > The console should use the router-supplied rate values rather than generate > its own local rates. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1291) Update console to use router-generated link settlement rates
[ https://issues.apache.org/jira/browse/DISPATCH-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796108#comment-16796108 ] ASF subversion and git services commented on DISPATCH-1291: --- Commit 1a83f99213f1880c2519e9c398c8d4e5ae343c67 in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=1a83f99 ] DISPATCH-1291 Show link settlement rate and delayed deliveries > Update console to use router-generated link settlement rates > > > Key: DISPATCH-1291 > URL: https://issues.apache.org/jira/browse/DISPATCH-1291 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > The console currently computes rates locally based on changes in link > counters. With DISPATCH-1289, these rates are now computed inside the router. > The console should use the router-supplied rate values rather than generate > its own local rates. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1293) Show traffic for stand-alone router
[ https://issues.apache.org/jira/browse/DISPATCH-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1293. Resolution: Fixed > Show traffic for stand-alone router > --- > > Key: DISPATCH-1293 > URL: https://issues.apache.org/jira/browse/DISPATCH-1293 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > If a router is in stand-alone mode, the chord diagram and the traffic > animation do not show messaging traffic. > This is due to the fact that a stand-alone router does not list itself in the > data returned from the request to get router.nodes. If the router is > configured as an interior router then it will report (self) in the > router.nodes list, but stand-alone routers do not. This is by design. > The console does not take this into account and traffic animations and does > not show any traffic. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1293) Show traffic for stand-alone router
[ https://issues.apache.org/jira/browse/DISPATCH-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796068#comment-16796068 ] ASF subversion and git services commented on DISPATCH-1293: --- Commit 1915f3e8b63e3b6369744be662185b576ef4422e in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=1915f3e ] DISPATCH-1293 Enable traffic animations for stand-alone routers > Show traffic for stand-alone router > --- > > Key: DISPATCH-1293 > URL: https://issues.apache.org/jira/browse/DISPATCH-1293 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > If a router is in stand-alone mode, the chord diagram and the traffic > animation do not show messaging traffic. > This is due to the fact that a stand-alone router does not list itself in the > data returned from the request to get router.nodes. If the router is > configured as an interior router then it will report (self) in the > router.nodes list, but stand-alone routers do not. This is by design. > The console does not take this into account and traffic animations and does > not show any traffic. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1293) Show traffic for stand-alone router
Ernest Allen created DISPATCH-1293: -- Summary: Show traffic for stand-alone router Key: DISPATCH-1293 URL: https://issues.apache.org/jira/browse/DISPATCH-1293 Project: Qpid Dispatch Issue Type: Bug Components: Console Affects Versions: 1.5.0 Reporter: Ernest Allen Assignee: Ernest Allen If a router is in stand-alone mode, the chord diagram and the traffic animation do not show messaging traffic. This is due to the fact that a stand-alone router does not list itself in the data returned from the request to get router.nodes. If the router is configured as an interior router then it will report (self) in the router.nodes list, but stand-alone routers do not. This is by design. The console does not take this into account and traffic animations and does not show any traffic. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1282) Support for building on macOS
[ https://issues.apache.org/jira/browse/DISPATCH-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796012#comment-16796012 ] ASF GitHub Bot commented on DISPATCH-1282: -- jdanekrh commented on issue #459: [WIP] DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-474334360 I've created StackOverflow question about what to do regarding SASL on macOS, because I have no clue myself. https://stackoverflow.com/questions/55240554/what-is-the-status-of-sasl-on-macos-in-2019 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support for building on macOS > - > > Key: DISPATCH-1282 > URL: https://issues.apache.org/jira/browse/DISPATCH-1282 > Project: Qpid Dispatch > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Jiri Daněk >Priority: Major > Labels: macOS > > Currently, Dispatch compilation fails on "rt" library being unavailable. > All Dispatch dependencies (Qpid Proton, libwebsockets, ...) can be built on > macOS. > I am attaching a patch which allows to compile dispatch on OSX and run it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR opened a new pull request #470: [dummy] Dispatch 1288 policy for router-initiated connector connections
ChugR opened a new pull request #470: [dummy] Dispatch 1288 policy for router-initiated connector connections URL: https://github.com/apache/qpid-dispatch/pull/470 This PR is a dummy and not intended to be merged. It shows the mission code as it is intended but it has not yet been tested thoroughly, seen internal self tests, or been documented. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #459: [WIP] DISPATCH-1282 - Support for building on macOS
jdanekrh commented on issue #459: [WIP] DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-474334360 I've created StackOverflow question about what to do regarding SASL on macOS, because I have no clue myself. https://stackoverflow.com/questions/55240554/what-is-the-status-of-sasl-on-macos-in-2019 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1292) Coverity issues on master branch
Ganesh Murthy created DISPATCH-1292:
---
Summary: Coverity issues on master branch
Key: DISPATCH-1292
URL: https://issues.apache.org/jira/browse/DISPATCH-1292
Project: Qpid Dispatch
Issue Type: Bug
Components: Container
Affects Versions: 1.5.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
Fix For: 1.6.0
{noformat}
10 of 17,133
New Defects reported by Coverity Scan for Apache Qpid dispatch-router
Inbox
x
scan-ad...@coverity.com
12:31 AM (7 hours ago)
to me
Hi,
Please find the latest report on new defect(s) introduced to Apache Qpid
dispatch-router found with Coverity Scan.
11 new defect(s) introduced to Apache Qpid dispatch-router found with Coverity
Scan.
55 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 11 of 11 defect(s)
** CID 336749: Control flow issues (MISSING_BREAK)
/home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle()
*** CID 336749: Control flow issues (MISSING_BREAK)
/home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle()
903 qdr_handle_authentication_service_connection_event(e);
904 return true;
905 }
906
907 switch (pn_event_type(e)) {
908
>>> CID 336749: Control flow issues (MISSING_BREAK)
>>> The case for value "PN_PROACTOR_INTERRUPT" is not terminated by a
>>>'break' statement.
909 case PN_PROACTOR_INTERRUPT:
910 if (qd_server->stopping) {
911 /* Interrupt the next thread */
912 pn_proactor_interrupt(qd_server->proactor);
913 /* Stop the current thread */
914 return false;
** CID 336748: Resource leaks (RESOURCE_LEAK)
/home/gmurthy/opensource/qpid-dispatch/src/router_node.c: 567 in
AMQP_rx_handler()
*** CID 336748: Resource leaks (RESOURCE_LEAK)
/home/gmurthy/opensource/qpid-dispatch/src/router_node.c: 567 in
AMQP_rx_handler()
561 qd_log(router->log_source, QD_LOG_DEBUG, "Message
rejected due to policy violation on target. User:%s", conn->user_id);
562 pn_link_flow(pn_link, 1);
563 pn_delivery_update(pnd, PN_REJECTED);
564 pn_delivery_settle(pnd);
565 qd_message_free(msg);
566 qd_iterator_free(addr_iter);
>>> CID 336748: Resource leaks (RESOURCE_LEAK)
>>> Variable "link_exclusions" going out of scope leaks the storage it
>>>points to.
567 return next_delivery;
568 }
569 }
570 } else {
571 //
572 // This is a targeted link, not anonymous.
** CID 336747: (RESOURCE_LEAK)
/home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 81 in
test_send_to_messenger()
/home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 86 in
test_send_to_messenger()
*** CID 336747: (RESOURCE_LEAK)
/home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 81 in
test_send_to_messenger()
75 static char* test_send_to_messenger(void *context)
76 {
77 qd_message_t *msg = qd_message();
78 qd_message_content_t *content = MSG_CONTENT(msg);
79 qd_message_compose_1(msg, "test_addr_0", 0);
80 qd_buffer_t *buf = DEQ_HEAD(content->buffers);
>>> CID 336747: (RESOURCE_LEAK)
>>> Variable "msg" going out of scope leaks the storage it points to.
81 if (buf == 0) return "Expected a buffer in the test message";
82
83 pn_message_t *pn_msg = pn_message();
84 size_t len = flatten_bufs(content);
85 int result = pn_message_decode(pn_msg, buffer, len);
86 if (result != 0) return "Error in pn_message_decode";
/home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 86 in
test_send_to_messenger()
80 qd_buffer_t *buf = DEQ_HEAD(content->buffers);
81 if (buf == 0) return "Expected a buffer in the test message";
82
83 pn_message_t *pn_msg = pn_message();
84 size_t len = flatten_bufs(content);
85 int result = pn_message_decode(pn_msg, buffer, len);
>>> CID 336747: (RESOURCE_LEAK)
>>> Variable "msg" going out of scope leaks the storage it points to.
86 if (result != 0) return "Error in pn_message_decode";
87
88 if (strcmp(pn_message_get_address(pn_msg), "test_addr_0") != 0)
89 return "Address mismatch in received message";
90
