[jira] [Created] (DISPATCH-1405) Display local addresses at startup
Chuck Rolke created DISPATCH-1405: - Summary: Display local addresses at startup Key: DISPATCH-1405 URL: https://issues.apache.org/jira/browse/DISPATCH-1405 Project: Qpid Dispatch Issue Type: Improvement Components: Management Agent Affects Versions: 1.8.0 Reporter: Chuck Rolke At boot time the router could display its local addresses. This would help debugging certain issues. An example of the information is from hawtio: ``` [io.hawt.system.ProxyWhitelist] Probing local addresses ... [io.hawt.system.ProxyWhitelist] Initial proxy whitelist: [localhost, 127.0.0.1, 10.10.111.222, ovpn-111-222.gw.example.com, 192.168.100.100, unused] ``` -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPIDIT-137) Change broker properties connection to use retries
[ https://issues.apache.org/jira/browse/QPIDIT-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet resolved QPIDIT-137. - Resolution: Fixed The get_broker_properties() method now allows 25 retry attempts before failing. > Change broker properties connection to use retries > -- > > Key: QPIDIT-137 > URL: https://issues.apache.org/jira/browse/QPIDIT-137 > Project: Apache QPID Interoperability Test Suite > Issue Type: Task >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Major > > Currently, if the attempt to obtain broker properties fails because a broker > is not running, the test terminates with an exception. > However, in an automated or CI environment (such as Jenkins) where it is > possible that a broker may take a little longer to start sometimes than > others, it is desirable to have a "window" in which to connect before > failing. Utilizing the retry mechanism to allow a fixed number of retries > before failing will provide this behavior. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDIT-137) Change broker properties connection to use retries
[ https://issues.apache.org/jira/browse/QPIDIT-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921729#comment-16921729 ] ASF subversion and git services commented on QPIDIT-137: Commit ee9eeea6db2190ea2d807be0cc3a82ca92f99d71 in qpid-interop-test's branch refs/heads/master from Kim van der Riet [ https://gitbox.apache.org/repos/asf?p=qpid-interop-test.git;h=ee9eeea ] QPIDIT-137: Change broker properties connection to use retries - 25 retries are now attmepted before the test fails. > Change broker properties connection to use retries > -- > > Key: QPIDIT-137 > URL: https://issues.apache.org/jira/browse/QPIDIT-137 > Project: Apache QPID Interoperability Test Suite > Issue Type: Task >Reporter: Kim van der Riet >Priority: Major > > Currently, if the attempt to obtain broker properties fails because a broker > is not running, the test terminates with an exception. > However, in an automated or CI environment (such as Jenkins) where it is > possible that a broker may take a little longer to start sometimes than > others, it is desirable to have a "window" in which to connect before > failing. Utilizing the retry mechanism to allow a fixed number of retries > before failing will provide this behavior. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPIDIT-137) Change broker properties connection to use retries
[ https://issues.apache.org/jira/browse/QPIDIT-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet reassigned QPIDIT-137: --- Assignee: Kim van der Riet > Change broker properties connection to use retries > -- > > Key: QPIDIT-137 > URL: https://issues.apache.org/jira/browse/QPIDIT-137 > Project: Apache QPID Interoperability Test Suite > Issue Type: Task >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Major > > Currently, if the attempt to obtain broker properties fails because a broker > is not running, the test terminates with an exception. > However, in an automated or CI environment (such as Jenkins) where it is > possible that a broker may take a little longer to start sometimes than > others, it is desirable to have a "window" in which to connect before > failing. Utilizing the retry mechanism to allow a fixed number of retries > before failing will provide this behavior. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2097) Linkage error when openssl version is too old or new (not sure)
[
https://issues.apache.org/jira/browse/PROTON-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921730#comment-16921730
]
Andrew Stitcher commented on PROTON-2097:
-
Ah, I realise I misunderstood how you are using python.
It is quite possible that it is pyenv that is the issue here as its use of
shims might well screw up CMake's detection logic. I have good experience using
virtualenv, so if you can use that to achieve what you need (perhaps with the
pyenv-virtualenv plugin) that is going to be easier (for me) to help you with.
> Linkage error when openssl version is too old or new (not sure)
> ---
>
> Key: PROTON-2097
> URL: https://issues.apache.org/jira/browse/PROTON-2097
> Project: Qpid Proton
> Issue Type: Improvement
> Components: python-binding
>Affects Versions: proton-c-0.29.0
>Reporter: Omer Katz
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> After successfully building I'm getting the following error when I try to
> import _cproton.
> {code:java}
> undefined symbol: CRYPTO_set_locking_callback{code}
> This is not the behavior I expected.
> The build should fail if this symbol is not present.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPIDIT-137) Change broker properties connection to use retries
[ https://issues.apache.org/jira/browse/QPIDIT-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet updated QPIDIT-137: Summary: Change broker properties connection to use retries (was: Change connection to obtain broker properties to use retries) > Change broker properties connection to use retries > -- > > Key: QPIDIT-137 > URL: https://issues.apache.org/jira/browse/QPIDIT-137 > Project: Apache QPID Interoperability Test Suite > Issue Type: Task >Reporter: Kim van der Riet >Priority: Major > > Currently, if the attempt to obtain broker properties fails because a broker > is not running, the test terminates with an exception. > However, in an automated or CI environment (such as Jenkins) where it is > possible that a broker may take a little longer to start sometimes than > others, it is desirable to have a "window" in which to connect before > failing. Utilizing the retry mechanism to allow a fixed number of retries > before failing will provide this behavior. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDIT-137) Change connection to obtain broker properties to use retries
Kim van der Riet created QPIDIT-137: --- Summary: Change connection to obtain broker properties to use retries Key: QPIDIT-137 URL: https://issues.apache.org/jira/browse/QPIDIT-137 Project: Apache QPID Interoperability Test Suite Issue Type: Task Reporter: Kim van der Riet Currently, if the attempt to obtain broker properties fails because a broker is not running, the test terminates with an exception. However, in an automated or CI environment (such as Jenkins) where it is possible that a broker may take a little longer to start sometimes than others, it is desirable to have a "window" in which to connect before failing. Utilizing the retry mechanism to allow a fixed number of retries before failing will provide this behavior. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1337) Fallback Destination for Unreachable Addresses
[
https://issues.apache.org/jira/browse/DISPATCH-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921703#comment-16921703
]
ASF subversion and git services commented on DISPATCH-1337:
---
Commit 589c54c65a07f7bc8c003a879c9518f05db9a7e0 in qpid-dispatch's branch
refs/heads/master from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=589c54c ]
DISPATCH-1337: remove spurious assert(false)
> Fallback Destination for Unreachable Addresses
> --
>
> Key: DISPATCH-1337
> URL: https://issues.apache.org/jira/browse/DISPATCH-1337
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.8.0
>
>
> This feature allows addresses to be configured such that an alternate
> fallback destination can be used to receive messages that are not deliverable
> to any normal consumers on the address.
> Typically, this feature will be used to allow a message broker to store
> messages that are not routable directly to consumers. When one or more
> consumers are attached in the router network, messages shall be delivered
> directly to the consumers. Where there are no reachable consumers,
> deliveries shall then be diverted to any fallback links that are attached.
> Once consumers re-connect to the network, messages shall again be delivered
> directly.
> When a consumer comes online after messages have been stored in a broker, it
> shall receive the stored messages interleaved with new messages from
> producers. No attempt shall be made by the router network to preserve the
> original delivery order of the messages.
> This feature can be configured by adding the attribute
> {noformat}
> enableFallback: yes
> {noformat}
> to an address configuration. This attribute tells the router that any address
> matching the configuration shall support the fallback destination capability.
> There are two ways to create a fallback link for an address:
> Using auto-links:
> An auto-link (or a pair of auto-links) can be configured to create a fallback
> link for an address. For example, assume that there is a route-container
> connector or listener for a broker called "alternate-broker".
> {noformat}
> address {
> prefix: position_update
> enableFallback: yes
> }
> autoLink {
> address: position_update.338
> direction: in
> connection: alternate-broker
> fallback: yes
> }
> autoLink {
> address: position_update.338
> direction: out
> connection: alternate-broker
> fallback: yes
> }
> {noformat}
> The above configuration will use a queue on the broker called
> "position_update.338" as the fallback destination for direct consumers.
> Furthermore, since there are both _in_ and _out_ auto-links, the router(s)
> shall send queued messages to newly attached direct consumers.
> Using terminus capabilities:
> As an alternative to using auto-links, the broker (or any other process) can
> attach sending and receiving links to the address with terminus-capability
> "qd.fallback". This will create the same behavior as the above example.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2021) [c] Make SSL/TLS usage more secure by default
[ https://issues.apache.org/jira/browse/PROTON-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921526#comment-16921526 ] Jiri Daněk commented on PROTON-2021: The fix in DISPATCH-401 may need to be updated in regards to this. Users of qdmanage/qdstat may want to put a CA certificate into system location and then have connections validated using that CA certificate. > [c] Make SSL/TLS usage more secure by default > - > > Key: PROTON-2021 > URL: https://issues.apache.org/jira/browse/PROTON-2021 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.28.0 > > > There are some aspects of using TLS with proton-c that are awkward and by > default less secure than they could be. > A good example of this is that it is tricky to set up to verify peer names > against the system default ca certificate list. Even though this is carefully > set up under many (most?) modern OS distributions. > Another example is that for a client on the internet verifying peer names is > the only safe way to use TLS, but this is not the default. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2094) Support Python 3.7
[ https://issues.apache.org/jira/browse/PROTON-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921485#comment-16921485 ] Andrew Stitcher commented on PROTON-2094: - To be specific my development environment is also python 3.7 with a virtual environment (but using Fedora 30) > Support Python 3.7 > -- > > Key: PROTON-2094 > URL: https://issues.apache.org/jira/browse/PROTON-2094 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: proton-c-0.29.0 > Environment: Ubuntu 18.04 >Reporter: Omer Katz >Assignee: Andrew Stitcher >Priority: Major > Labels: build, features > Fix For: proton-c-future > > > I tried building the bindings locally on Python 3.7 and it didn't work. > I checked setup.py and Python 3.7 is not listed under the supported versions. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2094) Support Python 3.7
[ https://issues.apache.org/jira/browse/PROTON-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921484#comment-16921484 ] Andrew Stitcher commented on PROTON-2094: - Are you sure your virtual environment is properly activated? Does it have the full set of libraries and headers? > Support Python 3.7 > -- > > Key: PROTON-2094 > URL: https://issues.apache.org/jira/browse/PROTON-2094 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: proton-c-0.29.0 > Environment: Ubuntu 18.04 >Reporter: Omer Katz >Assignee: Andrew Stitcher >Priority: Major > Labels: build, features > Fix For: proton-c-future > > > I tried building the bindings locally on Python 3.7 and it didn't work. > I checked setup.py and Python 3.7 is not listed under the supported versions. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2097) Linkage error when openssl version is too old or new (not sure)
[
https://issues.apache.org/jira/browse/PROTON-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921479#comment-16921479
]
Andrew Stitcher commented on PROTON-2097:
-
Currently if you are using some type of python virtual environment a good way
to run the master version of the python binding is this:
* Activate your python environment (for me this {{. /bin/activate}})
* Download and build qpid-proton
...
{{cmake ..}}
{{make}}
* install the python into your virtualenv:
{{pip install -e python/dist}}
This should put a link in your virtual env to a copy of the python binding in
the build area - this will change to match the actual python source tree
whenever you run {{make}}
> Linkage error when openssl version is too old or new (not sure)
> ---
>
> Key: PROTON-2097
> URL: https://issues.apache.org/jira/browse/PROTON-2097
> Project: Qpid Proton
> Issue Type: Improvement
> Components: python-binding
>Affects Versions: proton-c-0.29.0
>Reporter: Omer Katz
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> After successfully building I'm getting the following error when I try to
> import _cproton.
> {code:java}
> undefined symbol: CRYPTO_set_locking_callback{code}
> This is not the behavior I expected.
> The build should fail if this symbol is not present.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2097) Linkage error when openssl version is too old or new (not sure)
[
https://issues.apache.org/jira/browse/PROTON-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921477#comment-16921477
]
Andrew Stitcher commented on PROTON-2097:
-
* To see the full CMake configure output you need to run CMake with no cache -
I think you have run CMake before in this directory so there is a cache present.
* The SYSINSTALL_PYTHON=ON option is a hold over for a time long ago, and is
not much used or tested currently, so this may be an issue - you shouldn't need
it.
* Your error looks like a issue with the LD_LIBRARY_PATH - does pyenv set one
up? If so does it actually point to the place where libcrypto.so actually is?
One thing to try is finding the _cproton.so that is built as the loadable
python extension (it may have a longer name like
_cproton.cpython-37m-x86_64-linux-gnu.so) and running {{ldd _cprotonso}}
> Linkage error when openssl version is too old or new (not sure)
> ---
>
> Key: PROTON-2097
> URL: https://issues.apache.org/jira/browse/PROTON-2097
> Project: Qpid Proton
> Issue Type: Improvement
> Components: python-binding
>Affects Versions: proton-c-0.29.0
>Reporter: Omer Katz
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> After successfully building I'm getting the following error when I try to
> import _cproton.
> {code:java}
> undefined symbol: CRYPTO_set_locking_callback{code}
> This is not the behavior I expected.
> The build should fail if this symbol is not present.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #560: NO-JIRA: add a document explaining the router's threading implementat…
codecov-io commented on issue #560: NO-JIRA: add a document explaining the router's threading implementat… URL: https://github.com/apache/qpid-dispatch/pull/560#issuecomment-527474288 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/560?src=pr&el=h1) Report > Merging [#560](https://codecov.io/gh/apache/qpid-dispatch/pull/560?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b468642f3ad8fb451e9126f06e542d6e97f89237?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/560?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #560 +/- ## == + Coverage 86.57% 86.59% +0.01% == Files 88 88 Lines 1983219831 -1 == + Hits1717017173 +3 + Misses 2662 2658 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/560?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/560/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `66.83% <0%> (-0.51%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/560/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.18% <0%> (-0.02%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/560/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.92% <0%> (ø)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/560/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.12% <0%> (+0.12%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/560/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `85% <0%> (+0.23%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/560/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `95.11% <0%> (+0.77%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/560?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/560?src=pr&el=footer). Last update [b468642...fb89457](https://codecov.io/gh/apache/qpid-dispatch/pull/560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #559: NO-JIRA: print a full name banner to output log on startup
kgiusti closed pull request #559: NO-JIRA: print a full name banner to output log on startup URL: https://github.com/apache/qpid-dispatch/pull/559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPIDJMS-472) ensure Reader is closed if exception occurs
[ https://issues.apache.org/jira/browse/QPIDJMS-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPIDJMS-472. Resolution: Fixed > ensure Reader is closed if exception occurs > --- > > Key: QPIDJMS-472 > URL: https://issues.apache.org/jira/browse/QPIDJMS-472 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.45.0 >Reporter: Robbie Gemmell >Priority: Trivial > Fix For: 0.46.0 > > > The client has a couple of static mechanisms to try and determine its version > number, the later of which uses a BufferedReader but can fail to close this > if an exception occurs during the process. > Raised for PR #31: https://github.com/apache/qpid-jms/pull/31 -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-jms] gemmellr commented on issue #31: Make sure reader is properly closed
gemmellr commented on issue #31: Make sure reader is properly closed URL: https://github.com/apache/qpid-jms/pull/31#issuecomment-527433271 Thanks. Please create a JIRA for changes to the client code and reference its key in the PR title and commit message, as we use this for tracking changes, creating release notes etc. I've raised one \[1\] this time and updated the commit before pushing. \[1\] https://issues.apache.org/jira/browse/QPIDJMS-472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-jms] asfgit closed pull request #31: Make sure reader is properly closed
asfgit closed pull request #31: Make sure reader is properly closed URL: https://github.com/apache/qpid-jms/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-472) ensure Reader is closed if exception occurs
[ https://issues.apache.org/jira/browse/QPIDJMS-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921382#comment-16921382 ] ASF subversion and git services commented on QPIDJMS-472: - Commit c2ac6846226fbf13f5690391f4542f357547c652 in qpid-jms's branch refs/heads/master from Colm O hEigeartaigh [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=c2ac684 ] QPIDJMS-472: Make sure reader is properly closed. This closes #31 > ensure Reader is closed if exception occurs > --- > > Key: QPIDJMS-472 > URL: https://issues.apache.org/jira/browse/QPIDJMS-472 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.45.0 >Reporter: Robbie Gemmell >Priority: Trivial > Fix For: 0.46.0 > > > The client has a couple of static mechanisms to try and determine its version > number, the later of which uses a BufferedReader but can fail to close this > if an exception occurs during the process. > Raised for PR #31: https://github.com/apache/qpid-jms/pull/31 -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-472) ensure Reader is closed if exception occurs
Robbie Gemmell created QPIDJMS-472: -- Summary: ensure Reader is closed if exception occurs Key: QPIDJMS-472 URL: https://issues.apache.org/jira/browse/QPIDJMS-472 Project: Qpid JMS Issue Type: Bug Components: qpid-jms-client Affects Versions: 0.45.0 Reporter: Robbie Gemmell Fix For: 0.46.0 The client has a couple of static mechanisms to try and determine its version number, the later of which uses a BufferedReader but can fail to close this if an exception occurs during the process. Raised for PR #31: https://github.com/apache/qpid-jms/pull/31 -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8349) [Broker-J][AMQP 1.0][Tests] Improve protocol tests to be able to run the test suite against external broker
[
https://issues.apache.org/jira/browse/QPID-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921372#comment-16921372
]
ASF subversion and git services commented on QPID-8349:
---
Commit 4130a71d17e3b28784d9f2af99b8fc30a0dc4afa in qpid-broker-j's branch
refs/heads/master from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=4130a71 ]
QPID-8349: [Tests][AMQP 1.0] Make protocol tests for 0-9 consistent with
protocol tests for 1.0
> [Broker-J][AMQP 1.0][Tests] Improve protocol tests to be able to run the test
> suite against external broker
> ---
>
> Key: QPID-8349
> URL: https://issues.apache.org/jira/browse/QPID-8349
> Project: Qpid
> Issue Type: Task
> Components: Java Tests
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0
>
>
> The existing protocol test framework allows to run test against external
> broker only when annotation {{RunBrokerAdmin}} is added to the test class
> with a type pointing to external broker admin type.
> With this approach the implemented test can only be executed with a
> particular broker admin type.
> The original intention of protocol tests was to allow running protocol tests
> against any AMQP compliment broker. The specific broker admin needs to be
> injected into the test framework.
> Currently, we have "external" and "embedded" broker admin type, but, there is
> no way to execute protocol tests even against external Qpid broker.
> We need to modify protocol test framework to allow running existing tests
> against external broker
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8349) [Broker-J][AMQP 1.0][Tests] Improve protocol tests to be able to run the test suite against external broker
[
https://issues.apache.org/jira/browse/QPID-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921373#comment-16921373
]
ASF subversion and git services commented on QPID-8349:
---
Commit eb6f2b23c4810f8cbc20c02aba4513de2ef5b4f6 in qpid-broker-j's branch
refs/heads/master from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=eb6f2b2 ]
QPID-8349: [Tests][AMQP 1.0] Make protocol tests for amqp 0-10 consistent with
protocol tests for amqp 1.0
> [Broker-J][AMQP 1.0][Tests] Improve protocol tests to be able to run the test
> suite against external broker
> ---
>
> Key: QPID-8349
> URL: https://issues.apache.org/jira/browse/QPID-8349
> Project: Qpid
> Issue Type: Task
> Components: Java Tests
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0
>
>
> The existing protocol test framework allows to run test against external
> broker only when annotation {{RunBrokerAdmin}} is added to the test class
> with a type pointing to external broker admin type.
> With this approach the implemented test can only be executed with a
> particular broker admin type.
> The original intention of protocol tests was to allow running protocol tests
> against any AMQP compliment broker. The specific broker admin needs to be
> injected into the test framework.
> Currently, we have "external" and "embedded" broker admin type, but, there is
> no way to execute protocol tests even against external Qpid broker.
> We need to modify protocol test framework to allow running existing tests
> against external broker
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8349) [Broker-J][AMQP 1.0][Tests] Improve protocol tests to be able to run the test suite against external broker
[
https://issues.apache.org/jira/browse/QPID-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921374#comment-16921374
]
ASF subversion and git services commented on QPID-8349:
---
Commit 142026bd12017c89c64358d629640ba83f5b1f0f in qpid-broker-j's branch
refs/heads/master from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=142026b ]
QPID-8349: [Tests][AMQP 1.0] Remove duplicate code
> [Broker-J][AMQP 1.0][Tests] Improve protocol tests to be able to run the test
> suite against external broker
> ---
>
> Key: QPID-8349
> URL: https://issues.apache.org/jira/browse/QPID-8349
> Project: Qpid
> Issue Type: Task
> Components: Java Tests
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0
>
>
> The existing protocol test framework allows to run test against external
> broker only when annotation {{RunBrokerAdmin}} is added to the test class
> with a type pointing to external broker admin type.
> With this approach the implemented test can only be executed with a
> particular broker admin type.
> The original intention of protocol tests was to allow running protocol tests
> against any AMQP compliment broker. The specific broker admin needs to be
> injected into the test framework.
> Currently, we have "external" and "embedded" broker admin type, but, there is
> no way to execute protocol tests even against external Qpid broker.
> We need to modify protocol test framework to allow running existing tests
> against external broker
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8350) [Broker-J][AMQP 1.0][Tests] Fix protocol tests
[
https://issues.apache.org/jira/browse/QPID-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921375#comment-16921375
]
ASF subversion and git services commented on QPID-8350:
---
Commit 7d3c767df7a48aacfaface3df97e3356ede61640 in qpid-broker-j's branch
refs/heads/master from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=7d3c767 ]
QPID-8350: [Tests][AMQP 1.0] Rename test suite MalformedMessage into
MalformedMessageTest
> [Broker-J][AMQP 1.0][Tests] Fix protocol tests
> --
>
> Key: QPID-8350
> URL: https://issues.apache.org/jira/browse/QPID-8350
> Project: Qpid
> Issue Type: Task
> Components: Java Tests
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0
>
>
> Existing protocol tests works on a number of assumptions which are valid for
> Qpid Broker-J but when they are run against different broker the majority of
> test fail straight away due to various reasons like "not respecting
> counterpart settings in attach {{initial-delivery-count}}", lacking
> assertions about published/consumed messages, etc.
> As part of this JIRA we need to make tests amqp broker neutral and amqp
> complient
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-2100) Switch from CMake to Bazel?
[ https://issues.apache.org/jira/browse/PROTON-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921367#comment-16921367 ] Jiri Daněk edited comment on PROTON-2100 at 9/3/19 12:00 PM: - I've tried Bazel, for ActiveMQ Artemis. Back in the time before the AIO JNI library was split out of the project. Afaik the main problems with it are: 1) Tooling. There probably isn't that much experience regarding building RPM/DEB packages with Bazel. Although the fact that TensorFlow and other popular projects adopted Bazel is/will change that, slowly. 2) Support for systems besides Linux and Windows. Afaik Windows support is already there. Can Bazel produce artifacts that are easily consumable in CMake, Visual Studio, and language specific package managers like pip or gem, or go get? 3) Dependencies. As I remember, discovering native dependencies with Bazel is painful. Paths to shared libs change between systems. Proton has some optional dependencies. In the Artemis project above I had to do [1] and then [2]. Is there support for pkg-config in Bazel already? 4) Makes build depend on java. Bazel itself is fairly large, ~50 MB. Must be installed on Travis. Benefits: 1) BUILD file language. That is a plus, for me, actually. It is a restricted version of Python. 2) Test isolation. Tests are run in a sandbox, which can include network sandbox based on cgroups/namespaces. No more port clashes. We could possibly have this with CMake as well (reuse what bazel does, it is fairly self-contained). Bazel just brings it out of the box. [1] https://github.com/jdanekrh/activemq-artemis/blob/97fcde8f5d437ab75982304d0722a479140b3ae8/WORKSPACE#L31-L71 [2] https://github.com/jdanekrh/activemq-artemis/blob/97fcde8f5d437ab75982304d0722a479140b3ae8/artemis-native/BUILD#L20-L51 Btw, for discussions, project mailing list is probably better place. was (Author: jdanek): I've tried Bazel, for ActiveMQ Artemis. Back in the time before the AIO JNI library was split out of the project. Afaik the main problems with it are: 1) Tooling. There probably isn't that much experience regarding building RPM/DEB packages with Bazel. Although the fact that TensorFlow and other popular projects adopted Bazel is/will change that, slowly. 2) Dependencies. As I remember, discovering native dependencies with Bazel is painful. Paths to shared libs change between systems. Proton has some optional dependencies. In the Artemis project above I had to do [1] and then [2]. Is there support for pkg-config in Bazel already? 3) Makes build depend on java. Bazel itself is fairly large, ~50 MB. Must be installed on Travis. Benefits: 1) BUILD file language. That is a plus, for me, actually. It is a restricted version of Python. 2) Test isolation. Tests are run in a sandbox, which can include network sandbox based on cgroups/namespaces. No more port clashes. We could possibly have this with CMake as well (reuse what bazel does, it is fairly self-contained). Bazel just brings it out of the box. [1] https://github.com/jdanekrh/activemq-artemis/blob/97fcde8f5d437ab75982304d0722a479140b3ae8/WORKSPACE#L31-L71 [2] https://github.com/jdanekrh/activemq-artemis/blob/97fcde8f5d437ab75982304d0722a479140b3ae8/artemis-native/BUILD#L20-L51 Btw, for discussions, project mailing list is probably better place. > Switch from CMake to Bazel? > --- > > Key: PROTON-2100 > URL: https://issues.apache.org/jira/browse/PROTON-2100 > Project: Qpid Proton > Issue Type: Wish > Components: proton-c >Reporter: Omer Katz >Priority: Major > > Bazel is a modern build system for polygot repositories like qpid-proton. > Using it should simplify how we build and package our bindings and c library. > This issue is an opportunity to discuss if we want to switch and if so, how. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2100) Switch from CMake to Bazel?
[ https://issues.apache.org/jira/browse/PROTON-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921367#comment-16921367 ] Jiri Daněk commented on PROTON-2100: I've tried Bazel, for ActiveMQ Artemis. Back in the time before the AIO JNI library was split out of the project. Afaik the main problems with it are: 1) Tooling. There probably isn't that much experience regarding building RPM/DEB packages with Bazel. Although the fact that TensorFlow and other popular projects adopted Bazel is/will change that, slowly. 2) Dependencies. As I remember, discovering native dependencies with Bazel is painful. Paths to shared libs change between systems. Proton has some optional dependencies. In the Artemis project above I had to do [1] and then [2]. Is there support for pkg-config in Bazel already? 3) Makes build depend on java. Bazel itself is fairly large, ~50 MB. Must be installed on Travis. Benefits: 1) BUILD file language. That is a plus, for me, actually. It is a restricted version of Python. 2) Test isolation. Tests are run in a sandbox, which can include network sandbox based on cgroups/namespaces. No more port clashes. We could possibly have this with CMake as well (reuse what bazel does, it is fairly self-contained). Bazel just brings it out of the box. [1] https://github.com/jdanekrh/activemq-artemis/blob/97fcde8f5d437ab75982304d0722a479140b3ae8/WORKSPACE#L31-L71 [2] https://github.com/jdanekrh/activemq-artemis/blob/97fcde8f5d437ab75982304d0722a479140b3ae8/artemis-native/BUILD#L20-L51 Btw, for discussions, project mailing list is probably better place. > Switch from CMake to Bazel? > --- > > Key: PROTON-2100 > URL: https://issues.apache.org/jira/browse/PROTON-2100 > Project: Qpid Proton > Issue Type: Wish > Components: proton-c >Reporter: Omer Katz >Priority: Major > > Bazel is a modern build system for polygot repositories like qpid-proton. > Using it should simplify how we build and package our bindings and c library. > This issue is an opportunity to discuss if we want to switch and if so, how. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2100) Switch from CMake to Bazel?
Omer Katz created PROTON-2100: - Summary: Switch from CMake to Bazel? Key: PROTON-2100 URL: https://issues.apache.org/jira/browse/PROTON-2100 Project: Qpid Proton Issue Type: Wish Components: proton-c Reporter: Omer Katz Bazel is a modern build system for polygot repositories like qpid-proton. Using it should simplify how we build and package our bindings and c library. This issue is an opportunity to discuss if we want to switch and if so, how. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-jms] coheigea opened a new pull request #31: Make sure reader is properly closed
coheigea opened a new pull request #31: Make sure reader is properly closed URL: https://github.com/apache/qpid-jms/pull/31 This is a trivial fix to make sure that a BufferedReader is closed even in the case of an exception. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
