Re: [VOTE] Release Qpid Dispatch Router 1.9.0 (RC1)
May I vote DELAY? Could you please not conclude this vote until you receive my vote? I am seeing something that I don't understand with a large multicast test, and I would like to cast my vote only after I have a chance to talk to Ken Giusti about it. Unfortunately I am out today seeing a doctor about a brain transplant, but I think I will be able to contact Ken sometime today if all goes well and we will get this resolved. On Mon, Sep 9, 2019 at 5:36 PM Ganesh Murthy wrote: > Hello All, > > Please cast your vote on this thread to release RC1 as the > official Qpid Dispatch Router version 1.9.0. > > RC1 of Qpid Dispatch Router version 1.9.0 can be found here: > > https://dist.apache.org/repos/dist/dev/qpid/dispatch/1.9.0-rc1/ > > The following improvements, and bug fixes are introduced in 1.9.0: > > Improvements - > DISPATCH-480 - Default tests timeout is too short for some machines > DISPATCH-1266 - Improve router's handling of unsettled multicast > deliveries > DISPATCH-1338 - Improvements to edge router documentation > DISPATCH-1345 - Reduce the number of QDR_LINK_FLOW events by > coalescing credit grants > DISPATCH-1346 - Create documentation for priority delivery > DISPATCH-1347 - Update documentation for Dispatch Router console > DISPATCH-1350 - Update logging/monitoring documentation > DISPATCH-1353 - Document how to configure access policy control on > router-initiated connections > DISPATCH-1354 - Interrouter annotation processing uses slow methods > DISPATCH-1370 - Move the schema, connect, and entities tabs to the > right in the console > DISPATCH-1372 - alloc_pool intrusive linked list can be replaced > by a linked stack > DISPATCH-1374 - Add qdstat options --all-routers and all-entities > which display statistics of all routers and displays all entities > DISPATCH-1376 - Make it easier to change the product name in the > console > DISPATCH-1379 - Message receive performance improvements > DISPATCH-1381 - Create documentation for configuring fallback > destinations > DISPATCH-1382 - Document ability to force-close a connection from > the web console > DISPATCH-1385 - qd_message_list_t is dead code > DISPATCH-1388 - Authorization doc fails to describe vhost > abstraction clearly > DISPATCH-1396 - Doc how to start the router > > Bug fixes - > DISPATCH-1359 - Set ctest timeout to 300 seconds. > DISPATCH-1361 - system_tests_fallback_dest hanging in some cases > DISPATCH-1362 - Shutdown crash when trying to clean up fallback > addresses > DISPATCH-1365 - Table of links with delayed deliveries is showing > all endpoint links > DISPATCH-1378 - missing lock of connection's links_with_work list > DISPATCH-1380 - qdrouterd leaves dangling qd_link_t pointer > DISPATCH-1383 - system_tests_policy is timing out > DISPATCH-1387 - Coverity issues on master branch > DISPATCH-1391 - Proton link reference not cleared on router link > objects during session close > DISPATCH-1394 - qd_check_message() incorrectly validates partially > received messages > DISPATCH-1398 - "Expression with no effect" warning for console web > DISPATCH-1404 - message annotation parsing incorrectly uses > ->remainder for current buffer capacity > DISPATCH-1406 - Inter-router link stall on receive client failover > DISPATCH-1407 - Memory leak on link policy denial > DISPATCH-1408 - system_tests_distribution failing when running > under valgrind > DISPATCH-1410 - attach of auto-links not logged > DISPATCH-1413 - system_tests_two_routers.py failing intermittently on > Travis > > > Thanks. > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
[jira] [Updated] (QPID-8361) [Broker-J] Create a developer guide for Qpid Broker-J
[ https://issues.apache.org/jira/browse/QPID-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8361: - Description: The developer documentation is currently scattered over various Qpid confluence pages. It could be challenging for people interested in contributing to the project to find that documentation. A developer guide could be added to cover such aspects as * Environment Setup * Building project * Running tests * Releasing * Architecture overview The following wiki pages are good candidates for inclusion into a developer guide: [High Level Architecture|https://cwiki.apache.org/confluence/display/qpid/High+Level+Architecture] [How To Build Qpid Broker-J|https://cwiki.apache.org/confluence/display/qpid/How+To+Build+Qpid+Broker-J] [Releasing Qpid Broker-J|https://cwiki.apache.org/confluence/display/qpid/Releasing+Qpid+Broker-J] The wiki pages below might be included as well [Java Coding Standards|https://cwiki.apache.org/confluence/display/qpid/Java+Coding+Standards] [Qpid Java Run Scripts|https://cwiki.apache.org/confluence/display/qpid/Qpid+Java+Run+Scripts] The developer documentation should be easy to modify, maintain and preview. Thus, it can be written in markdown or [asciidoc|https://asciidoctor.org/docs/asciidoc-syntax-quick-reference/]. The latter is also supported on github. Potentially, it can be published on Qpid project site as part of release process. was: The developer documentation is currently scattered over various Qpid confluence pages. It could be challenging for people interesting in contributing to the project to find that documentation. A developer guide could be added to cover such aspects as * Environment Setup * Building project * Running tests * Releasing * Architecture overview The following wiki pages are good candidates for inclusion into a developer guide: [High Level Architecture|https://cwiki.apache.org/confluence/display/qpid/High+Level+Architecture] [How To Build Qpid Broker-J|https://cwiki.apache.org/confluence/display/qpid/How+To+Build+Qpid+Broker-J] [Releasing Qpid Broker-J|https://cwiki.apache.org/confluence/display/qpid/Releasing+Qpid+Broker-J] The wiki pages below might be included as well [Java Coding Standards|https://cwiki.apache.org/confluence/display/qpid/Java+Coding+Standards] [Qpid Java Run Scripts|https://cwiki.apache.org/confluence/display/qpid/Qpid+Java+Run+Scripts] The developer documentation should be easy to modify, maintain and preview. Thus, it can be written in markdown or [asciidoc|https://asciidoctor.org/docs/asciidoc-syntax-quick-reference/]. The latter is also supported on github. Potentially, it can be published on Qpid project site as part of release process. > [Broker-J] Create a developer guide for Qpid Broker-J > - > > Key: QPID-8361 > URL: https://issues.apache.org/jira/browse/QPID-8361 > Project: Qpid > Issue Type: Task > Components: Broker-J >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-8.0.0 > > > The developer documentation is currently scattered over various Qpid > confluence pages. It could be challenging for people interested in > contributing to the project to find that documentation. A developer guide > could be added to cover such aspects as > * Environment Setup > * Building project > * Running tests > * Releasing > * Architecture overview > The following wiki pages are good candidates for inclusion into a developer > guide: > [High Level > Architecture|https://cwiki.apache.org/confluence/display/qpid/High+Level+Architecture] > [How To Build Qpid > Broker-J|https://cwiki.apache.org/confluence/display/qpid/How+To+Build+Qpid+Broker-J] > [Releasing Qpid > Broker-J|https://cwiki.apache.org/confluence/display/qpid/Releasing+Qpid+Broker-J] > The wiki pages below might be included as well > [Java Coding > Standards|https://cwiki.apache.org/confluence/display/qpid/Java+Coding+Standards] > [Qpid Java Run > Scripts|https://cwiki.apache.org/confluence/display/qpid/Qpid+Java+Run+Scripts] > The developer documentation should be easy to modify, maintain and preview. > Thus, it can be written in markdown or > [asciidoc|https://asciidoctor.org/docs/asciidoc-syntax-quick-reference/]. The > latter is also supported on github. > Potentially, it can be published on Qpid project site as part of release > process. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8361) [Broker-J] Create a developer guide for Qpid Broker-J
Alex Rudyy created QPID-8361: Summary: [Broker-J] Create a developer guide for Qpid Broker-J Key: QPID-8361 URL: https://issues.apache.org/jira/browse/QPID-8361 Project: Qpid Issue Type: Task Components: Broker-J Reporter: Alex Rudyy Fix For: qpid-java-broker-8.0.0 The developer documentation is currently scattered over various Qpid confluence pages. It could be challenging for people interesting in contributing to the project to find that documentation. A developer guide could be added to cover such aspects as * Environment Setup * Building project * Running tests * Releasing * Architecture overview The following wiki pages are good candidates for inclusion into a developer guide: [High Level Architecture|https://cwiki.apache.org/confluence/display/qpid/High+Level+Architecture] [How To Build Qpid Broker-J|https://cwiki.apache.org/confluence/display/qpid/How+To+Build+Qpid+Broker-J] [Releasing Qpid Broker-J|https://cwiki.apache.org/confluence/display/qpid/Releasing+Qpid+Broker-J] The wiki pages below might be included as well [Java Coding Standards|https://cwiki.apache.org/confluence/display/qpid/Java+Coding+Standards] [Qpid Java Run Scripts|https://cwiki.apache.org/confluence/display/qpid/Qpid+Java+Run+Scripts] The developer documentation should be easy to modify, maintain and preview. Thus, it can be written in markdown or [asciidoc|https://asciidoctor.org/docs/asciidoc-syntax-quick-reference/]. The latter is also supported on github. Potentially, it can be published on Qpid project site as part of release process. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1416) Policy log could include denial counts on connection close
Chuck Rolke created DISPATCH-1416: - Summary: Policy log could include denial counts on connection close Key: DISPATCH-1416 URL: https://issues.apache.org/jira/browse/DISPATCH-1416 Project: Qpid Dispatch Issue Type: Improvement Components: Policy Engine Affects Versions: 1.8.0 Reporter: Chuck Rolke Assignee: Chuck Rolke Currently the Policy module logs the number of active sessions, senders, receivers, and nConnections(see below) on a connection when it is closed. This list could be expanded to include the policy statistics block that counts sessions, senders, and receiver denials. nConnections is the current live number of total incoming connections managed by policy and is not directly related to the current connection. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-6490) Configure SSL ciphers
[ https://issues.apache.org/jira/browse/QPID-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926756#comment-16926756 ] Trang Vo commented on QPID-6490: I updated /qpid-cpp-1.39.0/src/qpid/sys/ssl/util.h and util.cpp files to allow TLS version and cipher suites selections to be set in the broker config file. Please take a look at the attached files! What is the process and timeline to get this enhancement into the next release? > Configure SSL ciphers > - > > Key: QPID-6490 > URL: https://issues.apache.org/jira/browse/QPID-6490 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker >Affects Versions: 0.30 > Environment: Linux >Reporter: Brant Knudson >Priority: Major > Labels: security > Attachments: util.cpp, util.h > > > qpid-cpp must allow an admin to set the SSL ciphers / protocols that they > want the server to allow. The default should be ciphers / protocols that > don't have known security vulnerabilities like SSLv3 (POODLE) and RC4 ciphers > (Bar Mitzvah) > With CVE-2015-2808 (a.k.a. Bar Mitzvah affecting RC4 ciphers) and other > recent vulnerabilities found in different ciphers / protocols, we need to be > able to disable ciphers / protocols easily. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-6490) Configure SSL ciphers
[ https://issues.apache.org/jira/browse/QPID-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trang Vo updated QPID-6490: --- Attachment: util.h util.cpp > Configure SSL ciphers > - > > Key: QPID-6490 > URL: https://issues.apache.org/jira/browse/QPID-6490 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker >Affects Versions: 0.30 > Environment: Linux >Reporter: Brant Knudson >Priority: Major > Labels: security > Attachments: util.cpp, util.h > > > qpid-cpp must allow an admin to set the SSL ciphers / protocols that they > want the server to allow. The default should be ciphers / protocols that > don't have known security vulnerabilities like SSLv3 (POODLE) and RC4 ciphers > (Bar Mitzvah) > With CVE-2015-2808 (a.k.a. Bar Mitzvah affecting RC4 ciphers) and other > recent vulnerabilities found in different ciphers / protocols, we need to be > able to disable ciphers / protocols easily. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1368) Link (address) priority is ignored by the second hop router
[ https://issues.apache.org/jira/browse/DISPATCH-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-1368: - Affects Version/s: 1.9.0 > Link (address) priority is ignored by the second hop router > --- > > Key: DISPATCH-1368 > URL: https://issues.apache.org/jira/browse/DISPATCH-1368 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.8.0, 1.9.0 >Reporter: Ken Giusti >Assignee: michael goulish >Priority: Major > > Address-based priority is only enforced on the egress of the first hop router. > In a 3 router linear network: > Sender --> Router A --> Router B --> Router C --> Receiver > Message delivery is properly sent via the inter-router links between Router A > and Router B. > However, those messages are all forwarded on the default priority (4) between > router B and C. > [C --> Receiver is fine - priority doesn't apply to egress endpoint links] > The expectation is that the message priority is honored across all > inter-router links. > [Reproducer|https://github.com/kgiusti/dispatch/tree/DISPATCH-1368-reproducer] > Build the router, then run the priority test (ctest -VV -R priority). > Then grep for "DELIVERIES" in the log files: > grep "DELIVERIES" > tests/system_test.dir/system_tests_priority/CongestionTests/setUpClass/*.log > tests/system_test.dir/system_tests_priority/CongestionTests/setUpClass/A.log:2019-06-14 > 11:10:00.324389 -0400 ROUTER (error) DELIVERIES PER PRIORITY: 9=20 8=0 7=28 > 6=0 5=0 4(default)=21 3=0 2=12 1=0 0=343 > (/home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:188) > tests/system_test.dir/system_tests_priority/CongestionTests/setUpClass/B.log:2019-06-14 > 11:10:00.302570 -0400 ROUTER (error) DELIVERIES PER PRIORITY: 9=0 8=0 7=0 > 6=0 5=0 4(default)=172 3=0 2=0 1=0 0=286 > (/home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:188) > ... > Notice the counts on A (tx to B) - these are correct. > On B all msgs are sent priority 4 (default) to C - this is wrong. > > > > -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1373) the log system mutex is held far too long
[ https://issues.apache.org/jira/browse/DISPATCH-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-1373: - Affects Version/s: 1.9.0 > the log system mutex is held far too long > - > > Key: DISPATCH-1373 > URL: https://issues.apache.org/jira/browse/DISPATCH-1373 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.8.0, 1.9.0 >Reporter: Ken Giusti >Priority: Major > > The log code holds the log mutex(s) too long. Depending on the log level > (trace+ is worst) the lock has been observed being held for > 30 milliseconds. > The log lock is a singleton that is acquired by all calls to qd_log (active > log level only) - which means it is a global lock. > It appears as if the lock is held while doing I/O and alloc/dealloc'ing > memory - which may be expensive (in qd_vlog_impl() in log.c): > > {{ // Bounded buffer of log entries, keep most recent.}} > {{ *sys_mutex_lock(log_lock);*}} > {{ qd_log_entry_t *entry = new_qd_log_entry_t();}} > {{ DEQ_ITEM_INIT(entry);}} > {{ entry->module = source->module;}} > {{ entry->level = level;}} > {{ entry->file = file ? strdup(file) : 0;}} > {{ entry->line = line;}} > {{ gettimeofday(&entry->time, NULL);}} > {{ vsnprintf(entry->text, TEXT_MAX, fmt, ap);}} > {{ write_log(source, entry);}} > {{ DEQ_INSERT_TAIL(entries, entry);}} > {{ if (DEQ_SIZE(entries) > LIST_MAX)}} > {{ qd_log_entry_free_lh(DEQ_HEAD(entries));}} > {{ *sys_mutex_unlock(log_lock);*}}{{}} > -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1414) Include source/target address in the policy DENY info messages
[ https://issues.apache.org/jira/browse/DISPATCH-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926379#comment-16926379 ] Keith Wall edited comment on DISPATCH-1414 at 9/10/19 7:24 AM: --- Sorry - my error. I thought that '' was the link name. I see now that I am wrong. It would of course, be nice to see the link name in the message too :). was (Author: k-wall): Sorry - my error. I thought that '' was the link name. I see now that I am wrong, > Include source/target address in the policy DENY info messages > -- > > Key: DISPATCH-1414 > URL: https://issues.apache.org/jira/browse/DISPATCH-1414 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Assignee: Chuck Rolke >Priority: Major > Attachments: DISPATCH-1414.txt > > > The policy DENY info message currently omits the source/target address. This > impedes the diagnosis of policy misconfigurations. Currently the message > looks like this: > {{POLICY (info) [1228]: DENY AMQP Attach sender link '' for user 'u', > rhost '10.128.6.1', vhost 'vv' based on link target name}} -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1414) Include source/target address in the policy DENY info messages
[ https://issues.apache.org/jira/browse/DISPATCH-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926379#comment-16926379 ] Keith Wall commented on DISPATCH-1414: -- Sorry - my error. I thought that '' was the link name. I see now that I am wrong, > Include source/target address in the policy DENY info messages > -- > > Key: DISPATCH-1414 > URL: https://issues.apache.org/jira/browse/DISPATCH-1414 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Assignee: Chuck Rolke >Priority: Major > Attachments: DISPATCH-1414.txt > > > The policy DENY info message currently omits the source/target address. This > impedes the diagnosis of policy misconfigurations. Currently the message > looks like this: > {{POLICY (info) [1228]: DENY AMQP Attach sender link '' for user 'u', > rhost '10.128.6.1', vhost 'vv' based on link target name}} -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org