[jira] [Commented] (PROTON-2109) [Python] Correct default JSON schema to amqps

2019-09-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938322#comment-16938322
 ] 

ASF GitHub Bot commented on PROTON-2109:


rkubis commented on issue #190: PROTON-2109: [Python] Correct default JSON 
schema to amqps
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535365622
 
 
   @astitcher The Python tests are fixed now.
   
   I was not sure if the fix of the Python tests should be in a separate commit 
or not, I squashed the Python tests fix with the Python library fix into one 
commit.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] Correct default JSON schema to amqps
> -
>
> Key: PROTON-2109
> URL: https://issues.apache.org/jira/browse/PROTON-2109
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Reporter: Radim Kubis
>Priority: Major
>
> According to 
> [connect-config.md|https://github.com/apache/qpid-proton/blob/master/docs/connect-config.md],
>  default port should be \{{amqps}}, but there is \{{amqp}} now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] rkubis commented on issue #190: PROTON-2109: [Python] Correct default JSON schema to amqps

2019-09-25 Thread GitBox
rkubis commented on issue #190: PROTON-2109: [Python] Correct default JSON 
schema to amqps
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535365622
 
 
   @astitcher The Python tests are fixed now.
   
   I was not sure if the fix of the Python tests should be in a separate commit 
or not, I squashed the Python tests fix with the Python library fix into one 
commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2109) [Python] Correct default JSON schema to amqps

2019-09-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938025#comment-16938025
 ] 

ASF GitHub Bot commented on PROTON-2109:


astitcher commented on issue #190: PROTON-2109: [Python] Correct default JSON 
schema to amqps
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535188274
 
 
   @rkubis Sorry I just realised this change makes the python tests hang. You 
need to go into the python tests for the connect.json file and fix them up to 
carry on working. look in python/tests/proton_tests/connect.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] Correct default JSON schema to amqps
> -
>
> Key: PROTON-2109
> URL: https://issues.apache.org/jira/browse/PROTON-2109
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Reporter: Radim Kubis
>Priority: Major
>
> According to 
> [connect-config.md|https://github.com/apache/qpid-proton/blob/master/docs/connect-config.md],
>  default port should be \{{amqps}}, but there is \{{amqp}} now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] astitcher commented on issue #190: PROTON-2109: [Python] Correct default JSON schema to amqps

2019-09-25 Thread GitBox
astitcher commented on issue #190: PROTON-2109: [Python] Correct default JSON 
schema to amqps
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535188274
 
 
   @rkubis Sorry I just realised this change makes the python tests hang. You 
need to go into the python tests for the connect.json file and fix them up to 
carry on working. look in python/tests/proton_tests/connect.py


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1431) system_tests_one_router_failing on test_19_semantics_multicast

2019-09-25 Thread Ganesh Murthy (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1431:

Description: 
Turn on valgrind and compile the router code.
{noformat}
make clean
cmake .. -DUSE_VALGRIND=Yes -DVALGRIND_XML=Yes
make install{noformat}
Then run test_19_semantics_multicast
{noformat}
[gmurthy@localhost build]$ /usr/bin/python 
"/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
"-v" "system_tests_one_router.OneRouterTest.test_19_semantics_multicast"
test_19_semantics_multicast (system_tests_one_router.OneRouterTest) ... 
FAIL==
FAIL: test_19_semantics_multicast (system_tests_one_router.OneRouterTest)
--
Traceback (most recent call last):
  File 
"/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_one_router.py", line 
264, in test_19_semantics_multicast
self.assertEqual(None, test.error)
AssertionError: None != u'Timeout Expired: sent=1 
rcvd=0/1/0'--
Ran 1 test in 65.460sFAILED (failures=1)
[gmurthy@localhost build]$ 
 {noformat}

  was:
{noformat}
[gmurthy@localhost build]$ /usr/bin/python 
"/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
"-v" "system_tests_one_router.OneRouterTest.test_19_semantics_multicast"
test_19_semantics_multicast (system_tests_one_router.OneRouterTest) ... 
FAIL==
FAIL: test_19_semantics_multicast (system_tests_one_router.OneRouterTest)
--
Traceback (most recent call last):
  File 
"/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_one_router.py", line 
264, in test_19_semantics_multicast
self.assertEqual(None, test.error)
AssertionError: None != u'Timeout Expired: sent=1 
rcvd=0/1/0'--
Ran 1 test in 65.460sFAILED (failures=1)
[gmurthy@localhost build]$ 
 {noformat}


> system_tests_one_router_failing on test_19_semantics_multicast
> --
>
> Key: DISPATCH-1431
> URL: https://issues.apache.org/jira/browse/DISPATCH-1431
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.9.0
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.10.0
>
>
> Turn on valgrind and compile the router code.
> {noformat}
> make clean
> cmake .. -DUSE_VALGRIND=Yes -DVALGRIND_XML=Yes
> make install{noformat}
> Then run test_19_semantics_multicast
> {noformat}
> [gmurthy@localhost build]$ /usr/bin/python 
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_one_router.OneRouterTest.test_19_semantics_multicast"
> test_19_semantics_multicast (system_tests_one_router.OneRouterTest) ... 
> FAIL==
> FAIL: test_19_semantics_multicast (system_tests_one_router.OneRouterTest)
> --
> Traceback (most recent call last):
>   File 
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_one_router.py", 
> line 264, in test_19_semantics_multicast
> self.assertEqual(None, test.error)
> AssertionError: None != u'Timeout Expired: sent=1 
> rcvd=0/1/0'--
> Ran 1 test in 65.460sFAILED (failures=1)
> [gmurthy@localhost build]$ 
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1431) system_tests_one_router_failing on test_19_semantics_multicast

2019-09-25 Thread Ganesh Murthy (Jira)
Ganesh Murthy created DISPATCH-1431:
---

 Summary: system_tests_one_router_failing on 
test_19_semantics_multicast
 Key: DISPATCH-1431
 URL: https://issues.apache.org/jira/browse/DISPATCH-1431
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Tests
Affects Versions: 1.9.0
Reporter: Ganesh Murthy
Assignee: Ken Giusti
 Fix For: 1.10.0


{noformat}
[gmurthy@localhost build]$ /usr/bin/python 
"/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
"-v" "system_tests_one_router.OneRouterTest.test_19_semantics_multicast"
test_19_semantics_multicast (system_tests_one_router.OneRouterTest) ... 
FAIL==
FAIL: test_19_semantics_multicast (system_tests_one_router.OneRouterTest)
--
Traceback (most recent call last):
  File 
"/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_one_router.py", line 
264, in test_19_semantics_multicast
self.assertEqual(None, test.error)
AssertionError: None != u'Timeout Expired: sent=1 
rcvd=0/1/0'--
Ran 1 test in 65.460sFAILED (failures=1)
[gmurthy@localhost build]$ 
 {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2109) [Python] Correct default JSON schema to amqps

2019-09-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937987#comment-16937987
 ] 

ASF GitHub Bot commented on PROTON-2109:


rkubis commented on issue #190: PROTON-2109: [Python] Correct default JSON 
schema to amqps
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535157430
 
 
   JIRA https://issues.apache.org/jira/browse/PROTON-2109 raised and the change 
re-pushed.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] Correct default JSON schema to amqps
> -
>
> Key: PROTON-2109
> URL: https://issues.apache.org/jira/browse/PROTON-2109
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Reporter: Radim Kubis
>Priority: Major
>
> According to 
> [connect-config.md|https://github.com/apache/qpid-proton/blob/master/docs/connect-config.md],
>  default port should be \{{amqps}}, but there is \{{amqp}} now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] rkubis edited a comment on issue #190: PROTON-2109: [Python] Correct default JSON schema to amqps

2019-09-25 Thread GitBox
rkubis edited a comment on issue #190: PROTON-2109: [Python] Correct default 
JSON schema to amqps
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535157430
 
 
   JIRA [PROTON-2109](https://issues.apache.org/jira/browse/PROTON-2109) raised 
and the change re-pushed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2109) [Python] Correct default JSON schema to amqps

2019-09-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937988#comment-16937988
 ] 

ASF GitHub Bot commented on PROTON-2109:


rkubis commented on issue #190: PROTON-2109: [Python] Correct default JSON 
schema to amqps
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535157430
 
 
   JIRA [PROTON-2109](https://issues.apache.org/jira/browse/PROTON-2109) raised 
and the change re-pushed.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] Correct default JSON schema to amqps
> -
>
> Key: PROTON-2109
> URL: https://issues.apache.org/jira/browse/PROTON-2109
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Reporter: Radim Kubis
>Priority: Major
>
> According to 
> [connect-config.md|https://github.com/apache/qpid-proton/blob/master/docs/connect-config.md],
>  default port should be \{{amqps}}, but there is \{{amqp}} now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] rkubis commented on issue #190: PROTON-2109: [Python] Correct default JSON schema to amqps

2019-09-25 Thread GitBox
rkubis commented on issue #190: PROTON-2109: [Python] Correct default JSON 
schema to amqps
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535157430
 
 
   JIRA https://issues.apache.org/jira/browse/PROTON-2109 raised and the change 
re-pushed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-2109) [Python] Correct default JSON schema to amqps

2019-09-25 Thread Radim Kubis (Jira)
Radim Kubis created PROTON-2109:
---

 Summary: [Python] Correct default JSON schema to amqps
 Key: PROTON-2109
 URL: https://issues.apache.org/jira/browse/PROTON-2109
 Project: Qpid Proton
  Issue Type: Bug
  Components: python-binding
Reporter: Radim Kubis


According to 
[connect-config.md|https://github.com/apache/qpid-proton/blob/master/docs/connect-config.md],
 default port should be \{{amqps}}, but there is \{{amqp}} now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] rkubis commented on issue #190: FIX(python): Use amqps port as default

2019-09-25 Thread GitBox
rkubis commented on issue #190: FIX(python): Use amqps port as default
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535152139
 
 
   > @rkubis - In order to keep the git log good would you raise a JIRA for 
this change and then repush this change with a commit log like:
   > PROTON-2xxx: [Python] correct default json schema to amqps
   
   Yes, no problem, I will raise a JIRA and then repush the change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2105) Support Go modules

2019-09-25 Thread Roddie Kieley (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937971#comment-16937971
 ] 

Roddie Kieley commented on PROTON-2105:
---

[~lulf] Will take a look at your PR when I get a chance.

> Support Go modules
> --
>
> Key: PROTON-2105
> URL: https://issues.apache.org/jira/browse/PROTON-2105
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: go-binding
>Reporter: Ulf Lilleengen
>Assignee: Roddie Kieley
>Priority: Major
>
> As of Go 1.12, go module support is available. In order to manage 
> dependencies using go modules, dependencies must also be using go modules. 
> Therefore, adding a go.mod file to each module would allow qpid proton go 
> bindings to be managed as a go module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2107) Go module support

2019-09-25 Thread Roddie Kieley (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937969#comment-16937969
 ] 

Roddie Kieley commented on PROTON-2107:
---

This potentially duplicates PROTON-2105, although will wait until I get a 
chance to take a look / reproduce before marking it a duplicate for sure.

> Go module support
> -
>
> Key: PROTON-2107
> URL: https://issues.apache.org/jira/browse/PROTON-2107
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: build
>Affects Versions: proton-c-0.29.0
>Reporter: Thtiphong Anansukkasem
>Assignee: Roddie Kieley
>Priority: Major
>
> I found the error , when i run "go get" command in go module enabled project
> $go get -v qpid.apache.org/electron
> go: finding qpid.apache.org latest
> go get qpid.apache.org/electron: module qpid.apache.org@upgrade 
> (v0.0.0-20190919033840-551513f49822) found, but does not contain package 
> qpid.apache.org/electron
> $ go get -v qpid.apache.org/amqp
> go: finding qpid.apache.org latest
> go get qpid.apache.org/amqp: module qpid.apache.org@upgrade 
> (v0.0.0-20190919033840-551513f49822) found, but does not contain package 
> qpid.apache.org/amqp
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (PROTON-2107) Go module support

2019-09-25 Thread Roddie Kieley (Jira)


 [ 
https://issues.apache.org/jira/browse/PROTON-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roddie Kieley reassigned PROTON-2107:
-

Assignee: Roddie Kieley

> Go module support
> -
>
> Key: PROTON-2107
> URL: https://issues.apache.org/jira/browse/PROTON-2107
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: build
>Affects Versions: proton-c-0.29.0
>Reporter: Thtiphong Anansukkasem
>Assignee: Roddie Kieley
>Priority: Major
>
> I found the error , when i run "go get" command in go module enabled project
> $go get -v qpid.apache.org/electron
> go: finding qpid.apache.org latest
> go get qpid.apache.org/electron: module qpid.apache.org@upgrade 
> (v0.0.0-20190919033840-551513f49822) found, but does not contain package 
> qpid.apache.org/electron
> $ go get -v qpid.apache.org/amqp
> go: finding qpid.apache.org latest
> go get qpid.apache.org/amqp: module qpid.apache.org@upgrade 
> (v0.0.0-20190919033840-551513f49822) found, but does not contain package 
> qpid.apache.org/amqp
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (PROTON-2105) Support Go modules

2019-09-25 Thread Roddie Kieley (Jira)


 [ 
https://issues.apache.org/jira/browse/PROTON-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roddie Kieley reassigned PROTON-2105:
-

Assignee: Roddie Kieley

> Support Go modules
> --
>
> Key: PROTON-2105
> URL: https://issues.apache.org/jira/browse/PROTON-2105
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: go-binding
>Reporter: Ulf Lilleengen
>Assignee: Roddie Kieley
>Priority: Major
>
> As of Go 1.12, go module support is available. In order to manage 
> dependencies using go modules, dependencies must also be using go modules. 
> Therefore, adding a go.mod file to each module would allow qpid proton go 
> bindings to be managed as a go module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] astitcher commented on issue #190: FIX(python): Use amqps port as default

2019-09-25 Thread GitBox
astitcher commented on issue #190: FIX(python): Use amqps port as default
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535138220
 
 
   @rkubis - In order to keep the git log good would you raise a JIRA for this 
change and then repush this change with a commit log like:
   PROTON-2xxx: [Python] correct default json schema to amqps


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] astitcher commented on issue #190: FIX(python): Use amqps port as default

2019-09-25 Thread GitBox
astitcher commented on issue #190: FIX(python): Use amqps port as default
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535137004
 
 
   I just checked and the C++ implementation uses amqps as default so I will 
merge this PR.
   
   Thanks @rkubis .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] ssorj commented on issue #190: FIX(python): Use amqps port as default

2019-09-25 Thread GitBox
ssorj commented on issue #190: FIX(python): Use amqps port as default
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535125509
 
 
   I worked from the written spec and docs from Alan, which has "amqps" as the 
default.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] astitcher commented on issue #190: FIX(python): Use amqps port as default

2019-09-25 Thread GitBox
astitcher commented on issue #190: FIX(python): Use amqps port as default
URL: https://github.com/apache/qpid-proton/pull/190#issuecomment-535112331
 
 
   I'm not sure if this is the best thing or to change the documentation to 
match the implementation.
   As far as I remember the default should be 'amqp' not 'amqps' that is what 
the other json connect config readers use as default.
   @ssorj - Do you have insight here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8362) Message sent with 'int8_t' value property is corrupted

2019-09-25 Thread Michal Kasperek (Jira)


 [ 
https://issues.apache.org/jira/browse/QPID-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michal Kasperek updated QPID-8362:
--
Environment: 
 QPID C++ version 1.39.0, master: c58d88b32d294d048ae064e7948f703bed3a7fa0

amqp 1.0

Windows 10

Library compiled with Visual Studio toolchain: msvc-12, 64 bits, Debug

qpid-cpp\src\qpid\messaging\ interface used.

  was:
 

Windows 10.

Library compiled with Visual Studio toolchain: msvc-12, 64 bits, Debug

qpid-cpp\src\qpid\messaging\ interface used.


> Message sent with 'int8_t' value property is corrupted
> --
>
> Key: QPID-8362
> URL: https://issues.apache.org/jira/browse/QPID-8362
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: qpid-cpp-1.40.0
> Environment:  QPID C++ version 1.39.0, master: 
> c58d88b32d294d048ae064e7948f703bed3a7fa0
> amqp 1.0
> Windows 10
> Library compiled with Visual Studio toolchain: msvc-12, 64 bits, Debug
> qpid-cpp\src\qpid\messaging\ interface used.
>Reporter: Michal Kasperek
>Priority: Major
> Attachments: image-2019-09-25-13-46-54-001.png
>
>
> Message sent with 'int8_t' value property is corrupted. The type is 
> interpreted as long.
> This issue is only observed with int8_t type.
> ...
>  qpid::messaging::Sender m_sender;
>  ...
> const std::string msgString = "this is the message string";
> auto msg = Message(msgString);
>  Variant::Map content;
> int8_t value = 1;
>  content["CustomInt8"] = value;
>  msg.setProperties(content);
>  m_sender.send(msg, true);
> !image-2019-09-25-13-46-54-001.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8362) Message sent with 'int8_t' value property is corrupted

2019-09-25 Thread Michal Kasperek (Jira)


 [ 
https://issues.apache.org/jira/browse/QPID-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michal Kasperek updated QPID-8362:
--
Environment: 
 

Windows 10.

Library compiled with Visual Studio toolchain: msvc-12, 64 bits, Debug

qpid-cpp\src\qpid\messaging\ interface used.

  was:
Windows 10.

Library compiled with Visual Studio toolchain: msvc-12, 64 bits, Debug

qpid-cpp\src\qpid\messaging\ interface used.


> Message sent with 'int8_t' value property is corrupted
> --
>
> Key: QPID-8362
> URL: https://issues.apache.org/jira/browse/QPID-8362
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: qpid-cpp-1.40.0
> Environment:  
> Windows 10.
> Library compiled with Visual Studio toolchain: msvc-12, 64 bits, Debug
> qpid-cpp\src\qpid\messaging\ interface used.
>Reporter: Michal Kasperek
>Priority: Major
> Attachments: image-2019-09-25-13-46-54-001.png
>
>
> Message sent with 'int8_t' value property is corrupted. The type is 
> interpreted as long.
> This issue is only observed with int8_t type.
> ...
>  qpid::messaging::Sender m_sender;
>  ...
> const std::string msgString = "this is the message string";
> auto msg = Message(msgString);
>  Variant::Map content;
> int8_t value = 1;
>  content["CustomInt8"] = value;
>  msg.setProperties(content);
>  m_sender.send(msg, true);
> !image-2019-09-25-13-46-54-001.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-8362) Messsage property of int8 type

2019-09-25 Thread Michal Kasperek (Jira)
Michal Kasperek created QPID-8362:
-

 Summary: Messsage property of int8 type 
 Key: QPID-8362
 URL: https://issues.apache.org/jira/browse/QPID-8362
 Project: Qpid
  Issue Type: Bug
  Components: C++ Client
Affects Versions: qpid-cpp-1.40.0
 Environment: Windows 10.

Library compiled with Visual Studio toolchain: msvc-12, 64 bits, Debug

qpid-cpp\src\qpid\messaging\ interface used.
Reporter: Michal Kasperek
 Attachments: image-2019-09-25-13-46-54-001.png

Message sent with 'int8_t' value property is corrupted. The type is interpreted 
as long.

This issue is only observed with int8_t type.

...
 qpid::messaging::Sender m_sender;
 ...

const std::string msgString = "this is the message string";

auto msg = Message(msgString);
 Variant::Map content;

int8_t value = 1;
 content["CustomInt8"] = value;
 msg.setProperties(content);
 m_sender.send(msg, true);

!image-2019-09-25-13-46-54-001.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8362) Message sent with 'int8_t' value property is corrupted

2019-09-25 Thread Michal Kasperek (Jira)


 [ 
https://issues.apache.org/jira/browse/QPID-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michal Kasperek updated QPID-8362:
--
Summary: Message sent with 'int8_t' value property is corrupted  (was: 
Messsage property of int8 type )

> Message sent with 'int8_t' value property is corrupted
> --
>
> Key: QPID-8362
> URL: https://issues.apache.org/jira/browse/QPID-8362
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: qpid-cpp-1.40.0
> Environment: Windows 10.
> Library compiled with Visual Studio toolchain: msvc-12, 64 bits, Debug
> qpid-cpp\src\qpid\messaging\ interface used.
>Reporter: Michal Kasperek
>Priority: Major
> Attachments: image-2019-09-25-13-46-54-001.png
>
>
> Message sent with 'int8_t' value property is corrupted. The type is 
> interpreted as long.
> This issue is only observed with int8_t type.
> ...
>  qpid::messaging::Sender m_sender;
>  ...
> const std::string msgString = "this is the message string";
> auto msg = Message(msgString);
>  Variant::Map content;
> int8_t value = 1;
>  content["CustomInt8"] = value;
>  msg.setProperties(content);
>  m_sender.send(msg, true);
> !image-2019-09-25-13-46-54-001.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] rkubis opened a new pull request #190: FIX(python): Use amqps port as default

2019-09-25 Thread GitBox
rkubis opened a new pull request #190: FIX(python): Use amqps port as default
URL: https://github.com/apache/qpid-proton/pull/190
 
 
   According to the 
[documentation](https://github.com/apache/qpid-proton/blob/master/docs/connect-config.md),
 default port should be `amqps`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2108) supported source outcomes not set

2019-09-25 Thread Robbie Gemmell (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937516#comment-16937516
 ] 

Robbie Gemmell commented on PROTON-2108:


I think what you describe would be a reasonable behaviour and what it should 
have said (explicitly), but I don't think that is what it says/allows given the 
continuing outline that not setting outcomes means the default outcome applies 
to all transfers, and what is true if that is also not set. Prior discussions 
on this from the authors conveyed the same understanding I'm holding of the 
text, but that's how I would read it myself, though to be clear I do think its 
ridiculous.

On the way implementations treating things, I think its true that most folks 
have just largely ignored this entire area of the spec entirely since its 
annoying, and I've been guilty of that myself. It only takes one bit to 
implement what it says to cause problems, and as 
https://github.com/apache/activemq-artemis/pull/2847 shows someone else has 
actually done so, and had it not been caught in review it would likely later be 
causing problems.

The simple way to avoid that ever causing problems is for clients to advertise 
what they support using the mechanism that exists to do that. I am as you 
thought just proposing sending the full set since the bindings already use and 
handle them that way.

To your last point, I agree it seems wrong, and rather silly. There is 
potentially possibility though that a peer could also e.g detach the link with 
an error rather than accept and silently swallow the messages though. That is 
what the spec says to do in some cases such as if a transaction coordinator 
doesn't support the rejected outcome at a point its use would be needed for 
example.
 

> supported source outcomes not set
> -
>
> Key: PROTON-2108
> URL: https://issues.apache.org/jira/browse/PROTON-2108
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: proton-c-0.29.0
>Reporter: Robbie Gemmell
>Priority: Critical
>
> From looking at some recent traces, it appears that the bindings (at least 
> for python, but probably others) do no set the outcomes (or default-outcome) 
> field on its source terminus, although they do use/support all the outcomes. 
> To a peer that actually inspects the outcomes to influence behaviour this 
> strictly means only Accepted is supported, which can lead to issues (e.g it 
> might accept a message then drop it, rather than release/modify/reject it, 
> under cases it couldn't be processed).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org