[jira] [Commented] (PROTON-2105) Support Go modules
[
https://issues.apache.org/jira/browse/PROTON-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942432#comment-16942432
]
Roddie Kieley commented on PROTON-2105:
---
[~lulf] After reading the docs and looking at some examples I'm not sure we'll
be able to avoid something similar to the above. As per [Using Go
Modules|https://blog.golang.org/using-go-modules]:
{quote}
The go.mod file defines the module’s module path, which is also the import path
used for the root directory...
{quote}
So it appears in the qpid-proton go.mod file we'd have something like
{noformat}
module github.com/apache/qpid-proton
{noformat}
and in the import to get from the root to the go source for a package we need
the above + go/src/qpid.apache.org/amqp
{noformat}
import "github.com/apache/qpid-proton/go/src/qpid.apache.org/amqp"
{noformat}
And as well we don't get to require qpid-proton-c from the go side which would
be more accurate given that it depends on the native c libraries produced.
> Support Go modules
> --
>
> Key: PROTON-2105
> URL: https://issues.apache.org/jira/browse/PROTON-2105
> Project: Qpid Proton
> Issue Type: Bug
> Components: go-binding
>Reporter: Ulf Lilleengen
>Assignee: Roddie Kieley
>Priority: Major
>
> As of Go 1.12, go module support is available. In order to manage
> dependencies using go modules, dependencies must also be using go modules.
> Therefore, adding a go.mod file to each module would allow qpid proton go
> bindings to be managed as a go module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1434) Add new attribute saslPasswordFile to the connector entity
[ https://issues.apache.org/jira/browse/DISPATCH-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942375#comment-16942375 ] ASF GitHub Bot commented on DISPATCH-1434: -- codecov-io commented on issue #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector… URL: https://github.com/apache/qpid-dispatch/pull/578#issuecomment-537273937 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=h1) Report > Merging [#578](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b08babc21637ef99af60da893837c5b40c8c0ceb?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=tree) ```diff @@Coverage Diff@@ ## master#578 +/- ## = + Coverage 86.29% 86.3% +<.01% = Files 90 90 Lines 20386 20404 +18 = + Hits17592 17609 +17 - Misses 27942795 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `89.94% <100%> (+0.37%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.64% <0%> (-0.23%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.19%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.98% <0%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=footer). Last update [b08babc...b40f41e](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add new attribute saslPasswordFile to the connector entity > -- > > Key: DISPATCH-1434 > URL: https://issues.apache.org/jira/browse/DISPATCH-1434 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Add a new attribute called saslPasswordFile to the connector entity. This > will enable users to specify the saslPassword in a file instead of specifying > it in the config file. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector…
codecov-io commented on issue #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector… URL: https://github.com/apache/qpid-dispatch/pull/578#issuecomment-537273937 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=h1) Report > Merging [#578](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b08babc21637ef99af60da893837c5b40c8c0ceb?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=tree) ```diff @@Coverage Diff@@ ## master#578 +/- ## = + Coverage 86.29% 86.3% +<.01% = Files 90 90 Lines 20386 20404 +18 = + Hits17592 17609 +17 - Misses 27942795 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `89.94% <100%> (+0.37%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.64% <0%> (-0.23%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.19%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/578/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.98% <0%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=footer). Last update [b08babc...b40f41e](https://codecov.io/gh/apache/qpid-dispatch/pull/578?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8366) [Broker-J] The loss of BDB HA majority on invocation of house keeping operations can crash the broker
[
https://issues.apache.org/jira/browse/QPID-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942319#comment-16942319
]
ASF subversion and git services commented on QPID-8366:
---
Commit 98261ad92020c11784a3be2ab890cbabddec5fbc in qpid-broker-j's branch
refs/heads/master from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=98261ad ]
QPID-8366: [Broker-J] Handle ConnectionScopeRuntimeException on execution of
HouseKeepingTaks
> [Broker-J] The loss of BDB HA majority on invocation of house keeping
> operations can crash the broker
> -
>
> Key: QPID-8366
> URL: https://issues.apache.org/jira/browse/QPID-8366
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6, qpid-java-broker-7.0.7,
> qpid-java-broker-7.1.1, qpid-java-broker-7.1.2, qpid-java-broker-7.0.8,
> qpid-java-broker-7.1.3, qpid-java-broker-7.1.4
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.0.9,
> qpid-java-broker-7.1.5
>
>
> The {{ConnectionScopedRuntimeException}} thrown from {{VirtualHost}} {{House
> Keeping}} thread on invocation of {{MessageStore}} operations like
> {{checkMessageStatus}} can crash the broker. An example of such exception
> stack trace (from Qpid Broker version 7.0.6) is provided below:
> {noformat}
> 2019-09-27 07:53:38,168 ERROR [virtualhost-test-pool-1] (o.a.q.s.Main) -
> Uncaught exception, shutting down.
> org.apache.qpid.server.util.ConnectionScopedRuntimeException: Required number
> of nodes not reachable
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.handleDatabaseException(ReplicatedEnvironmentFacade.java:495)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.commit(ReplicatedEnvironmentFacade.java:332)
> at
> org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore.removeMessage(AbstractBDBMessageStore.java:288)
> at
> org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore$StoredBDBMessage.remove(AbstractBDBMessageStore.java:1090)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl.decrementReference(AbstractServerMessageImpl.java:118)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl.access$500(AbstractServerMessageImpl.java:37)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl$Reference.release(AbstractServerMessageImpl.java:309)
> at
> org.apache.qpid.server.queue.QueueEntryImpl.dispose(QueueEntryImpl.java:557)
> at
> org.apache.qpid.server.queue.QueueEntryImpl.delete(QueueEntryImpl.java:572)
> at
> org.apache.qpid.server.queue.AbstractQueue$11.postCommit(AbstractQueue.java:1729)
> at
> org.apache.qpid.server.txn.AutoCommitTransaction.dequeue(AutoCommitTransaction.java:92)
> at
> org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1722)
> at
> org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1717)
> at
> org.apache.qpid.server.queue.AbstractQueue.deleteEntry(AbstractQueue.java:1761)
> at
> org.apache.qpid.server.queue.AbstractQueue.checkMessageStatus(AbstractQueue.java:2165)
> at
> org.apache.qpid.server.virtualhost.AbstractVirtualHost$VirtualHostHouseKeepingTask.execute(AbstractVirtualHost.java:1965)
> at
> org.apache.qpid.server.virtualhost.HouseKeepingTask$1.run(HouseKeepingTask.java:56)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.qpid.server.virtualhost.HouseKeepingTask.run(HouseKeepingTask.java:51)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: com.sleepycat.je.rep.InsufficientAcksException: (JE 7.4.5)
> Transaction: -3459038252 VLSN: 10,380,435,448, initiated at: 07:53:20.
> Insufficient acks
[jira] [Commented] (DISPATCH-1434) Add new attribute saslPasswordFile to the connector entity
[ https://issues.apache.org/jira/browse/DISPATCH-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942316#comment-16942316 ] ASF GitHub Bot commented on DISPATCH-1434: -- bhardesty commented on issue #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector… URL: https://github.com/apache/qpid-dispatch/pull/578#issuecomment-537231659 The now deprecated "saslPassword" is used in the doc in two places. They should be updated: https://qpid.apache.org/releases/qpid-dispatch-1.9.0/user-guide/index.html#connecting-using-username-password-authentication-router https://qpid.apache.org/releases/qpid-dispatch-1.9.0/user-guide/index.html#managing_sasl_encryption_and_authentication This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add new attribute saslPasswordFile to the connector entity > -- > > Key: DISPATCH-1434 > URL: https://issues.apache.org/jira/browse/DISPATCH-1434 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Add a new attribute called saslPasswordFile to the connector entity. This > will enable users to specify the saslPassword in a file instead of specifying > it in the config file. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty commented on issue #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector…
bhardesty commented on issue #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector… URL: https://github.com/apache/qpid-dispatch/pull/578#issuecomment-537231659 The now deprecated "saslPassword" is used in the doc in two places. They should be updated: https://qpid.apache.org/releases/qpid-dispatch-1.9.0/user-guide/index.html#connecting-using-username-password-authentication-router https://qpid.apache.org/releases/qpid-dispatch-1.9.0/user-guide/index.html#managing_sasl_encryption_and_authentication This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector…
bhardesty commented on a change in pull request #578: DISPATCH-1434 - Added new
attribute saslPasswordFile to the connector…
URL: https://github.com/apache/qpid-dispatch/pull/578#discussion_r330274380
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -1002,10 +1002,17 @@
"saslPassword": {
"type": "string",
"required": false,
-"description": "The password that the connector is using
to connect to a peer.",
+"description": "(DEPRECATED) The password that the
connector is using to connect to a peer.",
"create": true,
+"deprecated": true,
"hidden": true
},
+"saslPasswordFile": {
+"type": "string",
+"required": false,
+"description": "The full path to the file that contains
the password that the connector uses to connect to a peer.",
Review comment:
Instead of "full path", use "absolute path".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1434) Add new attribute saslPasswordFile to the connector entity
[
https://issues.apache.org/jira/browse/DISPATCH-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942307#comment-16942307
]
ASF GitHub Bot commented on DISPATCH-1434:
--
bhardesty commented on pull request #578: DISPATCH-1434 - Added new attribute
saslPasswordFile to the connector…
URL: https://github.com/apache/qpid-dispatch/pull/578#discussion_r330274380
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -1002,10 +1002,17 @@
"saslPassword": {
"type": "string",
"required": false,
-"description": "The password that the connector is using
to connect to a peer.",
+"description": "(DEPRECATED) The password that the
connector is using to connect to a peer.",
"create": true,
+"deprecated": true,
"hidden": true
},
+"saslPasswordFile": {
+"type": "string",
+"required": false,
+"description": "The full path to the file that contains
the password that the connector uses to connect to a peer.",
Review comment:
Instead of "full path", use "absolute path".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add new attribute saslPasswordFile to the connector entity
> --
>
> Key: DISPATCH-1434
> URL: https://issues.apache.org/jira/browse/DISPATCH-1434
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.9.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> Add a new attribute called saslPasswordFile to the connector entity. This
> will enable users to specify the saslPassword in a file instead of specifying
> it in the config file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1434) Add new attribute saslPasswordFile to the connector entity
[ https://issues.apache.org/jira/browse/DISPATCH-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942297#comment-16942297 ] ASF GitHub Bot commented on DISPATCH-1434: -- ganeshmurthy commented on pull request #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector… URL: https://github.com/apache/qpid-dispatch/pull/578 … entity. saslPassword entity has been deprecated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add new attribute saslPasswordFile to the connector entity > -- > > Key: DISPATCH-1434 > URL: https://issues.apache.org/jira/browse/DISPATCH-1434 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Add a new attribute called saslPasswordFile to the connector entity. This > will enable users to specify the saslPassword in a file instead of specifying > it in the config file. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector…
ganeshmurthy opened a new pull request #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector… URL: https://github.com/apache/qpid-dispatch/pull/578 … entity. saslPassword entity has been deprecated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1434) Add new attribute saslPasswordFile to the connector entity
[ https://issues.apache.org/jira/browse/DISPATCH-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1434: Affects Version/s: (was: 1.8.0) 1.9.0 > Add new attribute saslPasswordFile to the connector entity > -- > > Key: DISPATCH-1434 > URL: https://issues.apache.org/jira/browse/DISPATCH-1434 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Add a new attribute called saslPasswordFile to the connector entity. This > will enable users to specify the saslPassword in a file instead of specifying > it in the config file. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1408) system_tests_distribution failing when running under valgrind
[
https://issues.apache.org/jira/browse/DISPATCH-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942140#comment-16942140
]
ASF subversion and git services commented on DISPATCH-1408:
---
Commit b08babc21637ef99af60da893837c5b40c8c0ceb in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=b08babc ]
DISPATCH-1408 - Additional fix. Make sure you send the exact number of messages
and send them only once
> system_tests_distribution failing when running under valgrind
> -
>
> Key: DISPATCH-1408
> URL: https://issues.apache.org/jira/browse/DISPATCH-1408
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.8.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.9.0
>
>
> System_tests_distribution failing when run under valgrind
>
> {noformat}
> 33:
> 33: ==
> 33: FAIL: test_10_closest_mesh (system_tests_distribution.DistributionTests)
> 33: --
> 33: Traceback (most recent call last):
> 33: File "/foo/qpid-dispatch/tests/system_test.py", line 706, in wrap
> 33: return f(*args, **kwargs)
> 33: File "/foo/qpid-dispatch/tests/system_tests_distribution.py", line 625,
> in test_10_closest_mesh
> 33: self.assertEqual ( None, test.error )
> 33: AssertionError: None != u'error: one of the receivers on router 1 got no
> messages.'
> 33:
> 33: --
> 33: Ran 25 tests in 21.785s {noformat}
>
> One more failure
> {noformat}
> 33: ==
> 33: FAIL: test_09_closest_linear (system_tests_distribution.DistributionTests)
> 33: --
> 33: Traceback (most recent call last):
> 33: File "/foo/qpid-dispatch/tests/system_test.py", line 706, in wrap
> 33: return f(*args, **kwargs)
> 33: File "/foo/qpid-dispatch/tests/system_tests_distribution.py", line 612,
> in test_09_closest_linear
> 33: self.assertEqual ( None, test.error )
> 33: AssertionError: None != u'error: one of the receivers on router 1 got no
> messages.'
> 33:
> 33: --
> {noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
ApacheCon North America 2020, project participation
Hi, folks, (Note: You're receiving this email because you're on the dev@ list for one or more Apache Software Foundation projects.) For ApacheCon North America 2019, we asked projects to participate in the creation of project/topic specific tracks. This was very successful, with about 15 projects stepping up to curate the content for their track/summit/event. We need to know if you're going to do the same for 2020. This informs how large a venue we book for the event, how long the event runs, and many other considerations. If you intend to participate again in 2020, we need to hear from you on the plann...@apachecon.com mailing list. This is not a firm commitment, but we need to know if you're, say, 75% confident that you'll be participating. And, no, we do not have any details at all, but assume that it will be in roughly the same calendar space as this year's event, ie, somewhere in the August-October timeframe. Thanks. -- Rich Bowen VP Conferences The Apache Software Foundation @apachecon - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2113) Allow a different certificate to be used for different virtual hosts as identified by SNI
Gordon Sim created PROTON-2113: -- Summary: Allow a different certificate to be used for different virtual hosts as identified by SNI Key: PROTON-2113 URL: https://issues.apache.org/jira/browse/PROTON-2113 Project: Qpid Proton Issue Type: New Feature Reporter: Gordon Sim -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPIDJMS-476) Improve send performance of anonymous fallback producer
[ https://issues.apache.org/jira/browse/QPIDJMS-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPIDJMS-476: --- Description: For servers that do not report support for the 'anonymous relay', allowing a single sending link to be created for 'anonymous' producers (either JMSProducer instances, or a MessageProducer created with null as the destination) we implemented a fallback mechanism that created a sender link that is opened on send and closed on completion of the send (remote sends disposition). This mechanism essentially makes every send using the anonymous fallback mechanism synchronous, with the overhead of Attach -> Transfer -> Detach for each call to send, inhibiting performance. We can improve this mechanism and also allow for asynchronous sends both from the JMS 1.1 send methods and from the JMS 2 CompletionListener send methods, as is currently done when the anonymous relay is supported by the server. By allowing for caching of sender links we can also reduce the number of attach and detach cycles for sends that encompass a fixed set of addresses as well. (was: For servers that do not report support for the 'anonymous relay', allowing a single sending link to be created for 'anonymous' producers (either JMSProducer instances, or a MessageProducer created with null as the destination) we implemented a fallback mechanism that created a sender link that is opened on send and closed on completion of the send (remote sends disposition). This mechanism essentially makes ever send using the anonymous fallback mechanism synchronous, with the overhead of Attach -> Transfer -> Detach for each call to send, inhibiting performance. We can improve this mechanism and also allow for asynchronous sends both from the JMS 1.1 send methods and from the JMS 2 CompletionListener send methods, as is currently done when the anonymous relay is supported by the server. By allowing for caching of sender links we can also reduce the number of attach and detach cycles for sends that encompass a fixed set of addresses as well. ) > Improve send performance of anonymous fallback producer > --- > > Key: QPIDJMS-476 > URL: https://issues.apache.org/jira/browse/QPIDJMS-476 > Project: Qpid JMS > Issue Type: Improvement > Components: qpid-jms-client >Affects Versions: 0.46.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: 0.47.0 > > > For servers that do not report support for the 'anonymous relay', allowing a > single sending link to be created for 'anonymous' producers (either > JMSProducer instances, or a MessageProducer created with null as the > destination) we implemented a fallback mechanism that created a sender link > that is opened on send and closed on completion of the send (remote sends > disposition). This mechanism essentially makes every send using the > anonymous fallback mechanism synchronous, with the overhead of Attach -> > Transfer -> Detach for each call to send, inhibiting performance. We can > improve this mechanism and also allow for asynchronous sends both from the > JMS 1.1 send methods and from the JMS 2 CompletionListener send methods, as > is currently done when the anonymous relay is supported by the server. By > allowing for caching of sender links we can also reduce the number of attach > and detach cycles for sends that encompass a fixed set of addresses as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-473) failure handling CompletionListener when using fallback anonymous producers
[
https://issues.apache.org/jira/browse/QPIDJMS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941880#comment-16941880
]
Robert Gemmell commented on QPIDJMS-473:
Some more outline for you and anyone else reading later
In AMQP 1.0 sending/receiving links are opened to specific node addresses, e.g
to a queue using its name. For 'anonymous' producer cases (either a
MessageProducer created with null as the destination, or the 'light weight'
JMSProducer instances) the address of the destination isnt known until the
point of send occuring. An extension mechanism was created to allow for a
single sending link to be created to an 'anonymous relay', to be used for
multiple destinations where each message sent carries its actual destination.
For servers that dont advertise support of this functionality, the client has a
fallback mechanism so that these 'anonymous producer' scenarios could at least
still work, albeit more slowly. It would seem ServiceBus does not advertise
'anonymous relay' support and so you ended up using the fallback mechanism, and
in concert with that you hit a bug in the JMS 2.0 additions made since it was
created and that we hadn't yet come across, due to mainly using servers that do
advertise the support.
0.46.0 resolves the bug, and QPIDJMS-476 now has the mentioned improvements
around increasing perf of the fallback mechanism.
> failure handling CompletionListener when using fallback anonymous producers
> ---
>
> Key: QPIDJMS-473
> URL: https://issues.apache.org/jira/browse/QPIDJMS-473
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
>Affects Versions: 0.45.0
> Environment: Windows 10/64
> Dell 5530 8 cores (possibly explaining why the send thread completes faster
> than the thread recording the SendComplete on the queue?)
> java 8
>
>Reporter: Consultant Leon
>Assignee: Robert Gemmell
>Priority: Critical
> Fix For: 0.46.0
>
> Attachments:
> fix_QPID-JMS-473_race_condition_where_SendCompletion_was_not_placed_on_asyncSendQueue_befo.patch
>
>
> When a server does not offer support for the 'anonymous relay' capability,
> the client falls back to opening and closing links to satisfy send requests
> for anonymous producers (i.e JMSProducer instances, and MessageProducers
> created without a destination). The fallback mechanism does not currently
> account for use of a CompletionListener during the send, and so fails to
> notify it. It should be updated to handle usage of a CompletionListener.
>
>
>
>
> Original Description:
>
> When I configure a completion listener and send 50 messages rapidly
> asynchronous I hit a race condition.
> Debugging the code proves that the envelope has not been placed on
> asyncSendQueue at the time the very first send completion arrives.
> This results in JmsSession line 1518 within the private AsyncCompletionTask
> class:
> SendCompletion completion = {color:#660e7a}asyncSendQueue{color}.peek();
> Returning *null* , as the asyncSendQueue does not yet contain the completion
> as it's still being populated in the other thread!
> The resulting null pointer exception is logged as a DEBUG message (!!! bad
> this should be a clear ERROR log with stack trace, it should never happen but
> if it does don't hide it this way !!!)
> Enabling debug logging then shows:
> 2019-09-19_03:53:00.526-DEBUG-[JmsSession
> [ID:811574d5-f47c-4dd3-82e9-c4aa4ce1d9b9:1:1] completion dispatcher]-Send
> completion task encounted unexpected error: null
> \{org.apache.qpid.jms.JmsSession:1567}
>
> Another comment on the logging style, the exception should be logged not
> ex.getMessage() !! (you can't see from the log that it's an NPE this way).
>
> Line 1567:
> {color:#660e7a}LOG{color}.debug({color:#008000}"Send completion task
> encounted unexpected error: {}"{color}, ex.getMessage());
> -->
> {color:#660e7a}LOG{color}.debug({color:#008000}"Send completion task
> encounted unexpected error"{color}, ex);
> (never assume getMessage() contains relevant data, log the stack unless 100%
> sure the exception is known and self descriptive but when are you 100% sure
> about such?)
> The problem is triggered by the design of the code at line 951:
>
> {color:#80}if {color}(envelope.isCompletionRequired()) {
>
> {color:#660e7a}transactionContext{color}.send({color:#660e7a}connection{color},
> envelope, {color:#80}new {color}ProviderSynchronization() {
> {color:#808000}@Override{color} {color:#80}public void
> {color}onPendingSuccess() {
> {color:#808080}// Provider accepted the send request so new we place the
> marker in{color}{color:#808080} // the queue so that it can be completed
> asynchronously.{color}
>
[jira] [Updated] (QPIDJMS-476) Improve send performance of anonymous fallback producer
[ https://issues.apache.org/jira/browse/QPIDJMS-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPIDJMS-476: --- Description: For servers that do not report support for the 'anonymous relay', allowing a single sending link to be created for 'anonymous' producers (either JMSProducer instances, or a MessageProducer created with null as the destination) we implemented a fallback mechanism that created a sender link that is opened on send and closed on completion of the send (remote sends disposition). This mechanism essentially makes ever send using the anonymous fallback mechanism synchronous, with the overhead of Attach -> Transfer -> Detach for each call to send, inhibiting performance. We can improve this mechanism and also allow for asynchronous sends both from the JMS 1.1 send methods and from the JMS 2 CompletionListener send methods, as is currently done when the anonymous relay is supported by the server. By allowing for caching of sender links we can also reduce the number of attach and detach cycles for sends that encompass a fixed set of addresses as well. (was: For remotes that do not report support for the anonymous relay we implement a fallback mechanism that creates a single sender link that is opened on send and close on completion of the send (remote sends disposition). This mechanism essentially makes ever send using the anonymous fallback mechanism synchronous with the overhead of Attach -> Transfer -> Detach for each call to send. We can improve this mechanism and also allow for asynchronous sends both from the JMS 1.1 send methods and from the JMS completion send methods as is currently done when the anonymous relay is supported. By allowing for caching of sender links we can reduce the number of attach and detach cycles for sends that encompass a fixed set of addresses as well. ) > Improve send performance of anonymous fallback producer > --- > > Key: QPIDJMS-476 > URL: https://issues.apache.org/jira/browse/QPIDJMS-476 > Project: Qpid JMS > Issue Type: Improvement > Components: qpid-jms-client >Affects Versions: 0.46.0 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Minor > Fix For: 0.47.0 > > > For servers that do not report support for the 'anonymous relay', allowing a > single sending link to be created for 'anonymous' producers (either > JMSProducer instances, or a MessageProducer created with null as the > destination) we implemented a fallback mechanism that created a sender link > that is opened on send and closed on completion of the send (remote sends > disposition). This mechanism essentially makes ever send using the anonymous > fallback mechanism synchronous, with the overhead of Attach -> Transfer -> > Detach for each call to send, inhibiting performance. We can improve this > mechanism and also allow for asynchronous sends both from the JMS 1.1 send > methods and from the JMS 2 CompletionListener send methods, as is currently > done when the anonymous relay is supported by the server. By allowing for > caching of sender links we can also reduce the number of attach and detach > cycles for sends that encompass a fixed set of addresses as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-473) failure handling CompletionListener when using fallback anonymous producers
[
https://issues.apache.org/jira/browse/QPIDJMS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941854#comment-16941854
]
Consultant Leon commented on QPIDJMS-473:
-
Thanks for the advise to try fixed destination MessageProducer, when I find
some time I'd like to see if that improves throughput as the current results
are rather disappointing. I'm not otherwise familiar with the specifics of the
qpid jms library except for hunting down this particular that blocked our
implementation. (our component is supported on many JMS implementations, maybe
other implementations also benefit from fixed destination MessageProducer's -
some benchmark will be needed!)
> failure handling CompletionListener when using fallback anonymous producers
> ---
>
> Key: QPIDJMS-473
> URL: https://issues.apache.org/jira/browse/QPIDJMS-473
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
>Affects Versions: 0.45.0
> Environment: Windows 10/64
> Dell 5530 8 cores (possibly explaining why the send thread completes faster
> than the thread recording the SendComplete on the queue?)
> java 8
>
>Reporter: Consultant Leon
>Assignee: Robert Gemmell
>Priority: Critical
> Fix For: 0.46.0
>
> Attachments:
> fix_QPID-JMS-473_race_condition_where_SendCompletion_was_not_placed_on_asyncSendQueue_befo.patch
>
>
> When a server does not offer support for the 'anonymous relay' capability,
> the client falls back to opening and closing links to satisfy send requests
> for anonymous producers (i.e JMSProducer instances, and MessageProducers
> created without a destination). The fallback mechanism does not currently
> account for use of a CompletionListener during the send, and so fails to
> notify it. It should be updated to handle usage of a CompletionListener.
>
>
>
>
> Original Description:
>
> When I configure a completion listener and send 50 messages rapidly
> asynchronous I hit a race condition.
> Debugging the code proves that the envelope has not been placed on
> asyncSendQueue at the time the very first send completion arrives.
> This results in JmsSession line 1518 within the private AsyncCompletionTask
> class:
> SendCompletion completion = {color:#660e7a}asyncSendQueue{color}.peek();
> Returning *null* , as the asyncSendQueue does not yet contain the completion
> as it's still being populated in the other thread!
> The resulting null pointer exception is logged as a DEBUG message (!!! bad
> this should be a clear ERROR log with stack trace, it should never happen but
> if it does don't hide it this way !!!)
> Enabling debug logging then shows:
> 2019-09-19_03:53:00.526-DEBUG-[JmsSession
> [ID:811574d5-f47c-4dd3-82e9-c4aa4ce1d9b9:1:1] completion dispatcher]-Send
> completion task encounted unexpected error: null
> \{org.apache.qpid.jms.JmsSession:1567}
>
> Another comment on the logging style, the exception should be logged not
> ex.getMessage() !! (you can't see from the log that it's an NPE this way).
>
> Line 1567:
> {color:#660e7a}LOG{color}.debug({color:#008000}"Send completion task
> encounted unexpected error: {}"{color}, ex.getMessage());
> -->
> {color:#660e7a}LOG{color}.debug({color:#008000}"Send completion task
> encounted unexpected error"{color}, ex);
> (never assume getMessage() contains relevant data, log the stack unless 100%
> sure the exception is known and self descriptive but when are you 100% sure
> about such?)
> The problem is triggered by the design of the code at line 951:
>
> {color:#80}if {color}(envelope.isCompletionRequired()) {
>
> {color:#660e7a}transactionContext{color}.send({color:#660e7a}connection{color},
> envelope, {color:#80}new {color}ProviderSynchronization() {
> {color:#808000}@Override{color} {color:#80}public void
> {color}onPendingSuccess() {
> {color:#808080}// Provider accepted the send request so new we place the
> marker in{color}{color:#808080} // the queue so that it can be completed
> asynchronously.{color}
> {color:#660e7a}asyncSendQueue{color}.addLast({color:#80}new
> {color}SendCompletion({color:#660e7a}envelope{color},
> {color:#660e7a}listener{color}));
> }
> {color:#808000}@Override{color} {color:#80}public void
> {color}onPendingFailure(ProviderException cause) {
> {color:#808080}// Provider has rejected the send request so we will throw
> the{color}{color:#808080} // exception that is to follow so no completion
> will be needed.{color} }
> });
> First the message is sent (and the sending is actually completed before the
> onPendingSuccess() is ever called!
> The design of this code should be changed to first record the outstanding
> send operation (so first do the asyncSendQueue.addLast) BEFORE
[jira] [Created] (DISPATCH-1434) Add new attribute saslPasswordFile to the connector entity
Ganesh Murthy created DISPATCH-1434: --- Summary: Add new attribute saslPasswordFile to the connector entity Key: DISPATCH-1434 URL: https://issues.apache.org/jira/browse/DISPATCH-1434 Project: Qpid Dispatch Issue Type: Improvement Components: Container Affects Versions: 1.8.0 Reporter: Ganesh Murthy Assignee: Ganesh Murthy Add a new attribute called saslPasswordFile to the connector entity. This will enable users to specify the saslPassword in a file instead of specifying it in the config file. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #577: NO-JIRA - add .asf.yaml
asfgit closed pull request #577: NO-JIRA - add .asf.yaml URL: https://github.com/apache/qpid-dispatch/pull/577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on issue #193: NO-JIRA: add .asf.yaml
gemmellr commented on issue #193: NO-JIRA: add .asf.yaml URL: https://github.com/apache/qpid-proton/pull/193#issuecomment-536954379 Since its just updating the tags, and many of the existing tags are entirely wrong thanks to being taken from a common source, I've just applied this regardless of the discussion thread. It helps folks see what it actually looks like applied also. I added a licence header to avoid updating e.g the RAT config or anything else, though I see form the other PR you already noticed that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on a change in pull request #577: NO-JIRA - add .asf.yaml
jdanekrh commented on a change in pull request #577: NO-JIRA - add .asf.yaml URL: https://github.com/apache/qpid-dispatch/pull/577#discussion_r329961433 ## File path: .asf.yaml ## @@ -0,0 +1,19 @@ +github: Review comment: ```suggestion # # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. # github: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on a change in pull request #577: NO-JIRA - add .asf.yaml
jdanekrh commented on a change in pull request #577: NO-JIRA - add .asf.yaml URL: https://github.com/apache/qpid-dispatch/pull/577#discussion_r329961433 ## File path: .asf.yaml ## @@ -0,0 +1,19 @@ +github: Review comment: ```suggestion # # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. # github: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] asfgit closed pull request #193: NO-JIRA: add .asf.yaml
asfgit closed pull request #193: NO-JIRA: add .asf.yaml URL: https://github.com/apache/qpid-proton/pull/193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #577: NO-JIRA - add .asf.yaml
jdanekrh opened a new pull request #577: NO-JIRA - add .asf.yaml URL: https://github.com/apache/qpid-dispatch/pull/577 https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1429) Autolink with address starting with double underscores gets converted to single underscore
[
https://issues.apache.org/jira/browse/DISPATCH-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941625#comment-16941625
]
ASF GitHub Bot commented on DISPATCH-1429:
--
grs commented on pull request #570: DISPATCH-1429: reset iterator for address
starting with _
URL: https://github.com/apache/qpid-dispatch/pull/570
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Autolink with address starting with double underscores gets converted to
> single underscore
> --
>
> Key: DISPATCH-1429
> URL: https://issues.apache.org/jira/browse/DISPATCH-1429
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Ulf Lilleengen
>Priority: Major
>
> I have the following in qdrouterd.conf:
>
> {code:java}
> address {
> prefix: __myqueue
> waypoint: true
> }
> autoLink {
> address: __myqueue
> direction: in
> containerId: c2
> }{code}
>
> Running the following command shows that address field gets converted from
> '__myqueue' to '_myqueue':
> {code:java}
> [lulf@pteppic ~]$ qdmanage QUERY --type=autoLink
> [
> {
> "name": "autoLink/0",
> "identity": "3",
> "type": "org.apache.qpid.dispatch.router.config.autoLink",
> "address": "_myqueue",
> "addr": "_myqueue",
> "direction": "in",
> "dir": "in",
> "phase": 1,
> "containerId": "c2",
> "operStatus": "inactive",
> "fallback": false
> }
> ]{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1428) route connection not indexed by 'connection' field of connector
[
https://issues.apache.org/jira/browse/DISPATCH-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941627#comment-16941627
]
ASF GitHub Bot commented on DISPATCH-1428:
--
grs commented on pull request #567: DISPATCH-1428
URL: https://github.com/apache/qpid-dispatch/pull/567
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> route connection not indexed by 'connection' field of connector
> ---
>
> Key: DISPATCH-1428
> URL: https://issues.apache.org/jira/browse/DISPATCH-1428
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> The connection established by a route-container connector will not be indexed
> by the 'connection' field of that connector if there is already an existing
> route-connection with the same container id but established by a different
> connector.
> E.g. start router on 5672 and a broker (or a separate router emulating a
> broker) on 5673, then:
> {noformat}
> for n in foo bar; do
> qdmanage CREATE --type connector --name $n role=route-container
> host=localhost port=5673;
> qdmanage CREATE --type linkRoute --name $n pattern=$n direction=in
> connection=$n;
> done;
> qdstat --linkroute
> {noformat}
> Only one of these link routes is active though both connections are
> established.
> The issues is that when the first connection is established, it indexes the
> qdr_conn_identifier_t by container-id and the connection label from the
> connector. When the second connection is established, it looks up first by
> container id, so adds itself to the qdr_conn_identifier_t created by the
> first connection. There is then no entry in the index for the connection
> label of the second connector, so the second link route can never be
> activated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1428) route connection not indexed by 'connection' field of connector
[
https://issues.apache.org/jira/browse/DISPATCH-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941626#comment-16941626
]
ASF GitHub Bot commented on DISPATCH-1428:
--
grs commented on pull request #567: DISPATCH-1428
URL: https://github.com/apache/qpid-dispatch/pull/567#discussion_r329933791
##
File path: tests/system_tests_link_routes.py
##
@@ -2052,6 +2052,132 @@ def on_message(self, event):
def run(self):
Container(self).run()
+class Dispatch1428(TestCase):
+"""
+Sets up 2 routers (one of which are acting as brokers (QDR.A)).
+
+QDR.A acting broker #1
+ +-+ +-+
+ | | <-- | |
+ | QDR.A | | QDR.B |
+ | | --> | |
+ +-+ +-+
+
+"""
+@classmethod
+def get_router(cls, index):
+return cls.routers[index]
+
+@classmethod
+def setUpClass(cls):
+"""Start two routers"""
+super(Dispatch1428, cls).setUpClass()
+
+def router(name, connection):
+
+config = [
+('router', {'mode': 'interior', 'id': 'QDR.%s'%name}),
+] + connection
+
+config = Qdrouterd.Config(config)
+cls.routers.append(cls.tester.qdrouterd(name, config, wait=False))
+
+cls.routers = []
+a_listener_port = cls.tester.get_port()
+b_listener_port = cls.tester.get_port()
+
+router('A',
+ [
+ ('listener', {'role': 'normal', 'host': '0.0.0.0', 'port':
a_listener_port, 'saslMechanisms': 'ANONYMOUS'}),
+ ])
+router('B',
+ [
+ ('listener', {'role': 'normal', 'host': '0.0.0.0', 'port':
b_listener_port, 'saslMechanisms': 'ANONYMOUS'}),
+ ('connector', {'name': 'one', 'role': 'route-container',
'host': '0.0.0.0', 'port': a_listener_port, 'saslMechanisms': 'ANONYMOUS'}),
+ ('connector', {'name': 'two', 'role': 'route-container',
'host': '0.0.0.0', 'port': a_listener_port, 'saslMechanisms': 'ANONYMOUS'})
+ ]
+ )
+sleep(2)
+
+
+def run_qdmanage(self, cmd, input=None, expect=Process.EXIT_OK,
address=None):
+p = self.popen(
+['qdmanage'] + cmd.split(' ') + ['--bus', address or
self.address(), '--indent=-1', '--timeout', str(TIMEOUT)],
+stdin=PIPE, stdout=PIPE, stderr=STDOUT, expect=expect,
+universal_newlines=True)
+out = p.communicate(input)[0]
+try:
+p.teardown()
+except Exception as e:
+raise Exception("%s\n%s" % (e, out))
+return out
+
+def test_both_link_routes_active(self):
+cmds = [
+'CREATE --type=linkRoute name=foo prefix=foo direction=in
connection=one',
+'CREATE --type=linkRoute name=bar prefix=bar direction=in
connection=two'
Review comment:
Done!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> route connection not indexed by 'connection' field of connector
> ---
>
> Key: DISPATCH-1428
> URL: https://issues.apache.org/jira/browse/DISPATCH-1428
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> The connection established by a route-container connector will not be indexed
> by the 'connection' field of that connector if there is already an existing
> route-connection with the same container id but established by a different
> connector.
> E.g. start router on 5672 and a broker (or a separate router emulating a
> broker) on 5673, then:
> {noformat}
> for n in foo bar; do
> qdmanage CREATE --type connector --name $n role=route-container
> host=localhost port=5673;
> qdmanage CREATE --type linkRoute --name $n pattern=$n direction=in
> connection=$n;
> done;
> qdstat --linkroute
> {noformat}
> Only one of these link routes is active though both connections are
> established.
> The issues is that when the first connection is established, it indexes the
> qdr_conn_identifier_t by container-id and the connection label from the
> connector. When the second connection is established, it looks up first by
> container id, so adds itself to the qdr_conn_identifier_t created by the
> first connection. There is then no entry in the index for the connection
> label of the second connector, so the second link route can never be
> activated.
--
This message was sent by
[jira] [Commented] (DISPATCH-1430) qd.waypoint capability not recognised if encoded as array
[ https://issues.apache.org/jira/browse/DISPATCH-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941628#comment-16941628 ] ASF GitHub Bot commented on DISPATCH-1430: -- grs commented on pull request #569: DISPATCH-1430: handle array of capabilities also URL: https://github.com/apache/qpid-dispatch/pull/569 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qd.waypoint capability not recognised if encoded as array > - > > Key: DISPATCH-1430 > URL: https://issues.apache.org/jira/browse/DISPATCH-1430 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Priority: Major > > The qd.waypoint capability on a linkcurrently has to be specified as a single > symbol. Not all libraries will encode even a single capability in this way, > pusing instead an array with a single item. (Both are legitimate AMQP > encodings). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] grs closed pull request #569: DISPATCH-1430: handle array of capabilities also
grs closed pull request #569: DISPATCH-1430: handle array of capabilities also URL: https://github.com/apache/qpid-dispatch/pull/569 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] grs commented on a change in pull request #567: DISPATCH-1428
grs commented on a change in pull request #567: DISPATCH-1428
URL: https://github.com/apache/qpid-dispatch/pull/567#discussion_r329933791
##
File path: tests/system_tests_link_routes.py
##
@@ -2052,6 +2052,132 @@ def on_message(self, event):
def run(self):
Container(self).run()
+class Dispatch1428(TestCase):
+"""
+Sets up 2 routers (one of which are acting as brokers (QDR.A)).
+
+QDR.A acting broker #1
+ +-+ +-+
+ | | <-- | |
+ | QDR.A | | QDR.B |
+ | | --> | |
+ +-+ +-+
+
+"""
+@classmethod
+def get_router(cls, index):
+return cls.routers[index]
+
+@classmethod
+def setUpClass(cls):
+"""Start two routers"""
+super(Dispatch1428, cls).setUpClass()
+
+def router(name, connection):
+
+config = [
+('router', {'mode': 'interior', 'id': 'QDR.%s'%name}),
+] + connection
+
+config = Qdrouterd.Config(config)
+cls.routers.append(cls.tester.qdrouterd(name, config, wait=False))
+
+cls.routers = []
+a_listener_port = cls.tester.get_port()
+b_listener_port = cls.tester.get_port()
+
+router('A',
+ [
+ ('listener', {'role': 'normal', 'host': '0.0.0.0', 'port':
a_listener_port, 'saslMechanisms': 'ANONYMOUS'}),
+ ])
+router('B',
+ [
+ ('listener', {'role': 'normal', 'host': '0.0.0.0', 'port':
b_listener_port, 'saslMechanisms': 'ANONYMOUS'}),
+ ('connector', {'name': 'one', 'role': 'route-container',
'host': '0.0.0.0', 'port': a_listener_port, 'saslMechanisms': 'ANONYMOUS'}),
+ ('connector', {'name': 'two', 'role': 'route-container',
'host': '0.0.0.0', 'port': a_listener_port, 'saslMechanisms': 'ANONYMOUS'})
+ ]
+ )
+sleep(2)
+
+
+def run_qdmanage(self, cmd, input=None, expect=Process.EXIT_OK,
address=None):
+p = self.popen(
+['qdmanage'] + cmd.split(' ') + ['--bus', address or
self.address(), '--indent=-1', '--timeout', str(TIMEOUT)],
+stdin=PIPE, stdout=PIPE, stderr=STDOUT, expect=expect,
+universal_newlines=True)
+out = p.communicate(input)[0]
+try:
+p.teardown()
+except Exception as e:
+raise Exception("%s\n%s" % (e, out))
+return out
+
+def test_both_link_routes_active(self):
+cmds = [
+'CREATE --type=linkRoute name=foo prefix=foo direction=in
connection=one',
+'CREATE --type=linkRoute name=bar prefix=bar direction=in
connection=two'
Review comment:
Done!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] grs closed pull request #567: DISPATCH-1428
grs closed pull request #567: DISPATCH-1428 URL: https://github.com/apache/qpid-dispatch/pull/567 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1428) route connection not indexed by 'connection' field of connector
[
https://issues.apache.org/jira/browse/DISPATCH-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gordon Sim resolved DISPATCH-1428.
--
Resolution: Fixed
> route connection not indexed by 'connection' field of connector
> ---
>
> Key: DISPATCH-1428
> URL: https://issues.apache.org/jira/browse/DISPATCH-1428
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> The connection established by a route-container connector will not be indexed
> by the 'connection' field of that connector if there is already an existing
> route-connection with the same container id but established by a different
> connector.
> E.g. start router on 5672 and a broker (or a separate router emulating a
> broker) on 5673, then:
> {noformat}
> for n in foo bar; do
> qdmanage CREATE --type connector --name $n role=route-container
> host=localhost port=5673;
> qdmanage CREATE --type linkRoute --name $n pattern=$n direction=in
> connection=$n;
> done;
> qdstat --linkroute
> {noformat}
> Only one of these link routes is active though both connections are
> established.
> The issues is that when the first connection is established, it indexes the
> qdr_conn_identifier_t by container-id and the connection label from the
> connector. When the second connection is established, it looks up first by
> container id, so adds itself to the qdr_conn_identifier_t created by the
> first connection. There is then no entry in the index for the connection
> label of the second connector, so the second link route can never be
> activated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] grs closed pull request #570: DISPATCH-1429: reset iterator for address starting with _
grs closed pull request #570: DISPATCH-1429: reset iterator for address starting with _ URL: https://github.com/apache/qpid-dispatch/pull/570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1429) Autolink with address starting with double underscores gets converted to single underscore
[
https://issues.apache.org/jira/browse/DISPATCH-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gordon Sim resolved DISPATCH-1429.
--
Resolution: Fixed
> Autolink with address starting with double underscores gets converted to
> single underscore
> --
>
> Key: DISPATCH-1429
> URL: https://issues.apache.org/jira/browse/DISPATCH-1429
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Ulf Lilleengen
>Priority: Major
>
> I have the following in qdrouterd.conf:
>
> {code:java}
> address {
> prefix: __myqueue
> waypoint: true
> }
> autoLink {
> address: __myqueue
> direction: in
> containerId: c2
> }{code}
>
> Running the following command shows that address field gets converted from
> '__myqueue' to '_myqueue':
> {code:java}
> [lulf@pteppic ~]$ qdmanage QUERY --type=autoLink
> [
> {
> "name": "autoLink/0",
> "identity": "3",
> "type": "org.apache.qpid.dispatch.router.config.autoLink",
> "address": "_myqueue",
> "addr": "_myqueue",
> "direction": "in",
> "dir": "in",
> "phase": 1,
> "containerId": "c2",
> "operStatus": "inactive",
> "fallback": false
> }
> ]{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1430) qd.waypoint capability not recognised if encoded as array
[ https://issues.apache.org/jira/browse/DISPATCH-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved DISPATCH-1430. -- Resolution: Fixed > qd.waypoint capability not recognised if encoded as array > - > > Key: DISPATCH-1430 > URL: https://issues.apache.org/jira/browse/DISPATCH-1430 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Priority: Major > > The qd.waypoint capability on a linkcurrently has to be specified as a single > symbol. Not all libraries will encode even a single capability in this way, > pusing instead an array with a single item. (Both are legitimate AMQP > encodings). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8366) [Broker-J] The loss of BDB HA majority on invocation of house keeping operations can crash the broker
[
https://issues.apache.org/jira/browse/QPID-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8366:
-
Issue Type: Bug (was: Task)
> [Broker-J] The loss of BDB HA majority on invocation of house keeping
> operations can crash the broker
> -
>
> Key: QPID-8366
> URL: https://issues.apache.org/jira/browse/QPID-8366
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6, qpid-java-broker-7.0.7,
> qpid-java-broker-7.1.1, qpid-java-broker-7.1.2, qpid-java-broker-7.0.8,
> qpid-java-broker-7.1.3, qpid-java-broker-7.1.4
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.0.9,
> qpid-java-broker-7.1.5
>
>
> The {{ConnectionScopedRuntimeException}} thrown from {{VirtualHost}} {{House
> Keeping}} thread on invocation of {{MessageStore}} operations like
> {{checkMessageStatus}} can crash the broker. An example of such exception
> stack trace (from Qpid Broker version 7.0.6) is provided below:
> {noformat}
> 2019-09-27 07:53:38,168 ERROR [virtualhost-test-pool-1] (o.a.q.s.Main) -
> Uncaught exception, shutting down.
> org.apache.qpid.server.util.ConnectionScopedRuntimeException: Required number
> of nodes not reachable
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.handleDatabaseException(ReplicatedEnvironmentFacade.java:495)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.commit(ReplicatedEnvironmentFacade.java:332)
> at
> org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore.removeMessage(AbstractBDBMessageStore.java:288)
> at
> org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore$StoredBDBMessage.remove(AbstractBDBMessageStore.java:1090)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl.decrementReference(AbstractServerMessageImpl.java:118)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl.access$500(AbstractServerMessageImpl.java:37)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl$Reference.release(AbstractServerMessageImpl.java:309)
> at
> org.apache.qpid.server.queue.QueueEntryImpl.dispose(QueueEntryImpl.java:557)
> at
> org.apache.qpid.server.queue.QueueEntryImpl.delete(QueueEntryImpl.java:572)
> at
> org.apache.qpid.server.queue.AbstractQueue$11.postCommit(AbstractQueue.java:1729)
> at
> org.apache.qpid.server.txn.AutoCommitTransaction.dequeue(AutoCommitTransaction.java:92)
> at
> org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1722)
> at
> org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1717)
> at
> org.apache.qpid.server.queue.AbstractQueue.deleteEntry(AbstractQueue.java:1761)
> at
> org.apache.qpid.server.queue.AbstractQueue.checkMessageStatus(AbstractQueue.java:2165)
> at
> org.apache.qpid.server.virtualhost.AbstractVirtualHost$VirtualHostHouseKeepingTask.execute(AbstractVirtualHost.java:1965)
> at
> org.apache.qpid.server.virtualhost.HouseKeepingTask$1.run(HouseKeepingTask.java:56)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.qpid.server.virtualhost.HouseKeepingTask.run(HouseKeepingTask.java:51)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: com.sleepycat.je.rep.InsufficientAcksException: (JE 7.4.5)
> Transaction: -3459038252 VLSN: 10,380,435,448, initiated at: 07:53:20.
> Insufficient acks for policy:SIMPLE_MAJORITY. Need replica acks: 2. Missing
> replica acks: 2. Timeout: 15000ms. FeederState=acc3_2(3)[MASTER]
> Current feeds:
> acc3_1: feederVLSN=10,380,435,456 replicaTxnEndVLSN=10,380,435,396
> acc3: feederVLSN=10,380,435,456 replicaTxnEndVLSN=10,380,435,396
> at
>
[jira] [Updated] (QPID-8366) [Broker-J] The loss of BDB HA majority on invocation of house keeping operations can crash the broker
[
https://issues.apache.org/jira/browse/QPID-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8366:
-
Fix Version/s: qpid-java-broker-7.1.5
qpid-java-broker-7.0.9
qpid-java-broker-8.0.0
> [Broker-J] The loss of BDB HA majority on invocation of house keeping
> operations can crash the broker
> -
>
> Key: QPID-8366
> URL: https://issues.apache.org/jira/browse/QPID-8366
> Project: Qpid
> Issue Type: Task
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4,
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6, qpid-java-broker-7.0.7,
> qpid-java-broker-7.1.1, qpid-java-broker-7.1.2, qpid-java-broker-7.0.8,
> qpid-java-broker-7.1.3, qpid-java-broker-7.1.4
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.0.9,
> qpid-java-broker-7.1.5
>
>
> The {{ConnectionScopedRuntimeException}} thrown from {{VirtualHost}} {{House
> Keeping}} thread on invocation of {{MessageStore}} operations like
> {{checkMessageStatus}} can crash the broker. An example of such exception
> stack trace (from Qpid Broker version 7.0.6) is provided below:
> {noformat}
> 2019-09-27 07:53:38,168 ERROR [virtualhost-test-pool-1] (o.a.q.s.Main) -
> Uncaught exception, shutting down.
> org.apache.qpid.server.util.ConnectionScopedRuntimeException: Required number
> of nodes not reachable
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.handleDatabaseException(ReplicatedEnvironmentFacade.java:495)
> at
> org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.commit(ReplicatedEnvironmentFacade.java:332)
> at
> org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore.removeMessage(AbstractBDBMessageStore.java:288)
> at
> org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore$StoredBDBMessage.remove(AbstractBDBMessageStore.java:1090)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl.decrementReference(AbstractServerMessageImpl.java:118)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl.access$500(AbstractServerMessageImpl.java:37)
> at
> org.apache.qpid.server.message.AbstractServerMessageImpl$Reference.release(AbstractServerMessageImpl.java:309)
> at
> org.apache.qpid.server.queue.QueueEntryImpl.dispose(QueueEntryImpl.java:557)
> at
> org.apache.qpid.server.queue.QueueEntryImpl.delete(QueueEntryImpl.java:572)
> at
> org.apache.qpid.server.queue.AbstractQueue$11.postCommit(AbstractQueue.java:1729)
> at
> org.apache.qpid.server.txn.AutoCommitTransaction.dequeue(AutoCommitTransaction.java:92)
> at
> org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1722)
> at
> org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1717)
> at
> org.apache.qpid.server.queue.AbstractQueue.deleteEntry(AbstractQueue.java:1761)
> at
> org.apache.qpid.server.queue.AbstractQueue.checkMessageStatus(AbstractQueue.java:2165)
> at
> org.apache.qpid.server.virtualhost.AbstractVirtualHost$VirtualHostHouseKeepingTask.execute(AbstractVirtualHost.java:1965)
> at
> org.apache.qpid.server.virtualhost.HouseKeepingTask$1.run(HouseKeepingTask.java:56)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.qpid.server.virtualhost.HouseKeepingTask.run(HouseKeepingTask.java:51)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: com.sleepycat.je.rep.InsufficientAcksException: (JE 7.4.5)
> Transaction: -3459038252 VLSN: 10,380,435,448, initiated at: 07:53:20.
> Insufficient acks for policy:SIMPLE_MAJORITY. Need replica acks: 2. Missing
> replica acks: 2. Timeout: 15000ms. FeederState=acc3_2(3)[MASTER]
> Current feeds:
> acc3_1: feederVLSN=10,380,435,456 replicaTxnEndVLSN=10,380,435,396
> acc3:
[jira] [Created] (QPID-8366) [Broker-J] The loss of BDB HA majority on invocation of house keeping operations can crash the broker
Alex Rudyy created QPID-8366:
Summary: [Broker-J] The loss of BDB HA majority on invocation of
house keeping operations can crash the broker
Key: QPID-8366
URL: https://issues.apache.org/jira/browse/QPID-8366
Project: Qpid
Issue Type: Task
Components: Broker-J
Affects Versions: qpid-java-broker-7.1.4, qpid-java-broker-7.1.3,
qpid-java-broker-7.0.8, qpid-java-broker-7.1.2, qpid-java-broker-7.1.1,
qpid-java-broker-7.0.7, qpid-java-broker-7.0.6, qpid-java-broker-7.0.5,
qpid-java-broker-7.0.4, qpid-java-broker-7.1.0
Reporter: Alex Rudyy
The {{ConnectionScopedRuntimeException}} thrown from {{VirtualHost}} {{House
Keeping}} thread on invocation of {{MessageStore}} operations like
{{checkMessageStatus}} can crash the broker. An example of such exception stack
trace (from Qpid Broker version 7.0.6) is provided below:
{noformat}
2019-09-27 07:53:38,168 ERROR [virtualhost-test-pool-1] (o.a.q.s.Main) -
Uncaught exception, shutting down.
org.apache.qpid.server.util.ConnectionScopedRuntimeException: Required number
of nodes not reachable
at
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.handleDatabaseException(ReplicatedEnvironmentFacade.java:495)
at
org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.commit(ReplicatedEnvironmentFacade.java:332)
at
org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore.removeMessage(AbstractBDBMessageStore.java:288)
at
org.apache.qpid.server.store.berkeleydb.AbstractBDBMessageStore$StoredBDBMessage.remove(AbstractBDBMessageStore.java:1090)
at
org.apache.qpid.server.message.AbstractServerMessageImpl.decrementReference(AbstractServerMessageImpl.java:118)
at
org.apache.qpid.server.message.AbstractServerMessageImpl.access$500(AbstractServerMessageImpl.java:37)
at
org.apache.qpid.server.message.AbstractServerMessageImpl$Reference.release(AbstractServerMessageImpl.java:309)
at
org.apache.qpid.server.queue.QueueEntryImpl.dispose(QueueEntryImpl.java:557)
at
org.apache.qpid.server.queue.QueueEntryImpl.delete(QueueEntryImpl.java:572)
at
org.apache.qpid.server.queue.AbstractQueue$11.postCommit(AbstractQueue.java:1729)
at
org.apache.qpid.server.txn.AutoCommitTransaction.dequeue(AutoCommitTransaction.java:92)
at
org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1722)
at
org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1717)
at
org.apache.qpid.server.queue.AbstractQueue.deleteEntry(AbstractQueue.java:1761)
at
org.apache.qpid.server.queue.AbstractQueue.checkMessageStatus(AbstractQueue.java:2165)
at
org.apache.qpid.server.virtualhost.AbstractVirtualHost$VirtualHostHouseKeepingTask.execute(AbstractVirtualHost.java:1965)
at
org.apache.qpid.server.virtualhost.HouseKeepingTask$1.run(HouseKeepingTask.java:56)
at java.security.AccessController.doPrivileged(Native Method)
at
org.apache.qpid.server.virtualhost.HouseKeepingTask.run(HouseKeepingTask.java:51)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at
org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
at java.lang.Thread.run(Thread.java:748)
Caused by: com.sleepycat.je.rep.InsufficientAcksException: (JE 7.4.5)
Transaction: -3459038252 VLSN: 10,380,435,448, initiated at: 07:53:20.
Insufficient acks for policy:SIMPLE_MAJORITY. Need replica acks: 2. Missing
replica acks: 2. Timeout: 15000ms. FeederState=acc3_2(3)[MASTER]
Current feeds:
acc3_1: feederVLSN=10,380,435,456 replicaTxnEndVLSN=10,380,435,396
acc3: feederVLSN=10,380,435,456 replicaTxnEndVLSN=10,380,435,396
at
com.sleepycat.je.rep.impl.node.DurabilityQuorum.ensureSufficientAcks(DurabilityQuorum.java:205)
at
com.sleepycat.je.rep.stream.FeederTxns.awaitReplicaAcks(FeederTxns.java:189)
at
com.sleepycat.je.rep.impl.RepImpl.postLogCommitHookInternal(RepImpl.java:1426)
at
com.sleepycat.je.rep.impl.RepImpl.postLogCommitHook(RepImpl.java:1385)
at
com.sleepycat.je.rep.txn.MasterTxn.postLogCommitHook(MasterTxn.java:228)
at com.sleepycat.je.txn.Txn.commit(Txn.java:772)
at
