[jira] [Commented] (PROTON-2131) Improved logging API
[
https://issues.apache.org/jira/browse/PROTON-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973951#comment-16973951
]
ASF subversion and git services commented on PROTON-2131:
-
Commit 825ab55e16887b62cbd4535bc984a4c3049863a3 in qpid-proton's branch
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=825ab55 ]
PROTON-2131: Document environment variables used to control proton logging
> Improved logging API
>
>
> Key: PROTON-2131
> URL: https://issues.apache.org/jira/browse/PROTON-2131
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-c
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> Problems with current proton logging:
> * There are multiple logging systems that are not connected
> - {{pn_log_*}} is used for some things that are not connected to an AMQP
> connection (but not all things)
> - pn_transport_t has its own logging system that is the major logging
> system in proton, with an {{pn_transport_logf()}} and friends API and an
> ability to sink the log its output log messages using
> {{pn_transport_set_tracer()}}. However not everything that might need to
> log messages is connected to a {{pn_transport_t}} so it makes a lot more
> sense for logging to be its own system that the {{pn_transport_t}} is
> connected to rather than the other way around.
> * The logging only has a set of vague somewhat amorphous trace flags to
> decide which messages get logged. Currently the only coherent use for
> this subsystem is to set the environment variable {{PN_TRACE_FRM}} to get
> AMQP frame traces. There are other environment variable which produce
> output (and flags can be set programmatically by client programs) but
> which flags produce what output is not very systematic. There is no way
> to output only logging related to SSL/TLS for example.
> * The callback function that an application can attach to receive the
> log messages only gets the message and maybe the {{pn_transport_t}} that is
> associated, but no indication of the severity or what pert of the
> library it came from.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2131) Improved logging API
[
https://issues.apache.org/jira/browse/PROTON-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973949#comment-16973949
]
ASF subversion and git services commented on PROTON-2131:
-
Commit 2fca6618dc79aa937ffcf22d8bbdb325bded5206 in qpid-proton's branch
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=2fca661 ]
PROTON-2131: Improve and rationalise logger settings from the environment
- Introduced a new environment variable PN_LOG which can be used to set
multiple logger levels active.
> Improved logging API
>
>
> Key: PROTON-2131
> URL: https://issues.apache.org/jira/browse/PROTON-2131
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-c
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> Problems with current proton logging:
> * There are multiple logging systems that are not connected
> - {{pn_log_*}} is used for some things that are not connected to an AMQP
> connection (but not all things)
> - pn_transport_t has its own logging system that is the major logging
> system in proton, with an {{pn_transport_logf()}} and friends API and an
> ability to sink the log its output log messages using
> {{pn_transport_set_tracer()}}. However not everything that might need to
> log messages is connected to a {{pn_transport_t}} so it makes a lot more
> sense for logging to be its own system that the {{pn_transport_t}} is
> connected to rather than the other way around.
> * The logging only has a set of vague somewhat amorphous trace flags to
> decide which messages get logged. Currently the only coherent use for
> this subsystem is to set the environment variable {{PN_TRACE_FRM}} to get
> AMQP frame traces. There are other environment variable which produce
> output (and flags can be set programmatically by client programs) but
> which flags produce what output is not very systematic. There is no way
> to output only logging related to SSL/TLS for example.
> * The callback function that an application can attach to receive the
> log messages only gets the message and maybe the {{pn_transport_t}} that is
> associated, but no indication of the severity or what pert of the
> library it came from.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2131) Improved logging API
[
https://issues.apache.org/jira/browse/PROTON-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973950#comment-16973950
]
ASF subversion and git services commented on PROTON-2131:
-
Commit c692aa831d838aa1ee7efe3a819862b5522bd700 in qpid-proton's branch
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=c692aa8 ]
PROTON-2131: Improved documentation of logger API
> Improved logging API
>
>
> Key: PROTON-2131
> URL: https://issues.apache.org/jira/browse/PROTON-2131
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-c
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> Problems with current proton logging:
> * There are multiple logging systems that are not connected
> - {{pn_log_*}} is used for some things that are not connected to an AMQP
> connection (but not all things)
> - pn_transport_t has its own logging system that is the major logging
> system in proton, with an {{pn_transport_logf()}} and friends API and an
> ability to sink the log its output log messages using
> {{pn_transport_set_tracer()}}. However not everything that might need to
> log messages is connected to a {{pn_transport_t}} so it makes a lot more
> sense for logging to be its own system that the {{pn_transport_t}} is
> connected to rather than the other way around.
> * The logging only has a set of vague somewhat amorphous trace flags to
> decide which messages get logged. Currently the only coherent use for
> this subsystem is to set the environment variable {{PN_TRACE_FRM}} to get
> AMQP frame traces. There are other environment variable which produce
> output (and flags can be set programmatically by client programs) but
> which flags produce what output is not very systematic. There is no way
> to output only logging related to SSL/TLS for example.
> * The callback function that an application can attach to receive the
> log messages only gets the message and maybe the {{pn_transport_t}} that is
> associated, but no indication of the severity or what pert of the
> library it came from.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1480) Address Sanitizer leak in system_tests_multi_phase
[
https://issues.apache.org/jira/browse/DISPATCH-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973786#comment-16973786
]
ASF GitHub Bot commented on DISPATCH-1480:
--
codecov-io commented on issue #619: DISPATCH-1480: properly settle messages
received by the edge address …
URL: https://github.com/apache/qpid-dispatch/pull/619#issuecomment-553648344
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=h1)
Report
> Merging
[#619](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/46307e7e747e8b101dfa9ad86e168f1be5d2990e?src=pr=desc)
will **decrease** coverage by `0.03%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=tree)
```diff
@@Coverage Diff @@
## master #619 +/- ##
==
- Coverage 86.46% 86.43% -0.04%
==
Files 91 91
Lines 2061820622 +4
==
- Hits1782817824 -4
- Misses 2790 2798 +8
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/modules/edge\_router/addr\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvYWRkcl9wcm94eS5j)
| `91.83% <50%> (-0.88%)` | :arrow_down: |
|
[src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==)
| `88.18% <0%> (-1.58%)` | :arrow_down: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `68.11% <0%> (-0.49%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=)
| `87.64% <0%> (-0.45%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.97% <0%> (-0.23%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.34% <0%> (-0.17%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.08% <0%> (-0.01%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.05% <0%> (+0.49%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=footer).
Last update
[46307e7...2a243ad](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Address Sanitizer leak in system_tests_multi_phase
> --
>
> Key: DISPATCH-1480
> URL: https://issues.apache.org/jira/browse/DISPATCH-1480
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
>
> {noformat}
> 57: Test command: /usr/bin/python
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_multi_phase"57: Test timeout computed to be: 60057:
> test_01_waypoint_same_interior (system_tests_multi_phase.RouterTest) ...
> ok57: test_02_waypoint_same_edge (system_tests_multi_phase.RouterTest) ...
> ok57: test_03_waypoint_edge_interior (system_tests_multi_phase.RouterTest)
> ... ok57: test_04_waypoint_interior_edge
> (system_tests_multi_phase.RouterTest) ... ok57:
>
[GitHub] [qpid-dispatch] codecov-io commented on issue #619: DISPATCH-1480: properly settle messages received by the edge address …
codecov-io commented on issue #619: DISPATCH-1480: properly settle messages received by the edge address … URL: https://github.com/apache/qpid-dispatch/pull/619#issuecomment-553648344 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=h1) Report > Merging [#619](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/46307e7e747e8b101dfa9ad86e168f1be5d2990e?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=tree) ```diff @@Coverage Diff @@ ## master #619 +/- ## == - Coverage 86.46% 86.43% -0.04% == Files 91 91 Lines 2061820622 +4 == - Hits1782817824 -4 - Misses 2790 2798 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/modules/edge\_router/addr\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvYWRkcl9wcm94eS5j) | `91.83% <50%> (-0.88%)` | :arrow_down: | | [src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==) | `88.18% <0%> (-1.58%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `68.11% <0%> (-0.49%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.64% <0%> (-0.45%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <0%> (-0.23%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.17%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.08% <0%> (-0.01%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/619/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.05% <0%> (+0.49%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=footer). Last update [46307e7...2a243ad](https://codecov.io/gh/apache/qpid-dispatch/pull/619?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1481) Multicast producers should block on credit until consumers are present
[ https://issues.apache.org/jira/browse/DISPATCH-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973778#comment-16973778 ] ASF GitHub Bot commented on DISPATCH-1481: -- codecov-io commented on issue #618: DISPATCH-1481: Multicast links should block until a consumer is present URL: https://github.com/apache/qpid-dispatch/pull/618#issuecomment-553644436 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=h1) Report > Merging [#618](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/46307e7e747e8b101dfa9ad86e168f1be5d2990e?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=tree) ```diff @@Coverage Diff @@ ## master #618 +/- ## == - Coverage 86.46% 86.44% -0.03% == Files 91 91 Lines 2061820620 +2 == - Hits1782817824 -4 - Misses 2790 2796 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/modules/address\_lookup\_client/lookup\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfY2xpZW50L2xvb2t1cF9jbGllbnQuYw==) | `92.36% <ø> (-0.03%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.36% <100%> (-0.2%)` | :arrow_down: | | [src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==) | `88.18% <0%> (-1.58%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `68.11% <0%> (-0.49%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.86% <0%> (-0.23%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <0%> (-0.23%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.09% <0%> (ø)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.54% <0%> (+0.19%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=footer). Last update [46307e7...e920fee](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Multicast producers should block on credit until consumers are present > -- > > Key: DISPATCH-1481 > URL: https://issues.apache.org/jira/browse/DISPATCH-1481 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.8.0, 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.10.0 > > > For all anycast forwarding treatments (balanced, closest, etc.) the router > does not provide capacity (credit) to the publisher until the router is aware > of at least one consumer for that address. This allows the application to > avoid sending messages that the router will simply RELEASE due to lack of > consumers. > This is not the case for multicast producers
[GitHub] [qpid-dispatch] codecov-io commented on issue #618: DISPATCH-1481: Multicast links should block until a consumer is present
codecov-io commented on issue #618: DISPATCH-1481: Multicast links should block until a consumer is present URL: https://github.com/apache/qpid-dispatch/pull/618#issuecomment-553644436 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=h1) Report > Merging [#618](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/46307e7e747e8b101dfa9ad86e168f1be5d2990e?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=tree) ```diff @@Coverage Diff @@ ## master #618 +/- ## == - Coverage 86.46% 86.44% -0.03% == Files 91 91 Lines 2061820620 +2 == - Hits1782817824 -4 - Misses 2790 2796 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/modules/address\_lookup\_client/lookup\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfY2xpZW50L2xvb2t1cF9jbGllbnQuYw==) | `92.36% <ø> (-0.03%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.36% <100%> (-0.2%)` | :arrow_down: | | [src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==) | `88.18% <0%> (-1.58%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `68.11% <0%> (-0.49%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.86% <0%> (-0.23%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <0%> (-0.23%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.09% <0%> (ø)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/618/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.54% <0%> (+0.19%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=footer). Last update [46307e7...e920fee](https://codecov.io/gh/apache/qpid-dispatch/pull/618?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1480) Address Sanitizer leak in system_tests_multi_phase
[
https://issues.apache.org/jira/browse/DISPATCH-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973745#comment-16973745
]
ASF GitHub Bot commented on DISPATCH-1480:
--
kgiusti commented on pull request #619: DISPATCH-1480: properly settle messages
received by the edge address …
URL: https://github.com/apache/qpid-dispatch/pull/619
…proxy
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Address Sanitizer leak in system_tests_multi_phase
> --
>
> Key: DISPATCH-1480
> URL: https://issues.apache.org/jira/browse/DISPATCH-1480
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
>
> {noformat}
> 57: Test command: /usr/bin/python
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_multi_phase"57: Test timeout computed to be: 60057:
> test_01_waypoint_same_interior (system_tests_multi_phase.RouterTest) ...
> ok57: test_02_waypoint_same_edge (system_tests_multi_phase.RouterTest) ...
> ok57: test_03_waypoint_edge_interior (system_tests_multi_phase.RouterTest)
> ... ok57: test_04_waypoint_interior_edge
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_05_waypoint_interior_interior (system_tests_multi_phase.RouterTest) ...
> ok57: test_06_waypoint_edge_edge (system_tests_multi_phase.RouterTest) ...
> ok57: test_07_waypoint_edge_endpoints_int_1
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_08_waypoint_edge_endpoints_int_2 (system_tests_multi_phase.RouterTest)
> ... ok57: test_09_waypoint_int_endpoints_edge_1
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_10_waypoint_int_endpoints_edge_2 (system_tests_multi_phase.RouterTest)
> ... ok57: test_11_waypoint_int_endpoints_int_1
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_12_waypoint_int_endpoints_int_2 (system_tests_multi_phase.RouterTest)
> ... ok57: test_13_waypoint_edge_endpoints_edge_1
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_14_waypoint_edge_endpoints_edge_2 (system_tests_multi_phase.RouterTest)
> ... ok57: test_15_multiphase_1 (system_tests_multi_phase.RouterTest) ...
> ok57: test_16_multiphase_2 (system_tests_multi_phase.RouterTest) ... ok57:
> test_17_multiphase_3 (system_tests_multi_phase.RouterTest) ... ok57: ERROR57:
> 57: ==57:
> ERROR: tearDownClass (system_tests_multi_phase.RouterTest)57:
> --57:
> Traceback (most recent call last):57: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 670, in
> tearDownClass57: cls.tester.teardown()57: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 615, in
> teardown57: raise RuntimeError("Errors during teardown: \n\n%s" %
> "\n\n".join([str(e) for e in errors]))57: RuntimeError: Errors during
> teardown: {noformat}
> 57: Process 13237 error: exit code 23, expected 0
>
> 57: qdrouterd -c EA1.conf -I /home/travis/build/apache/qpid-dispatch/python
>
> 57:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_multi_phase/RouterTest/setUpClass/EA1-3.cmd
>
> 57:
>
> 57:
>
> 57: =
>
> 57: ==13237==ERROR: LeakSanitizer: detected memory leaks
>
> 57:
>
> 57: Indirect leak of 1728 byte(s) in 3 object(s) allocated from:
>
> 57: #0 0x7fd4cbb67076 in __interceptor_posix_memalign
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x99076)
>
> 57: #1 0x7fd4cb47fac8 in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:320
>
> 57: #2 0x7fd4cb489b1d in qd_buffer
> /home/travis/build/apache/qpid-dispatch/src/buffer.c:44
>
> 57: #3 0x7fd4cb49b7f4 in qd_insert
> /home/travis/build/apache/qpid-dispatch/src/compose.c:64
>
> 57: #4 0x7fd4cb49b7f4 in qd_insert_8
> /home/travis/build/apache/qpid-dispatch/src/compose.c:85
>
> 57: #5 0x7fd4cb49b7f4 in qd_compose
> /home/travis/build/apache/qpid-dispatch/src/compose.c:230
>
> 57: #6 0x7fd4cb51c0b6 in qcm_link_route_lookup_request
> /home/travis/build/apache/qpid-dispatch/src/address_lookup_utils.c:36
>
> 57: #7 0x7fd4cb5cfd25 in qcm_addr_lookup_process_pending_requests_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/address_lookup_client/lookup_client.c:487
>
> 57: #8 0x7fd4cb5d17ff
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #619: DISPATCH-1480: properly settle messages received by the edge address …
kgiusti opened a new pull request #619: DISPATCH-1480: properly settle messages received by the edge address … URL: https://github.com/apache/qpid-dispatch/pull/619 …proxy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1481) Multicast producers should block on credit until consumers are present
[ https://issues.apache.org/jira/browse/DISPATCH-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973731#comment-16973731 ] ASF GitHub Bot commented on DISPATCH-1481: -- kgiusti commented on pull request #618: DISPATCH-1481: Multicast links should block until a consumer is present URL: https://github.com/apache/qpid-dispatch/pull/618 This fixes an infinite loop bug which occurs when using multicast addresses on inbound waypoint (broker) links. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Multicast producers should block on credit until consumers are present > -- > > Key: DISPATCH-1481 > URL: https://issues.apache.org/jira/browse/DISPATCH-1481 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.8.0, 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.10.0 > > > For all anycast forwarding treatments (balanced, closest, etc.) the router > does not provide capacity (credit) to the publisher until the router is aware > of at least one consumer for that address. This allows the application to > avoid sending messages that the router will simply RELEASE due to lack of > consumers. > This is not the case for multicast producers (specifically, ingress links > with a multicast target address). In fact, the router's behavior has varied > over several releases (both intentionally and unintentionally): > * pre 1.0: mcast credit was consistent with anycast - block until consumers > present > * at 1.0 mcast credit was change to always be provided regardless of the > presence of consumers > ([DISPATCH-779|https://issues.apache.org/jira/browse/DISPATCH-779]) > * at some point after 1.2 the router began returning RELEASED outcome for > unsettled multicast. This appears to be unintentional (and reveals a hole in > the system test suite) as it can force an infinite loop as credit will > automatically be replenished (per DISPATCH-779). > * in 1.9.0 the router's handling of unsettled multicast outcomes was > corrected and brought in line with the handling of anycast unsettled messages > [DISPATCH-1266|https://issues.apache.org/jira/browse/DISPATCH-1266]. This > change ended up codifying the RELEASED on no-consumer behavior as > intentional, but did not address the infinite credit loop issue. > The router should be consistent in the way it manages credit regardless of > the forwarding treatment. Providing an unlimited credit supply can result in > an infinite transmit->RELEASE->retransmit loop. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #618: DISPATCH-1481: Multicast links should block until a consumer is present
kgiusti opened a new pull request #618: DISPATCH-1481: Multicast links should block until a consumer is present URL: https://github.com/apache/qpid-dispatch/pull/618 This fixes an infinite loop bug which occurs when using multicast addresses on inbound waypoint (broker) links. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2115) Bitrot in qpid-proton/c/tests/fdlimit.py
[
https://issues.apache.org/jira/browse/PROTON-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved PROTON-2115.
Fix Version/s: proton-c-0.30.0
Resolution: Fixed
> Bitrot in qpid-proton/c/tests/fdlimit.py
>
>
> Key: PROTON-2115
> URL: https://issues.apache.org/jira/browse/PROTON-2115
> Project: Qpid Proton
> Issue Type: Test
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> Originally, {{Proc}} was imported in scope,
> https://github.com/apache/qpid-proton/commit/087b94faef6f0bc3fc2eac50ba0d2c2b03d82fbd#diff-9ad88150e74c307cdd1f621348dca9d6R20
> Nowadays, it isn't, current state of the file is this
> https://github.com/apache/qpid-proton/blob/9778eda8e9387caa8a207fbb6fedfa09ac0e298a/c/tests/fdlimit.py#L41
>
> {noformat}
> # Check if we can run prlimit to control resources
> try:
> Proc(["prlimit"]).wait_exit()
> except:
> print("Skipping test: prlimit not available")
> sys.exit(0)
> {noformat}
> The broad except masks the error here, and also anything else in the rest of
> the file (which is never executed).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2115) Bitrot in qpid-proton/c/tests/fdlimit.py
[
https://issues.apache.org/jira/browse/PROTON-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated PROTON-2115:
---
Component/s: proton-c
> Bitrot in qpid-proton/c/tests/fdlimit.py
>
>
> Key: PROTON-2115
> URL: https://issues.apache.org/jira/browse/PROTON-2115
> Project: Qpid Proton
> Issue Type: Test
> Components: proton-c
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> Originally, {{Proc}} was imported in scope,
> https://github.com/apache/qpid-proton/commit/087b94faef6f0bc3fc2eac50ba0d2c2b03d82fbd#diff-9ad88150e74c307cdd1f621348dca9d6R20
> Nowadays, it isn't, current state of the file is this
> https://github.com/apache/qpid-proton/blob/9778eda8e9387caa8a207fbb6fedfa09ac0e298a/c/tests/fdlimit.py#L41
>
> {noformat}
> # Check if we can run prlimit to control resources
> try:
> Proc(["prlimit"]).wait_exit()
> except:
> print("Skipping test: prlimit not available")
> sys.exit(0)
> {noformat}
> The broad except masks the error here, and also anything else in the rest of
> the file (which is never executed).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2115) Bitrot in qpid-proton/c/tests/fdlimit.py
[
https://issues.apache.org/jira/browse/PROTON-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973598#comment-16973598
]
Jiri Daněk commented on PROTON-2115:
Test is not being run under valgrind in current master, and I've made sure that
it won't run under valgrind even after my change for PROTON-2135. The only
worrying thing about fdlimit test is the failure in Travis on PR
https://github.com/apache/qpid-proton/pull/202 for PROTON-2130,
https://travis-ci.org/apache/qpid-proton/builds/608636995. I think it is ok to
close, since master is green.
> Bitrot in qpid-proton/c/tests/fdlimit.py
>
>
> Key: PROTON-2115
> URL: https://issues.apache.org/jira/browse/PROTON-2115
> Project: Qpid Proton
> Issue Type: Test
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Originally, {{Proc}} was imported in scope,
> https://github.com/apache/qpid-proton/commit/087b94faef6f0bc3fc2eac50ba0d2c2b03d82fbd#diff-9ad88150e74c307cdd1f621348dca9d6R20
> Nowadays, it isn't, current state of the file is this
> https://github.com/apache/qpid-proton/blob/9778eda8e9387caa8a207fbb6fedfa09ac0e298a/c/tests/fdlimit.py#L41
>
> {noformat}
> # Check if we can run prlimit to control resources
> try:
> Proc(["prlimit"]).wait_exit()
> except:
> print("Skipping test: prlimit not available")
> sys.exit(0)
> {noformat}
> The broad except masks the error here, and also anything else in the rest of
> the file (which is never executed).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #617: DISPATCH-1472 - Add new section to qdstat man page for qdstat -g
asfgit closed pull request #617: DISPATCH-1472 - Add new section to qdstat man page for qdstat -g URL: https://github.com/apache/qpid-dispatch/pull/617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1472) qdstat --general option not documented in qdstat man page
[ https://issues.apache.org/jira/browse/DISPATCH-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973537#comment-16973537 ] ASF GitHub Bot commented on DISPATCH-1472: -- asfgit commented on pull request #617: DISPATCH-1472 - Add new section to qdstat man page for qdstat -g URL: https://github.com/apache/qpid-dispatch/pull/617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdstat --general option not documented in qdstat man page > - > > Key: DISPATCH-1472 > URL: https://issues.apache.org/jira/browse/DISPATCH-1472 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ben Hardesty >Priority: Major > > The qdstat command's man page does not document the qdstat -g option. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] RedFlashNinja opened a new pull request #41: NO-JIRA: Clean Code
RedFlashNinja opened a new pull request #41: NO-JIRA: Clean Code URL: https://github.com/apache/qpid-broker-j/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2136) fuzz-connection-driver.c exits with 1 when the engine stops accepting additional input
[
https://issues.apache.org/jira/browse/PROTON-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973327#comment-16973327
]
ASF GitHub Bot commented on PROTON-2136:
jdanekrh commented on pull request #208: PROTON-2136 Fix fuzz-connection-driver
to be tolerant of NULL input buffer
URL: https://github.com/apache/qpid-proton/pull/208
I completely forgot about this one. Maybe when it is fixed, the fuzz target
will not be crashing so much and the OSS Fuzz infra will run it more.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> fuzz-connection-driver.c exits with 1 when the engine stops accepting
> additional input
> --
>
> Key: PROTON-2136
> URL: https://issues.apache.org/jira/browse/PROTON-2136
> Project: Qpid Proton
> Issue Type: Test
> Components: proton-c
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> size_t fcd_read(pn_connection_driver_t *driver, uint8_t **data, size_t *size)
> {
> pn_rwbytes_t buf = pn_connection_driver_read_buffer(driver);
> size_t s = (*size < buf.size) ? *size : buf.size;
> if (buf.start == NULL) {
> exit(1);
> }
> {noformat}
> The engine offers a null buffer for further input. AFAIK that is legit,
> because it is just that the "socket" was closed for further input, after
> reading the invalid header.
> The fuzz target should just return peacefully at this point and not crash.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jdanekrh opened a new pull request #208: PROTON-2136 Fix fuzz-connection-driver to be tolerant of NULL input buffer
jdanekrh opened a new pull request #208: PROTON-2136 Fix fuzz-connection-driver to be tolerant of NULL input buffer URL: https://github.com/apache/qpid-proton/pull/208 I completely forgot about this one. Maybe when it is fixed, the fuzz target will not be crashing so much and the OSS Fuzz infra will run it more. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2136) fuzz-connection-driver.c exits with 1 when the engine stops accepting additional input
Jiri Daněk created PROTON-2136:
--
Summary: fuzz-connection-driver.c exits with 1 when the engine
stops accepting additional input
Key: PROTON-2136
URL: https://issues.apache.org/jira/browse/PROTON-2136
Project: Qpid Proton
Issue Type: Test
Components: proton-c
Affects Versions: proton-c-0.29.0
Reporter: Jiri Daněk
Assignee: Jiri Daněk
{noformat}
size_t fcd_read(pn_connection_driver_t *driver, uint8_t **data, size_t *size) {
pn_rwbytes_t buf = pn_connection_driver_read_buffer(driver);
size_t s = (*size < buf.size) ? *size : buf.size;
if (buf.start == NULL) {
exit(1);
}
{noformat}
The engine offers a null buffer for further input. AFAIK that is legit, because
it is just that the "socket" was closed for further input, after reading the
invalid header.
The fuzz target should just return peacefully at this point and not crash.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8375) [Broker-J][ACL] Normalize identinity names represented as Distingished Names
Alex Rudyy created QPID-8375: Summary: [Broker-J][ACL] Normalize identinity names represented as Distingished Names Key: QPID-8375 URL: https://issues.apache.org/jira/browse/QPID-8375 Project: Qpid Issue Type: Improvement Components: Broker-J Reporter: Alex Rudyy The current implementation of ACL uses case insensitive lookup for the rules by comparing rule identity with the subject principal names. When ACL rule identity is represented as Distinguished name (for example, an LDAP group or LDAP user entity), it is quite easy to specify extra spaces in the rule identity (between RDNs), as result the rule might not be selected for the right principal name. Potentially, the identity names represented as Distingished Names can be normalized in order to get rid from extra spaces. See [Distinguished Names|https://ldapwiki.com/wiki/Distinguished%20Names]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on issue #39: Qpid-8127: [Broker-J] Allow case insensitive matching of group and user names for LDAP DN search
alex-rufous commented on issue #39: Qpid-8127: [Broker-J] Allow case insensitive matching of group and user names for LDAP DN search URL: https://github.com/apache/qpid-broker-j/pull/39#issuecomment-553347444 Hi Stanislav, Thanks for submitting a pull request. Please note, that I have closed QPID-8127 as invalid and raised a new JIRA QPID-8374 for case insensitive group look-up. In order to keep backward compatibility, the existing case sensitive group look-up behaviour needs to be preserved and kept as a default behaviour. In JIRA description QPID-8374 I suggested an alternative approach for the implementation. The best way to address the JIRA is to have a switch to configure the desired group look-up behaviour. The changes implemented in commit f6b54b8 needs to be redone to preserve the current behaviour and switch to case insensitive group mapping if it is configured so. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2133) c-fdlimit-tests with epoll is not tsan clean
[
https://issues.apache.org/jira/browse/PROTON-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973217#comment-16973217
]
Jiri Daněk commented on PROTON-2133:
[~astitcher] [~cliffjansen] [~kpvdr] I think that in yesterday's discussion,
the power of the helgrind/tsan algorithm was too underappreciated. If anything,
these usually tend to get appeased by spurious synchronization (due to e.g.
printing to stdout, if there is some lock in that [1]), rather than to produce
false positives due to missed barriers, or patterns when value is not
specifically "guarded by" a specific lock, but accesses are protected by
piggybacking on synchronization due to some other lock.
It may report "harmless" races (although any race has undefined behavior), and
it has bugs, e.g. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78158, but what
it reports should be mostly real, as opposed to the "lockset" algorithms, and
some other static analysis which is more prone to false positives.
For example, regarding the report above,
{noformat}
6: WARNING: ThreadSanitizer: data race (pid=7358)
6: Write of size 4 at 0x7b729818 by thread T3:
6: #0 stop_polling
/home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:313:10
(libqpid-proton-proactor.so.1+0xd22a)
6: #1 pconnection_cleanup
/home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:896:3
(libqpid-proton-proactor.so.1+0xcacb)
6: #2 pconnection_done
/home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1044:7
(libqpid-proton-proactor.so.1+0xa670)
6: #3 pn_proactor_done
/home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:2166:5
(libqpid-proton-proactor.so.1+0xa670)
6: #4 broker_thread
/home/jdanek/repos/qpid/qpid-proton/c/examples/broker.c:439:5 (broker+0x4cb4e6)
6:
6: Previous read of size 4 at 0x7b729818 by thread T2 (mutexes: write
M2131):
6: #0 rearm
/home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:720:48
(libqpid-proton-proactor.so.1+0x8703)
6: #1 pconnection_rearm
/home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1014:5
(libqpid-proton-proactor.so.1+0xcf78)
6: #2 pconnection_done
/home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1051:14
(libqpid-proton-proactor.so.1+0x9e24)
6: #3 pn_proactor_done
/home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:2166:5
(libqpid-proton-proactor.so.1+0x9e24)
6: #4 broker_thread
/home/jdanek/repos/qpid/qpid-proton/c/examples/broker.c:439:5 (broker+0x4cb4e6)
{noformat}
{noformat}
static void stop_polling(epoll_extended_t *ee, int epollfd) {
// TODO: check for error, return bool or just log?
// TODO: is EPOLL_CTL_DEL ever needed beyond auto de-register when ee->fd is
closed?
if (ee->fd == -1 || !ee->polling || epollfd == -1)
return;
struct epoll_event ev = {0};
ev.data.ptr = ee;
ev.events = 0;
memory_barrier(ee);
// HERE
if (epoll_ctl(epollfd, EPOLL_CTL_DEL, ee->fd, ) == -1)
EPOLL_FATAL("EPOLL_CTL_DEL", errno);
ee->fd = -1;
ee->polling = false;
}
static void rearm(pn_proactor_t *p, epoll_extended_t *ee) {
struct epoll_event ev = {0};
ev.data.ptr = ee;
ev.events = ee->wanted | EPOLLONESHOT;
memory_barrier(ee);
// HERE
if (epoll_ctl(p->epollfd, EPOLL_CTL_MOD, ee->fd, ) == -1)
EPOLL_FATAL("arming polled file descriptor", errno);
}
{noformat}
I think what the report is about is that both threads can get to the point
marked {{// HERE}}, and then there is a race on {{ee->fd}}.
[1] https://mail.openjdk.java.net/pipermail/tsan-dev/2019-July/000260.html and
Dmitry's response in the thread. It's for java (which synchronizes
system.out.println, but the algorithm is the same there and in regular tsan.
> c-fdlimit-tests with epoll is not tsan clean
>
>
> Key: PROTON-2133
> URL: https://issues.apache.org/jira/browse/PROTON-2133
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {noformat}
> 6: Test timeout computed to be: 1500
> 6: E
> 6: ==
> 6: ERROR: test_fd_limit_broker (__main__.FdLimitTest)
> 6: Check behaviour when running out of file descriptors on accept
> 6: --
> 6: Traceback (most recent call last):
> 6: File "/home/jdanek/repos/qpid/qpid-proton/c/tests/fdlimit.py", line 87,
> in test_fd_limit_broker
> 6: self.assertIn("10 messages received",
> test_subprocess.check_output(["receive", "", b.port],
> universal_newlines=True))
> 6: File "/home/jdanek/repos/qpid/qpid-proton/tests/py/test_subprocess.py",
> line 110, in __exit__
> 6: self.on_exit()
> 6: File "/home/jdanek/repos/qpid/qpid-proton/tests/py/test_subprocess.py",
>
[jira] [Closed] (QPID-8127) [Broker-J][ACL] Allow case insensitive matching of group and user names in existing ACL
[ https://issues.apache.org/jira/browse/QPID-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy closed QPID-8127. Resolution: Invalid A new JIRA QPID-8374 was raised to implement case insensitive group mapping > [Broker-J][ACL] Allow case insensitive matching of group and user names in > existing ACL > --- > > Key: QPID-8127 > URL: https://issues.apache.org/jira/browse/QPID-8127 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Alex Rudyy >Priority: Major > > The current ACL rules matching functionality is case sensitive for user names > and group names. > When SimpleLdap authentication provider is configured and groups are fetched > from LDAP as distinguished names, it is quite easy to make a mistake in > group/user DN and put some of letter in wrong case as LDAP DN search is > case-insensitive. Thus, users can specify some parts of DN in ACL using > letters in wrong case. > The debugging of such mistyped names can be time-consuming. IMHO, it make > more sense to add ability into ACL implementation to match groups and user > names in case insensitive way. > The following link provides a good overview of case sensitivity of DN: > [http://ldapwiki.com/wiki/Distinguished%20Name%20Case%20Sensitivity] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8374) [Broker-J][ACL] Allow case insensitive mapping of group members to groups in existing GroupProvider
Alex Rudyy created QPID-8374:
Summary: [Broker-J][ACL] Allow case insensitive mapping of group
members to groups in existing GroupProvider
Key: QPID-8374
URL: https://issues.apache.org/jira/browse/QPID-8374
Project: Qpid
Issue Type: Improvement
Components: Broker-J
Reporter: Alex Rudyy
The user groups currently identified by exact equality of authenticated
principal name and group member name. (See
{{org.apache.qpid.server.security.group.GroupProviderImpl#getGroupPrincipalsForUser}}
and
{{org.apache.qpid.server.model.adapter.FileBasedGroupProviderImpl#getGroupPrincipalsForUser}}.)
The user groups are used in in ACL to define rules applicable to multiple
users belonging to the same group. The ACL identities are case insensitive. As
result, any letter case can be used in identities to express the ACL rule. In
many cases, when authenticated principals are coming from external systems like
LDAP, OAUTH2 based providers, etc, and they are case insensitive, it is desired
to have group mapping case insensitive as well, as it is quite easy to make a
mistake and specify the group member using upper cased letters rather than
lower cased, for example, {{cn=Alex,ou=users,dc=qpid,dc=org}} vs
{{cn=alex,ou=users,dc=qpid,dc=org}}.
The existing GroupProviders can be modified to allow case insensitive mapping
of group members to groups. Though, the existing case sensitive group mapping
behaviour should be preserved for backward compatibility reasons. It should be
enabled by default. A special switch (either attribute or/and context variable
) could be provided to make group mapping case insensitive if desired.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2135) C, cpp, and fuzz tests do not set TEST_ENV on Linux
[
https://issues.apache.org/jira/browse/PROTON-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated PROTON-2135:
---
Description:
% cmake .. -DRUNTIME_CHECK=memcheck
% ctest -V -N
{noformat}
2: Test command:
/nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
"--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
"--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
"/home/jdanek/repos/qpid/qpid-proton/build/c/tests/c-core-test"
Test #2: c-core-test
8: Test command:
/nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
"--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
"--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
"/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode"
"@/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode-files"
Test #8: fuzz-message-decode
{noformat}
I'd've expected to see the execution wrapped in the env.py script.
was:
% cmake .. -DRUNTIME_CHECK=memcheck
% ctest -V -N
{noformat}
2: Test command:
/nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
"--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
"--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
"/home/jdanek/repos/qpid/qpid-proton/build/c/tests/c-core-test"
Test #2: c-core-test
8: Test command:
/nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
"--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
"--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
"/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode"
"@/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode-files"
Test #8: fuzz-message-decode
{noformat}
> C, cpp, and fuzz tests do not set TEST_ENV on Linux
> ---
>
> Key: PROTON-2135
> URL: https://issues.apache.org/jira/browse/PROTON-2135
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> % cmake .. -DRUNTIME_CHECK=memcheck
> % ctest -V -N
> {noformat}
> 2: Test command:
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/c-core-test"
> Test #2: c-core-test
> 8: Test command:
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode"
> "@/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode-files"
> Test #8: fuzz-message-decode
> {noformat}
> I'd've expected to see the execution wrapped in the env.py script.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2133) c-fdlimit-tests with epoll is not tsan clean
[
https://issues.apache.org/jira/browse/PROTON-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973183#comment-16973183
]
ASF GitHub Bot commented on PROTON-2133:
jdanekrh commented on issue #204: PROTON-2133 PROTON-2134 asan and tsan
suppressions and travis jobs
URL: https://github.com/apache/qpid-proton/pull/204#issuecomment-553323079
TEST_ENV change is in https://github.com/apache/qpid-proton/pull/207, I gave
it a Jira. Ready for review, now. Hopefully.
```diff
+ When the land is green, sheep is plentiful in the east.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c-fdlimit-tests with epoll is not tsan clean
>
>
> Key: PROTON-2133
> URL: https://issues.apache.org/jira/browse/PROTON-2133
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {noformat}
> 6: Test timeout computed to be: 1500
> 6: E
> 6: ==
> 6: ERROR: test_fd_limit_broker (__main__.FdLimitTest)
> 6: Check behaviour when running out of file descriptors on accept
> 6: --
> 6: Traceback (most recent call last):
> 6: File "/home/jdanek/repos/qpid/qpid-proton/c/tests/fdlimit.py", line 87,
> in test_fd_limit_broker
> 6: self.assertIn("10 messages received",
> test_subprocess.check_output(["receive", "", b.port],
> universal_newlines=True))
> 6: File "/home/jdanek/repos/qpid/qpid-proton/tests/py/test_subprocess.py",
> line 110, in __exit__
> 6: self.on_exit()
> 6: File "/home/jdanek/repos/qpid/qpid-proton/tests/py/test_subprocess.py",
> line 84, in check_kill
> 6: raise TestProcessError(self, "check_kill found error output")
> 6: TestProcessError: ['prlimit', '-n256', 'broker', '', '0'] pid=7358
> exit=-9: check_kill found error output
> 6: stderr(7358)
>
> 6: ==
> 6: WARNING: ThreadSanitizer: data race (pid=7358)
> 6: Write of size 4 at 0x7b729818 by thread T3:
> 6: #0 stop_polling
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:313:10
> (libqpid-proton-proactor.so.1+0xd22a)
> 6: #1 pconnection_cleanup
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:896:3
> (libqpid-proton-proactor.so.1+0xcacb)
> 6: #2 pconnection_done
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1044:7
> (libqpid-proton-proactor.so.1+0xa670)
> 6: #3 pn_proactor_done
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:2166:5
> (libqpid-proton-proactor.so.1+0xa670)
> 6: #4 broker_thread
> /home/jdanek/repos/qpid/qpid-proton/c/examples/broker.c:439:5
> (broker+0x4cb4e6)
> 6:
> 6: Previous read of size 4 at 0x7b729818 by thread T2 (mutexes: write
> M2131):
> 6: #0 rearm
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:720:48
> (libqpid-proton-proactor.so.1+0x8703)
> 6: #1 pconnection_rearm
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1014:5
> (libqpid-proton-proactor.so.1+0xcf78)
> 6: #2 pconnection_done
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1051:14
> (libqpid-proton-proactor.so.1+0x9e24)
> 6: #3 pn_proactor_done
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:2166:5
> (libqpid-proton-proactor.so.1+0x9e24)
> 6: #4 broker_thread
> /home/jdanek/repos/qpid/qpid-proton/c/examples/broker.c:439:5
> (broker+0x4cb4e6)
> 6:
> 6: Location is heap block of size 1880 at 0x7b729800 allocated by
> thread T2:
> 6: #0 calloc (broker+0x45b124)
> 6: #1 pn_listener_accept2
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1795:40
> (libqpid-proton-proactor.so.1+0x7d91)
> 6: #2 handle
> /home/jdanek/repos/qpid/qpid-proton/c/examples/broker.c:306:6
> (broker+0x4cb794)
> 6: #3 broker_thread
> /home/jdanek/repos/qpid/qpid-proton/c/examples/broker.c:437:14
> (broker+0x4cb794)
> 6:
> 6: Mutex M2131 (0x7b729ee8) created at:
> 6: #0 pthread_mutex_init (broker+0x42e922)
> 6: #1 pmutex_init
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:105:7
> (libqpid-proton-proactor.so.1+0x560a)
> 6: #2 pconnection_setup
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:853:3
> (libqpid-proton-proactor.so.1+0x560a)
> 6: #3 pn_listener_accept2
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1797:21
[GitHub] [qpid-proton] codecov-io commented on issue #204: PROTON-2133 PROTON-2134 asan and tsan suppressions and travis jobs
codecov-io commented on issue #204: PROTON-2133 PROTON-2134 asan and tsan suppressions and travis jobs URL: https://github.com/apache/qpid-proton/pull/204#issuecomment-553323026 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=h1) Report > Merging [#204](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/9dd013335de0694bc52848897b17190f297450c1?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #204 +/- ## === Coverage 81.96% 81.96% === Files 267 267 Lines 3590335903 === Hits2942729427 Misses 6476 6476 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=footer). Last update [9dd0133...52f5a8b](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jdanekrh commented on issue #204: PROTON-2133 PROTON-2134 asan and tsan suppressions and travis jobs
jdanekrh commented on issue #204: PROTON-2133 PROTON-2134 asan and tsan suppressions and travis jobs URL: https://github.com/apache/qpid-proton/pull/204#issuecomment-553323079 TEST_ENV change is in https://github.com/apache/qpid-proton/pull/207, I gave it a Jira. Ready for review, now. Hopefully. ```diff + When the land is green, sheep is plentiful in the east. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2133) c-fdlimit-tests with epoll is not tsan clean
[
https://issues.apache.org/jira/browse/PROTON-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973180#comment-16973180
]
ASF GitHub Bot commented on PROTON-2133:
codecov-io commented on issue #204: PROTON-2133 PROTON-2134 asan and tsan
suppressions and travis jobs
URL: https://github.com/apache/qpid-proton/pull/204#issuecomment-553323026
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=h1)
Report
> Merging
[#204](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/9dd013335de0694bc52848897b17190f297450c1?src=pr=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=tree)
```diff
@@ Coverage Diff @@
## master #204 +/- ##
===
Coverage 81.96% 81.96%
===
Files 267 267
Lines 3590335903
===
Hits2942729427
Misses 6476 6476
```
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=footer).
Last update
[9dd0133...52f5a8b](https://codecov.io/gh/apache/qpid-proton/pull/204?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c-fdlimit-tests with epoll is not tsan clean
>
>
> Key: PROTON-2133
> URL: https://issues.apache.org/jira/browse/PROTON-2133
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {noformat}
> 6: Test timeout computed to be: 1500
> 6: E
> 6: ==
> 6: ERROR: test_fd_limit_broker (__main__.FdLimitTest)
> 6: Check behaviour when running out of file descriptors on accept
> 6: --
> 6: Traceback (most recent call last):
> 6: File "/home/jdanek/repos/qpid/qpid-proton/c/tests/fdlimit.py", line 87,
> in test_fd_limit_broker
> 6: self.assertIn("10 messages received",
> test_subprocess.check_output(["receive", "", b.port],
> universal_newlines=True))
> 6: File "/home/jdanek/repos/qpid/qpid-proton/tests/py/test_subprocess.py",
> line 110, in __exit__
> 6: self.on_exit()
> 6: File "/home/jdanek/repos/qpid/qpid-proton/tests/py/test_subprocess.py",
> line 84, in check_kill
> 6: raise TestProcessError(self, "check_kill found error output")
> 6: TestProcessError: ['prlimit', '-n256', 'broker', '', '0'] pid=7358
> exit=-9: check_kill found error output
> 6: stderr(7358)
>
> 6: ==
> 6: WARNING: ThreadSanitizer: data race (pid=7358)
> 6: Write of size 4 at 0x7b729818 by thread T3:
> 6: #0 stop_polling
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:313:10
> (libqpid-proton-proactor.so.1+0xd22a)
> 6: #1 pconnection_cleanup
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:896:3
> (libqpid-proton-proactor.so.1+0xcacb)
> 6: #2 pconnection_done
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1044:7
> (libqpid-proton-proactor.so.1+0xa670)
> 6: #3 pn_proactor_done
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:2166:5
> (libqpid-proton-proactor.so.1+0xa670)
> 6: #4 broker_thread
> /home/jdanek/repos/qpid/qpid-proton/c/examples/broker.c:439:5
> (broker+0x4cb4e6)
> 6:
> 6: Previous read of size 4 at 0x7b729818 by thread T2 (mutexes: write
> M2131):
> 6: #0 rearm
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:720:48
> (libqpid-proton-proactor.so.1+0x8703)
> 6: #1 pconnection_rearm
> /home/jdanek/repos/qpid/qpid-proton/c/src/proactor/epoll.c:1014:5
> (libqpid-proton-proactor.so.1+0xcf78)
>
[jira] [Created] (QPIDJMS-480) Connection hangs for ws transport with wss server
Stephan Siano created QPIDJMS-480: - Summary: Connection hangs for ws transport with wss server Key: QPIDJMS-480 URL: https://issues.apache.org/jira/browse/QPIDJMS-480 Project: Qpid JMS Issue Type: Bug Components: qpid-jms-client Affects Versions: 0.47.0, 0.46.0 Reporter: Stephan Siano If you try to connect to a qpid-jms client with the amqpws (without TLS) transport to an SSL enabled server supporting the websocket protocol, the connection will hang (instead of failing with an error). You can reproduce the issue if you change line 60 of NettyWsTransportTest to return new NettyEchoServer(options, true, needClientAuth, true); and execute testConnectToServerUsingCorrectPath(). The test is expected to fail, but it fails only because the test times out after 60 seconds, not because the connection fails. Without that test timeout, the connection will hang indefinitely. If I try something similar with a TCP transport (connecting with amqp to an amqps) server, this fails after 10 seconds, which looks like a timeout to me (and is something I would consider ok). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1480) Address Sanitizer leak in system_tests_multi_phase
[
https://issues.apache.org/jira/browse/DISPATCH-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972698#comment-16972698
]
Jiri Daněk edited comment on DISPATCH-1480 at 11/13/19 9:35 AM:
[~kgiusti], btw, regarding {{"\*python2\*"}} and so on, when I was reading
documentation, I was surprised that \*...\* in sanitizer suppression file is
assumed implicitly. If you don't want it, ^ and $ must be used.
was (Author: jdanek):
[~kgiusti], btw, regarding {{"\*python2\*"}} and so on, when I was reading
documentation, I was surprised that *...* in sanitizer suppression file is
assumed implicitly. If you don't want it, ^ and $ must be used.
> Address Sanitizer leak in system_tests_multi_phase
> --
>
> Key: DISPATCH-1480
> URL: https://issues.apache.org/jira/browse/DISPATCH-1480
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
>
> {noformat}
> 57: Test command: /usr/bin/python
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_multi_phase"57: Test timeout computed to be: 60057:
> test_01_waypoint_same_interior (system_tests_multi_phase.RouterTest) ...
> ok57: test_02_waypoint_same_edge (system_tests_multi_phase.RouterTest) ...
> ok57: test_03_waypoint_edge_interior (system_tests_multi_phase.RouterTest)
> ... ok57: test_04_waypoint_interior_edge
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_05_waypoint_interior_interior (system_tests_multi_phase.RouterTest) ...
> ok57: test_06_waypoint_edge_edge (system_tests_multi_phase.RouterTest) ...
> ok57: test_07_waypoint_edge_endpoints_int_1
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_08_waypoint_edge_endpoints_int_2 (system_tests_multi_phase.RouterTest)
> ... ok57: test_09_waypoint_int_endpoints_edge_1
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_10_waypoint_int_endpoints_edge_2 (system_tests_multi_phase.RouterTest)
> ... ok57: test_11_waypoint_int_endpoints_int_1
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_12_waypoint_int_endpoints_int_2 (system_tests_multi_phase.RouterTest)
> ... ok57: test_13_waypoint_edge_endpoints_edge_1
> (system_tests_multi_phase.RouterTest) ... ok57:
> test_14_waypoint_edge_endpoints_edge_2 (system_tests_multi_phase.RouterTest)
> ... ok57: test_15_multiphase_1 (system_tests_multi_phase.RouterTest) ...
> ok57: test_16_multiphase_2 (system_tests_multi_phase.RouterTest) ... ok57:
> test_17_multiphase_3 (system_tests_multi_phase.RouterTest) ... ok57: ERROR57:
> 57: ==57:
> ERROR: tearDownClass (system_tests_multi_phase.RouterTest)57:
> --57:
> Traceback (most recent call last):57: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 670, in
> tearDownClass57: cls.tester.teardown()57: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 615, in
> teardown57: raise RuntimeError("Errors during teardown: \n\n%s" %
> "\n\n".join([str(e) for e in errors]))57: RuntimeError: Errors during
> teardown: {noformat}
> 57: Process 13237 error: exit code 23, expected 0
>
> 57: qdrouterd -c EA1.conf -I /home/travis/build/apache/qpid-dispatch/python
>
> 57:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_multi_phase/RouterTest/setUpClass/EA1-3.cmd
>
> 57:
>
> 57:
>
> 57: =
>
> 57: ==13237==ERROR: LeakSanitizer: detected memory leaks
>
> 57:
>
> 57: Indirect leak of 1728 byte(s) in 3 object(s) allocated from:
>
> 57: #0 0x7fd4cbb67076 in __interceptor_posix_memalign
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x99076)
>
> 57: #1 0x7fd4cb47fac8 in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:320
>
> 57: #2 0x7fd4cb489b1d in qd_buffer
> /home/travis/build/apache/qpid-dispatch/src/buffer.c:44
>
> 57: #3 0x7fd4cb49b7f4 in qd_insert
> /home/travis/build/apache/qpid-dispatch/src/compose.c:64
>
> 57: #4 0x7fd4cb49b7f4 in qd_insert_8
> /home/travis/build/apache/qpid-dispatch/src/compose.c:85
>
> 57: #5 0x7fd4cb49b7f4 in qd_compose
> /home/travis/build/apache/qpid-dispatch/src/compose.c:230
>
> 57: #6 0x7fd4cb51c0b6 in qcm_link_route_lookup_request
> /home/travis/build/apache/qpid-dispatch/src/address_lookup_utils.c:36
>
> 57: #7 0x7fd4cb5cfd25 in qcm_addr_lookup_process_pending_requests_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/address_lookup_client/lookup_client.c:487
>
> 57: #8 0x7fd4cb5d17ff
