[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection

2020-05-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110285#comment-17110285
 ] 

ASF GitHub Bot commented on DISPATCH-1614:
--

ted-ross commented on a change in pull request #738:
URL: https://github.com/apache/qpid-dispatch/pull/738#discussion_r426624937



##
File path: src/router_core/modules/edge_router/addr_proxy.c
##
@@ -215,6 +215,50 @@ static void del_outlink(qcm_edge_addr_proxy_t *ap, 
qdr_address_t *addr)
 }
 }
 
+static void on_link_event(void *context, qdrc_event_t event, qdr_link_t *link)
+{
+if (!link || !link->conn)
+return;
+
+//
+// We only care if the link event is on an edge connection.
+//
+if (link->conn->role != QDR_ROLE_EDGE_CONNECTION)
+return;
+
+switch (event) {
+case QDRC_EVENT_LINK_OUT_DETACHED: {
+qdr_address_t *addr = link->owning_addr;
+if (addr && addr->edge_outlink && link == addr->edge_outlink) {

Review comment:
   The second condition in the if is technically not necessary.  
edge_outlink is never dereferenced, only compared.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Edge router crash when interior closes edge uplink connection
> -
>
> Key: DISPATCH-1614
> URL: https://issues.apache.org/jira/browse/DISPATCH-1614
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.11.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.12.0
>
> Attachments: DISPATCH-1614-edge-router-log.txt
>
>
> When the connection to the interior router goes down then the 
> addr.edge_outlink link proper is freed but the pointer to the link is still 
> in the addr struct.
> Later when the addr is unbound the link is dereferenced causing a segfault.
> An attached log trace shows the events. Search for link _0x1c31210_ using 
> mobile address _M0e61_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #738: DISPATCH-1614 - Raised and handled QDRC_EVENT_LINK_IN_DETACHED and QD…

2020-05-18 Thread GitBox


ted-ross commented on a change in pull request #738:
URL: https://github.com/apache/qpid-dispatch/pull/738#discussion_r426624937



##
File path: src/router_core/modules/edge_router/addr_proxy.c
##
@@ -215,6 +215,50 @@ static void del_outlink(qcm_edge_addr_proxy_t *ap, 
qdr_address_t *addr)
 }
 }
 
+static void on_link_event(void *context, qdrc_event_t event, qdr_link_t *link)
+{
+if (!link || !link->conn)
+return;
+
+//
+// We only care if the link event is on an edge connection.
+//
+if (link->conn->role != QDR_ROLE_EDGE_CONNECTION)
+return;
+
+switch (event) {
+case QDRC_EVENT_LINK_OUT_DETACHED: {
+qdr_address_t *addr = link->owning_addr;
+if (addr && addr->edge_outlink && link == addr->edge_outlink) {

Review comment:
   The second condition in the if is technically not necessary.  
edge_outlink is never dereferenced, only compared.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Reopened] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection

2020-05-18 Thread Ganesh Murthy (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy reopened DISPATCH-1614:
-

> Edge router crash when interior closes edge uplink connection
> -
>
> Key: DISPATCH-1614
> URL: https://issues.apache.org/jira/browse/DISPATCH-1614
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.11.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.12.0
>
> Attachments: DISPATCH-1614-edge-router-log.txt
>
>
> When the connection to the interior router goes down then the 
> addr.edge_outlink link proper is freed but the pointer to the link is still 
> in the addr struct.
> Later when the addr is unbound the link is dereferenced causing a segfault.
> An attached log trace shows the events. Search for link _0x1c31210_ using 
> mobile address _M0e61_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] asfgit closed pull request #738: DISPATCH-1614 - Raised and handled QDRC_EVENT_LINK_IN_DETACHED and QD…

2020-05-18 Thread GitBox


asfgit closed pull request #738:
URL: https://github.com/apache/qpid-dispatch/pull/738


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection

2020-05-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110350#comment-17110350
 ] 

ASF GitHub Bot commented on DISPATCH-1614:
--

asfgit closed pull request #738:
URL: https://github.com/apache/qpid-dispatch/pull/738


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Edge router crash when interior closes edge uplink connection
> -
>
> Key: DISPATCH-1614
> URL: https://issues.apache.org/jira/browse/DISPATCH-1614
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.11.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.12.0
>
> Attachments: DISPATCH-1614-edge-router-log.txt
>
>
> When the connection to the interior router goes down then the 
> addr.edge_outlink link proper is freed but the pointer to the link is still 
> in the addr struct.
> Later when the addr is unbound the link is dereferenced causing a segfault.
> An attached log trace shows the events. Search for link _0x1c31210_ using 
> mobile address _M0e61_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection

2020-05-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110349#comment-17110349
 ] 

ASF subversion and git services commented on DISPATCH-1614:
---

Commit fdbe7c9ab68492c6902b60959f31371c42258aa8 in qpid-dispatch's branch 
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=fdbe7c9 ]

DISPATCH-1614 - Raised and handled QDRC_EVENT_LINK_IN_DETACHED and 
QDRC_EVENT_LINK_OUT_DETACHED events where the addr's edge_inlink and 
edge_outlink can be zeroed out. This closes #738.


> Edge router crash when interior closes edge uplink connection
> -
>
> Key: DISPATCH-1614
> URL: https://issues.apache.org/jira/browse/DISPATCH-1614
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.11.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.12.0
>
> Attachments: DISPATCH-1614-edge-router-log.txt
>
>
> When the connection to the interior router goes down then the 
> addr.edge_outlink link proper is freed but the pointer to the link is still 
> in the addr struct.
> Later when the addr is unbound the link is dereferenced causing a segfault.
> An attached log trace shows the events. Search for link _0x1c31210_ using 
> mobile address _M0e61_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection

2020-05-18 Thread Ganesh Murthy (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy resolved DISPATCH-1614.
-
Resolution: Fixed

> Edge router crash when interior closes edge uplink connection
> -
>
> Key: DISPATCH-1614
> URL: https://issues.apache.org/jira/browse/DISPATCH-1614
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.11.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.12.0
>
> Attachments: DISPATCH-1614-edge-router-log.txt
>
>
> When the connection to the interior router goes down then the 
> addr.edge_outlink link proper is freed but the pointer to the link is still 
> in the addr struct.
> Later when the addr is unbound the link is dereferenced causing a segfault.
> An attached log trace shows the events. Search for link _0x1c31210_ using 
> mobile address _M0e61_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection

2020-05-18 Thread Ganesh Murthy (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy closed DISPATCH-1614.
---

> Edge router crash when interior closes edge uplink connection
> -
>
> Key: DISPATCH-1614
> URL: https://issues.apache.org/jira/browse/DISPATCH-1614
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.11.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.12.0
>
> Attachments: DISPATCH-1614-edge-router-log.txt
>
>
> When the connection to the interior router goes down then the 
> addr.edge_outlink link proper is freed but the pointer to the link is still 
> in the addr struct.
> Later when the addr is unbound the link is dereferenced causing a segfault.
> An attached log trace shows the events. Search for link _0x1c31210_ using 
> mobile address _M0e61_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-proton] jiridanek merged pull request #141: PROTON-2215: Windows build fails if CMAKE_MODULE_PATH is not empty

2020-05-18 Thread GitBox


jiridanek merged pull request #141:
URL: https://github.com/apache/qpid-proton/pull/141


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2215) Windows build fails if CMAKE_MODULE_PATH is not empty

2020-05-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110366#comment-17110366
 ] 

ASF subversion and git services commented on PROTON-2215:
-

Commit 7f86fa4eb261fad7ade33f62acf3d2ce115e9497 in qpid-proton's branch 
refs/heads/master from Matthieu
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=7f86fa4 ]

PROTON-2215: Windows build fails if CMAKE_MODULE_PATH is not empty (#141)

The previously used CMAKE_MODULE_PATH is actually a list of directories,
and therefore should not be used here.

Co-authored-by: Matthieu Longo 
Co-authored-by: Jiri Danek 

> Windows build fails if CMAKE_MODULE_PATH is not empty
> -
>
> Key: PROTON-2215
> URL: https://issues.apache.org/jira/browse/PROTON-2215
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>  Labels: windows
> Fix For: proton-c-0.32.0
>
>
> In {{tools/cmake/Modules/WindowsC99CheckDef.cmake}}:
> {code}
> COMMAND ${PYTHON_EXECUTABLE}
>   ${CMAKE_MODULE_PATH}/WindowsC99SymbolCheck.py 
> $
> {code}
> This is wrong, if only because {{CMAKE_MODULE_PATH}} is a list of 
> directories, not a single directory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-2215) Windows build fails if CMAKE_MODULE_PATH is not empty

2020-05-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/PROTON-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110365#comment-17110365
 ] 

ASF GitHub Bot commented on PROTON-2215:


jiridanek merged pull request #141:
URL: https://github.com/apache/qpid-proton/pull/141


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Windows build fails if CMAKE_MODULE_PATH is not empty
> -
>
> Key: PROTON-2215
> URL: https://issues.apache.org/jira/browse/PROTON-2215
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>  Labels: windows
> Fix For: proton-c-0.32.0
>
>
> In {{tools/cmake/Modules/WindowsC99CheckDef.cmake}}:
> {code}
> COMMAND ${PYTHON_EXECUTABLE}
>   ${CMAKE_MODULE_PATH}/WindowsC99SymbolCheck.py 
> $
> {code}
> This is wrong, if only because {{CMAKE_MODULE_PATH}} is a list of 
> directories, not a single directory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] kgiusti opened a new pull request #739: NO-JIRA: fix spurious timeout in StreamingMessageTest.test_03_streami…

2020-05-18 Thread GitBox


kgiusti opened a new pull request #739:
URL: https://github.com/apache/qpid-dispatch/pull/739


   …ng_multicast



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-2215) Windows build fails if CMAKE_MODULE_PATH is not empty

2020-05-18 Thread Jira


 [ 
https://issues.apache.org/jira/browse/PROTON-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk resolved PROTON-2215.

Resolution: Fixed

> Windows build fails if CMAKE_MODULE_PATH is not empty
> -
>
> Key: PROTON-2215
> URL: https://issues.apache.org/jira/browse/PROTON-2215
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>  Labels: windows
> Fix For: proton-c-0.32.0
>
>
> In {{tools/cmake/Modules/WindowsC99CheckDef.cmake}}:
> {code}
> COMMAND ${PYTHON_EXECUTABLE}
>   ${CMAKE_MODULE_PATH}/WindowsC99SymbolCheck.py 
> $
> {code}
> This is wrong, if only because {{CMAKE_MODULE_PATH}} is a list of 
> directories, not a single directory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] asfgit closed pull request #735: bug in doc, missing "--"

2020-05-18 Thread GitBox


asfgit closed pull request #735:
URL: https://github.com/apache/qpid-dispatch/pull/735


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1629) Doc how to enable trace logging for a connection

2020-05-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110432#comment-17110432
 ] 

ASF subversion and git services commented on DISPATCH-1629:
---

Commit c09330a1b188af5f741d8077a40c409982eb00a6 in qpid-dispatch's branch 
refs/heads/master from Nicolas Brignone
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c09330a ]

DISPATCH-1629 - Added the missing "--" in qdmanage command. This closes #735.


> Doc how to enable trace logging for a connection
> 
>
> Key: DISPATCH-1629
> URL: https://issues.apache.org/jira/browse/DISPATCH-1629
> Project: Qpid Dispatch
>  Issue Type: Task
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
> Fix For: 1.13.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1658) Receiver unable to receive messages on waypointed addresses

2020-05-18 Thread Ganesh Murthy (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110481#comment-17110481
 ] 

Ganesh Murthy commented on DISPATCH-1658:
-

I acccidentally commited the fix to this issue with the Jira number as 
DISPATCH-1614

This commit should fix the issue - 
https://github.com/apache/qpid-dispatch/commit/fdbe7c9ab68492c6902b60959f31371c42258aa8

> Receiver unable to receive messages on waypointed addresses
> ---
>
> Key: DISPATCH-1658
> URL: https://issues.apache.org/jira/browse/DISPATCH-1658
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.12.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: EA1.conf, EA2.conf, EB1.conf, EB2.conf, INT.A.conf, 
> INT.B.conf
>
>
> To reproduce
>  
>  # Start a broker on port amqp
>  # Use the attached configs and start the routers
>  # Send 200 messages on the waypointed address "examples" by connecting to 
> the EA2 router like this python simple_send.py --address 
> 0.0.0.0:28100/examples -m200. Make sure the messages reached the broker queue.
>  # Now receive one message from the same EA2 router  - python simple_recv.py 
> --address 0.0.0.0:28100/examples -m1 - this will work
>  # Repeat step 4 more time. This receive will not work



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1658) Receiver unable to receive messages on waypointed addresses

2020-05-18 Thread Ganesh Murthy (Jira)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy resolved DISPATCH-1658.
-
Fix Version/s: 1.13.0
   Resolution: Fixed

> Receiver unable to receive messages on waypointed addresses
> ---
>
> Key: DISPATCH-1658
> URL: https://issues.apache.org/jira/browse/DISPATCH-1658
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.12.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.13.0
>
> Attachments: EA1.conf, EA2.conf, EB1.conf, EB2.conf, INT.A.conf, 
> INT.B.conf
>
>
> To reproduce
>  
>  # Start a broker on port amqp
>  # Use the attached configs and start the routers
>  # Send 200 messages on the waypointed address "examples" by connecting to 
> the EA2 router like this python simple_send.py --address 
> 0.0.0.0:28100/examples -m200. Make sure the messages reached the broker queue.
>  # Now receive one message from the same EA2 router  - python simple_recv.py 
> --address 0.0.0.0:28100/examples -m1 - this will work
>  # Repeat step 4 more time. This receive will not work



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #740: DISPATCH-1646 - Enabled deletion of http listener

2020-05-18 Thread GitBox


ganeshmurthy opened a new pull request #740:
URL: https://github.com/apache/qpid-dispatch/pull/740


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1646) Unable to delete listener with http enabled

2020-05-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110612#comment-17110612
 ] 

ASF GitHub Bot commented on DISPATCH-1646:
--

ganeshmurthy opened a new pull request #740:
URL: https://github.com/apache/qpid-dispatch/pull/740


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to delete listener with http enabled
> ---
>
> Key: DISPATCH-1646
> URL: https://issues.apache.org/jira/browse/DISPATCH-1646
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Ulf Lilleengen
>Assignee: Ganesh Murthy
>Priority: Major
>
> I'm running into an issue when trying to delete a listener which has 'http: 
> true' set. The router returns the error message "HTTP listeners cannot be 
> deleted". I can see that there is a test for this in the router code as well.
> However, in order for EnMasse to be able to create and delete listeners that 
> are used to handle websocket connections for different tenants, we need a way 
> to delete listeners with http: true set through AMQP management without 
> restarting the router.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1646) Unable to delete listener with http enabled

2020-05-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110639#comment-17110639
 ] 

ASF GitHub Bot commented on DISPATCH-1646:
--

ganeshmurthy commented on pull request #740:
URL: https://github.com/apache/qpid-dispatch/pull/740#issuecomment-630448726


   DO NOT MERGE.  I am still working on this



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to delete listener with http enabled
> ---
>
> Key: DISPATCH-1646
> URL: https://issues.apache.org/jira/browse/DISPATCH-1646
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Ulf Lilleengen
>Assignee: Ganesh Murthy
>Priority: Major
>
> I'm running into an issue when trying to delete a listener which has 'http: 
> true' set. The router returns the error message "HTTP listeners cannot be 
> deleted". I can see that there is a test for this in the router code as well.
> However, in order for EnMasse to be able to create and delete listeners that 
> are used to handle websocket connections for different tenants, we need a way 
> to delete listeners with http: true set through AMQP management without 
> restarting the router.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #740: DISPATCH-1646 - Enabled deletion of http listener

2020-05-18 Thread GitBox


ganeshmurthy commented on pull request #740:
URL: https://github.com/apache/qpid-dispatch/pull/740#issuecomment-630448726


   DO NOT MERGE.  I am still working on this



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] [qpid-dispatch] asfgit closed pull request #739: NO-JIRA: fix spurious timeout in StreamingMessageTest.test_03_streami…

2020-05-18 Thread GitBox


asfgit closed pull request #739:
URL: https://github.com/apache/qpid-dispatch/pull/739


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org