[GitHub] [qpid-broker-j] asfgit closed pull request #50: QPID-8455: [Broker-J] Change broker version to 9.0.0-SNAPSHOT
asfgit closed pull request #50: URL: https://github.com/apache/qpid-broker-j/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8456) [Broker-J] Configurable shutdown timeout
[ https://issues.apache.org/jira/browse/QPID-8456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161904#comment-17161904 ] ASF GitHub Bot commented on QPID-8456: -- asfgit closed pull request #49: URL: https://github.com/apache/qpid-broker-j/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J] Configurable shutdown timeout > > > Key: QPID-8456 > URL: https://issues.apache.org/jira/browse/QPID-8456 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Tomas Vavricka >Priority: Minor > > Shutdown timeout could be configurable. If broker fails to stop in 30 > seconds, then immediate exit could lead to corrupted store. > {noformat} > 2020-04-06 13:54:24,548 WARN [QpidBrokerShutdownHook] > (o.a.q.s.m.AbstractSystemConfig) - Attempting to cleanly shutdown took too > long, exiting immediately > java.util.concurrent.TimeoutException: Waited 3 milliseconds (plus 83875 > nanoseconds delay) for > com.google.common.util.concurrent.SettableFuture@347b074b[status=PENDING] > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:494) > at > com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:97) > at > org.apache.qpid.server.model.AbstractSystemConfig$ShutdownService$1.run(AbstractSystemConfig.java:616) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:360) > at > org.apache.qpid.server.model.AbstractSystemConfig$ShutdownService.run(AbstractSystemConfig.java:606) > at java.lang.Thread.run(Thread.java:745) > {noformat} > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] asfgit closed pull request #49: QPID-8456 [Broker-J] Configurable shutdown timeout
asfgit closed pull request #49: URL: https://github.com/apache/qpid-broker-j/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8457) [Broker-J] Change broker version on master to 9.0.0-SNAPSHOT and update the model
[ https://issues.apache.org/jira/browse/QPID-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161901#comment-17161901 ] ASF subversion and git services commented on QPID-8457: --- Commit 7fe4191f8f6fd35ea0137fdcda3f5e49d320facf in qpid-broker-j's branch refs/heads/master from Dedeepya Tunga [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=7fe4191 ] QPID-8457: [Broker-J] Change broker version to 9.0.0-SNAPSHOT This closes #50 > [Broker-J] Change broker version on master to 9.0.0-SNAPSHOT and update the > model > - > > Key: QPID-8457 > URL: https://issues.apache.org/jira/browse/QPID-8457 > Project: Qpid > Issue Type: New Feature > Components: Broker-J > Environment: We need to change the broker version and the model > version to 9.0 for upcoming work >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-9.0.0 > > > The broker version needs to be bumped to 9.0.0 for upcoming work in > QPID-8455, QPID-8456, QPID-8368, etc -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8455) [Broker-J]Use allow/deny list terminology for existing attributes and context variables
[ https://issues.apache.org/jira/browse/QPID-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161905#comment-17161905 ] ASF GitHub Bot commented on QPID-8455: -- asfgit closed pull request #50: URL: https://github.com/apache/qpid-broker-j/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J]Use allow/deny list terminology for existing attributes and context > variables > --- > > Key: QPID-8455 > URL: https://issues.apache.org/jira/browse/QPID-8455 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Dedeepya >Priority: Major > Fix For: qpid-java-broker-8.0.1, qpid-java-broker-7.1.9 > > Attachments: > 0001-QPID-8455-Broker-J-Use-allow-deny-list-terminology-f.patch > > > Rename attributes and context variables containing the term white/black list > to allow/deny list. > The names allow/deny list are more inlined with current industry naming > standards. > Example: > The port derived attributes tlsCipherSuiteWhiteList and > tlsCipherSuiteBlackList will have to be renamed to tlsCipherSuiteAllowList > and tlsCipherSuiteDenyList respectively. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8456) [Broker-J] Configurable shutdown timeout
[ https://issues.apache.org/jira/browse/QPID-8456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161902#comment-17161902 ] ASF subversion and git services commented on QPID-8456: --- Commit 6e395612a604fa747cfe9353ab5c86e3b752a9fb in qpid-broker-j's branch refs/heads/master from Tomas Vavricka [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=6e39561 ] QPID-8456: [Broker-J] Configurable shutdown timeout This closes #49 > [Broker-J] Configurable shutdown timeout > > > Key: QPID-8456 > URL: https://issues.apache.org/jira/browse/QPID-8456 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Tomas Vavricka >Priority: Minor > > Shutdown timeout could be configurable. If broker fails to stop in 30 > seconds, then immediate exit could lead to corrupted store. > {noformat} > 2020-04-06 13:54:24,548 WARN [QpidBrokerShutdownHook] > (o.a.q.s.m.AbstractSystemConfig) - Attempting to cleanly shutdown took too > long, exiting immediately > java.util.concurrent.TimeoutException: Waited 3 milliseconds (plus 83875 > nanoseconds delay) for > com.google.common.util.concurrent.SettableFuture@347b074b[status=PENDING] > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:494) > at > com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:97) > at > org.apache.qpid.server.model.AbstractSystemConfig$ShutdownService$1.run(AbstractSystemConfig.java:616) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:360) > at > org.apache.qpid.server.model.AbstractSystemConfig$ShutdownService.run(AbstractSystemConfig.java:606) > at java.lang.Thread.run(Thread.java:745) > {noformat} > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8449) [Broker-J][WMC] Query browser widget fails to load query data
[ https://issues.apache.org/jira/browse/QPID-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161903#comment-17161903 ] ASF subversion and git services commented on QPID-8449: --- Commit 16bc623e22b5154d01054150dea44c48a5744960 in qpid-broker-j's branch refs/heads/master from Alex Rudyy [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=16bc623 ] QPID-8449: [Broker-J][WMC] Fix query store updater > [Broker-J][WMC] Query browser widget fails to load query data > - > > Key: QPID-8449 > URL: https://issues.apache.org/jira/browse/QPID-8449 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.0 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-8.0.1 > > > The query browser widget fails to load queries with the error like the one > below > {noformat} > dojo.js:8 ReferenceError: queryResults is not defined > at Object.fetch (StoreUpdater.js:72) > at Object.update (StoreUpdater.js:91) > at Object.update (PreferenceBrowserWidget.js:260) > at Object.startup (PreferenceBrowserWidget.js:193) > at QueryBrowserTab.onOpen (QueryBrowserTab.js:76) > at QueryBrowserTab.js:47 > at _2f9 (dojo.js:8) > at Array.then._306.then (dojo.js:8) > at QueryBrowserTab.open (QueryBrowserTab.js:45) > at Object.controller.showTab (controller.js:204) "ReferenceError: > queryResults is not defined > at Object.fetch > (http://localhost:8080/js/qpid/management/query/StoreUpdater.js:72:42) > at Object.update > (http://localhost:8080/js/qpid/management/query/StoreUpdater.js:91:37) > at Object.update > (http://localhost:8080/js/qpid/management/preference/PreferenceBrowserWidget.js:260:50) > at Object.startup > (http://localhost:8080/js/qpid/management/preference/PreferenceBrowserWidget.js:193:26) > at QueryBrowserTab.onOpen > (http://localhost:8080/js/qpid/management/QueryBrowserTab.js:76:37) > at http://localhost:8080/js/qpid/management/QueryBrowserTab.js:47:26 > at _2f9 (http://localhost:8080/dojo/dojo/dojo.js:8:69192) > at Array.then._306.then (http://localhost:8080/dojo/dojo/dojo.js:8:71086) > at QueryBrowserTab.open > (http://localhost:8080/js/qpid/management/QueryBrowserTab.js:45:18) > at Object.controller.showTab > (http://localhost:8080/js/qpid/management/controller.js:204:31) > > rejected at _2ff (http://localhost:8080/dojo/dojo/dojo.js:8:69833) > at _2f9 (http://localhost:8080/dojo/dojo/dojo.js:8:69444) > at Array.then._306.then (http://localhost:8080/dojo/dojo/dojo.js:8:71086) > at QueryBrowserTab.open > (http://localhost:8080/js/qpid/management/QueryBrowserTab.js:45:18) > at Object.controller.showTab > (http://localhost:8080/js/qpid/management/controller.js:204:31) > at Object.showQueryBrowser > (http://localhost:8080/js/qpid/common/ConsoleHelper.js:126:29) > at Object.onClick (eval at _11 > (http://localhost:8080/dojo/dojo/parser.js:11:8), :1:45) > at Object.onItemClick > (http://localhost:8080/dojo/dijit/_MenuBase.js:124:36) > at HTMLTableRowElement. > (http://localhost:8080/dojo/dijit/_MenuBase.js:28:5) > at HTMLTableSectionElement. > (http://localhost:8080/dojo/dojo/dojo.js:8:81031) > > Error > at Array.then._306.then (http://localhost:8080/dojo/dojo/dojo.js:8:71005) > at QueryBrowserTab.open > (http://localhost:8080/js/qpid/management/QueryBrowserTab.js:45:18) > at Object.controller.showTab > (http://localhost:8080/js/qpid/management/controller.js:204:31) > at Object.showQueryBrowser > (http://localhost:8080/js/qpid/common/ConsoleHelper.js:126:29) > at Object.onClick (eval at _11 > (http://localhost:8080/dojo/dojo/parser.js:11:8), :1:45) > at Object.onItemClick > (http://localhost:8080/dojo/dijit/_MenuBase.js:124:36) > at HTMLTableRowElement. > (http://localhost:8080/dojo/dijit/_MenuBase.js:28:5) > at HTMLTableSectionElement. > (http://localhost:8080/dojo/dojo/dojo.js:8:81031)" > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #771: Add a short note about the multi-tenancy flag
jiridanek commented on a change in pull request #771: URL: https://github.com/apache/qpid-dispatch/pull/771#discussion_r457983274 ## File path: docs/books/modules/user-guide/listening-client-connections.adoc ## @@ -59,6 +60,7 @@ listener { + For more information, see xref:understanding-connection-failover-{context}[]. -- +`multiTenant` (optional):: If true, apply multi-tenancy to endpoints connected at this listener. The address space is defined by the virtual host (hostname field in the Open). Review comment: You're completely right. If this is merged, it would be the third copy of this same paragraph in dispatch ;) It's not undocumented feature, even now. You can see it in the config file docs at https://qpid.apache.org/releases/qpid-dispatch-1.12.0/man/qdrouterd.conf.html#_listener that are autogenerated from the schema. Afaik it is not a good idea to have the `listener` configuration example show every conceivable configuration option, just because it was a cool and new configuration option at some point in time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #771: Add a short note about the multi-tenancy flag
jiridanek commented on pull request #771: URL: https://github.com/apache/qpid-dispatch/pull/771#issuecomment-661768308 > "The address space is defined by the virtual host (hostname field in the Open)."... is that Enmasse specific? The hostname field in Open performative is regular AMQP, http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open. The idea of a virtual host is afaik a dispatch concept. I am unsure about address space. That sounds to me as an Enmasse specific concept, which seems to be slowly leaking into dispatch https://github.com/apache/qpid-dispatch/search?q=%22address+space%22&unscoped_q=%22address+space%22. Tbh, I am not personally clear what address space actually is. I am guessing that it is a namespace for addresses, scoped to tenants. Two endpoints, each in different tenant, can listen on the same address, but messages sent to that address don't intermix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek edited a comment on pull request #771: Add a short note about the multi-tenancy flag
jiridanek edited a comment on pull request #771: URL: https://github.com/apache/qpid-dispatch/pull/771#issuecomment-661768308 > "The address space is defined by the virtual host (hostname field in the Open)."... is that Enmasse specific? The hostname field in Open performative is regular AMQP, http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open. The idea of a virtual host is afaik a dispatch concept. I am unsure about address space. That sounds to me as an Enmasse specific concept, which seems to be slowly leaking into dispatch https://github.com/apache/qpid-dispatch/search?q=%22address+space%22&unscoped_q=%22address+space%22. Tbh, I am not personally clear what address space actually is. I am guessing that it is a namespace for addresses, scoped to tenants (=virtual hosts). Two endpoints, each in different tenant, can listen on the same address, but messages sent to that address don't intermix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1719) Add note about vhost
[ https://issues.apache.org/jira/browse/DISPATCH-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Wright reassigned DISPATCH-1719: - Assignee: Paul Wright > Add note about vhost > > > Key: DISPATCH-1719 > URL: https://issues.apache.org/jira/browse/DISPATCH-1719 > Project: Qpid Dispatch > Issue Type: Task > Components: Documentation >Reporter: Paul Wright >Assignee: Paul Wright >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1719) Add note about vhost
Paul Wright created DISPATCH-1719: - Summary: Add note about vhost Key: DISPATCH-1719 URL: https://issues.apache.org/jira/browse/DISPATCH-1719 Project: Qpid Dispatch Issue Type: Task Components: Documentation Reporter: Paul Wright -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1719) Add note about vhost
[ https://issues.apache.org/jira/browse/DISPATCH-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161974#comment-17161974 ] Paul Wright commented on DISPATCH-1719: --- following from discussion at [https://issues.redhat.com/browse/ENTMQIC-2175] need to tell user that vhost entries are empty unless you've enabled multitenancy > Add note about vhost > > > Key: DISPATCH-1719 > URL: https://issues.apache.org/jira/browse/DISPATCH-1719 > Project: Qpid Dispatch > Issue Type: Task > Components: Documentation >Reporter: Paul Wright >Assignee: Paul Wright >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1719) Add note about vhost
[ https://issues.apache.org/jira/browse/DISPATCH-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Wright updated DISPATCH-1719: -- Description: PR at [https://github.com/apache/qpid-dispatch/pull/764/files] > Add note about vhost > > > Key: DISPATCH-1719 > URL: https://issues.apache.org/jira/browse/DISPATCH-1719 > Project: Qpid Dispatch > Issue Type: Task > Components: Documentation >Reporter: Paul Wright >Assignee: Paul Wright >Priority: Major > > PR at [https://github.com/apache/qpid-dispatch/pull/764/files] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] pwright commented on pull request #764: DISPATCH-1719 logging and vhost note
pwright commented on pull request #764: URL: https://github.com/apache/qpid-dispatch/pull/764#issuecomment-661815357 @fgiorgetti could you approve this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1719) Add note about vhost
[ https://issues.apache.org/jira/browse/DISPATCH-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161980#comment-17161980 ] ASF GitHub Bot commented on DISPATCH-1719: -- pwright commented on pull request #764: URL: https://github.com/apache/qpid-dispatch/pull/764#issuecomment-661815357 @fgiorgetti could you approve this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add note about vhost > > > Key: DISPATCH-1719 > URL: https://issues.apache.org/jira/browse/DISPATCH-1719 > Project: Qpid Dispatch > Issue Type: Task > Components: Documentation >Reporter: Paul Wright >Assignee: Paul Wright >Priority: Major > > PR at [https://github.com/apache/qpid-dispatch/pull/764/files] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1494) Qdstat heading for a memory display is Types
[ https://issues.apache.org/jira/browse/DISPATCH-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162039#comment-17162039 ] ASF subversion and git services commented on DISPATCH-1494: --- Commit 1eb47314c9d7c529f5983ed678ab035067761086 in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=1eb4731 ] DISPATCH-1494: Rename qdstat memory usage section titles Give sections descriptive names that help users identify the memory sections, especially when viewed by --all-entities. > Qdstat heading for a memory display is Types > > > Key: DISPATCH-1494 > URL: https://issues.apache.org/jira/browse/DISPATCH-1494 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.9.0 >Reporter: Charles E. Rolke >Priority: Major > > Commands _qdstat -m_ or _qdstat --memory_ produce a table titled _Types_. > The table could use a better title like _Router Memory_. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1494) Qdstat heading for a memory display is Types
[ https://issues.apache.org/jira/browse/DISPATCH-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke resolved DISPATCH-1494. Fix Version/s: 1.13.0 Resolution: Fixed Fixed at commit 1eb4731 Changed two headers ||Old || New || | Types | Memory Pools | | Summary | Memory Summary | > Qdstat heading for a memory display is Types > > > Key: DISPATCH-1494 > URL: https://issues.apache.org/jira/browse/DISPATCH-1494 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.9.0 >Reporter: Charles E. Rolke >Priority: Major > Fix For: 1.13.0 > > > Commands _qdstat -m_ or _qdstat --memory_ produce a table titled _Types_. > The table could use a better title like _Router Memory_. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #777: DISPATCH-1716 Don't set -Wl,-z,defs in -fsanitize= builds with Clang
jiridanek commented on pull request #777: URL: https://github.com/apache/qpid-dispatch/pull/777#issuecomment-661903034 I don't have any significantly better ideas how to parameterize the `-Wl,-z,defs` option, so I'll leave it at this. I'm going to merge the PR eod today, unless somebody complains. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek edited a comment on pull request #777: DISPATCH-1716 Don't set -Wl,-z,defs in -fsanitize= builds with Clang
jiridanek edited a comment on pull request #777: URL: https://github.com/apache/qpid-dispatch/pull/777#issuecomment-661903034 I don't have any significantly better ideas how to parameterize the `-Wl,-z,defs` option, so I'll leave it at this. I'm going to squash and merge the PR at the eod today, unless somebody complains. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1716) [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible
[ https://issues.apache.org/jira/browse/DISPATCH-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162078#comment-17162078 ] ASF GitHub Bot commented on DISPATCH-1716: -- jiridanek edited a comment on pull request #777: URL: https://github.com/apache/qpid-dispatch/pull/777#issuecomment-661903034 I don't have any significantly better ideas how to parameterize the `-Wl,-z,defs` option, so I'll leave it at this. I'm going to squash and merge the PR at the eod today, unless somebody complains. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible > > > Key: DISPATCH-1716 > URL: https://issues.apache.org/jira/browse/DISPATCH-1716 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > https://travis-ci.com/github/jiridanek/qpid-dispatch/jobs/362505100 > As discussed at https://github.com/google/sanitizers/issues/380, the option > -Wl,-z,defs is incompatible with sanitizers. This only manifested for me with > clang. I did not have this problem with gcc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1716) [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible
[ https://issues.apache.org/jira/browse/DISPATCH-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162077#comment-17162077 ] ASF GitHub Bot commented on DISPATCH-1716: -- jiridanek commented on pull request #777: URL: https://github.com/apache/qpid-dispatch/pull/777#issuecomment-661903034 I don't have any significantly better ideas how to parameterize the `-Wl,-z,defs` option, so I'll leave it at this. I'm going to merge the PR eod today, unless somebody complains. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible > > > Key: DISPATCH-1716 > URL: https://issues.apache.org/jira/browse/DISPATCH-1716 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > https://travis-ci.com/github/jiridanek/qpid-dispatch/jobs/362505100 > As discussed at https://github.com/google/sanitizers/issues/380, the option > -Wl,-z,defs is incompatible with sanitizers. This only manifested for me with > clang. I did not have this problem with gcc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8456) [Broker-J] Configurable shutdown timeout
[ https://issues.apache.org/jira/browse/QPID-8456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8456: - Fix Version/s: qpid-java-broker-9.0.0 > [Broker-J] Configurable shutdown timeout > > > Key: QPID-8456 > URL: https://issues.apache.org/jira/browse/QPID-8456 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Tomas Vavricka >Priority: Minor > Fix For: qpid-java-broker-9.0.0 > > > Shutdown timeout could be configurable. If broker fails to stop in 30 > seconds, then immediate exit could lead to corrupted store. > {noformat} > 2020-04-06 13:54:24,548 WARN [QpidBrokerShutdownHook] > (o.a.q.s.m.AbstractSystemConfig) - Attempting to cleanly shutdown took too > long, exiting immediately > java.util.concurrent.TimeoutException: Waited 3 milliseconds (plus 83875 > nanoseconds delay) for > com.google.common.util.concurrent.SettableFuture@347b074b[status=PENDING] > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:494) > at > com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:97) > at > org.apache.qpid.server.model.AbstractSystemConfig$ShutdownService$1.run(AbstractSystemConfig.java:616) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:360) > at > org.apache.qpid.server.model.AbstractSystemConfig$ShutdownService.run(AbstractSystemConfig.java:606) > at java.lang.Thread.run(Thread.java:745) > {noformat} > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8457) [Broker-J] Change broker version on master to 9.0.0-SNAPSHOT and update the model
[ https://issues.apache.org/jira/browse/QPID-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-8457. -- Resolution: Fixed > [Broker-J] Change broker version on master to 9.0.0-SNAPSHOT and update the > model > - > > Key: QPID-8457 > URL: https://issues.apache.org/jira/browse/QPID-8457 > Project: Qpid > Issue Type: New Feature > Components: Broker-J > Environment: We need to change the broker version and the model > version to 9.0 for upcoming work >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-9.0.0 > > > The broker version needs to be bumped to 9.0.0 for upcoming work in > QPID-8455, QPID-8456, QPID-8368, etc -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8456) [Broker-J] Configurable shutdown timeout
[ https://issues.apache.org/jira/browse/QPID-8456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-8456. -- Resolution: Fixed > [Broker-J] Configurable shutdown timeout > > > Key: QPID-8456 > URL: https://issues.apache.org/jira/browse/QPID-8456 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Tomas Vavricka >Priority: Minor > Fix For: qpid-java-broker-9.0.0 > > > Shutdown timeout could be configurable. If broker fails to stop in 30 > seconds, then immediate exit could lead to corrupted store. > {noformat} > 2020-04-06 13:54:24,548 WARN [QpidBrokerShutdownHook] > (o.a.q.s.m.AbstractSystemConfig) - Attempting to cleanly shutdown took too > long, exiting immediately > java.util.concurrent.TimeoutException: Waited 3 milliseconds (plus 83875 > nanoseconds delay) for > com.google.common.util.concurrent.SettableFuture@347b074b[status=PENDING] > at > com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:494) > at > com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:97) > at > org.apache.qpid.server.model.AbstractSystemConfig$ShutdownService$1.run(AbstractSystemConfig.java:616) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:360) > at > org.apache.qpid.server.model.AbstractSystemConfig$ShutdownService.run(AbstractSystemConfig.java:606) > at java.lang.Thread.run(Thread.java:745) > {noformat} > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #684: DISPATCH-1568: using doctest
jiridanek commented on pull request #684: URL: https://github.com/apache/qpid-dispatch/pull/684#issuecomment-661926892 @nicob87 awesome, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) add c-unittest support
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162109#comment-17162109 ] ASF GitHub Bot commented on DISPATCH-1568: -- jiridanek commented on pull request #684: URL: https://github.com/apache/qpid-dispatch/pull/684#issuecomment-661926892 @nicob87 awesome, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add c-unittest support > -- > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Reporter: Nicolas >Priority: Major > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Clients > using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2236) report more meaningful unexpected-type errors during decode
[ https://issues.apache.org/jira/browse/PROTON-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-2236: --- Summary: report more meaningful unexpected-type errors during decode (was: [proton-j] Error message when decoding illegal message properties key is unhelpful) > report more meaningful unexpected-type errors during decode > --- > > Key: PROTON-2236 > URL: https://issues.apache.org/jira/browse/PROTON-2236 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Reporter: Kim van der Riet >Priority: Trivial > Fix For: proton-j-0.33.6 > > > While decoding a message containing a non-string application-properties key > (eg a symbol key), then the following message is seen: > {{Error on transform: Expected String type but found encoding: -93}} > which is not very intuitive. Perhaps converting the type to hex and providing > a stringified version would be better, such as: > {{Expected String type but found encoding 0xb3 (symbol)}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1716) [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible
[ https://issues.apache.org/jira/browse/DISPATCH-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162193#comment-17162193 ] ASF GitHub Bot commented on DISPATCH-1716: -- jiridanek merged pull request #777: URL: https://github.com/apache/qpid-dispatch/pull/777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible > > > Key: DISPATCH-1716 > URL: https://issues.apache.org/jira/browse/DISPATCH-1716 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > https://travis-ci.com/github/jiridanek/qpid-dispatch/jobs/362505100 > As discussed at https://github.com/google/sanitizers/issues/380, the option > -Wl,-z,defs is incompatible with sanitizers. This only manifested for me with > clang. I did not have this problem with gcc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #777: DISPATCH-1716 Don't set -Wl,-z,defs in -fsanitize= builds with Clang
jiridanek merged pull request #777: URL: https://github.com/apache/qpid-dispatch/pull/777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1716) [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible
[ https://issues.apache.org/jira/browse/DISPATCH-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162194#comment-17162194 ] ASF subversion and git services commented on DISPATCH-1716: --- Commit 1fb8b07482bd8a67a3bff69ccc775e2c82cb4f96 in qpid-dispatch's branch refs/heads/master from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=1fb8b07 ] DISPATCH-1716 Don't set -Wl,-z,defs in -fsanitize= builds with Clang (#777) > [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible > > > Key: DISPATCH-1716 > URL: https://issues.apache.org/jira/browse/DISPATCH-1716 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > https://travis-ci.com/github/jiridanek/qpid-dispatch/jobs/362505100 > As discussed at https://github.com/google/sanitizers/issues/380, the option > -Wl,-z,defs is incompatible with sanitizers. This only manifested for me with > clang. I did not have this problem with gcc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1716) [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible
[ https://issues.apache.org/jira/browse/DISPATCH-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1716: - Status: Reviewable (was: In Progress) > [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible > > > Key: DISPATCH-1716 > URL: https://issues.apache.org/jira/browse/DISPATCH-1716 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > https://travis-ci.com/github/jiridanek/qpid-dispatch/jobs/362505100 > As discussed at https://github.com/google/sanitizers/issues/380, the option > -Wl,-z,defs is incompatible with sanitizers. This only manifested for me with > clang. I did not have this problem with gcc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1716) [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible
[ https://issues.apache.org/jira/browse/DISPATCH-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk resolved DISPATCH-1716. -- Fix Version/s: 1.13.0 Resolution: Fixed > [clang] -fsanitize=address and -Wl,-z,defs compiler options are incompatible > > > Key: DISPATCH-1716 > URL: https://issues.apache.org/jira/browse/DISPATCH-1716 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.13.0 > > > https://travis-ci.com/github/jiridanek/qpid-dispatch/jobs/362505100 > As discussed at https://github.com/google/sanitizers/issues/380, the option > -Wl,-z,defs is incompatible with sanitizers. This only manifested for me with > clang. I did not have this problem with gcc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1720) Run javascript console tests in CI
Jiri Daněk created DISPATCH-1720: Summary: Run javascript console tests in CI Key: DISPATCH-1720 URL: https://issues.apache.org/jira/browse/DISPATCH-1720 Project: Qpid Dispatch Issue Type: Test Components: Tests Affects Versions: 1.12.0 Reporter: Jiri Daněk Console tests ({{npm run test}}) are not being run in CI currently. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #779: DISPATCH-1720 Add GitHub Action to run console tests through npm
jiridanek opened a new pull request #779: URL: https://github.com/apache/qpid-dispatch/pull/779 CC @gemmellr @kpvdr my first real GH Action (not counting the rat check) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1720) Run javascript console tests in CI
[ https://issues.apache.org/jira/browse/DISPATCH-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162276#comment-17162276 ] ASF GitHub Bot commented on DISPATCH-1720: -- jiridanek opened a new pull request #779: URL: https://github.com/apache/qpid-dispatch/pull/779 CC @gemmellr @kpvdr my first real GH Action (not counting the rat check) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run javascript console tests in CI > -- > > Key: DISPATCH-1720 > URL: https://issues.apache.org/jira/browse/DISPATCH-1720 > Project: Qpid Dispatch > Issue Type: Test > Components: Tests >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Priority: Major > > Console tests ({{npm run test}}) are not being run in CI currently. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1721) Qdstat table for policy vhostgroups is too wide
Charles E. Rolke created DISPATCH-1721: -- Summary: Qdstat table for policy vhostgroups is too wide Key: DISPATCH-1721 URL: https://issues.apache.org/jira/browse/DISPATCH-1721 Project: Qpid Dispatch Issue Type: Bug Components: Management Agent, Policy Engine Affects Versions: 1.12.0 Reporter: Charles E. Rolke Assignee: Charles E. Rolke Fix For: 1.13.0 A single wide table for usergroupsettings is "too wide". Break the table into pieces: * one table for all user groups showing int and boolean settings * separate tables of each vhost usergroup showing strings users, hosts, sources, and targets Fetch the attached router's schema. Display usergroupsettings defaults from that schema. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1494) Qdstat heading for a memory display is Types
[ https://issues.apache.org/jira/browse/DISPATCH-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162367#comment-17162367 ] ASF subversion and git services commented on DISPATCH-1494: --- Commit 8212d2c45c59a01695f26cda71d8a8a049ae3a6b in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8212d2c ] DISPATCH-1494: Change title of qdstat memory tables This commit should have been included with commit 1eb47314 > Qdstat heading for a memory display is Types > > > Key: DISPATCH-1494 > URL: https://issues.apache.org/jira/browse/DISPATCH-1494 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.9.0 >Reporter: Charles E. Rolke >Priority: Major > Fix For: 1.13.0 > > > Commands _qdstat -m_ or _qdstat --memory_ produce a table titled _Types_. > The table could use a better title like _Router Memory_. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2208) Change base C language/compiler requirements to C99 or equivalent
[ https://issues.apache.org/jira/browse/PROTON-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162403#comment-17162403 ] ASF subversion and git services commented on PROTON-2208: - Commit 911d5794f5af515b954cb3c08d025e4011507277 in qpid-proton's branch refs/heads/master from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=911d579 ] PROTON-2208: Fix static library build - Also fix long standing fuzz test failure with static build - Also allow link time optimization for Clang and MSVC > Change base C language/compiler requirements to C99 or equivalent > - > > Key: PROTON-2208 > URL: https://issues.apache.org/jira/browse/PROTON-2208 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.32.0 > > > The current language supposedly supported for clients by proton-c is C89. The > current language allowed for implementing proton-c is the common subset of > C89 and C++03. This was to support Visual Studio which at the time didn't > support enough C99. > This led to significant build complexity so we can build proton-c as C++ on > Visual Studio. > Since Visual Studio 2013/2015, Visual Studio has had sufficient C99 support > to compile proton. > It would allow us to significantly simplify the build process, library usage > and ongoing code maintenance requirements if we only supported VS2015 and > later (or if necessary VS2013 - VS2015 would be better as it has C library > compatibility changes). Stripping the complex build hacks and header file > hacks that support earlier Visual Studio compilers. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org