[jira] [Commented] (DISPATCH-1779) http stats/metrics
[ https://issues.apache.org/jira/browse/DISPATCH-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217959#comment-17217959 ] ASF GitHub Bot commented on DISPATCH-1779: -- grs commented on pull request #888: URL: https://github.com/apache/qpid-dispatch/pull/888#issuecomment-713158403 @kgiusti @ganeshmurthy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > http stats/metrics > -- > > Key: DISPATCH-1779 > URL: https://issues.apache.org/jira/browse/DISPATCH-1779 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] grs commented on pull request #888: DISPATCH-1779: initial http stats for http1 and http2 adaptors
grs commented on pull request #888: URL: https://github.com/apache/qpid-dispatch/pull/888#issuecomment-713158403 @kgiusti @ganeshmurthy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1779) http stats/metrics
[ https://issues.apache.org/jira/browse/DISPATCH-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217896#comment-17217896 ] ASF GitHub Bot commented on DISPATCH-1779: -- grs opened a new pull request #888: URL: https://github.com/apache/qpid-dispatch/pull/888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > http stats/metrics > -- > > Key: DISPATCH-1779 > URL: https://issues.apache.org/jira/browse/DISPATCH-1779 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] grs opened a new pull request #888: DISPATCH-1779: initial http stats for http1 and http2 adaptors
grs opened a new pull request #888: URL: https://github.com/apache/qpid-dispatch/pull/888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] grs closed pull request #858: DISPATCH-1779: initial http stats for http1 and http2 adaptors
grs closed pull request #858: URL: https://github.com/apache/qpid-dispatch/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1779) http stats/metrics
[ https://issues.apache.org/jira/browse/DISPATCH-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217895#comment-17217895 ] ASF GitHub Bot commented on DISPATCH-1779: -- grs closed pull request #858: URL: https://github.com/apache/qpid-dispatch/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > http stats/metrics > -- > > Key: DISPATCH-1779 > URL: https://issues.apache.org/jira/browse/DISPATCH-1779 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1496) C epoll proactor needs better timer implementation for connections
[
https://issues.apache.org/jira/browse/PROTON-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217870#comment-17217870
]
ASF GitHub Bot commented on PROTON-1496:
astitcher commented on a change in pull request #275:
URL: https://github.com/apache/qpid-proton/pull/275#discussion_r508676592
##
File path: c/include/proton/cid.h
##
@@ -68,7 +68,8 @@ typedef enum {
CID_pn_proactor,
CID_pn_listener_socket,
- CID_pn_raw_connection
+ CID_pn_raw_connection,
+ CID_pn_tick_timer
Review comment:
Is this actually needed? As in will the code compile without this enum
definition? It should only be needed for application visible types. For
example, if you need to put a pn_tick_timer into an event sent to the
application. But this is not happening here.
##
File path: c/src/proactor/epoll-internal.h
##
@@ -54,11 +54,13 @@ extern "C" {
typedef struct acceptor_t acceptor_t;
typedef struct tslot_t tslot_t;
typedef pthread_mutex_t pmutex;
+typedef struct pconnection_t pconnection_t;
+typedef struct pn_tick_timer_t pn_tick_timer_t;
typedef enum {
WAKE, /* see if any work to do in proactor/psocket context */
PCONNECTION_IO,
- PCONNECTION_TIMER,
+ CTIMERQ_TIMER,
Review comment:
Please don't use this obtuse name: Is it TICK_TIMER? TIMER_QUEUE?
CONNECTION_TIMER_QUEUE_TIMER??? That last seems to be the expansion of the
name, but isn't very comprehensible besides being redundant!
##
File path: c/src/proactor/epoll-internal.h
##
@@ -77,15 +79,14 @@ typedef struct ptimer_t {
pmutex mutex;
epoll_extended_t epoll_io;
bool timer_active;
- bool in_doubt; // 0 or 1 callbacks are possible
- bool shutting_down;
} ptimer_t;
typedef enum {
PROACTOR,
PCONNECTION,
LISTENER,
- RAW_CONNECTION
+ RAW_CONNECTION,
+ CONN_TIMERQ
Review comment:
As above, bad naming - I think here just TIMER would be good enough, if
this name is no good because it clashes then PTIMER.
##
File path: c/src/proactor/epoll-internal.h
##
@@ -360,6 +384,13 @@ pcontext_t *pni_raw_connection_context(praw_connection_t
*rc);
praw_connection_t *pni_batch_raw_connection(pn_event_batch_t* batch);
void pni_raw_connection_done(praw_connection_t *rc);
+bool ctimerq_init(pn_proactor_t *p);
+void ctimerq_finalize(pn_proactor_t *p);
+bool ctimerq_register(connection_timerq_t *ctq, pconnection_t *pc);
+void ctimerq_deregister(connection_timerq_t *ctq, pconnection_t *pc);
+void ctimerq_schedule_tick(connection_timerq_t *ctq, pconnection_t *pc,
uint64_t deadline, uint64_t now);
+pn_event_batch_t *ctimerq_process(connection_timerq_t *ctq, bool timeout);
+
Review comment:
These are misnamed all internal API has pni_ prefix
Also ctimerq_t is not the struct name so they are misnamed that that way
too.
If connection_timerq_t is too long in one context it is in all contexts! I
don't see the relevance of the connection_ bit. Why not just timer_queue_t? Why
is it specific to connections? Shouldn't it also handle the proactor timers too?
##
File path: c/src/proactor/epoll-internal.h
##
@@ -347,6 +366,11 @@ bool start_polling(epoll_extended_t *ee, int epollfd);
void stop_polling(epoll_extended_t *ee, int epollfd);
void rearm_polling(epoll_extended_t *ee, int epollfd);
+bool ptimer_init(ptimer_t *pt, epoll_type_t ep_type);
+void ptimer_finalize(ptimer_t *pt);
+void ptimer_set(ptimer_t *pt, uint64_t t_millis);
+bool ptimer_callback(ptimer_t *pt);
Review comment:
These are now misnamed all internal API has the pni_ prefix
And also seeing as they are now API external to epoll.c why not put them in
their own file?
##
File path: c/src/proactor/epoll-internal.h
##
@@ -217,16 +227,15 @@ typedef struct psocket_t {
uint32_t working_io_events;
} psocket_t;
-typedef struct pconnection_t {
+struct pconnection_t {
psocket_t psocket;
pcontext_t context;
- ptimer_t timer; // TODO: review one timerfd per connection
const char *host, *port;
+ pn_tick_timer_t *timer; // Idle timeout timer. Protected by and sole use
by ctimerq.
Review comment:
Comment incorrect: I assume this means really part of
context.proactor.ctimerq
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C epoll proactor needs better timer implementation for connections
> --
>
> Key: PROTON-1496
> URL: https://issues.apache.org/jira/browse/PROTON-1496
> Project: Qpid Proton
> Issue Type: Improvement
> Co
[GitHub] [qpid-proton] astitcher commented on a change in pull request #275: PROTON-1496: epoll proactor - single timer queue and timerfd for all …
astitcher commented on a change in pull request #275:
URL: https://github.com/apache/qpid-proton/pull/275#discussion_r508676592
##
File path: c/include/proton/cid.h
##
@@ -68,7 +68,8 @@ typedef enum {
CID_pn_proactor,
CID_pn_listener_socket,
- CID_pn_raw_connection
+ CID_pn_raw_connection,
+ CID_pn_tick_timer
Review comment:
Is this actually needed? As in will the code compile without this enum
definition? It should only be needed for application visible types. For
example, if you need to put a pn_tick_timer into an event sent to the
application. But this is not happening here.
##
File path: c/src/proactor/epoll-internal.h
##
@@ -54,11 +54,13 @@ extern "C" {
typedef struct acceptor_t acceptor_t;
typedef struct tslot_t tslot_t;
typedef pthread_mutex_t pmutex;
+typedef struct pconnection_t pconnection_t;
+typedef struct pn_tick_timer_t pn_tick_timer_t;
typedef enum {
WAKE, /* see if any work to do in proactor/psocket context */
PCONNECTION_IO,
- PCONNECTION_TIMER,
+ CTIMERQ_TIMER,
Review comment:
Please don't use this obtuse name: Is it TICK_TIMER? TIMER_QUEUE?
CONNECTION_TIMER_QUEUE_TIMER??? That last seems to be the expansion of the
name, but isn't very comprehensible besides being redundant!
##
File path: c/src/proactor/epoll-internal.h
##
@@ -77,15 +79,14 @@ typedef struct ptimer_t {
pmutex mutex;
epoll_extended_t epoll_io;
bool timer_active;
- bool in_doubt; // 0 or 1 callbacks are possible
- bool shutting_down;
} ptimer_t;
typedef enum {
PROACTOR,
PCONNECTION,
LISTENER,
- RAW_CONNECTION
+ RAW_CONNECTION,
+ CONN_TIMERQ
Review comment:
As above, bad naming - I think here just TIMER would be good enough, if
this name is no good because it clashes then PTIMER.
##
File path: c/src/proactor/epoll-internal.h
##
@@ -360,6 +384,13 @@ pcontext_t *pni_raw_connection_context(praw_connection_t
*rc);
praw_connection_t *pni_batch_raw_connection(pn_event_batch_t* batch);
void pni_raw_connection_done(praw_connection_t *rc);
+bool ctimerq_init(pn_proactor_t *p);
+void ctimerq_finalize(pn_proactor_t *p);
+bool ctimerq_register(connection_timerq_t *ctq, pconnection_t *pc);
+void ctimerq_deregister(connection_timerq_t *ctq, pconnection_t *pc);
+void ctimerq_schedule_tick(connection_timerq_t *ctq, pconnection_t *pc,
uint64_t deadline, uint64_t now);
+pn_event_batch_t *ctimerq_process(connection_timerq_t *ctq, bool timeout);
+
Review comment:
These are misnamed all internal API has pni_ prefix
Also ctimerq_t is not the struct name so they are misnamed that that way
too.
If connection_timerq_t is too long in one context it is in all contexts! I
don't see the relevance of the connection_ bit. Why not just timer_queue_t? Why
is it specific to connections? Shouldn't it also handle the proactor timers too?
##
File path: c/src/proactor/epoll-internal.h
##
@@ -347,6 +366,11 @@ bool start_polling(epoll_extended_t *ee, int epollfd);
void stop_polling(epoll_extended_t *ee, int epollfd);
void rearm_polling(epoll_extended_t *ee, int epollfd);
+bool ptimer_init(ptimer_t *pt, epoll_type_t ep_type);
+void ptimer_finalize(ptimer_t *pt);
+void ptimer_set(ptimer_t *pt, uint64_t t_millis);
+bool ptimer_callback(ptimer_t *pt);
Review comment:
These are now misnamed all internal API has the pni_ prefix
And also seeing as they are now API external to epoll.c why not put them in
their own file?
##
File path: c/src/proactor/epoll-internal.h
##
@@ -217,16 +227,15 @@ typedef struct psocket_t {
uint32_t working_io_events;
} psocket_t;
-typedef struct pconnection_t {
+struct pconnection_t {
psocket_t psocket;
pcontext_t context;
- ptimer_t timer; // TODO: review one timerfd per connection
const char *host, *port;
+ pn_tick_timer_t *timer; // Idle timeout timer. Protected by and sole use
by ctimerq.
Review comment:
Comment incorrect: I assume this means really part of
context.proactor.ctimerq
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1778) spurious buffer inserted in body data
[ https://issues.apache.org/jira/browse/DISPATCH-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217859#comment-17217859 ] ASF GitHub Bot commented on DISPATCH-1778: -- ChugR commented on pull request #860: URL: https://github.com/apache/qpid-dispatch/pull/860#issuecomment-713060349 Fixed at commit 4fe73d8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > spurious buffer inserted in body data > - > > Key: DISPATCH-1778 > URL: https://issues.apache.org/jira/browse/DISPATCH-1778 > Project: Qpid Dispatch > Issue Type: Sub-task >Reporter: Gordon Sim >Priority: Major > Attachments: DISPATCH-1778-01-analysis.txt, SINGLE_SERVER.conf > > > When running a simple telnet driven tcp-echo through the tcp adapater in the > router I often see a spurious buffer in the body data read on egress from the > message. This seems to consist of the data section header, binary code and > length. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1778) spurious buffer inserted in body data
[ https://issues.apache.org/jira/browse/DISPATCH-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217860#comment-17217860 ] ASF GitHub Bot commented on DISPATCH-1778: -- ChugR closed pull request #860: URL: https://github.com/apache/qpid-dispatch/pull/860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > spurious buffer inserted in body data > - > > Key: DISPATCH-1778 > URL: https://issues.apache.org/jira/browse/DISPATCH-1778 > Project: Qpid Dispatch > Issue Type: Sub-task >Reporter: Gordon Sim >Priority: Major > Attachments: DISPATCH-1778-01-analysis.txt, SINGLE_SERVER.conf > > > When running a simple telnet driven tcp-echo through the tcp adapater in the > router I often see a spurious buffer in the body data read on egress from the > message. This seems to consist of the data section header, binary code and > length. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR closed pull request #860: DISPATCH-1778: Extra data included in adaptor outbound streams
ChugR closed pull request #860: URL: https://github.com/apache/qpid-dispatch/pull/860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on pull request #860: DISPATCH-1778: Extra data included in adaptor outbound streams
ChugR commented on pull request #860: URL: https://github.com/apache/qpid-dispatch/pull/860#issuecomment-713060349 Fixed at commit 4fe73d8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1803) HTTP1.x adaptor stall when body data section > Q2 limit
[ https://issues.apache.org/jira/browse/DISPATCH-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217854#comment-17217854 ] ASF GitHub Bot commented on DISPATCH-1803: -- kgiusti closed pull request #879: URL: https://github.com/apache/qpid-dispatch/pull/879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > HTTP1.x adaptor stall when body data section > Q2 limit > --- > > Key: DISPATCH-1803 > URL: https://issues.apache.org/jira/browse/DISPATCH-1803 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > > Since the adaptors process body-data chunks by buffering the full body-data > before forwarding it to the endpoint, body data chunks of > Q2 limit will > cause the message forwarding to hang as Q2 limit will be hit yet the buffers > will not be drained since the adaptor is waiting for the entire body data to > arrive before the adaptor can write out the buffers. > My apologies to Mrs. Smith, my fourth grade English teacher, for the above > run-on sentence. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1803) HTTP1.x adaptor stall when body data section > Q2 limit
[ https://issues.apache.org/jira/browse/DISPATCH-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217855#comment-17217855 ] ASF GitHub Bot commented on DISPATCH-1803: -- kgiusti commented on pull request #879: URL: https://github.com/apache/qpid-dispatch/pull/879#issuecomment-713054604 Merged to dev-protocol-adaptors-2 branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > HTTP1.x adaptor stall when body data section > Q2 limit > --- > > Key: DISPATCH-1803 > URL: https://issues.apache.org/jira/browse/DISPATCH-1803 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > > Since the adaptors process body-data chunks by buffering the full body-data > before forwarding it to the endpoint, body data chunks of > Q2 limit will > cause the message forwarding to hang as Q2 limit will be hit yet the buffers > will not be drained since the adaptor is waiting for the entire body data to > arrive before the adaptor can write out the buffers. > My apologies to Mrs. Smith, my fourth grade English teacher, for the above > run-on sentence. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #879: DISPATCH-1803: prevent body_data sections from violating Q2 limit
kgiusti closed pull request #879: URL: https://github.com/apache/qpid-dispatch/pull/879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-713054654 Its working, its working... more or less. The test to add autoLink through management message really adds an autoLink, and can do it without any network communication! And I cannot reduce scope of the test any further, because then I'd hit static functions and types that are defined in .c files, so I cannot see inside. More work needed, but it starts to look hopeful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #879: DISPATCH-1803: prevent body_data sections from violating Q2 limit
kgiusti commented on pull request #879: URL: https://github.com/apache/qpid-dispatch/pull/879#issuecomment-713054604 Merged to dev-protocol-adaptors-2 branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1751) unexpected incoming-window in begin frame when running Dispatch on 32 bit system
[ https://issues.apache.org/jira/browse/DISPATCH-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke resolved DISPATCH-1751. Fix Version/s: 1.15.0 Resolution: Fixed Fixed at Commit 7525ac6 > unexpected incoming-window in begin frame when running Dispatch on 32 bit > system > > > Key: DISPATCH-1751 > URL: https://issues.apache.org/jira/browse/DISPATCH-1751 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.13.0 >Reporter: Ganesh Murthy >Priority: Major > Fix For: 1.15.0 > > > On 32bit systems, an unexpected incoming-window value is set. This for > example causes system_tests_protocol_settings failures on 32bit systems, with > test expecting to see the incoming-window be 2147483647 but instead finding > it much less, e.g 131071. > This is due to the way the session capacity is configured, particularly on > 32bit systems. See more details (output, code, etc) from prior discussions on > PROTON-2255 (raised when this was incorrectly thought to be a proton issue). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1751) unexpected incoming-window in begin frame when running Dispatch on 32 bit system
[ https://issues.apache.org/jira/browse/DISPATCH-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217842#comment-17217842 ] ASF GitHub Bot commented on DISPATCH-1751: -- asfgit closed pull request #847: URL: https://github.com/apache/qpid-dispatch/pull/847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > unexpected incoming-window in begin frame when running Dispatch on 32 bit > system > > > Key: DISPATCH-1751 > URL: https://issues.apache.org/jira/browse/DISPATCH-1751 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.13.0 >Reporter: Ganesh Murthy >Priority: Major > > On 32bit systems, an unexpected incoming-window value is set. This for > example causes system_tests_protocol_settings failures on 32bit systems, with > test expecting to see the incoming-window be 2147483647 but instead finding > it much less, e.g 131071. > This is due to the way the session capacity is configured, particularly on > 32bit systems. See more details (output, code, etc) from prior discussions on > PROTON-2255 (raised when this was incorrectly thought to be a proton issue). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1751) unexpected incoming-window in begin frame when running Dispatch on 32 bit system
[ https://issues.apache.org/jira/browse/DISPATCH-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217841#comment-17217841 ] ASF subversion and git services commented on DISPATCH-1751: --- Commit 7525ac665c3600805615c86796482914cdba783d in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7525ac6 ] DISPATCH-1751: Rework how AMQP session incoming-window is derived Proton allows specification of a session 'capacity'. Initially the incoming-window will be (capacity / max-frame-size), defining at most how many max-size transfers will definitely be accepted on the session. Dispatch listener config defines a maxFrameSize and a maxSessionFrames the product of which is equal to the capacity to be configured in Proton. Dispatch vhostUserGroup policy defines a maxFrameSize and a maxSessionWindow. The maxSessionWindow is passed directly to Proton as the capacity. This closes #847 > unexpected incoming-window in begin frame when running Dispatch on 32 bit > system > > > Key: DISPATCH-1751 > URL: https://issues.apache.org/jira/browse/DISPATCH-1751 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.13.0 >Reporter: Ganesh Murthy >Priority: Major > > On 32bit systems, an unexpected incoming-window value is set. This for > example causes system_tests_protocol_settings failures on 32bit systems, with > test expecting to see the incoming-window be 2147483647 but instead finding > it much less, e.g 131071. > This is due to the way the session capacity is configured, particularly on > 32bit systems. See more details (output, code, etc) from prior discussions on > PROTON-2255 (raised when this was incorrectly thought to be a proton issue). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #847: DISPATCH-1751: Rework how AMQP session incoming-window is derived
asfgit closed pull request #847: URL: https://github.com/apache/qpid-dispatch/pull/847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #880: WIP: unittest for starting router and adding autoLink
jiridanek commented on a change in pull request #880:
URL: https://github.com/apache/qpid-dispatch/pull/880#discussion_r508739576
##
File path: src/log.c
##
@@ -520,6 +524,7 @@ void qd_log_finalize(void) {
qd_log_entry_free_lh(DEQ_HEAD(entries));
while (DEQ_HEAD(sink_list))
log_sink_free_lh(DEQ_HEAD(sink_list));
+default_log_source = NULL; // stale value would end up misconfiguring
router again in the same process
Review comment:
Global variable that needs to be NULLed out on exit, otherwise starting
again in the same process segfaults on logging.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1806) TCP adaptor mishandles outgoing body_data
[ https://issues.apache.org/jira/browse/DISPATCH-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke resolved DISPATCH-1806. Fix Version/s: 1.15.0 Resolution: Fixed Fixed at commit 4fe73d8 > TCP adaptor mishandles outgoing body_data > - > > Key: DISPATCH-1806 > URL: https://issues.apache.org/jira/browse/DISPATCH-1806 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Protocol Adaptors >Affects Versions: 1.14.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Blocker > Fix For: 1.15.0 > > > * Function read_message_body() calls qd_message_next_body_data() every time > it processes up to four body data buffers. > A vbin segment may contain more than four body data buffers > * Using a simple (DISPATCH-1778) example a single telnet session may assert > that offset is beyond the body_data_buffer_count limit. > Each vbin segment must track the segment length to know when to stop reading > that segment and call qd_message_next_body_data for the next segment. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on pull request #881: Fixes to get inter-router TCP flowing (rebased, improved)
ChugR commented on pull request #881: URL: https://github.com/apache/qpid-dispatch/pull/881#issuecomment-712960227 Fixed with commits eccba23a..4fe73d8b. Resolved conflicts in tcp_adaptor.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR closed pull request #881: Fixes to get inter-router TCP flowing (rebased, improved)
ChugR closed pull request #881: URL: https://github.com/apache/qpid-dispatch/pull/881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1654) tcp protocol bridging (ingress and egress)
[ https://issues.apache.org/jira/browse/DISPATCH-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217714#comment-17217714 ] ASF subversion and git services commented on DISPATCH-1654: --- Commit 9dc69d55b003cd097efa8b30edaed5b3f789a10d in qpid-dispatch's branch refs/heads/dev-protocol-adaptors-2 from Gordon Sim [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=9dc69d5 ] DISPATCH-1654: need to set to field on message > tcp protocol bridging (ingress and egress) > -- > > Key: DISPATCH-1654 > URL: https://issues.apache.org/jira/browse/DISPATCH-1654 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1654) tcp protocol bridging (ingress and egress)
[ https://issues.apache.org/jira/browse/DISPATCH-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217715#comment-17217715 ] ASF subversion and git services commented on DISPATCH-1654: --- Commit c56a1fba5165589c11a7779580a251c45e20828a in qpid-dispatch's branch refs/heads/dev-protocol-adaptors-2 from Gordon Sim [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c56a1fb ] DISPATCH-1654: allow content to be seen when available > tcp protocol bridging (ingress and egress) > -- > > Key: DISPATCH-1654 > URL: https://issues.apache.org/jira/browse/DISPATCH-1654 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1654) tcp protocol bridging (ingress and egress)
[ https://issues.apache.org/jira/browse/DISPATCH-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217716#comment-17217716 ] ASF subversion and git services commented on DISPATCH-1654: --- Commit a8e548bfca44851305a8b6a59cfb21272ca668ca in qpid-dispatch's branch refs/heads/dev-protocol-adaptors-2 from Gordon Sim [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=a8e548b ] DISPATCH-1654: fix for streaming message > tcp protocol bridging (ingress and egress) > -- > > Key: DISPATCH-1654 > URL: https://issues.apache.org/jira/browse/DISPATCH-1654 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1806) TCP adaptor mishandles outgoing body_data
[ https://issues.apache.org/jira/browse/DISPATCH-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217717#comment-17217717 ] ASF subversion and git services commented on DISPATCH-1806: --- Commit 4fe73d8b299f343f8a57cce80932a12c16f0385d in qpid-dispatch's branch refs/heads/dev-protocol-adaptors-2 from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4fe73d8 ] DISPATCH-1806: Rearrange TCP adaptor outbound body data handling > TCP adaptor mishandles outgoing body_data > - > > Key: DISPATCH-1806 > URL: https://issues.apache.org/jira/browse/DISPATCH-1806 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Protocol Adaptors >Affects Versions: 1.14.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Blocker > > * Function read_message_body() calls qd_message_next_body_data() every time > it processes up to four body data buffers. > A vbin segment may contain more than four body data buffers > * Using a simple (DISPATCH-1778) example a single telnet session may assert > that offset is beyond the body_data_buffer_count limit. > Each vbin segment must track the segment length to know when to stop reading > that segment and call qd_message_next_body_data for the next segment. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1807) TCP adaptor has no system tests
[ https://issues.apache.org/jira/browse/DISPATCH-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217694#comment-17217694 ] ASF subversion and git services commented on DISPATCH-1807: --- Commit eccba23ad05df2490e23790ea6690eee41bd99f4 in qpid-dispatch's branch refs/heads/dev-protocol-adaptors-2 from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=eccba23 ] DISPATCH-1807: TCP adaptor test echo server > TCP adaptor has no system tests > --- > > Key: DISPATCH-1807 > URL: https://issues.apache.org/jira/browse/DISPATCH-1807 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Protocol Adaptors >Reporter: Charles E. Rolke >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1757) failure in system_tests_edge_router: raise Empty
[
https://issues.apache.org/jira/browse/DISPATCH-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti reassigned DISPATCH-1757:
Assignee: Ken Giusti
> failure in system_tests_edge_router: raise Empty
>
>
> Key: DISPATCH-1757
> URL: https://issues.apache.org/jira/browse/DISPATCH-1757
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.13.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
>
> This is a rare flaky failure of the test.
> https://travis-ci.com/github/jiridanek/qpid-dispatch/jobs/373299500#L5382
> {noformat}
> test 54
> Start 54: system_tests_edge_router
> 54: Test command: /usr/bin/python
> "/home/travis/build/jiridanek/qpid-dispatch/build/tests/run.py" "-m"
> "unittest" "-v" "system_tests_edge_router"
> 54: Test timeout computed to be: 600
> 54: test_edge_listener_sender_crash_DISPATCH_1492
> (system_tests_edge_router.EdgeListenerSender) ... ok
> 54: test_01_active_flag (system_tests_edge_router.EdgeRouterTest) ... ok
> 54:
> 54: Router EA1 debug dump file:
> 54:
> 54: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 2
> 54: Leak: 2020-08-18 19:55:39.587954 + type: qd_timer_t address: 0xfee050
> (suppressed)
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x306)
> [0x7fa83c242870]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(new_qd_timer_t+0x38)
> [0x7fa83c3059d4]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_timer+0x2b)
> [0x7fa83c305ff7]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_server_connector+0x173)
> [0x7fa83c30506e]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_dispatch_configure_connector+0x3e)
> [0x7fa83c24f29c]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call_unix64+0x4c)
> [0x7fa838d98e40]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call+0x2eb) [0x7fa838d988ab]
> 54:
> /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(_ctypes_callproc+0x48f)
> [0x7fa838fa83df]
> 54: /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(+0x11d82)
> [0x7fa838facd82]
> 54: /usr/lib/x86_64-linux-gnu/libpython2.7.so.1.0(PyObject_Call+0x43)
> [0x7fa83af3a2b3]
> 54:
> 54: Leak: 2020-08-18 19:55:39.588979 + type: qd_timer_t address: 0xfeded0
> (suppressed)
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x306)
> [0x7fa83c242870]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(new_qd_timer_t+0x38)
> [0x7fa83c3059d4]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_timer+0x2b)
> [0x7fa83c305ff7]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_server_connector+0x173)
> [0x7fa83c30506e]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_dispatch_configure_connector+0x3e)
> [0x7fa83c24f29c]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call_unix64+0x4c)
> [0x7fa838d98e40]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call+0x2eb) [0x7fa838d988ab]
> 54:
> /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(_ctypes_callproc+0x48f)
> [0x7fa838fa83df]
> 54: /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(+0x11d82)
> [0x7fa838facd82]
> 54: /usr/lib/x86_64-linux-gnu/libpython2.7.so.1.0(PyObject_Call+0x43)
> [0x7fa83af3a2b3]
> 54:
> 54: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 2
> 54: Leak: 2020-08-18 19:55:39.587950 + type: qd_connector_t address:
> 0x10c2390 (suppressed)
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x842)
> [0x7fa83c242dac]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(new_qd_connector_t+0x38)
> [0x7fa83c2fb8fe]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_server_connector+0x23)
> [0x7fa83c304f1e]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_dispatch_configure_connector+0x3e)
> [0x7fa83c24f29c]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call_unix64+0x4c)
> [0x7fa838d98e40]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call+0x2eb) [0x7fa838d988ab]
> 54:
> /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(_ctypes_callproc+0x48f)
> [0x7fa838fa83df]
> 54: /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(+0x11d82)
> [0x7fa838facd82]
> 54: /usr/lib/x86_64-linux-gnu/libpython2.7.so.1.0(PyObject_Call+0x43)
> [0x7fa83af3a2b3]
> 54: /usr/lib/x86_64-linux-gnu/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x543c)
> [0x7fa83aed839c]
> 54:
> 54: Leak: 2020-08-18 19
[jira] [Closed] (DISPATCH-1809) HTTP1.x streaming messages in multi-hop config stall
[ https://issues.apache.org/jira/browse/DISPATCH-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti closed DISPATCH-1809. Resolution: Duplicate > HTTP1.x streaming messages in multi-hop config stall > > > Key: DISPATCH-1809 > URL: https://issues.apache.org/jira/browse/DISPATCH-1809 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > > This appears to be due to body_data message buffers not being freed and > triggering Q2/3 flow control. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1809) HTTP1.x streaming messages in multi-hop config stall
[ https://issues.apache.org/jira/browse/DISPATCH-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217679#comment-17217679 ] Ken Giusti commented on DISPATCH-1809: -- Closing as duplicate > HTTP1.x streaming messages in multi-hop config stall > > > Key: DISPATCH-1809 > URL: https://issues.apache.org/jira/browse/DISPATCH-1809 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > > This appears to be due to body_data message buffers not being freed and > triggering Q2/3 flow control. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1803) HTTP1.x adaptor stall when body data section > Q2 limit
[ https://issues.apache.org/jira/browse/DISPATCH-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-1803. -- Resolution: Fixed > HTTP1.x adaptor stall when body data section > Q2 limit > --- > > Key: DISPATCH-1803 > URL: https://issues.apache.org/jira/browse/DISPATCH-1803 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > > Since the adaptors process body-data chunks by buffering the full body-data > before forwarding it to the endpoint, body data chunks of > Q2 limit will > cause the message forwarding to hang as Q2 limit will be hit yet the buffers > will not be drained since the adaptor is waiting for the entire body data to > arrive before the adaptor can write out the buffers. > My apologies to Mrs. Smith, my fourth grade English teacher, for the above > run-on sentence. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1803) HTTP1.x adaptor stall when body data section > Q2 limit
[ https://issues.apache.org/jira/browse/DISPATCH-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217677#comment-17217677 ] ASF subversion and git services commented on DISPATCH-1803: --- Commit 3732ca4334c3ba6cfb15870f37af6c1c435bea90 in qpid-dispatch's branch refs/heads/dev-protocol-adaptors-2 from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=3732ca4 ] DISPATCH-1803: prevent body_data sections from violating Q2 limit This closes #879 > HTTP1.x adaptor stall when body data section > Q2 limit > --- > > Key: DISPATCH-1803 > URL: https://issues.apache.org/jira/browse/DISPATCH-1803 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > > Since the adaptors process body-data chunks by buffering the full body-data > before forwarding it to the endpoint, body data chunks of > Q2 limit will > cause the message forwarding to hang as Q2 limit will be hit yet the buffers > will not be drained since the adaptor is waiting for the entire body data to > arrive before the adaptor can write out the buffers. > My apologies to Mrs. Smith, my fourth grade English teacher, for the above > run-on sentence. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1791) HTTP1.x adaptor leaks message buffers and deliveries
[ https://issues.apache.org/jira/browse/DISPATCH-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217674#comment-17217674 ] Ken Giusti commented on DISPATCH-1791: -- Nearly all fixed: dropping priority from blocker. > HTTP1.x adaptor leaks message buffers and deliveries > > > Key: DISPATCH-1791 > URL: https://issues.apache.org/jira/browse/DISPATCH-1791 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: HTTP/1.x > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1791) HTTP1.x adaptor leaks message buffers and deliveries
[ https://issues.apache.org/jira/browse/DISPATCH-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-1791: - Priority: Major (was: Blocker) > HTTP1.x adaptor leaks message buffers and deliveries > > > Key: DISPATCH-1791 > URL: https://issues.apache.org/jira/browse/DISPATCH-1791 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: HTTP/1.x > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1791) HTTP1.x adaptor leaks message buffers and deliveries
[ https://issues.apache.org/jira/browse/DISPATCH-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217668#comment-17217668 ] ASF GitHub Bot commented on DISPATCH-1791: -- kgiusti closed pull request #882: URL: https://github.com/apache/qpid-dispatch/pull/882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > HTTP1.x adaptor leaks message buffers and deliveries > > > Key: DISPATCH-1791 > URL: https://issues.apache.org/jira/browse/DISPATCH-1791 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1791) HTTP1.x adaptor leaks message buffers and deliveries
[ https://issues.apache.org/jira/browse/DISPATCH-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217667#comment-17217667 ] ASF GitHub Bot commented on DISPATCH-1791: -- kgiusti commented on pull request #882: URL: https://github.com/apache/qpid-dispatch/pull/882#issuecomment-712925005 Merged to dev-protocol-adaptors branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > HTTP1.x adaptor leaks message buffers and deliveries > > > Key: DISPATCH-1791 > URL: https://issues.apache.org/jira/browse/DISPATCH-1791 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #882: DISPATCH-1791: fix strdup and qdr_delivery_t leaks
kgiusti closed pull request #882: URL: https://github.com/apache/qpid-dispatch/pull/882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #882: DISPATCH-1791: fix strdup and qdr_delivery_t leaks
kgiusti commented on pull request #882: URL: https://github.com/apache/qpid-dispatch/pull/882#issuecomment-712925005 Merged to dev-protocol-adaptors branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1805) Free body buffers when body data is freed.
[ https://issues.apache.org/jira/browse/DISPATCH-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217657#comment-17217657 ] Ganesh Murthy commented on DISPATCH-1805: - This is not a duplicate of DISPATCH-1800 This Jira specifically calls for freeing buffers in a body data. > Free body buffers when body data is freed. > -- > > Key: DISPATCH-1805 > URL: https://issues.apache.org/jira/browse/DISPATCH-1805 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Reporter: Ganesh Murthy >Assignee: Ted Ross >Priority: Major > > When a body data is freed, free its body data buffers. In some cases the last > buffer cannot be freed if the next body data begins in the last buffer -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (DISPATCH-1805) Free body buffers when body data is freed.
[ https://issues.apache.org/jira/browse/DISPATCH-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reopened DISPATCH-1805: - > Free body buffers when body data is freed. > -- > > Key: DISPATCH-1805 > URL: https://issues.apache.org/jira/browse/DISPATCH-1805 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Reporter: Ganesh Murthy >Assignee: Ted Ross >Priority: Major > > When a body data is freed, free its body data buffers. In some cases the last > buffer cannot be freed if the next body data begins in the last buffer -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1805) Free body buffers when body data is freed.
[ https://issues.apache.org/jira/browse/DISPATCH-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reassigned DISPATCH-1805: --- Assignee: Ted Ross > Free body buffers when body data is freed. > -- > > Key: DISPATCH-1805 > URL: https://issues.apache.org/jira/browse/DISPATCH-1805 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Reporter: Ganesh Murthy >Assignee: Ted Ross >Priority: Major > > When a body data is freed, free its body data buffers. In some cases the last > buffer cannot be freed if the next body data begins in the last buffer -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1810) HTTP1.x system tests frequently fail in travis CI with mutex errors
Ken Giusti created DISPATCH-1810: Summary: HTTP1.x system tests frequently fail in travis CI with mutex errors Key: DISPATCH-1810 URL: https://issues.apache.org/jira/browse/DISPATCH-1810 Project: Qpid Dispatch Issue Type: Bug Components: Protocol Adaptors Affects Versions: 1.15.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.15.0 Assert triggered on mutex failure: 69: qdrouterd -c EA1.conf -I /home/travis/build/kgiusti/dispatch/python 69: /home/travis/build/kgiusti/dispatch/build/tests/system_test.dir/system_tests_http1_adaptor/Http1AdaptorEdge2EdgeTest/setUpClass/EA1-2.cmd 69: 69: qdrouterd: /home/travis/build/kgiusti/dispatch/src/posix/threading.c:58: sys_mutex_lock: Assertion `result == 0' failed. 69: Often hit mutex leak: 69: ==15606==ERROR: LeakSanitizer: detected memory leaks 69: 69: Direct leak of 64 byte(s) in 1 object(s) allocated from: 69: #0 0x7f5a08cd0076 in __interceptor_posix_memalign (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x99076) 69: #1 0x7f5a084adc41 in sys_mutex /home/travis/build/kgiusti/dispatch/src/posix/threading.c:41 69: #2 0x7f5a0847546f in qd_message /home/travis/build/kgiusti/dispatch/src/message.c:1009 69: #3 0x7f5a08406f21 in _server_rx_headers_done_cb /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_server.c:807 69: #4 0x7f5a083db58b in process_headers_done /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_codec.c:831 69: #5 0x7f5a083dc52a in parse_header /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_codec.c:908 69: #6 0x7f5a083e1219 in decode_incoming /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_codec.c:1260 69: #7 0x7f5a083e1ec8 in h1_codec_connection_rx_data /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_codec.c:1305 69: #8 0x7f5a084034f2 in _handle_connection_events /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_server.c:511 69: #9 0x7f5a085c2052 in handle_event_with_context /home/travis/build/kgiusti/dispatch/src/server.c:804 69: #10 0x7f5a085c2094 in do_handle_raw_connection_event /home/travis/build/kgiusti/dispatch/src/server.c:810 69: #11 0x7f5a085c568e in handle /home/travis/build/kgiusti/dispatch/src/server.c:1090 69: #12 0x7f5a085c58ef in thread_run /home/travis/build/kgiusti/dispatch/src/server.c:1122 69: #13 0x7f5a084ae352 in _thread_init /home/travis/build/kgiusti/dispatch/src/posix/threading.c:172 69: #14 0x7f5a07e736b9 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1810) HTTP1.x system tests frequently fail in travis CI with mutex errors
[ https://issues.apache.org/jira/browse/DISPATCH-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-1810: - Labels: HTTP/1.x (was: ) > HTTP1.x system tests frequently fail in travis CI with mutex errors > --- > > Key: DISPATCH-1810 > URL: https://issues.apache.org/jira/browse/DISPATCH-1810 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > > Assert triggered on mutex failure: > > 69: qdrouterd -c EA1.conf -I /home/travis/build/kgiusti/dispatch/python > > 69: > /home/travis/build/kgiusti/dispatch/build/tests/system_test.dir/system_tests_http1_adaptor/Http1AdaptorEdge2EdgeTest/setUpClass/EA1-2.cmd > > 69: > > 69: qdrouterd: /home/travis/build/kgiusti/dispatch/src/posix/threading.c:58: > sys_mutex_lock: Assertion `result == 0' failed. > 69: > > Often hit mutex leak: > > > 69: ==15606==ERROR: LeakSanitizer: detected memory leaks > > 69: > > 69: Direct leak of 64 byte(s) in 1 object(s) allocated from: > > 69: #0 0x7f5a08cd0076 in __interceptor_posix_memalign > (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x99076) > > 69: #1 0x7f5a084adc41 in sys_mutex > /home/travis/build/kgiusti/dispatch/src/posix/threading.c:41 > > 69: #2 0x7f5a0847546f in qd_message > /home/travis/build/kgiusti/dispatch/src/message.c:1009 > > 69: #3 0x7f5a08406f21 in _server_rx_headers_done_cb > /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_server.c:807 > > 69: #4 0x7f5a083db58b in process_headers_done > /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_codec.c:831 > > 69: #5 0x7f5a083dc52a in parse_header > /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_codec.c:908 > > 69: #6 0x7f5a083e1219 in decode_incoming > /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_codec.c:1260 > > 69: #7 0x7f5a083e1ec8 in h1_codec_connection_rx_data > /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_codec.c:1305 > > 69: #8 0x7f5a084034f2 in _handle_connection_events > /home/travis/build/kgiusti/dispatch/src/adaptors/http1/http1_server.c:511 > > 69: #9 0x7f5a085c2052 in handle_event_with_context > /home/travis/build/kgiusti/dispatch/src/server.c:804 > > 69: #10 0x7f5a085c2094 in do_handle_raw_connection_event > /home/travis/build/kgiusti/dispatch/src/server.c:810 > > 69: #11 0x7f5a085c568e in handle > /home/travis/build/kgiusti/dispatch/src/server.c:1090 > > 69: #12 0x7f5a085c58ef in thread_run > /home/travis/build/kgiusti/dispatch/src/server.c:1122 > > 69: #13 0x7f5a084ae352 in _thread_init > /home/travis/build/kgiusti/dispatch/src/posix/threading.c:172 > 69: #14 0x7f5a07e736b9 in start_thread > (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1809) HTTP1.x streaming messages in multi-hop config stall
Ken Giusti created DISPATCH-1809: Summary: HTTP1.x streaming messages in multi-hop config stall Key: DISPATCH-1809 URL: https://issues.apache.org/jira/browse/DISPATCH-1809 Project: Qpid Dispatch Issue Type: Bug Components: Protocol Adaptors Affects Versions: 1.15.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.15.0 This appears to be due to body_data message buffers not being freed and triggering Q2/3 flow control. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1809) HTTP1.x streaming messages in multi-hop config stall
[ https://issues.apache.org/jira/browse/DISPATCH-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-1809: - Labels: HTTP/1.x (was: ) > HTTP1.x streaming messages in multi-hop config stall > > > Key: DISPATCH-1809 > URL: https://issues.apache.org/jira/browse/DISPATCH-1809 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > > This appears to be due to body_data message buffers not being freed and > triggering Q2/3 flow control. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1751) unexpected incoming-window in begin frame when running Dispatch on 32 bit system
[ https://issues.apache.org/jira/browse/DISPATCH-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217614#comment-17217614 ] ASF GitHub Bot commented on DISPATCH-1751: -- ChugR commented on a change in pull request #847: URL: https://github.com/apache/qpid-dispatch/pull/847#discussion_r508519223 ## File path: src/amqp.c ## @@ -96,6 +96,8 @@ const char * const QD_AMQPS_PORT_STR = "5671"; const char * const QD_AMQP_DFLT_PROTO = "tcp"; +const int PN_AMQP_MAX_SESSION_CAPACITY_32BIT = 2147483647; Review comment: 2^31-1 is not a limit imposed by Proton or by AMQP. It is half of a 32-bit address space and the chances of it being reached are about zero. I've renamed the constant and reduced its scope in another patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > unexpected incoming-window in begin frame when running Dispatch on 32 bit > system > > > Key: DISPATCH-1751 > URL: https://issues.apache.org/jira/browse/DISPATCH-1751 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.13.0 >Reporter: Ganesh Murthy >Priority: Major > > On 32bit systems, an unexpected incoming-window value is set. This for > example causes system_tests_protocol_settings failures on 32bit systems, with > test expecting to see the incoming-window be 2147483647 but instead finding > it much less, e.g 131071. > This is due to the way the session capacity is configured, particularly on > 32bit systems. See more details (output, code, etc) from prior discussions on > PROTON-2255 (raised when this was incorrectly thought to be a proton issue). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #847: DISPATCH-1751: Rework how AMQP session incoming-window is derived
ChugR commented on a change in pull request #847: URL: https://github.com/apache/qpid-dispatch/pull/847#discussion_r508519223 ## File path: src/amqp.c ## @@ -96,6 +96,8 @@ const char * const QD_AMQPS_PORT_STR = "5671"; const char * const QD_AMQP_DFLT_PROTO = "tcp"; +const int PN_AMQP_MAX_SESSION_CAPACITY_32BIT = 2147483647; Review comment: 2^31-1 is not a limit imposed by Proton or by AMQP. It is half of a 32-bit address space and the chances of it being reached are about zero. I've renamed the constant and reduced its scope in another patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1802) Router crash during HTTP connection activation
[ https://issues.apache.org/jira/browse/DISPATCH-1802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-1802. -- Resolution: Fixed > Router crash during HTTP connection activation > -- > > Key: DISPATCH-1802 > URL: https://issues.apache.org/jira/browse/DISPATCH-1802 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors, Router Node >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.15.0 > > > Use after free crash: the router core thread attempts to activate the HTTP1 > adaptor's connection at the same moment the I/O thread frees the proactor > connection in response to endpoint connection drop. > Fairly easy to reproduce therefore blocker status. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8478) [Broker-J] NPE thrown for ACL rules like 'ALLOW ALL ALL' or 'DENY ALL ALL'
[ https://issues.apache.org/jira/browse/QPID-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217510#comment-17217510 ] ASF GitHub Bot commented on QPID-8478: -- Dedeepya-T closed pull request #67: URL: https://github.com/apache/qpid-broker-j/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J] NPE thrown for ACL rules like 'ALLOW ALL ALL' or 'DENY ALL ALL' > -- > > Key: QPID-8478 > URL: https://issues.apache.org/jira/browse/QPID-8478 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.1, qpid-java-broker-7.1.9 >Reporter: Dedeepya >Priority: Major > Fix For: qpid-java-broker-8.0.2 > > Attachments: ACL_NPE.txt > > > When ACL rule consist of three arguments (for example, 'ALLOW ALL ALL' or > 'DENY ALL ALL') the NPE is thrown on the rule check and reload operation > An example of error stack trace is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8478) [Broker-J] NPE thrown for ACL rules like 'ALLOW ALL ALL' or 'DENY ALL ALL'
[ https://issues.apache.org/jira/browse/QPID-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217511#comment-17217511 ] ASF GitHub Bot commented on QPID-8478: -- Dedeepya-T commented on pull request #67: URL: https://github.com/apache/qpid-broker-j/pull/67#issuecomment-712767422 This request fixes NPE when ACL length is 3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J] NPE thrown for ACL rules like 'ALLOW ALL ALL' or 'DENY ALL ALL' > -- > > Key: QPID-8478 > URL: https://issues.apache.org/jira/browse/QPID-8478 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.1, qpid-java-broker-7.1.9 >Reporter: Dedeepya >Priority: Major > Fix For: qpid-java-broker-8.0.2 > > Attachments: ACL_NPE.txt > > > When ACL rule consist of three arguments (for example, 'ALLOW ALL ALL' or > 'DENY ALL ALL') the NPE is thrown on the rule check and reload operation > An example of error stack trace is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on pull request #67: QPID-8478:[Broker-J]Added null check for ACL predicates
Dedeepya-T commented on pull request #67: URL: https://github.com/apache/qpid-broker-j/pull/67#issuecomment-712767422 This request fixes NPE when ACL length is 3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T closed pull request #67: QPID-8478:[Broker-J]Added null check for ACL predicates
Dedeepya-T closed pull request #67: URL: https://github.com/apache/qpid-broker-j/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1496) C epoll proactor needs better timer implementation for connections
[ https://issues.apache.org/jira/browse/PROTON-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217494#comment-17217494 ] ASF GitHub Bot commented on PROTON-1496: codecov-io commented on pull request #275: URL: https://github.com/apache/qpid-proton/pull/275#issuecomment-712754081 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=h1) Report > Merging [#275](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/34ca28fae4a880151440c33312ca7f723441c2b2?el=desc) will **decrease** coverage by `0.20%`. > The diff coverage is `34.82%`. [](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #275 +/- ## == - Coverage 79.68% 79.48% -0.21% == Files 342 343 +1 Lines 4288642989 +103 == - Hits3417534170 -5 - Misses 8711 8819 +108 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll-internal.h](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwtaW50ZXJuYWwuaA==) | `86.66% <ø> (ø)` | | | [c/src/proactor/epoll\_timer\_queue.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGxfdGltZXJfcXVldWUuYw==) | `27.67% <27.67%> (ø)` | | | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `81.97% <61.90%> (-0.24%)` | :arrow_down: | | [c/src/ssl/openssl.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvc3NsL29wZW5zc2wuYw==) | `83.28% <0.00%> (-0.11%)` | :arrow_down: | | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.73% <0.00%> (+0.05%)` | :arrow_up: | | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.43% <0.00%> (+0.13%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=footer). Last update [34ca28f...c15d749](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > C epoll proactor needs better timer implementation for connections > -- > > Key: PROTON-1496 > URL: https://issues.apache.org/jira/browse/PROTON-1496 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.18.0 > Environment: Linux environments with epoll support >Reporter: Clifford Jansen >Assignee: Clifford Jansen >Priority: Major > > The epoll proactor allocates a timerfd per connection. This is a convenience > for the initial implementation and may surprise some applications running > into system limits on file descriptors twice as fast as expected. > The timer is used for heartbeats. It should be possible to write a > per-proactor heartbeat timer that is shared among the connections -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] codecov-io edited a comment on pull request #275: PROTON-1496: epoll proactor - single timer queue and timerfd for all …
codecov-io edited a comment on pull request #275: URL: https://github.com/apache/qpid-proton/pull/275#issuecomment-712754081 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=h1) Report > Merging [#275](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/34ca28fae4a880151440c33312ca7f723441c2b2?el=desc) will **decrease** coverage by `0.20%`. > The diff coverage is `34.82%`. [](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #275 +/- ## == - Coverage 79.68% 79.48% -0.21% == Files 342 343 +1 Lines 4288642989 +103 == - Hits3417534170 -5 - Misses 8711 8819 +108 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll-internal.h](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwtaW50ZXJuYWwuaA==) | `86.66% <ø> (ø)` | | | [c/src/proactor/epoll\_timer\_queue.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGxfdGltZXJfcXVldWUuYw==) | `27.67% <27.67%> (ø)` | | | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `81.97% <61.90%> (-0.24%)` | :arrow_down: | | [c/src/ssl/openssl.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvc3NsL29wZW5zc2wuYw==) | `83.28% <0.00%> (-0.11%)` | :arrow_down: | | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.73% <0.00%> (+0.05%)` | :arrow_up: | | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.43% <0.00%> (+0.13%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=footer). Last update [34ca28f...c15d749](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1496) C epoll proactor needs better timer implementation for connections
[ https://issues.apache.org/jira/browse/PROTON-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217495#comment-17217495 ] ASF GitHub Bot commented on PROTON-1496: codecov-io edited a comment on pull request #275: URL: https://github.com/apache/qpid-proton/pull/275#issuecomment-712754081 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=h1) Report > Merging [#275](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/34ca28fae4a880151440c33312ca7f723441c2b2?el=desc) will **decrease** coverage by `0.20%`. > The diff coverage is `34.82%`. [](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #275 +/- ## == - Coverage 79.68% 79.48% -0.21% == Files 342 343 +1 Lines 4288642989 +103 == - Hits3417534170 -5 - Misses 8711 8819 +108 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll-internal.h](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwtaW50ZXJuYWwuaA==) | `86.66% <ø> (ø)` | | | [c/src/proactor/epoll\_timer\_queue.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGxfdGltZXJfcXVldWUuYw==) | `27.67% <27.67%> (ø)` | | | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `81.97% <61.90%> (-0.24%)` | :arrow_down: | | [c/src/ssl/openssl.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvc3NsL29wZW5zc2wuYw==) | `83.28% <0.00%> (-0.11%)` | :arrow_down: | | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.73% <0.00%> (+0.05%)` | :arrow_up: | | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.43% <0.00%> (+0.13%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=footer). Last update [34ca28f...c15d749](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > C epoll proactor needs better timer implementation for connections > -- > > Key: PROTON-1496 > URL: https://issues.apache.org/jira/browse/PROTON-1496 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.18.0 > Environment: Linux environments with epoll support >Reporter: Clifford Jansen >Assignee: Clifford Jansen >Priority: Major > > The epoll proactor allocates a timerfd per connection. This is a convenience > for the initial implementation and may surprise some applications running > into system limits on file descriptors twice as fast as expected. > The timer is used for heartbeats. It should be possible to write a > per-proactor heartbeat timer that is shared among the connections -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] codecov-io commented on pull request #275: PROTON-1496: epoll proactor - single timer queue and timerfd for all …
codecov-io commented on pull request #275: URL: https://github.com/apache/qpid-proton/pull/275#issuecomment-712754081 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=h1) Report > Merging [#275](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/34ca28fae4a880151440c33312ca7f723441c2b2?el=desc) will **decrease** coverage by `0.20%`. > The diff coverage is `34.82%`. [](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #275 +/- ## == - Coverage 79.68% 79.48% -0.21% == Files 342 343 +1 Lines 4288642989 +103 == - Hits3417534170 -5 - Misses 8711 8819 +108 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll-internal.h](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwtaW50ZXJuYWwuaA==) | `86.66% <ø> (ø)` | | | [c/src/proactor/epoll\_timer\_queue.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGxfdGltZXJfcXVldWUuYw==) | `27.67% <27.67%> (ø)` | | | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `81.97% <61.90%> (-0.24%)` | :arrow_down: | | [c/src/ssl/openssl.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvc3NsL29wZW5zc2wuYw==) | `83.28% <0.00%> (-0.11%)` | :arrow_down: | | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.73% <0.00%> (+0.05%)` | :arrow_up: | | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.43% <0.00%> (+0.13%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=footer). Last update [34ca28f...c15d749](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8469) [Broker-J][Message Store] The message is already cleaned when the delete listener is called
[ https://issues.apache.org/jira/browse/QPID-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-8469: - Affects Version/s: (was: qpid-java-broker-8.0.0) qpid-java-broker-8.0.1 qpid-java-broker-7.1.9 > [Broker-J][Message Store] The message is already cleaned when the delete > listener is called > --- > > Key: QPID-8469 > URL: https://issues.apache.org/jira/browse/QPID-8469 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.1, qpid-java-broker-7.1.9 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-8.0.2, qpid-java-broker-7.1.10 > > > We're trying to implement the claim-check pattern on top of the Broker. > So when a big message is sent, we put the payload in a blob store and we just > pass the ID in the message headers. > The biggest problem is, when do we remove the payload from the blob store, > especially in multicast mode ? > The message delete listener would be perfect for that except that the message > has already been cleaned when it is called and the headers have been > removed... -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8469) [Broker-J][Message Store] The message is already cleaned when the delete listener is called
[ https://issues.apache.org/jira/browse/QPID-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-8469. -- Resolution: Fixed > [Broker-J][Message Store] The message is already cleaned when the delete > listener is called > --- > > Key: QPID-8469 > URL: https://issues.apache.org/jira/browse/QPID-8469 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.1, qpid-java-broker-7.1.9 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-8.0.2, qpid-java-broker-7.1.10 > > > We're trying to implement the claim-check pattern on top of the Broker. > So when a big message is sent, we put the payload in a blob store and we just > pass the ID in the message headers. > The biggest problem is, when do we remove the payload from the blob store, > especially in multicast mode ? > The message delete listener would be perfect for that except that the message > has already been cleaned when it is called and the headers have been > removed... -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-8469) [Broker-J][Message Store] The message is already cleaned when the delete listener is called
[ https://issues.apache.org/jira/browse/QPID-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-8469: Assignee: Alex Rudyy > [Broker-J][Message Store] The message is already cleaned when the delete > listener is called > --- > > Key: QPID-8469 > URL: https://issues.apache.org/jira/browse/QPID-8469 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.0 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-8.0.2, qpid-java-broker-7.1.10 > > > We're trying to implement the claim-check pattern on top of the Broker. > So when a big message is sent, we put the payload in a blob store and we just > pass the ID in the message headers. > The biggest problem is, when do we remove the payload from the blob store, > especially in multicast mode ? > The message delete listener would be perfect for that except that the message > has already been cleaned when it is called and the headers have been > removed... -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8469) [Broker-J][Message Store] The message is already cleaned when the delete listener is called
[ https://issues.apache.org/jira/browse/QPID-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-8469: - Fix Version/s: qpid-java-broker-7.1.10 qpid-java-broker-8.0.2 > [Broker-J][Message Store] The message is already cleaned when the delete > listener is called > --- > > Key: QPID-8469 > URL: https://issues.apache.org/jira/browse/QPID-8469 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.0 >Reporter: Olivier VERMEULEN >Priority: Major > Fix For: qpid-java-broker-8.0.2, qpid-java-broker-7.1.10 > > > We're trying to implement the claim-check pattern on top of the Broker. > So when a big message is sent, we put the payload in a blob store and we just > pass the ID in the message headers. > The biggest problem is, when do we remove the payload from the blob store, > especially in multicast mode ? > The message delete listener would be perfect for that except that the message > has already been cleaned when it is called and the headers have been > removed... -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1496) C epoll proactor needs better timer implementation for connections
[ https://issues.apache.org/jira/browse/PROTON-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217380#comment-17217380 ] ASF GitHub Bot commented on PROTON-1496: cliffjansen opened a new pull request #275: URL: https://github.com/apache/qpid-proton/pull/275 …connection heartbeat timers This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > C epoll proactor needs better timer implementation for connections > -- > > Key: PROTON-1496 > URL: https://issues.apache.org/jira/browse/PROTON-1496 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.18.0 > Environment: Linux environments with epoll support >Reporter: Clifford Jansen >Assignee: Clifford Jansen >Priority: Major > > The epoll proactor allocates a timerfd per connection. This is a convenience > for the initial implementation and may surprise some applications running > into system limits on file descriptors twice as fast as expected. > The timer is used for heartbeats. It should be possible to write a > per-proactor heartbeat timer that is shared among the connections -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] cliffjansen opened a new pull request #275: PROTON-1496: epoll proactor - single timer queue and timerfd for all …
cliffjansen opened a new pull request #275: URL: https://github.com/apache/qpid-proton/pull/275 …connection heartbeat timers This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
