[jira] [Commented] (PROTON-2231) Assertion fail on macOS with libuv in c-threaderciser test
[ https://issues.apache.org/jira/browse/PROTON-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239854#comment-17239854 ] Roddie Kieley commented on PROTON-2231: --- I think everything I've seen indicates that it is not platform specific. Tracing through the function calls with the timeouts disabled we see that it always the code path always comes directly through remove_active which eventually asserts that active must be greater than zero for you to call a remove that will decrement it. As far as I can tell the threadercizer does not track open versus closed listeners and can close more than have been opened, although at this point this is from recollection. > Assertion fail on macOS with libuv in c-threaderciser test > -- > > Key: PROTON-2231 > URL: https://issues.apache.org/jira/browse/PROTON-2231 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.32.0 >Reporter: Jiri Daněk >Assignee: Roddie Kieley >Priority: Major > Labels: freebsd, macOS > > As described on PROTON-2225, the test fails with assertion error. It is > currently disabled on macOS for this reason (in .travis.yml). > {noformat} > 6: Test command: /usr/local/opt/python/libexec/bin/python > "/Users/travis/build/jiridanek/qpid-proton/scripts/env.py" "--" > "/Users/travis/build/jiridanek/qpid-proton/build/c/tests/c-threaderciser" > 6: Test timeout computed to be: 1500 > 6: threaderciser start: threads=8, time=1, actions=[listen, close-listen, > connect, close-connect, wake, timeout, cancel-timeout] > 6: Assertion failed: (p->active > 0), function remove_active_lh, file > /Users/travis/build/jiridanek/qpid-proton/c/src/proactor/libuv.c, line 392. > 6/31 Test #6: c-threaderciser ..***Failed0.18 sec > {noformat} > If the test is meant to stay disabled for a longer time, it will have to be > disabled in CMakeLists.txt, so that users compiling the project do not run it > accidentally. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-521) ExceptionListener fired due to async dispatch failure is unable to close the Session/Connection
[ https://issues.apache.org/jira/browse/QPIDJMS-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239764#comment-17239764 ] ASF subversion and git services commented on QPIDJMS-521: - Commit 8fea843e9b46457f4dda3b21b35c3c16558b723f in qpid-jms's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=8fea843 ] QPIDJMS-521: ensure ExceptionListener called during unexpected async dispatch failure is allowed to close the Session/Connection > ExceptionListener fired due to async dispatch failure is unable to close the > Session/Connection > --- > > Key: QPIDJMS-521 > URL: https://issues.apache.org/jira/browse/QPIDJMS-521 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Affects Versions: 0.55.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 0.56.0 > > > **When an unexpected failure occurs during the process of dispatching a > message to an asynchronous consumer (i.e the work surrounding, but not > including, onMessage), the connection ExceptionListener is fired as a result. > If the ExceptionListener attempts to close the consumers containing Session > or Connection it will currently fail with an javax.jms.IllegalStateException > noting an "Illegal invocation from MessageListener callback". > This happens because the session async dispatch thread is ordinarily not > allowed to call these methods, is in keeping with the impl and their API > definitions. However, in this case it is not firing onMessage at the time but > is rather actually firing onException instead (and has relinquished the > session delivery lock). As such the "Illegal invocation" exception is > incorrect and the thread calling those operations should be permitted during > this scenario. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-521) ExceptionListener fired due to async dispatch failure is unable to close the Session/Connection
Robbie Gemmell created QPIDJMS-521: -- Summary: ExceptionListener fired due to async dispatch failure is unable to close the Session/Connection Key: QPIDJMS-521 URL: https://issues.apache.org/jira/browse/QPIDJMS-521 Project: Qpid JMS Issue Type: Task Reporter: Robbie Gemmell **When an unexpected failure occurs during the process of dispatching a message to an asynchronous consumer (i.e the work surrounding, but not including, onMessage), the connection ExceptionListener is fired as a result. If the ExceptionListener attempts to close the consumers containing Session or Connection it will currently fail with an javax.jms.IllegalStateException noting an "Illegal invocation from MessageListener callback". This happens because the session async dispatch thread is ordinarily not allowed to call these methods, is in keeping with the impl and their API definitions. However, in this case it is not firing onMessage at the time but is rather actually firing onException instead (and has relinquished the session delivery lock). As such the "Illegal invocation" exception is incorrect and the thread calling those operations should be permitted during this scenario. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPIDJMS-521) ExceptionListener fired due to async dispatch failure is unable to close the Session/Connection
[ https://issues.apache.org/jira/browse/QPIDJMS-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPIDJMS-521: -- Component/s: qpid-jms-client Fix Version/s: 0.56.0 Affects Version/s: 0.55.0 Assignee: Robbie Gemmell > ExceptionListener fired due to async dispatch failure is unable to close the > Session/Connection > --- > > Key: QPIDJMS-521 > URL: https://issues.apache.org/jira/browse/QPIDJMS-521 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Affects Versions: 0.55.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 0.56.0 > > > **When an unexpected failure occurs during the process of dispatching a > message to an asynchronous consumer (i.e the work surrounding, but not > including, onMessage), the connection ExceptionListener is fired as a result. > If the ExceptionListener attempts to close the consumers containing Session > or Connection it will currently fail with an javax.jms.IllegalStateException > noting an "Illegal invocation from MessageListener callback". > This happens because the session async dispatch thread is ordinarily not > allowed to call these methods, is in keeping with the impl and their API > definitions. However, in this case it is not firing onMessage at the time but > is rather actually firing onException instead (and has relinquished the > session delivery lock). As such the "Illegal invocation" exception is > incorrect and the thread calling those operations should be permitted during > this scenario. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org