[jira] [Commented] (DISPATCH-1902) qdr_link_complete_sent_message fails to update delivery work value
[ https://issues.apache.org/jira/browse/DISPATCH-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254578#comment-17254578 ] ASF GitHub Bot commented on DISPATCH-1902: -- codecov-io commented on pull request #968: URL: https://github.com/apache/qpid-dispatch/pull/968#issuecomment-750914995 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=h1) Report > Merging [#968](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=desc) (6073e3f) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/99eee5a337393878ca6348f0438e7a46b2d7a8bc?el=desc) (99eee5a) will **decrease** coverage by `0.00%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=tree) ```diff @@Coverage Diff @@ ## master #968 +/- ## == - Coverage 78.86% 78.85% -0.01% == Files 110 110 Lines 2838928400 +11 == + Hits2238922395 +6 - Misses 6000 6005 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.70% <0.00%> (+0.23%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `86.46% <0.00%> (-1.52%)` | :arrow_down: | | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `90.32% <0.00%> (-1.08%)` | :arrow_down: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `80.11% <0.00%> (-0.58%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `86.84% <0.00%> (-0.20%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.60% <0.00%> (-0.19%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=footer). Last update [99eee5a...6073e3f](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdr_link_complete_sent_message fails to update delivery work value > -- > > Key: DISPATCH-1902 > URL: https://issues.apache.org/jira/browse/DISPATCH-1902 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.15.0 > > > When a delivery is sent the associate link_work entry must have its value > decremented and removed if the value becomes zero. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail:
[GitHub] [qpid-dispatch] codecov-io commented on pull request #968: DISPATCH-1902: qdr_link_complete_sent_message update delivery link_wo…
codecov-io commented on pull request #968: URL: https://github.com/apache/qpid-dispatch/pull/968#issuecomment-750914995 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=h1) Report > Merging [#968](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=desc) (6073e3f) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/99eee5a337393878ca6348f0438e7a46b2d7a8bc?el=desc) (99eee5a) will **decrease** coverage by `0.00%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=tree) ```diff @@Coverage Diff @@ ## master #968 +/- ## == - Coverage 78.86% 78.85% -0.01% == Files 110 110 Lines 2838928400 +11 == + Hits2238922395 +6 - Misses 6000 6005 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.70% <0.00%> (+0.23%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `86.46% <0.00%> (-1.52%)` | :arrow_down: | | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `90.32% <0.00%> (-1.08%)` | :arrow_down: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `80.11% <0.00%> (-0.58%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `86.84% <0.00%> (-0.20%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.60% <0.00%> (-0.19%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/968/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=footer). Last update [99eee5a...6073e3f](https://codecov.io/gh/apache/qpid-dispatch/pull/968?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1902) qdr_link_complete_sent_message fails to update delivery work value
[ https://issues.apache.org/jira/browse/DISPATCH-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254570#comment-17254570 ] ASF GitHub Bot commented on DISPATCH-1902: -- kgiusti opened a new pull request #968: URL: https://github.com/apache/qpid-dispatch/pull/968 …rk value This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdr_link_complete_sent_message fails to update delivery work value > -- > > Key: DISPATCH-1902 > URL: https://issues.apache.org/jira/browse/DISPATCH-1902 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.15.0 > > > When a delivery is sent the associate link_work entry must have its value > decremented and removed if the value becomes zero. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #968: DISPATCH-1902: qdr_link_complete_sent_message update delivery link_wo…
kgiusti opened a new pull request #968: URL: https://github.com/apache/qpid-dispatch/pull/968 …rk value This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1902) qdr_link_complete_sent_message fails to update delivery work value
Ken Giusti created DISPATCH-1902: Summary: qdr_link_complete_sent_message fails to update delivery work value Key: DISPATCH-1902 URL: https://issues.apache.org/jira/browse/DISPATCH-1902 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.15.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.15.0 When a delivery is sent the associate link_work entry must have its value decremented and removed if the value becomes zero. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-2231) Assertion fail on macOS with libuv in c-threaderciser test
[
https://issues.apache.org/jira/browse/PROTON-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254516#comment-17254516
]
Roddie Kieley edited comment on PROTON-2231 at 12/24/20, 12:11 PM:
---
I've now tested in the same way on both an 8 core atom Fedora 32 box as well as
the 6 core macOS box. The behaviour with libuv is broken on both while the
epoll proactor implementation on the Fedora 32 box is well behaved every run.
Looking more closely at libuv we see that the problem behaviours, i.e. stopping
new listening, hanging on exit, or asserting as per the description, appear to
be caused by the fact that at some point in the test execution uv_run does not
return when called in the chain pn_proactor_wait -> leader_lead_lh -> uv_run.
This causes the current leader to not relinquish the lead and the other threads
to be unable to do more work or exit. NOTE that we see this more clearly when
we change the uv_cond_wait call in pn_proactor_wait to un_cond_timedwait for 1
second and observe that the non leader threads dutifully continue to check once
per second rather than blocking while uv_run is blocked and the leader doesn't
change.
Temporarily switching to pn_proactor_get instead of pn_proactor_wait for the
test shows that execution runs successfully until the end when leader_lead_lh
again blocks at uv_run, does not exit, cannot join, and thus the test is still
hung although main test execution behaviour appears correct. If we add a
uv_loop_alive check before the uv_run this check passes, i.e. returns != 0, and
uv_run continues to cause the problem.
As the libuv documentation says that for
[UV_RUN_ONCE|http://docs.libuv.org/en/v1.x/loop.html]
{quote}Note that this function blocks if there are no pending callbacks.
{quote}
Further investigation will be along those lines, however suggestions welcome
[~astitcher] or [~cliffjansen].
was (Author: rkieley):
I've now tested in the same way on both an 8 core atom Fedora 32 box as well as
the 6 core macOS box. The behaviour with libuv is broken on both while the
epoll proactor implementation on the Fedora 32 box is well behaved every run.
Looking more closely at libuv we see that the problem behaviours, i.e. stopping
new listening, hanging on exit, or asserting as per the description, appear to
be caused by the fact that at some point in the test execution uv_run does not
return when called in the chain pn_proactor_wait -> leader_lead_lh -> uv_run.
This causes the current leader to not relinquish the lead and the other threads
to be unable to do more work or exit.
Temporarily switching to pn_proactor_get instead of pn_proactor_wait for the
test shows that execution runs successfully until the end when leader_lead_lh
again blocks at uv_run, does not exit, cannot join, and thus the test is still
hung although main test execution behaviour appears correct. If we add a
uv_loop_alive check before the uv_run this check passes, i.e. returns != 0, and
uv_run continues to cause the problem.
As the libuv documentation says that for
[UV_RUN_ONCE|http://docs.libuv.org/en/v1.x/loop.html]
{quote}Note that this function blocks if there are no pending callbacks.
{quote}
Further investigation will be along those lines, however suggestions welcome
[~astitcher] or [~cliffjansen].
> Assertion fail on macOS with libuv in c-threaderciser test
> --
>
> Key: PROTON-2231
> URL: https://issues.apache.org/jira/browse/PROTON-2231
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.32.0
>Reporter: Jiri Daněk
>Assignee: Roddie Kieley
>Priority: Major
> Labels: freebsd, macOS
>
> As described on PROTON-2225, the test fails with assertion error. It is
> currently disabled on macOS for this reason (in .travis.yml).
> {noformat}
> 6: Test command: /usr/local/opt/python/libexec/bin/python
> "/Users/travis/build/jiridanek/qpid-proton/scripts/env.py" "--"
> "/Users/travis/build/jiridanek/qpid-proton/build/c/tests/c-threaderciser"
> 6: Test timeout computed to be: 1500
> 6: threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> 6: Assertion failed: (p->active > 0), function remove_active_lh, file
> /Users/travis/build/jiridanek/qpid-proton/c/src/proactor/libuv.c, line 392.
> 6/31 Test #6: c-threaderciser ..***Failed0.18 sec
> {noformat}
> If the test is meant to stay disabled for a longer time, it will have to be
> disabled in CMakeLists.txt, so that users compiling the project do not run it
> accidentally.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe,
[jira] [Commented] (PROTON-2231) Assertion fail on macOS with libuv in c-threaderciser test
[
https://issues.apache.org/jira/browse/PROTON-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254516#comment-17254516
]
Roddie Kieley commented on PROTON-2231:
---
I've now tested in the same way on both an 8 core atom Fedora 32 box as well as
the 6 core macOS box. The behaviour with libuv is broken on both while the
epoll proactor implementation on the Fedora 32 box is well behaved every run.
Looking more closely at libuv we see that the problem behaviours, i.e. stopping
new listening, hanging on exit, or asserting as per the description, appear to
be caused by the fact that at some point in the test execution uv_run does not
return when called in the chain pn_proactor_wait -> leader_lead_lh -> uv_run.
This causes the current leader to not relinquish the lead and the other threads
to be unable to do more work or exit.
Temporarily switching to pn_proactor_get instead of pn_proactor_wait for the
test shows that execution runs successfully until the end when leader_lead_lh
again blocks at uv_run, does not exit, cannot join, and thus the test is still
hung although main test execution behaviour appears correct. If we add a
uv_loop_alive check before the uv_run this check passes, i.e. returns != 0, and
uv_run continues to cause the problem.
As the libuv documentation says that for
[UV_RUN_ONCE|http://docs.libuv.org/en/v1.x/loop.html]
{quote}Note that this function blocks if there are no pending callbacks.
{quote}
Further investigation will be along those lines, however suggestions welcome
[~astitcher] or [~cliffjansen].
> Assertion fail on macOS with libuv in c-threaderciser test
> --
>
> Key: PROTON-2231
> URL: https://issues.apache.org/jira/browse/PROTON-2231
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.32.0
>Reporter: Jiri Daněk
>Assignee: Roddie Kieley
>Priority: Major
> Labels: freebsd, macOS
>
> As described on PROTON-2225, the test fails with assertion error. It is
> currently disabled on macOS for this reason (in .travis.yml).
> {noformat}
> 6: Test command: /usr/local/opt/python/libexec/bin/python
> "/Users/travis/build/jiridanek/qpid-proton/scripts/env.py" "--"
> "/Users/travis/build/jiridanek/qpid-proton/build/c/tests/c-threaderciser"
> 6: Test timeout computed to be: 1500
> 6: threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> 6: Assertion failed: (p->active > 0), function remove_active_lh, file
> /Users/travis/build/jiridanek/qpid-proton/c/src/proactor/libuv.c, line 392.
> 6/31 Test #6: c-threaderciser ..***Failed0.18 sec
> {noformat}
> If the test is meant to stay disabled for a longer time, it will have to be
> disabled in CMakeLists.txt, so that users compiling the project do not run it
> accidentally.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
