[GitHub] [qpid-jms] rreddy13Official commented on pull request #37: QPIDJMS-153-methods to access message/delivery names
rreddy13Official commented on pull request #37: URL: https://github.com/apache/qpid-jms/pull/37#issuecomment-774969728 Changes to solve the below ticket with regard to the reading message/delivery annotations: https://issues.apache.org/jira/browse/QPIDJMS-153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-153) add support for application use of MessageAnnotations and DeliveryAnnotations
[ https://issues.apache.org/jira/browse/QPIDJMS-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280844#comment-17280844 ] ASF GitHub Bot commented on QPIDJMS-153: rreddy13Official commented on pull request #37: URL: https://github.com/apache/qpid-jms/pull/37#issuecomment-774969728 Changes to solve the below ticket with regard to the reading message/delivery annotations: https://issues.apache.org/jira/browse/QPIDJMS-153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add support for application use of MessageAnnotations and DeliveryAnnotations > - > > Key: QPIDJMS-153 > URL: https://issues.apache.org/jira/browse/QPIDJMS-153 > Project: Qpid JMS > Issue Type: New Feature > Components: qpid-jms-client >Reporter: Robbie Gemmell >Priority: Major > > Whilst the client makes use of MessageAnnotations internally for meta-data > relating to JMS semantics, it does not yet support applications making use of > them or DeliveryAnnotations either. > Some prior discussion and impl in the older JMS client may be relevant here, > e.g see QPID-6065 and QPID-6078 plus > http://qpid.2158936.n2.nabble.com/Setting-message-annotations-on-send-in-AMQP-1-0-td7612277.html. > There is an outstanding task to detail behaviour around this for the AMQP > JMS Mapping document also > https://issues.oasis-open.org/browse/AMQPBINDMAP-26. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] ihsinme commented on pull request #295: fix invalid unsigned arithmetic.
ihsinme commented on pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#issuecomment-774978625 it seems to me a decrease in coverage. and the collection error is related to the time limit for the test. not with my changes in the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #295: fix invalid unsigned arithmetic.
jiridanek commented on a change in pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#discussion_r571908931 ## File path: c/src/messenger/store.c ## @@ -421,7 +421,7 @@ int pni_store_update(pni_store_t *store, pn_sequence_t id, pn_status_t status, } } - while (store->hwm - store->lwm > 0 && + while (store->hwm > store->lwm && Review comment: I'd feel safer replacing this with `store->hwm != store->lwm` just to keep the code behavior completely identical. I haven't managed to convince myself that this change is always going to work... Somebody else who actually understands this needs to review as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1013: DISPATCH-1946: Ensure that router schema is presented to json as a string
asfgit closed pull request #1013: URL: https://github.com/apache/qpid-dispatch/pull/1013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1946) [docker] Schema compile fails in ubuntu xenial container
[
https://issues.apache.org/jira/browse/DISPATCH-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1728#comment-1728
]
ASF subversion and git services commented on DISPATCH-1946:
---
Commit e78a18ae77451afc5dda064467f0695a3742fd41 in qpid-dispatch's branch
refs/heads/master from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e78a18a ]
DISPATCH-1946: Ensure that router schema is presented to json as a string
This closes #1013
> [docker] Schema compile fails in ubuntu xenial container
>
>
> Key: DISPATCH-1946
> URL: https://issues.apache.org/jira/browse/DISPATCH-1946
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container, Management Agent
>Affects Versions: 1.14.0
> Environment: Host: Fedora 32 x86_64;
> Docker version 19.03.11, build 42e35e6;
> File dockerfiles/Dockerfile-ubuntu changed: "FROM ubuntu:latest", to use
> "FROM ubuntu:xenial"
>
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
>
> {{ValueError: Invalid schema qdrouter.json: the JSON object must be str, not
> 'bytes'}}
>
> {code:java}
> # make
> [ 1%] Generating schema_enum.h, schema_enum.c
> Run python script '/qpid-dispatch/src/schema_c.py':ValueError: Invalid schema
> qdrouter.json: the JSON object must be str, not 'bytes'
> Traceback (most recent call last):
> File "/qpid-dispatch/python/qpid_dispatch_internal/management/qdrouter.py",
> line 45, in __init__
> super(QdSchema, self).__init__(**json.loads(qd_schema,
> **JSON_LOAD_KWARGS))
> File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
> s.__class__.__name__))
> TypeError: the JSON object must be str, not 'bytes'
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File "/qpid-dispatch/build/tests/run.py", line 132, in
> run_path(sys.argv[0], run_name="__main__")
> File "/qpid-dispatch/build/tests/run.py", line 116, in run_path
> runpy.run_path(file_path, run_name=run_name)
> File "/usr/lib/python3.5/runpy.py", line 254, in run_path
> pkg_name=pkg_name, script_name=fname)
> File "/usr/lib/python3.5/runpy.py", line 96, in _run_module_code
> mod_name, mod_spec, pkg_name, script_name)
> File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
> exec(code, run_globals)
> File "/qpid-dispatch/src/schema_c.py", line 111, in
> Generator()
> File "/qpid-dispatch/src/schema_c.py", line 58, in __init__
> self.schema = QdSchema()
> File "/qpid-dispatch/python/qpid_dispatch_internal/management/qdrouter.py",
> line 47, in __init__
> raise ValueError("Invalid schema qdrouter.json: %s" % e)
> ValueError: Invalid schema qdrouter.json: the JSON object must be str, not
> 'bytes'
> src/CMakeFiles/qpid-dispatch.dir/build.make:71: recipe for target
> 'src/schema_enum.h' failed
> make[2]: *** [src/schema_enum.h] Error 1
> CMakeFiles/Makefile2:981: recipe for target
> 'src/CMakeFiles/qpid-dispatch.dir/all' failed
> make[1]: *** [src/CMakeFiles/qpid-dispatch.dir/all] Error 2
> Makefile:138: recipe for target 'all' failed
> make: *** [all] Error 2
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1946) [docker] Schema compile fails in ubuntu xenial container
[
https://issues.apache.org/jira/browse/DISPATCH-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281112#comment-17281112
]
ASF GitHub Bot commented on DISPATCH-1946:
--
asfgit closed pull request #1013:
URL: https://github.com/apache/qpid-dispatch/pull/1013
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [docker] Schema compile fails in ubuntu xenial container
>
>
> Key: DISPATCH-1946
> URL: https://issues.apache.org/jira/browse/DISPATCH-1946
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container, Management Agent
>Affects Versions: 1.14.0
> Environment: Host: Fedora 32 x86_64;
> Docker version 19.03.11, build 42e35e6;
> File dockerfiles/Dockerfile-ubuntu changed: "FROM ubuntu:latest", to use
> "FROM ubuntu:xenial"
>
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
>
> {{ValueError: Invalid schema qdrouter.json: the JSON object must be str, not
> 'bytes'}}
>
> {code:java}
> # make
> [ 1%] Generating schema_enum.h, schema_enum.c
> Run python script '/qpid-dispatch/src/schema_c.py':ValueError: Invalid schema
> qdrouter.json: the JSON object must be str, not 'bytes'
> Traceback (most recent call last):
> File "/qpid-dispatch/python/qpid_dispatch_internal/management/qdrouter.py",
> line 45, in __init__
> super(QdSchema, self).__init__(**json.loads(qd_schema,
> **JSON_LOAD_KWARGS))
> File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
> s.__class__.__name__))
> TypeError: the JSON object must be str, not 'bytes'
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File "/qpid-dispatch/build/tests/run.py", line 132, in
> run_path(sys.argv[0], run_name="__main__")
> File "/qpid-dispatch/build/tests/run.py", line 116, in run_path
> runpy.run_path(file_path, run_name=run_name)
> File "/usr/lib/python3.5/runpy.py", line 254, in run_path
> pkg_name=pkg_name, script_name=fname)
> File "/usr/lib/python3.5/runpy.py", line 96, in _run_module_code
> mod_name, mod_spec, pkg_name, script_name)
> File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
> exec(code, run_globals)
> File "/qpid-dispatch/src/schema_c.py", line 111, in
> Generator()
> File "/qpid-dispatch/src/schema_c.py", line 58, in __init__
> self.schema = QdSchema()
> File "/qpid-dispatch/python/qpid_dispatch_internal/management/qdrouter.py",
> line 47, in __init__
> raise ValueError("Invalid schema qdrouter.json: %s" % e)
> ValueError: Invalid schema qdrouter.json: the JSON object must be str, not
> 'bytes'
> src/CMakeFiles/qpid-dispatch.dir/build.make:71: recipe for target
> 'src/schema_enum.h' failed
> make[2]: *** [src/schema_enum.h] Error 1
> CMakeFiles/Makefile2:981: recipe for target
> 'src/CMakeFiles/qpid-dispatch.dir/all' failed
> make[1]: *** [src/CMakeFiles/qpid-dispatch.dir/all] Error 2
> Makefile:138: recipe for target 'all' failed
> make: *** [all] Error 2
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1946) [docker] Schema compile fails in ubuntu xenial container
[
https://issues.apache.org/jira/browse/DISPATCH-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles E. Rolke resolved DISPATCH-1946.
Fix Version/s: 1.15.0
Resolution: Fixed
Fixed at e78a18ae
> [docker] Schema compile fails in ubuntu xenial container
>
>
> Key: DISPATCH-1946
> URL: https://issues.apache.org/jira/browse/DISPATCH-1946
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container, Management Agent
>Affects Versions: 1.14.0
> Environment: Host: Fedora 32 x86_64;
> Docker version 19.03.11, build 42e35e6;
> File dockerfiles/Dockerfile-ubuntu changed: "FROM ubuntu:latest", to use
> "FROM ubuntu:xenial"
>
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.15.0
>
>
> {{ValueError: Invalid schema qdrouter.json: the JSON object must be str, not
> 'bytes'}}
>
> {code:java}
> # make
> [ 1%] Generating schema_enum.h, schema_enum.c
> Run python script '/qpid-dispatch/src/schema_c.py':ValueError: Invalid schema
> qdrouter.json: the JSON object must be str, not 'bytes'
> Traceback (most recent call last):
> File "/qpid-dispatch/python/qpid_dispatch_internal/management/qdrouter.py",
> line 45, in __init__
> super(QdSchema, self).__init__(**json.loads(qd_schema,
> **JSON_LOAD_KWARGS))
> File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
> s.__class__.__name__))
> TypeError: the JSON object must be str, not 'bytes'
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File "/qpid-dispatch/build/tests/run.py", line 132, in
> run_path(sys.argv[0], run_name="__main__")
> File "/qpid-dispatch/build/tests/run.py", line 116, in run_path
> runpy.run_path(file_path, run_name=run_name)
> File "/usr/lib/python3.5/runpy.py", line 254, in run_path
> pkg_name=pkg_name, script_name=fname)
> File "/usr/lib/python3.5/runpy.py", line 96, in _run_module_code
> mod_name, mod_spec, pkg_name, script_name)
> File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
> exec(code, run_globals)
> File "/qpid-dispatch/src/schema_c.py", line 111, in
> Generator()
> File "/qpid-dispatch/src/schema_c.py", line 58, in __init__
> self.schema = QdSchema()
> File "/qpid-dispatch/python/qpid_dispatch_internal/management/qdrouter.py",
> line 47, in __init__
> raise ValueError("Invalid schema qdrouter.json: %s" % e)
> ValueError: Invalid schema qdrouter.json: the JSON object must be str, not
> 'bytes'
> src/CMakeFiles/qpid-dispatch.dir/build.make:71: recipe for target
> 'src/schema_enum.h' failed
> make[2]: *** [src/schema_enum.h] Error 1
> CMakeFiles/Makefile2:981: recipe for target
> 'src/CMakeFiles/qpid-dispatch.dir/all' failed
> make[1]: *** [src/CMakeFiles/qpid-dispatch.dir/all] Error 2
> Makefile:138: recipe for target 'all' failed
> make: *** [all] Error 2
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (DISPATCH-1776) HTTP/2 - grpc call causes segfault
[
https://issues.apache.org/jira/browse/DISPATCH-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy reopened DISPATCH-1776:
-
> HTTP/2 - grpc call causes segfault
> --
>
> Key: DISPATCH-1776
> URL: https://issues.apache.org/jira/browse/DISPATCH-1776
> Project: Qpid Dispatch
> Issue Type: Sub-task
> Components: Protocol Adaptors
>Reporter: Gordon Sim
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.15.0
>
>
> Running a simple grpc echo (over http2) through the router causes a segfault.
> To reproduce run router with (you can change the ports if desired, just be
> consistent with the server and client):
> {noformat}
> router {
> mode: interior
> }
> listener {
> host: 0.0.0.0
> port: amqp
> authenticatePeer: no
> saslMechanisms: ANONYMOUS
> }
> httpListener {
> host: 0.0.0.0
> port: 9090
> address: foo
> protocolVersion: HTTP2
> }
> httpConnector {
> host: 127.0.0.1
> port: 8080
> address: foo
> protocolVersion: HTTP2
> }
> log {
> module: HTTP_ADAPTOR
> enable: trace+
> }
> {noformat}
> Then run grpc server with podman (or docker):
> {noformat}
> podman run -it -p8080:9000 quay.io/mhausenblas/yages:0.1.0
> {noformat}
> Then run grpc client, again with podman (or docker):
> {noformat}
> podman run -it --network=host quay.io/mhausenblas/gump:0.1 grpcurl
> --plaintext 127.0.0.1:9090 yages.Echo.Ping
> {noformat}
> I see segfault with following backtrace:
> {noformat}
> Thread 4 "qdrouterd" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffeedb5700 (LWP 3841832)]
> 0x77f4a417 in qd_compose_end_map () at
> /home/gordon/projects/dispatch/src/compose.c:179
> 179 DEQ_INSERT_HEAD(field->fieldStack, comp);
> Missing separate debuginfos, use: dnf debuginfo-install
> cyrus-sasl-lib-2.1.27-2.fc31.x86_64 keyutils-libs-1.6-3.fc31.x86_64
> krb5-libs-1.17-46.fc31.x86_64 libcom_err-1.45.5-1.fc31.x86_64
> libev-4.27-1.fc31.x86_64 libffi-3.1-23.fc31.x86_64
> libnghttp2-1.41.0-1.fc31.x86_64 libselinux-2.9-5.fc31.x86_64
> libuv-1.34.2-1.fc31.x86_64 libwebsockets-3.2.1-1.fc31.x86_64
> libxcrypt-4.4.15-1.fc31.x86_64 openssl-libs-1.1.1d-2.fc31.x86_64
> pcre2-10.34-8.fc31.x86_64 python3-libs-3.7.6-2.fc31.x86_64
> zlib-1.2.11-20.fc31.x86_64
> (gdb) bt
> #0 0x77f4a417 in qd_compose_end_map () at
> /home/gordon/projects/dispatch/src/compose.c:179
> #1 0x77f4008a in on_frame_recv_callback (session=,
> frame=0x64ea70, user_data=0x64a308) at
> /home/gordon/projects/dispatch/src/adaptors/http2/http2_adaptor.c:702
> #2 0x77a8c32e in nghttp2_session_mem_recv () from
> /lib64/libnghttp2.so.14
> #3 0x77f41bdd in handle_incoming_http (conn=0x64a308) at
> /home/gordon/projects/dispatch/src/adaptors/http2/http2_adaptor.h:149
> #4 handle_connection_event (e=, qd_server=,
> context=0x64a308) at
> /home/gordon/projects/dispatch/src/adaptors/http2/http2_adaptor.c:1456
> #5 0x77f933f1 in handle_event_with_context (context=,
> qd_server=, e=) at
> /home/gordon/projects/dispatch/src/server.c:781
> #6 do_handle_raw_connection_event (qd_server=, e= out>) at /home/gordon/projects/dispatch/src/server.c:787
> #7 handle (qd_server=qd_server@entry=0x4371d0, e=e@entry=0x7fffe4000c20,
> pn_conn=pn_conn@entry=0x0, ctx=ctx@entry=0x0) at
> /home/gordon/projects/dispatch/src/server.c:1067
> #8 0x77f942c8 in thread_run (arg=0x4371d0) at
> /home/gordon/projects/dispatch/src/server.c:1099
> #9 0x77e7f4e2 in start_thread () from /lib64/libpthread.so.0
> #10 0x779b46d3 in clone () from /lib64/libc.so.6
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1776) HTTP/2 - grpc call causes segfault
[
https://issues.apache.org/jira/browse/DISPATCH-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1776.
-
Resolution: Fixed
> HTTP/2 - grpc call causes segfault
> --
>
> Key: DISPATCH-1776
> URL: https://issues.apache.org/jira/browse/DISPATCH-1776
> Project: Qpid Dispatch
> Issue Type: Sub-task
> Components: Protocol Adaptors
>Reporter: Gordon Sim
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.15.0
>
>
> Running a simple grpc echo (over http2) through the router causes a segfault.
> To reproduce run router with (you can change the ports if desired, just be
> consistent with the server and client):
> {noformat}
> router {
> mode: interior
> }
> listener {
> host: 0.0.0.0
> port: amqp
> authenticatePeer: no
> saslMechanisms: ANONYMOUS
> }
> httpListener {
> host: 0.0.0.0
> port: 9090
> address: foo
> protocolVersion: HTTP2
> }
> httpConnector {
> host: 127.0.0.1
> port: 8080
> address: foo
> protocolVersion: HTTP2
> }
> log {
> module: HTTP_ADAPTOR
> enable: trace+
> }
> {noformat}
> Then run grpc server with podman (or docker):
> {noformat}
> podman run -it -p8080:9000 quay.io/mhausenblas/yages:0.1.0
> {noformat}
> Then run grpc client, again with podman (or docker):
> {noformat}
> podman run -it --network=host quay.io/mhausenblas/gump:0.1 grpcurl
> --plaintext 127.0.0.1:9090 yages.Echo.Ping
> {noformat}
> I see segfault with following backtrace:
> {noformat}
> Thread 4 "qdrouterd" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffeedb5700 (LWP 3841832)]
> 0x77f4a417 in qd_compose_end_map () at
> /home/gordon/projects/dispatch/src/compose.c:179
> 179 DEQ_INSERT_HEAD(field->fieldStack, comp);
> Missing separate debuginfos, use: dnf debuginfo-install
> cyrus-sasl-lib-2.1.27-2.fc31.x86_64 keyutils-libs-1.6-3.fc31.x86_64
> krb5-libs-1.17-46.fc31.x86_64 libcom_err-1.45.5-1.fc31.x86_64
> libev-4.27-1.fc31.x86_64 libffi-3.1-23.fc31.x86_64
> libnghttp2-1.41.0-1.fc31.x86_64 libselinux-2.9-5.fc31.x86_64
> libuv-1.34.2-1.fc31.x86_64 libwebsockets-3.2.1-1.fc31.x86_64
> libxcrypt-4.4.15-1.fc31.x86_64 openssl-libs-1.1.1d-2.fc31.x86_64
> pcre2-10.34-8.fc31.x86_64 python3-libs-3.7.6-2.fc31.x86_64
> zlib-1.2.11-20.fc31.x86_64
> (gdb) bt
> #0 0x77f4a417 in qd_compose_end_map () at
> /home/gordon/projects/dispatch/src/compose.c:179
> #1 0x77f4008a in on_frame_recv_callback (session=,
> frame=0x64ea70, user_data=0x64a308) at
> /home/gordon/projects/dispatch/src/adaptors/http2/http2_adaptor.c:702
> #2 0x77a8c32e in nghttp2_session_mem_recv () from
> /lib64/libnghttp2.so.14
> #3 0x77f41bdd in handle_incoming_http (conn=0x64a308) at
> /home/gordon/projects/dispatch/src/adaptors/http2/http2_adaptor.h:149
> #4 handle_connection_event (e=, qd_server=,
> context=0x64a308) at
> /home/gordon/projects/dispatch/src/adaptors/http2/http2_adaptor.c:1456
> #5 0x77f933f1 in handle_event_with_context (context=,
> qd_server=, e=) at
> /home/gordon/projects/dispatch/src/server.c:781
> #6 do_handle_raw_connection_event (qd_server=, e= out>) at /home/gordon/projects/dispatch/src/server.c:787
> #7 handle (qd_server=qd_server@entry=0x4371d0, e=e@entry=0x7fffe4000c20,
> pn_conn=pn_conn@entry=0x0, ctx=ctx@entry=0x0) at
> /home/gordon/projects/dispatch/src/server.c:1067
> #8 0x77f942c8 in thread_run (arg=0x4371d0) at
> /home/gordon/projects/dispatch/src/server.c:1099
> #9 0x77e7f4e2 in start_thread () from /lib64/libpthread.so.0
> #10 0x779b46d3 in clone () from /lib64/libc.so.6
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1735) system_tests_management failing on Fedora 32
[
https://issues.apache.org/jira/browse/DISPATCH-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy updated DISPATCH-1735:
Fix Version/s: (was: 1.15.0)
> system_tests_management failing on Fedora 32
>
>
> Key: DISPATCH-1735
> URL: https://issues.apache.org/jira/browse/DISPATCH-1735
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 19: ==
> 19: FAIL: test_dummy (system_tests_management.ManagementTest)
> 19: Test all operations on the dummy test entity
> 19: --
> 19: Traceback (most recent call last):
> 19: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_management.py",
> line 347, in test_dummy
> 19: self.assertEqual(
> 19: AssertionError: {'operation': 'callme', 'type': 'org.apache[58
> chars]tes'} != {'type': 'org.apache.qpid.dispatch.dummy', [57 chars]y/0'}
> 19: - {'data': b'bytes',
> 19: ? -
> 19:
> 19: + {'data': 'bytes',
> 19:'identity': 'dummy/0',
> 19:'operation': 'callme',
> 19:'type': 'org.apache.qpid.dispatch.dummy'}
> 19:
> 19: --
> 19: Ran 21 tests in 9.483s
> 19:
> 19: FAILED (failures=1)
> 1/1 Test #19: system_tests_management ..***Failed9.69 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1909) test_000_stats in system_tests_http2 failing intermittently
[
https://issues.apache.org/jira/browse/DISPATCH-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy updated DISPATCH-1909:
Fix Version/s: (was: 1.15.0)
> test_000_stats in system_tests_http2 failing intermittently
> ---
>
> Key: DISPATCH-1909
> URL: https://issues.apache.org/jira/browse/DISPATCH-1909
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.14.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 68:
> 68: ==
> 68: FAIL: test_000_stats (system_tests_http2.Http2TestOneStandaloneRouter)
> 68: --
> 68: Traceback (most recent call last):
> 68: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 935, in wrap
> 68: return f(*args, **kwargs)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http2.py", line
> 321, in test_000_stats
> 68: self.assertEqual(s.get('requests'), 2)
> 68: AssertionError: 1 != 2
> 68:
> 68: --
> 68: Ran 77 tests in 84.573s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1757) failure in system_tests_edge_router: raise Empty
[
https://issues.apache.org/jira/browse/DISPATCH-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy updated DISPATCH-1757:
Fix Version/s: (was: 1.15.0)
> failure in system_tests_edge_router: raise Empty
>
>
> Key: DISPATCH-1757
> URL: https://issues.apache.org/jira/browse/DISPATCH-1757
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.13.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
>
> This is a rare flaky failure of the test.
> https://travis-ci.com/github/jiridanek/qpid-dispatch/jobs/373299500#L5382
> {noformat}
> test 54
> Start 54: system_tests_edge_router
> 54: Test command: /usr/bin/python
> "/home/travis/build/jiridanek/qpid-dispatch/build/tests/run.py" "-m"
> "unittest" "-v" "system_tests_edge_router"
> 54: Test timeout computed to be: 600
> 54: test_edge_listener_sender_crash_DISPATCH_1492
> (system_tests_edge_router.EdgeListenerSender) ... ok
> 54: test_01_active_flag (system_tests_edge_router.EdgeRouterTest) ... ok
> 54:
> 54: Router EA1 debug dump file:
> 54:
> 54: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 2
> 54: Leak: 2020-08-18 19:55:39.587954 + type: qd_timer_t address: 0xfee050
> (suppressed)
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x306)
> [0x7fa83c242870]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(new_qd_timer_t+0x38)
> [0x7fa83c3059d4]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_timer+0x2b)
> [0x7fa83c305ff7]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_server_connector+0x173)
> [0x7fa83c30506e]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_dispatch_configure_connector+0x3e)
> [0x7fa83c24f29c]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call_unix64+0x4c)
> [0x7fa838d98e40]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call+0x2eb) [0x7fa838d988ab]
> 54:
> /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(_ctypes_callproc+0x48f)
> [0x7fa838fa83df]
> 54: /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(+0x11d82)
> [0x7fa838facd82]
> 54: /usr/lib/x86_64-linux-gnu/libpython2.7.so.1.0(PyObject_Call+0x43)
> [0x7fa83af3a2b3]
> 54:
> 54: Leak: 2020-08-18 19:55:39.588979 + type: qd_timer_t address: 0xfeded0
> (suppressed)
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x306)
> [0x7fa83c242870]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(new_qd_timer_t+0x38)
> [0x7fa83c3059d4]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_timer+0x2b)
> [0x7fa83c305ff7]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_server_connector+0x173)
> [0x7fa83c30506e]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_dispatch_configure_connector+0x3e)
> [0x7fa83c24f29c]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call_unix64+0x4c)
> [0x7fa838d98e40]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call+0x2eb) [0x7fa838d988ab]
> 54:
> /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(_ctypes_callproc+0x48f)
> [0x7fa838fa83df]
> 54: /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(+0x11d82)
> [0x7fa838facd82]
> 54: /usr/lib/x86_64-linux-gnu/libpython2.7.so.1.0(PyObject_Call+0x43)
> [0x7fa83af3a2b3]
> 54:
> 54: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 2
> 54: Leak: 2020-08-18 19:55:39.587950 + type: qd_connector_t address:
> 0x10c2390 (suppressed)
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x842)
> [0x7fa83c242dac]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(new_qd_connector_t+0x38)
> [0x7fa83c2fb8fe]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_server_connector+0x23)
> [0x7fa83c304f1e]
> 54:
> /home/travis/build/jiridanek/qpid-dispatch/build/src/libqpid-dispatch.so(qd_dispatch_configure_connector+0x3e)
> [0x7fa83c24f29c]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call_unix64+0x4c)
> [0x7fa838d98e40]
> 54: /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call+0x2eb) [0x7fa838d988ab]
> 54:
> /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(_ctypes_callproc+0x48f)
> [0x7fa838fa83df]
> 54: /usr/lib/python2.7/lib-dynload/_ctypes.x86_64-linux-gnu.so(+0x11d82)
> [0x7fa838facd82]
> 54: /usr/lib/x86_64-linux-gnu/libpython2.7.so.1.0(PyObject_Call+0x43)
> [0x7fa83af3a2b3]
> 54: /usr/lib/x86_64-linux-gnu/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x543c)
> [0x7fa83aed839c]
> 54:
> 54: Leak: 20
[GitHub] [qpid-proton] astitcher commented on a change in pull request #295: fix invalid unsigned arithmetic.
astitcher commented on a change in pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#discussion_r572213601 ## File path: c/src/messenger/store.c ## @@ -421,7 +421,7 @@ int pni_store_update(pni_store_t *store, pn_sequence_t id, pn_status_t status, } } - while (store->hwm - store->lwm > 0 && + while (store->hwm > store->lwm && Review comment: See my comment - the change is incorrect. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher closed pull request #295: fix invalid unsigned arithmetic.
astitcher closed pull request #295: URL: https://github.com/apache/qpid-proton/pull/295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] ihsinme commented on pull request #295: fix invalid unsigned arithmetic.
ihsinme commented on pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#issuecomment-775318072 it seems to me a practical example that will help to understand why I proposed changes. ```cpp unsigned long A; // A= 70; (A - 11) = 59; true // A= 11; (A - 11) = 0; false // A= 1; (A - 11) = 18446744073709551607; true // A= 0; (A - 11) = 18446744073709551606; true if (A - 11 > 0) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #295: fix invalid unsigned arithmetic.
astitcher commented on pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#issuecomment-775323966 > it seems to me a practical example that will help to understand why I proposed changes. > > ```c++ > unsigned long A; > > // A= 70; (A - 11) = 59; true > // A= 11; (A - 11) = 0; false > // A= 1; (A - 11) = 18446744073709551607; true > // A= 0; (A - 11) = 18446744073709551606; true > if (A - 11 > 0) > ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #295: fix invalid unsigned arithmetic.
astitcher commented on pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#issuecomment-775332803 Apologies, you are correct that the test is useless and will always return true, due to the unsigned. But your fix is incorrect because it fails to understand the intent of the test! The test is attempting to make sure that the hwm is ahead of the lwm, but if the lwm is (for a 16 bit example)at 0x and the hwm is at 0x0003 then the test should indeed be true (because of the wrapping nature of the buffer), but in your 'fix' it will be false. I think the correct test is something like hwm-lwm < 0x8000 (in the 16 bit case). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher edited a comment on pull request #295: fix invalid unsigned arithmetic.
astitcher edited a comment on pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#issuecomment-775332803 Apologies, you are correct that the test is useless and will always return true, due to the unsigned. But your fix is incorrect because it fails to understand the intent of the test! The test is attempting to make sure that the hwm is ahead of the lwm, but if the lwm is (for a 16 bit example)at 0x and the hwm is at 0x0003 then the test should indeed be true (because of the wrapping nature of the buffer), but in your 'fix' it will be false. I think the correct test is something like hwm-lwm >0 && hwm-lwm< 0x8000 (in the 16 bit case). [Edit to fix the proposed correct test] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] ihsinme commented on pull request #295: fix invalid unsigned arithmetic.
ihsinme commented on pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#issuecomment-775345261 It’s more and more difficult for me to understand what confuses you. we're talking about `typedef uint32_t pn_sequence_t;`. while it will work as written if `lwm = 0x` and `hwm = 0x3` then `lwm> hwm`. if you are talking about the inaccuracy of the initial check, then explain it in more detail. because `hwm-lwm <0x8000` is generally dangerous in my opinion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1940) Router HTTP2 adaptor should pass h2spec
[
https://issues.apache.org/jira/browse/DISPATCH-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti reassigned DISPATCH-1940:
Assignee: Ken Giusti
> Router HTTP2 adaptor should pass h2spec
> ---
>
> Key: DISPATCH-1940
> URL: https://issues.apache.org/jira/browse/DISPATCH-1940
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Labels: crash
> Attachments: h2spec.conf
>
>
> h2spec (https://github.com/summerwind/h2spec) is a HTTP/2 conformance
> checker, mentioned in
> https://blog.cloudflare.com/tools-for-debugging-testing-and-using-http-2
> Running h2spec against nghttpd directly produces only one failure
> {noformat}
> Failures:
> Hypertext Transfer Protocol Version 2 (HTTP/2)
> 5. Streams and Multiplexing
> 5.1. Stream States
> 5.1.1. Stream Identifiers
> using source address 127.0.0.1:53110
> × 2: Sends stream identifier that is numerically smaller than previous
> -> The endpoint MUST respond with a connection error of type
> PROTOCOL_ERROR.
> Expected: GOAWAY Frame (Error Code: PROTOCOL_ERROR)
>Connection closed
>Actual: DATA Frame (length:147, flags:0x01, stream_id:5)
> {noformat}
> When Dispatch is put in between, it fails a few first checks, then dispatch
> crashes
> {code}
> $ wget
> https://github.com/summerwind/h2spec/releases/download/v2.6.0/h2spec_linux_amd64.tar.gz
> $ nghttpd --no-tls -D -d /tmp
> $ qdrouterd -c h2spec.conf
> $ ./h2spec -p 24162
> {code}
> I get the following result every time I run the above commands
> {noformat}
> 2. Streams and Multiplexing
> ✔ 1: Sends a PRIORITY frame on idle stream
> using source address 127.0.0.1:35814half-closed (remote) stream
> × 2: Sends a WINDOW_UPDATE frame on half-closed (remote) stream
> -> The endpoint MUST accept WINDOW_UPDATE frame.
> Expected: DATA frame
>Actual: HEADERS Frame (length:69, flags:0x04, stream_id:1)
> using source address 127.0.0.1:35816closed (remote) stream
> × 3: Sends a PRIORITY frame on half-closed (remote) stream
> -> The endpoint MUST accept PRIORITY frame.
> Expected: DATA frame
>Actual: HEADERS Frame (length:69, flags:0x04, stream_id:1)
> ✔ 4: Sends a RST_STREAM frame on half-closed (remote) stream
> ✔ 5: Sends a PRIORITY frame on closed stream
> {noformat}
> {noformat}
> 3.8. GOAWAY
> using source address 127.0.0.1:35850
> × 1: Sends a GOAWAY frame
> -> The endpoint MUST accept GOAWAY frame.
>Expected: Connection closed
> PING Frame (length:8, flags:0x01, stream_id:0,
> opaque_data:h2spec)
> Actual: Timeout
> {noformat}
> {noformat}
> 4. HTTP Message Exchanges
> ✔ 1: Sends a GET request
> ✔ 2: Sends a HEAD request
> ✔ 3: Sends a POST request
> using source address 127.0.0.1:35866ers
> × 4: Sends a POST request with trailers
> -> The endpoint MUST respond to the request.
> Expected: HEADERS Frame (stream_id:1)
>Actual: Connection closed
> {noformat}
> {noformat}
> 5. HPACK
> × 1: Sends a indexed header field representation
> 2021-01-31 13:26:25.042679 +0100 ROUTER_CORE (trace) Core action
> 'link_first_attach' (../src/router_core/router_core_thread.c:238)
> 2021-01-31 13:26:25.042912 +0100 ROUTER_CORE (info) [C31][L95] Link attached:
> dir=out source={(dyn) expire:link} target={ expire:link}
> (../src/router_core/connections.c:1812)
> 2021-01-31 13:26:25.042983 +0100 HTTP_ADAPTOR (trace) [C31] Activation
> triggered, calling pn_raw_connection_wake()
> (../src/adaptors/http2/http2_adaptor.c:1524)
> ../src/router_core/delivery.c:109:19: runtime error: member access within
> null pointer of type 'struct qdr_delivery_t'
> AddressSanitizer:DEADLYSIGNAL
> =
> ==567==ERROR: AddressSanitizer: SEGV on unknown address 0x0018 (pc
> 0x7fb3080acb9b bp 0x7fff063b3ea0 sp 0x7fff063b3e90 T0)
> ==567==The signal is caused by a WRITE memory access.
> ==567==Hint: address points to the zero page.
> #0 0x7fb3080acb9b in sys_atomic_add ../include/qpid/dispatch/atomic.h:80
> #1 0x7fb3080acc86 in sys_atomic_inc ../include/qpid/dispatch/atomic.h:209
> #2 0x7fb3080ad65f in qdr_delivery_incref ../src/router_core/delivery.c:109
> #3 0x7fb3080aeaa4 in qdr_delivery_continue
> ../src/router_core/delivery.c:220
> #4 0x7fb3081e69e2 in on_frame_recv_callback
> ../src/adaptors/http2/http2_adaptor.c:988
> #5 0x7fb307535d4d in nghttp2_session_mem_recv
> (/nix/store/1blnfglp53fsrd8rjmrcql18k9hdi
[jira] [Assigned] (DISPATCH-1941) Crash in HTTP1 adaptor: member access within null pointer of type 'const struct qd_buffer_t'
[
https://issues.apache.org/jira/browse/DISPATCH-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti reassigned DISPATCH-1941:
Assignee: Ken Giusti
> Crash in HTTP1 adaptor: member access within null pointer of type 'const
> struct qd_buffer_t'
>
>
> Key: DISPATCH-1941
> URL: https://issues.apache.org/jira/browse/DISPATCH-1941
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Labels: crash
>
> https://github.com/jiridanek/qpid-dispatch/runs/1801886361?check_suite_focus=true#step:9:1844
> {noformat}
> ../include/qpid/dispatch/buffer.h:83:44: runtime error: member access within
> null pointer of type 'const struct qd_buffer_t'
> AddressSanitizer:DEADLYSIGNAL
> =
> ==31711==ERROR: AddressSanitizer: SEGV on unknown address 0x0010 (pc
> 0x7fb51d73dd10 bp 0x7fb50883e7b0 sp 0x7fb50883e790 T4)
> ==31711==The signal is caused by a READ memory access.
> ==31711==Hint: address points to the zero page.
> #0 0x7fb51d73dd10 in qd_buffer_cursor ../include/qpid/dispatch/buffer.h:83
> #1 0x7fb51d741af7 in ensure_outgoing_capacity
> ../src/adaptors/http1/http1_codec.c:346
> #2 0x7fb51d741bbd in write_string ../src/adaptors/http1/http1_codec.c:356
> #3 0x7fb51d753cf3 in h1_codec_tx_request
> ../src/adaptors/http1/http1_codec.c:1448
> #4 0x7fb51d79435a in _send_request_headers
> ../src/adaptors/http1/http1_server.c:1291
> #5 0x7fb51d795193 in _encode_request_message
> ../src/adaptors/http1/http1_server.c:1369
> #6 0x7fb51d79671b in _send_request_message
> ../src/adaptors/http1/http1_server.c:1431
> #7 0x7fb51d7973e7 in qdr_http1_server_core_link_deliver
> ../src/adaptors/http1/http1_server.c:1505
> #8 0x7fb51d761042 in _core_link_deliver
> ../src/adaptors/http1/http1_adaptor.c:569
> #9 0x7fb51d96fc71 in qdr_link_process_deliveries
> ../src/router_core/transfer.c:176
> #10 0x7fb51d760d1b in _core_link_push
> ../src/adaptors/http1/http1_adaptor.c:550
> #11 0x7fb51d8ab61e in qdr_connection_process
> ../src/router_core/connections.c:412
> #12 0x7fb51d786664 in _do_reconnect
> ../src/adaptors/http1/http1_server.c:417
> #13 0x7fb51d9f701a in qd_timer_visit ../src/timer.c:201
> #14 0x7fb51d9e59c5 in handle ../src/server.c:1008
> #15 0x7fb51d9e764d in thread_run ../src/server.c:1122
> #16 0x7fb51d87006f in _thread_init ../src/posix/threading.c:172
> #17 0x7fb51d18beac in start_thread
> (/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libpthread.so.0+0x7eac)
> #18 0x7fb51c327d2e in __GI___clone
> (/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libc.so.6+0xf7d2e)
> AddressSanitizer can not provide additional info.
> SUMMARY: AddressSanitizer: SEGV ../include/qpid/dispatch/buffer.h:83 in
> qd_buffer_cursor
> Thread T4 created by T0 here:
> #0 0x7fb51e1a22a2 in __interceptor_pthread_create
> (/nix/store/9f76hk7scn4lll0rc7da0rixhgc8r28a-gcc-10.2.0-lib/lib/libasan.so.6+0x582a2)
> #1 0x7fb51d8701da in sys_thread ../src/posix/threading.c:181
> #2 0x7fb51d9ee89d in qd_server_run ../src/server.c:1482
> #3 0x4026e4 in main_process ../router/src/main.c:113
> #4 0x404564 in main ../router/src/main.c:367
> #5 0x7fb51c253c7c in __libc_start_main
> (/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libc.so.6+0x23c7c)
> ==31711==ABORTING
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1940) Router HTTP2 adaptor should pass h2spec
[
https://issues.apache.org/jira/browse/DISPATCH-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti reassigned DISPATCH-1940:
Assignee: Ganesh Murthy (was: Ken Giusti)
> Router HTTP2 adaptor should pass h2spec
> ---
>
> Key: DISPATCH-1940
> URL: https://issues.apache.org/jira/browse/DISPATCH-1940
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Labels: crash
> Attachments: h2spec.conf
>
>
> h2spec (https://github.com/summerwind/h2spec) is a HTTP/2 conformance
> checker, mentioned in
> https://blog.cloudflare.com/tools-for-debugging-testing-and-using-http-2
> Running h2spec against nghttpd directly produces only one failure
> {noformat}
> Failures:
> Hypertext Transfer Protocol Version 2 (HTTP/2)
> 5. Streams and Multiplexing
> 5.1. Stream States
> 5.1.1. Stream Identifiers
> using source address 127.0.0.1:53110
> × 2: Sends stream identifier that is numerically smaller than previous
> -> The endpoint MUST respond with a connection error of type
> PROTOCOL_ERROR.
> Expected: GOAWAY Frame (Error Code: PROTOCOL_ERROR)
>Connection closed
>Actual: DATA Frame (length:147, flags:0x01, stream_id:5)
> {noformat}
> When Dispatch is put in between, it fails a few first checks, then dispatch
> crashes
> {code}
> $ wget
> https://github.com/summerwind/h2spec/releases/download/v2.6.0/h2spec_linux_amd64.tar.gz
> $ nghttpd --no-tls -D -d /tmp
> $ qdrouterd -c h2spec.conf
> $ ./h2spec -p 24162
> {code}
> I get the following result every time I run the above commands
> {noformat}
> 2. Streams and Multiplexing
> ✔ 1: Sends a PRIORITY frame on idle stream
> using source address 127.0.0.1:35814half-closed (remote) stream
> × 2: Sends a WINDOW_UPDATE frame on half-closed (remote) stream
> -> The endpoint MUST accept WINDOW_UPDATE frame.
> Expected: DATA frame
>Actual: HEADERS Frame (length:69, flags:0x04, stream_id:1)
> using source address 127.0.0.1:35816closed (remote) stream
> × 3: Sends a PRIORITY frame on half-closed (remote) stream
> -> The endpoint MUST accept PRIORITY frame.
> Expected: DATA frame
>Actual: HEADERS Frame (length:69, flags:0x04, stream_id:1)
> ✔ 4: Sends a RST_STREAM frame on half-closed (remote) stream
> ✔ 5: Sends a PRIORITY frame on closed stream
> {noformat}
> {noformat}
> 3.8. GOAWAY
> using source address 127.0.0.1:35850
> × 1: Sends a GOAWAY frame
> -> The endpoint MUST accept GOAWAY frame.
>Expected: Connection closed
> PING Frame (length:8, flags:0x01, stream_id:0,
> opaque_data:h2spec)
> Actual: Timeout
> {noformat}
> {noformat}
> 4. HTTP Message Exchanges
> ✔ 1: Sends a GET request
> ✔ 2: Sends a HEAD request
> ✔ 3: Sends a POST request
> using source address 127.0.0.1:35866ers
> × 4: Sends a POST request with trailers
> -> The endpoint MUST respond to the request.
> Expected: HEADERS Frame (stream_id:1)
>Actual: Connection closed
> {noformat}
> {noformat}
> 5. HPACK
> × 1: Sends a indexed header field representation
> 2021-01-31 13:26:25.042679 +0100 ROUTER_CORE (trace) Core action
> 'link_first_attach' (../src/router_core/router_core_thread.c:238)
> 2021-01-31 13:26:25.042912 +0100 ROUTER_CORE (info) [C31][L95] Link attached:
> dir=out source={(dyn) expire:link} target={ expire:link}
> (../src/router_core/connections.c:1812)
> 2021-01-31 13:26:25.042983 +0100 HTTP_ADAPTOR (trace) [C31] Activation
> triggered, calling pn_raw_connection_wake()
> (../src/adaptors/http2/http2_adaptor.c:1524)
> ../src/router_core/delivery.c:109:19: runtime error: member access within
> null pointer of type 'struct qdr_delivery_t'
> AddressSanitizer:DEADLYSIGNAL
> =
> ==567==ERROR: AddressSanitizer: SEGV on unknown address 0x0018 (pc
> 0x7fb3080acb9b bp 0x7fff063b3ea0 sp 0x7fff063b3e90 T0)
> ==567==The signal is caused by a WRITE memory access.
> ==567==Hint: address points to the zero page.
> #0 0x7fb3080acb9b in sys_atomic_add ../include/qpid/dispatch/atomic.h:80
> #1 0x7fb3080acc86 in sys_atomic_inc ../include/qpid/dispatch/atomic.h:209
> #2 0x7fb3080ad65f in qdr_delivery_incref ../src/router_core/delivery.c:109
> #3 0x7fb3080aeaa4 in qdr_delivery_continue
> ../src/router_core/delivery.c:220
> #4 0x7fb3081e69e2 in on_frame_recv_callback
> ../src/adaptors/http2/http2_adaptor.c:988
> #5 0x7fb307535d4d in nghttp2_session_mem_recv
> (/nix/store/1bln
[jira] [Updated] (DISPATCH-1941) Crash in HTTP1 adaptor: member access within null pointer of type 'const struct qd_buffer_t'
[
https://issues.apache.org/jira/browse/DISPATCH-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated DISPATCH-1941:
-
Fix Version/s: 1.16.0
> Crash in HTTP1 adaptor: member access within null pointer of type 'const
> struct qd_buffer_t'
>
>
> Key: DISPATCH-1941
> URL: https://issues.apache.org/jira/browse/DISPATCH-1941
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Labels: crash
> Fix For: 1.16.0
>
>
> https://github.com/jiridanek/qpid-dispatch/runs/1801886361?check_suite_focus=true#step:9:1844
> {noformat}
> ../include/qpid/dispatch/buffer.h:83:44: runtime error: member access within
> null pointer of type 'const struct qd_buffer_t'
> AddressSanitizer:DEADLYSIGNAL
> =
> ==31711==ERROR: AddressSanitizer: SEGV on unknown address 0x0010 (pc
> 0x7fb51d73dd10 bp 0x7fb50883e7b0 sp 0x7fb50883e790 T4)
> ==31711==The signal is caused by a READ memory access.
> ==31711==Hint: address points to the zero page.
> #0 0x7fb51d73dd10 in qd_buffer_cursor ../include/qpid/dispatch/buffer.h:83
> #1 0x7fb51d741af7 in ensure_outgoing_capacity
> ../src/adaptors/http1/http1_codec.c:346
> #2 0x7fb51d741bbd in write_string ../src/adaptors/http1/http1_codec.c:356
> #3 0x7fb51d753cf3 in h1_codec_tx_request
> ../src/adaptors/http1/http1_codec.c:1448
> #4 0x7fb51d79435a in _send_request_headers
> ../src/adaptors/http1/http1_server.c:1291
> #5 0x7fb51d795193 in _encode_request_message
> ../src/adaptors/http1/http1_server.c:1369
> #6 0x7fb51d79671b in _send_request_message
> ../src/adaptors/http1/http1_server.c:1431
> #7 0x7fb51d7973e7 in qdr_http1_server_core_link_deliver
> ../src/adaptors/http1/http1_server.c:1505
> #8 0x7fb51d761042 in _core_link_deliver
> ../src/adaptors/http1/http1_adaptor.c:569
> #9 0x7fb51d96fc71 in qdr_link_process_deliveries
> ../src/router_core/transfer.c:176
> #10 0x7fb51d760d1b in _core_link_push
> ../src/adaptors/http1/http1_adaptor.c:550
> #11 0x7fb51d8ab61e in qdr_connection_process
> ../src/router_core/connections.c:412
> #12 0x7fb51d786664 in _do_reconnect
> ../src/adaptors/http1/http1_server.c:417
> #13 0x7fb51d9f701a in qd_timer_visit ../src/timer.c:201
> #14 0x7fb51d9e59c5 in handle ../src/server.c:1008
> #15 0x7fb51d9e764d in thread_run ../src/server.c:1122
> #16 0x7fb51d87006f in _thread_init ../src/posix/threading.c:172
> #17 0x7fb51d18beac in start_thread
> (/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libpthread.so.0+0x7eac)
> #18 0x7fb51c327d2e in __GI___clone
> (/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libc.so.6+0xf7d2e)
> AddressSanitizer can not provide additional info.
> SUMMARY: AddressSanitizer: SEGV ../include/qpid/dispatch/buffer.h:83 in
> qd_buffer_cursor
> Thread T4 created by T0 here:
> #0 0x7fb51e1a22a2 in __interceptor_pthread_create
> (/nix/store/9f76hk7scn4lll0rc7da0rixhgc8r28a-gcc-10.2.0-lib/lib/libasan.so.6+0x582a2)
> #1 0x7fb51d8701da in sys_thread ../src/posix/threading.c:181
> #2 0x7fb51d9ee89d in qd_server_run ../src/server.c:1482
> #3 0x4026e4 in main_process ../router/src/main.c:113
> #4 0x404564 in main ../router/src/main.c:367
> #5 0x7fb51c253c7c in __libc_start_main
> (/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libc.so.6+0x23c7c)
> ==31711==ABORTING
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1022: DISPATCH-1941: fix http1 parser to detect null characters
kgiusti opened a new pull request #1022: URL: https://github.com/apache/qpid-dispatch/pull/1022 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1941) Crash in HTTP1 adaptor: member access within null pointer of type 'const struct qd_buffer_t'
[
https://issues.apache.org/jira/browse/DISPATCH-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281280#comment-17281280
]
ASF GitHub Bot commented on DISPATCH-1941:
--
kgiusti opened a new pull request #1022:
URL: https://github.com/apache/qpid-dispatch/pull/1022
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Crash in HTTP1 adaptor: member access within null pointer of type 'const
> struct qd_buffer_t'
>
>
> Key: DISPATCH-1941
> URL: https://issues.apache.org/jira/browse/DISPATCH-1941
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Labels: crash
> Fix For: 1.16.0
>
>
> https://github.com/jiridanek/qpid-dispatch/runs/1801886361?check_suite_focus=true#step:9:1844
> {noformat}
> ../include/qpid/dispatch/buffer.h:83:44: runtime error: member access within
> null pointer of type 'const struct qd_buffer_t'
> AddressSanitizer:DEADLYSIGNAL
> =
> ==31711==ERROR: AddressSanitizer: SEGV on unknown address 0x0010 (pc
> 0x7fb51d73dd10 bp 0x7fb50883e7b0 sp 0x7fb50883e790 T4)
> ==31711==The signal is caused by a READ memory access.
> ==31711==Hint: address points to the zero page.
> #0 0x7fb51d73dd10 in qd_buffer_cursor ../include/qpid/dispatch/buffer.h:83
> #1 0x7fb51d741af7 in ensure_outgoing_capacity
> ../src/adaptors/http1/http1_codec.c:346
> #2 0x7fb51d741bbd in write_string ../src/adaptors/http1/http1_codec.c:356
> #3 0x7fb51d753cf3 in h1_codec_tx_request
> ../src/adaptors/http1/http1_codec.c:1448
> #4 0x7fb51d79435a in _send_request_headers
> ../src/adaptors/http1/http1_server.c:1291
> #5 0x7fb51d795193 in _encode_request_message
> ../src/adaptors/http1/http1_server.c:1369
> #6 0x7fb51d79671b in _send_request_message
> ../src/adaptors/http1/http1_server.c:1431
> #7 0x7fb51d7973e7 in qdr_http1_server_core_link_deliver
> ../src/adaptors/http1/http1_server.c:1505
> #8 0x7fb51d761042 in _core_link_deliver
> ../src/adaptors/http1/http1_adaptor.c:569
> #9 0x7fb51d96fc71 in qdr_link_process_deliveries
> ../src/router_core/transfer.c:176
> #10 0x7fb51d760d1b in _core_link_push
> ../src/adaptors/http1/http1_adaptor.c:550
> #11 0x7fb51d8ab61e in qdr_connection_process
> ../src/router_core/connections.c:412
> #12 0x7fb51d786664 in _do_reconnect
> ../src/adaptors/http1/http1_server.c:417
> #13 0x7fb51d9f701a in qd_timer_visit ../src/timer.c:201
> #14 0x7fb51d9e59c5 in handle ../src/server.c:1008
> #15 0x7fb51d9e764d in thread_run ../src/server.c:1122
> #16 0x7fb51d87006f in _thread_init ../src/posix/threading.c:172
> #17 0x7fb51d18beac in start_thread
> (/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libpthread.so.0+0x7eac)
> #18 0x7fb51c327d2e in __GI___clone
> (/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libc.so.6+0xf7d2e)
> AddressSanitizer can not provide additional info.
> SUMMARY: AddressSanitizer: SEGV ../include/qpid/dispatch/buffer.h:83 in
> qd_buffer_cursor
> Thread T4 created by T0 here:
> #0 0x7fb51e1a22a2 in __interceptor_pthread_create
> (/nix/store/9f76hk7scn4lll0rc7da0rixhgc8r28a-gcc-10.2.0-lib/lib/libasan.so.6+0x582a2)
> #1 0x7fb51d8701da in sys_thread ../src/posix/threading.c:181
> #2 0x7fb51d9ee89d in qd_server_run ../src/server.c:1482
> #3 0x4026e4 in main_process ../router/src/main.c:113
> #4 0x404564 in main ../router/src/main.c:367
> #5 0x7fb51c253c7c in __libc_start_main
> (/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libc.so.6+0x23c7c)
> ==31711==ABORTING
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on pull request #1022: DISPATCH-1941: fix http1 parser to detect null characters
codecov-io commented on pull request #1022: URL: https://github.com/apache/qpid-dispatch/pull/1022#issuecomment-775367687 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=h1) Report > Merging [#1022](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=desc) (474244c) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/044092aafaaaf20190fdeac720e1e27d5d1d6806?el=desc) (044092a) will **decrease** coverage by `0.07%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1022 +/- ## == - Coverage 82.50% 82.43% -0.08% == Files 111 111 Lines 2730827311 +3 == - Hits2253022513 -17 - Misses 4778 4798 +20 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.15% <100.00%> (+0.07%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.27% <100.00%> (ø)` | | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.29% <0.00%> (-3.88%)` | :arrow_down: | | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `90.32% <0.00%> (-1.08%)` | :arrow_down: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `92.64% <0.00%> (-0.40%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `86.68% <0.00%> (-0.02%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.12% <0.00%> (+0.19%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `88.81% <0.00%> (+0.19%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `80.69% <0.00%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=footer). Last update [044092a...474244c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1941) Crash in HTTP1 adaptor: member access within null pointer of type 'const struct qd_buffer_t'
[ https://issues.apache.org/jira/browse/DISPATCH-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281306#comment-17281306 ] ASF GitHub Bot commented on DISPATCH-1941: -- codecov-io commented on pull request #1022: URL: https://github.com/apache/qpid-dispatch/pull/1022#issuecomment-775367687 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=h1) Report > Merging [#1022](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=desc) (474244c) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/044092aafaaaf20190fdeac720e1e27d5d1d6806?el=desc) (044092a) will **decrease** coverage by `0.07%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1022 +/- ## == - Coverage 82.50% 82.43% -0.08% == Files 111 111 Lines 2730827311 +3 == - Hits2253022513 -17 - Misses 4778 4798 +20 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.15% <100.00%> (+0.07%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.27% <100.00%> (ø)` | | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.29% <0.00%> (-3.88%)` | :arrow_down: | | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `90.32% <0.00%> (-1.08%)` | :arrow_down: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `92.64% <0.00%> (-0.40%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `86.68% <0.00%> (-0.02%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.12% <0.00%> (+0.19%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `88.81% <0.00%> (+0.19%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `80.69% <0.00%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=footer). Last update [044092a...474244c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Crash in HTTP1 adaptor: member access within null pointer of type 'const > struct qd_buffer_t' > > > Key: DISPATCH-1941 > URL: https://issues.apache.org/jira/browse/DISPATCH-1941 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Jiri Daněk >Assignee: Ken Giusti >Priority: Major > Labels: crash > Fix For: 1.16.0 > > > https://github.com/jiridanek/qpid
[jira] [Commented] (DISPATCH-1735) system_tests_management failing on Fedora 32
[
https://issues.apache.org/jira/browse/DISPATCH-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281322#comment-17281322
]
Ted Ross commented on DISPATCH-1735:
I also saw this failure on Fedora 32. After completely removing the build and
install directories and re-building from nothing, the failure went away. It
appears that this is caused by some build artifacts left over from an earlier
version. Consider closing this as not-a-bug.
> system_tests_management failing on Fedora 32
>
>
> Key: DISPATCH-1735
> URL: https://issues.apache.org/jira/browse/DISPATCH-1735
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 19: ==
> 19: FAIL: test_dummy (system_tests_management.ManagementTest)
> 19: Test all operations on the dummy test entity
> 19: --
> 19: Traceback (most recent call last):
> 19: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_management.py",
> line 347, in test_dummy
> 19: self.assertEqual(
> 19: AssertionError: {'operation': 'callme', 'type': 'org.apache[58
> chars]tes'} != {'type': 'org.apache.qpid.dispatch.dummy', [57 chars]y/0'}
> 19: - {'data': b'bytes',
> 19: ? -
> 19:
> 19: + {'data': 'bytes',
> 19:'identity': 'dummy/0',
> 19:'operation': 'callme',
> 19:'type': 'org.apache.qpid.dispatch.dummy'}
> 19:
> 19: --
> 19: Ran 21 tests in 9.483s
> 19:
> 19: FAILED (failures=1)
> 1/1 Test #19: system_tests_management ..***Failed9.69 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1735) system_tests_management failing on Fedora 32
[
https://issues.apache.org/jira/browse/DISPATCH-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281379#comment-17281379
]
Ganesh Murthy commented on DISPATCH-1735:
-
I had forgotten about this, thanks for reminding [~tross] , I have not seen
this error for a while on my F33 setup. closing it.
> system_tests_management failing on Fedora 32
>
>
> Key: DISPATCH-1735
> URL: https://issues.apache.org/jira/browse/DISPATCH-1735
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 19: ==
> 19: FAIL: test_dummy (system_tests_management.ManagementTest)
> 19: Test all operations on the dummy test entity
> 19: --
> 19: Traceback (most recent call last):
> 19: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_management.py",
> line 347, in test_dummy
> 19: self.assertEqual(
> 19: AssertionError: {'operation': 'callme', 'type': 'org.apache[58
> chars]tes'} != {'type': 'org.apache.qpid.dispatch.dummy', [57 chars]y/0'}
> 19: - {'data': b'bytes',
> 19: ? -
> 19:
> 19: + {'data': 'bytes',
> 19:'identity': 'dummy/0',
> 19:'operation': 'callme',
> 19:'type': 'org.apache.qpid.dispatch.dummy'}
> 19:
> 19: --
> 19: Ran 21 tests in 9.483s
> 19:
> 19: FAILED (failures=1)
> 1/1 Test #19: system_tests_management ..***Failed9.69 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (DISPATCH-1735) system_tests_management failing on Fedora 32
[
https://issues.apache.org/jira/browse/DISPATCH-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy closed DISPATCH-1735.
---
Resolution: Cannot Reproduce
> system_tests_management failing on Fedora 32
>
>
> Key: DISPATCH-1735
> URL: https://issues.apache.org/jira/browse/DISPATCH-1735
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 19: ==
> 19: FAIL: test_dummy (system_tests_management.ManagementTest)
> 19: Test all operations on the dummy test entity
> 19: --
> 19: Traceback (most recent call last):
> 19: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_management.py",
> line 347, in test_dummy
> 19: self.assertEqual(
> 19: AssertionError: {'operation': 'callme', 'type': 'org.apache[58
> chars]tes'} != {'type': 'org.apache.qpid.dispatch.dummy', [57 chars]y/0'}
> 19: - {'data': b'bytes',
> 19: ? -
> 19:
> 19: + {'data': 'bytes',
> 19:'identity': 'dummy/0',
> 19:'operation': 'callme',
> 19:'type': 'org.apache.qpid.dispatch.dummy'}
> 19:
> 19: --
> 19: Ran 21 tests in 9.483s
> 19:
> 19: FAILED (failures=1)
> 1/1 Test #19: system_tests_management ..***Failed9.69 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
