[jira] [Commented] (QPID-8526) Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
[
https://issues.apache.org/jira/browse/QPID-8526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356917#comment-17356917
]
ASF GitHub Bot commented on QPID-8526:
--
alex-rufous commented on pull request #87:
URL: https://github.com/apache/qpid-broker-j/pull/87#issuecomment-854239275
This PR have been already merged into main. Please close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
>
>
> Key: QPID-8526
> URL: https://issues.apache.org/jira/browse/QPID-8526
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Daniil Kirilyuk
>Priority: Minor
> Fix For: qpid-java-broker-8.0.5
>
>
> Issue is similar to QPID-8489: on certain conditions SSL connection thread
> falls into an infinite loop consuming CPU.
> Stacktrace from the threaddump:
> {noformat}
> "IO-/127.0.0.1:50414" #32 prio=5 os_prio=0 cpu=43504522.88ms
> elapsed=330519.20s tid=0x7f47a0375000 nid=0x9089 runnable
> [0x7f47956fe000]
>java.lang.Thread.State: RUNNABLE
> at
> sun.security.ssl.TransportContext.getHandshakeStatus(java.base@11.0.7/TransportContext.java:571)
> at
> sun.security.ssl.SSLEngineImpl.getHandshakeStatus(java.base@11.0.7/SSLEngineImpl.java:801)
> - locked <0x7f4b721e7340> (a sun.security.ssl.SSLEngineImpl)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.wrapBufferArray(NonBlockingConnectionTLSDelegate.java:239)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.doWrite(NonBlockingConnectionTLSDelegate.java:164)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWrite(NonBlockingConnection.java:521)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdownFinalWrite(NonBlockingConnection.java:422)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdown(NonBlockingConnection.java:384)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:313)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:575)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:366)
> at
> org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
> at
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:533)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@11.0.7/ThreadPoolExecutor.java:1128)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@11.0.7/ThreadPoolExecutor.java:628)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory$$Lambda$64/0x7f47d52bcc40.run(Unknown
> Source)
> at java.lang.Thread.run(java.base@11.0.7/Thread.java:834)
> {noformat}
> Stacktrace 2 from the threaddump:
> {noformat}
> "IO-/127.0.0.1:50414" #32 prio=5 os_prio=0 cpu=43536330.84ms
> elapsed=330555.26s tid=0x7f47a0375000 nid=0x9089 runnable
> [0x7f47956fe000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.encryptSSL(QpidByteBufferFactory.java:178)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBuffer.encryptSSL(QpidByteBuffer.java:62)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.wrapBufferArray(NonBlockingConnectionTLSDelegate.java:255)
> at
> org.apache.qpid.server.transport.NonBlockingConnectionTLSDelegate.doWrite(NonBlockingConnectionTLSDelegate.java:164)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWrite(NonBlockingConnection.java:521)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdownFinalWrite(NonBlockingConnection.java:422)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.shutdown(NonBlockingConnection.java:384)
> at
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:313)
> at
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:134)
> at
> org.apache.qpid.server.transpor
[GitHub] [qpid-broker-j] alex-rufous commented on pull request #87: QPID-8526:[Broker-J] Connection looping in NonBlockingConnectionTLSDelegate.doWrite()
alex-rufous commented on pull request #87: URL: https://github.com/apache/qpid-broker-j/pull/87#issuecomment-854239275 This PR have been already merged into main. Please close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8529) NPE when trying to access digestCrecentials in the cached mode
[ https://issues.apache.org/jira/browse/QPID-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356916#comment-17356916 ] ASF GitHub Bot commented on QPID-8529: -- alex-rufous commented on pull request #89: URL: https://github.com/apache/qpid-broker-j/pull/89#issuecomment-854238997 This PR have been already merged into main. Please close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > NPE when trying to access digestCrecentials in the cached mode > -- > > Key: QPID-8529 > URL: https://issues.apache.org/jira/browse/QPID-8529 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.4 >Reporter: Dedeepya >Priority: Major > Fix For: qpid-java-broker-8.0.5 > > > There is a NPE thrown when trying to digest the credentials from the cache. > Below is the stack trace > 2021-05-21T13:58:19,703Z WARN [qtp1216638014-207] (o.e.j.s.HttpChannel) - > /2021-05-21T13:58:19,703Z WARN [qtp1216638014-207] (o.e.j.s.HttpChannel) - > /java.lang.NullPointerException: null at > org.apache.qpid.server.security.auth.manager.AuthenticationResultCacher.digestCredentials(AuthenticationResultCacher.java:118) > at > org.apache.qpid.server.security.auth.manager.AuthenticationResultCacher.getOrLoad(AuthenticationResultCacher.java:82) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on pull request #89: QPID-8529:[Broker-J]set subject on non authenticated http requests
alex-rufous commented on pull request #89: URL: https://github.com/apache/qpid-broker-j/pull/89#issuecomment-854238997 This PR have been already merged into main. Please close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers
alex-rufous commented on a change in pull request #88:
URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r645165431
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/group/FileGroupDatabase.java
##
@@ -104,17 +105,21 @@ public synchronized void setGroupFile(String groupFile)
throws IOException
@Override
public synchronized void addUserToGroup(String user, String group)
{
-Set users =
_groupToUserMap.get(keySearch(_groupToUserMap.keySet(), group));
-if (users == null)
+Set groupUsers =
_groupToUserMap.get(keySearch(_groupToUserMap.keySet(), group));
+if (groupUsers == null)
{
throw new IllegalArgumentException("Group "
+ group
+ " does not exist so could not
add "
+ user
+ " to it");
}
+else if (groupUsers.contains(keySearch(_userToGroupMap.keySet(),
user)))
Review comment:
`keySearch(_userToGroupMap.keySet(), user))` is invoked multiple times.
Please introduce a variable to keep the result of call
`keySearch(_userToGroupMap.keySet(), user))` in order to reuse it later
##
File path:
broker-core/src/test/java/org/apache/qpid/server/security/group/FileGroupDatabaseCaseInsensitiveTest.java
##
@@ -360,6 +357,34 @@ public void
testCreateGroupPersistedToFileCaseInsensitive() throws Exception
assertTrue(newGroups.contains(MY_GROUP));
}
+@Test(expected = IllegalConfigurationException.class)
+public void testDuplicateCreateGroupPersistedToFileCaseInsensitive()
throws Exception
+{
+_util.writeAndSetGroupFile();
+
+Set groups = _fileGroupDatabase.getAllGroups();
+assertTrue(groups.isEmpty());
+
+_fileGroupDatabase.createGroup(MY_GROUP);
+
+groups = _fileGroupDatabase.getAllGroups();
+assertEquals(1, groups.size());
+assertTrue(groups.contains(MY_GROUP));
+
+_fileGroupDatabase.createGroup(MY_GROUP);
Review comment:
the test will throw exception at this line
the rest of test code is "dead". please remove code after this line and
please replace `MY_GROUP` with "MyGroup1"
##
File path:
broker-core/src/test/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImplTest.java
##
@@ -364,6 +366,116 @@ public void testSharingUnderlyingFileDisallowed() throws
Exception
}
}
+@Test(expected = IllegalConfigurationException.class)
+public void testDuplicateAddGroup() throws Exception
+{
+_groupFile = createTemporaryGroupFile(Collections.emptyMap());
+
+Map providerAttrs = new HashMap<>();
+String groupsFile = _groupFile.getAbsolutePath();
+providerAttrs.put(FileBasedGroupProvider.TYPE,
GROUP_FILE_PROVIDER_TYPE);
+providerAttrs.put(FileBasedGroupProvider.PATH, groupsFile);
+providerAttrs.put(FileBasedGroupProvider.NAME, getTestName());
+
+@SuppressWarnings("unchecked")
+GroupProvider provider = _objectFactory.create(GroupProvider.class,
providerAttrs, _broker);
+
+assertThat(provider.getChildren(Group.class).size(), is(equalTo(0)));
+
+final Map groupAttrs =
Collections.singletonMap(Group.NAME, "supers");
+Group superGroup = provider.createChild(Group.class, groupAttrs);
+assertThat(superGroup.getName(), is(equalTo("supers")));
+
+provider.createChild(Group.class, groupAttrs);
+assertThrows("Group with name supers already exists",
IllegalConfigurationException.class, null);
+assertThat(superGroup.getChildren(Group.class).size(), is(equalTo(1)));
+
+}
+@Test(expected = IllegalConfigurationException.class)
Review comment:
new line is missed
##
File path:
broker-core/src/test/java/org/apache/qpid/server/security/group/FileGroupDatabaseTest.java
##
@@ -215,21 +217,14 @@ public void
testGetGroupPrincipalsForUserWhenUserRemovedFromGroup() throws Excep
assertTrue(_fileGroupDatabase.getGroupsForUser(USER1.toUpperCase()).isEmpty());
}
-@Test
+@Test(expected = IllegalConfigurationException.class)
public void
testGetGroupPrincipalsForUserWhenUserAddedToGroupTheyAreAlreadyIn() throws
Exception
{
_util.writeAndSetGroupFile("myGroup.users", USER1);
_fileGroupDatabase.addUserToGroup(USER1, MY_GROUP);
Review comment:
the test throws exception at this line
the rest of the test is a dead code... please remove code after this line
##
File path:
broker-core/src/test/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImplTest.java
##
@@ -364,6 +366,116 @@ public void testSharingUnderlyingFileDisallowed() throws
Exception
}
}
+@Test(expected = IllegalConf
[jira] [Commented] (QPID-8530) [Broker-J] Duplicated functionality of the Selector::wakeup method in SelectorThread
[
https://issues.apache.org/jira/browse/QPID-8530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356713#comment-17356713
]
ASF GitHub Bot commented on QPID-8530:
--
mklaca opened a new pull request #90:
URL: https://github.com/apache/qpid-broker-j/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J] Duplicated functionality of the Selector::wakeup method in
> SelectorThread
>
>
> Key: QPID-8530
> URL: https://issues.apache.org/jira/browse/QPID-8530
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
> Labels: Broker, Java, Thread, selector
>
> It is stated in Java documentation of the
> [Selector::wakeup|https://docs.oracle.com/javase/7/docs/api/java/nio/channels/Selector.html#wakeup()]
> method that:
> {code:none}
> Causes the first selection operation that has not yet returned to return
> immediately.
> If another thread is currently blocked in an invocation of the select() or
> select(long) methods then that invocation will return immediately. If no
> selection operation is currently in progress then the next invocation of one
> of these methods will return immediately unless the selectNow() method is
> invoked in the meantime. In any case the value returned by that invocation
> may be non-zero. Subsequent invocations of the select() or select(long)
> methods will block as usual unless this method is invoked again in the
> meantime.
> Invoking this method more than once between two successive selection
> operations has the same effect as invoking it just once.
> {code}
> SelectorThread.SelectionTask inner class in Java broker duplicates build in
> functionality of the Selector::wakeup method, what complicates the
> implementation. If the class attributes '_inSelect' and '_wakeups' were
> removed then the code of SelectorThread.SelectionTask class would be
> simplified. The wakeup method could be directly executed, there is no need
> for another checks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] mklaca opened a new pull request #90: QPID-8530: [Broker-J] Duplicated functionality of the Selector::wakeup method in SelectorThread
mklaca opened a new pull request #90: URL: https://github.com/apache/qpid-broker-j/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8536) [Broker-J] Incorrect check of maximum open connections
Marek Laca created QPID-8536: Summary: [Broker-J] Incorrect check of maximum open connections Key: QPID-8536 URL: https://issues.apache.org/jira/browse/QPID-8536 Project: Qpid Issue Type: Bug Components: Broker-J Reporter: Marek Laca The AMQP port has the limit of maximum open connections. But this limit is not checked correctly. The AMQP port has two methods AmqpPort::canAcceptNewConnection and AmqpPort::incrementConnectionCount. Suppose that the port has the limit 5 connection and clients open 7 connections at the same time: # 7 parallel connections is open by IO-threads. # All threads call the AmqpPort::canAcceptNewConnection method and every thread receive the positive answer because any connection has not been registered yet. # All threads call the AmqpPort::incrementConnectionCount methods. Hence the connection count is increased to 7 what breaks the limits. # All 7 connections are accepted in spite of breaking limit. The every thread can see the intermediate state of the counter when the limit is checked by another thread but the counter has not been incremented yet. The solution is the combination of the steps 'check' and 'increment' into single atomic operation when every thread has the exclusive access to the counter. The counter can be observed only in two states: 'before check' or 'after incrementation'. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2393) Enhancments to the AMQP Test driver
[ https://issues.apache.org/jira/browse/PROTON-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356684#comment-17356684 ] ASF subversion and git services commented on PROTON-2393: - Commit db64796ac715a8eeff2be69aaffd5780b99c41c7 in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=db64796 ] PROTON-2393 Provide more readable frame logging for the test peer Produce more readable logging for the types that are read and written by the test peer during normal operations. > Enhancments to the AMQP Test driver > --- > > Key: PROTON-2393 > URL: https://issues.apache.org/jira/browse/PROTON-2393 > Project: Qpid Proton > Issue Type: Task > Components: protonj2 >Affects Versions: protonj2-1.0.0-M2 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M3 > > > Continue ongoing development of the AMQP test driver included in with the > ProtonJ2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1240: NO-JIRA: Uncomment http tests in CI
asfgit closed pull request #1240: URL: https://github.com/apache/qpid-dispatch/pull/1240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2165) Assert in qd_message_free: stream_data_list is not empty
Charles E. Rolke created DISPATCH-2165:
--
Summary: Assert in qd_message_free: stream_data_list is not empty
Key: DISPATCH-2165
URL: https://issues.apache.org/jira/browse/DISPATCH-2165
Project: Qpid Dispatch
Issue Type: Bug
Components: Router Node
Affects Versions: 1.16.0
Reporter: Charles E. Rolke
Running TCP half-closed tests on a two router setup with tcpListener on one
node and tcpConnector on the other.
{code:java}
(gdb) bt
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x7f0c683cb895 in __GI_abort () at abort.c:79
#2 0x7f0c683cb769 in __assert_fail_base (fmt=0x7f0c685390d8 "%s%s%s:%u:
%s%sAssertion `%s' failed.\n%n", assertion=0x7f0c68b02778
"DEQ_IS_EMPTY(msg->stream_data_list)",
file=0x7f0c68b026d8 "/home/chug/git/qpid-dispatch/src/message.c",
line=1041, function=) at assert.c:92
#3 0x7f0c683dae86 in __GI___assert_fail (assertion=0x7f0c68b02778
"DEQ_IS_EMPTY(msg->stream_data_list)", file=0x7f0c68b026d8
"/home/chug/git/qpid-dispatch/src/message.c", line=1041,
function=0x7f0c68b02b90 <__PRETTY_FUNCTION__.11> "qd_message_free") at
assert.c:101
#4 0x7f0c68a86591 in qd_message_free (in_msg=0x7f0c540d1dd0) at
/home/chug/git/qpid-dispatch/src/message.c:1041
#5 0x7f0c68ac49f4 in qdr_do_message_to_addr_free (core=0xe68f60,
work=0x7f0c5407e750) at
/home/chug/git/qpid-dispatch/src/router_core/router_core_thread.c:102
#6 0x7f0c68ac38cd in qdr_general_handler (context=0xe68f60) at
/home/chug/git/qpid-dispatch/src/router_core/router_core.c:942
#7 0x7f0c68ae89e7 in qd_timer_visit () at
/home/chug/git/qpid-dispatch/src/timer.c:317
#8 0x7f0c68ae5535 in handle (qd_server=0xd58150, e=0x7f0c4406df50,
pn_conn=0x0, ctx=0x0) at /home/chug/git/qpid-dispatch/src/server.c:1006
#9 0x7f0c68ae5b94 in thread_run (arg=0xd58150) at
/home/chug/git/qpid-dispatch/src/server.c:1121
#10 0x7f0c68a97747 in _thread_init (arg=0xf3d8d0) at
/home/chug/git/qpid-dispatch/src/posix/threading.c:172
#11 0x7f0c68963432 in start_thread (arg=) at
pthread_create.c:477
#12 0x7f0c684a76d3 in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) up 4
#4 0x7f0c68a86591 in qd_message_free (in_msg=0x7f0c540d1dd0) at
/home/chug/git/qpid-dispatch/src/message.c:1041
1041assert(DEQ_IS_EMPTY(msg->stream_data_list));
(gdb) list
1036LOCK(content->lock);
1037
1038// DISPATCH-2099: ensure all outstanding stream_data items
associated
1039// with this message have been returned since the underlying
buffers
1040// may be released
1041assert(DEQ_IS_EMPTY(msg->stream_data_list));
1042
1043const bool was_blocked =
!qd_message_Q2_holdoff_should_unblock(in_msg);
1044qd_buffer_t *buf = msg->cursor.buffer;
1045while (buf) {
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2164) test_26_multicast_mobile_address_edge_to_interior failing in system_tests_edge_router
Ganesh Murthy created DISPATCH-2164:
---
Summary: test_26_multicast_mobile_address_edge_to_interior failing
in system_tests_edge_router
Key: DISPATCH-2164
URL: https://issues.apache.org/jira/browse/DISPATCH-2164
Project: Qpid Dispatch
Issue Type: Test
Components: Tests
Affects Versions: 1.16.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
{noformat}
55:
55:
55: ==
55: FAIL: test_26_multicast_mobile_address_edge_to_interior
(system_tests_edge_router.RouterTest)
55: --
55: Traceback (most recent call last):
55: File
"/home/travis/build/apache/qpid-dispatch/tests/system_tests_edge_router.py",
line 663, in test_26_multicast_mobile_address_edge_to_interior
55: self.assertIsNone(test.error)
55: AssertionError: 'Timeout Expired - n_sent=100 n_rcvd1=100, n_rcvd2=99,
n_rcvd3=99, n_released=0, addr=multicast.26' is not None
55:
55: --
55: Ran 89 tests in 545.208s
55:
55: FAILED (failures=1)
55/72 Test #55: system_tests_edge_router ..***Failed
545.35 sec {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1994) [http2] Use PN_RAW_CONNECTION_DRAIN_BUFFERS in http2 adaptor
[ https://issues.apache.org/jira/browse/DISPATCH-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1994: Priority: Minor (was: Major) > [http2] Use PN_RAW_CONNECTION_DRAIN_BUFFERS in http2 adaptor > > > Key: DISPATCH-1994 > URL: https://issues.apache.org/jira/browse/DISPATCH-1994 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Protocol Adaptors >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Minor > Fix For: 1.17.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2393) Enhancments to the AMQP Test driver
[ https://issues.apache.org/jira/browse/PROTON-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356553#comment-17356553 ] ASF subversion and git services commented on PROTON-2393: - Commit 3f5986c0be6c13325e0c068170aa166be51206db in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=3f5986c ] PROTON-2393 Add support for providing a query string for the server URI Allows a client to supply the query string that should be supplied when requesting a connection URI for the running test server. > Enhancments to the AMQP Test driver > --- > > Key: PROTON-2393 > URL: https://issues.apache.org/jira/browse/PROTON-2393 > Project: Qpid Proton > Issue Type: Task > Components: protonj2 >Affects Versions: protonj2-1.0.0-M2 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M3 > > > Continue ongoing development of the AMQP test driver included in with the > ProtonJ2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock
[
https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356529#comment-17356529
]
michael goulish commented on DISPATCH-1956:
---
This might be an improvement in code logic, but it will introduce changes in
behavior that are not relevant to this PR. Indeed – when I tried it, I got a
test failure.
Any code clean-up like this suggestion should be pursued as part of a separate
PR just for that purpose. And then we can fix whatever issues it may introduce
as part of that PR.
> Potential deadlock: logging lock vs entity cache lock
> -
>
> Key: DISPATCH-1956
> URL: https://issues.apache.org/jira/browse/DISPATCH-1956
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Major
> Labels: deadlock, tsan
> Fix For: 1.17.0
>
> Attachments: tsan.supp
>
>
> {noformat}
> WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (pid=1474955)
> Cycle in lock order graph: M11 (0x7b1002c0) => M9 (0x7b100240) =>
> M11
>
> Mutex M9 acquired here while holding mutex M11 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 push_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63
> (libqpid-dispatch.so+0x6fa13)
> #3 qd_entity_cache_add
> /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69
> (libqpid-dispatch.so+0x6fc26)
> #4 qd_alloc_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302
> (libqpid-dispatch.so+0x5878b)
> #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318
> (libqpid-dispatch.so+0x5878b)
> #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61
> (libqpid-dispatch.so+0x75891)
> #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426
> (libqpid-dispatch.so+0x76205)
> #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #9 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #10 (libpython3.8.so.1.0+0x12a23b)
> #11 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative
> warning message
>
> Mutex M11 acquired here while holding mutex M9 in main thread:
> #0 pthread_mutex_lock (libtsan.so.0+0x528ac)
> #1 sys_mutex_lock
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57
> (libqpid-dispatch.so+0x8cb7d)
> #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425
> (libqpid-dispatch.so+0x76200)
> #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453
> (libqpid-dispatch.so+0x76580)
> #4 qd_python_log
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547
> (libqpid-dispatch.so+0x8d1cb)
> #5 (libpython3.8.so.1.0+0x12a23b)
> #6 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
>
> SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock)
> (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1896) [http2] GOAWAY frame received from server not propagated to client
[ https://issues.apache.org/jira/browse/DISPATCH-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356516#comment-17356516 ] ASF GitHub Bot commented on DISPATCH-1896: -- ganeshmurthy opened a new pull request #1242: URL: https://github.com/apache/qpid-dispatch/pull/1242 …rver all the way back to the client -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [http2] GOAWAY frame received from server not propagated to client > -- > > Key: DISPATCH-1896 > URL: https://issues.apache.org/jira/browse/DISPATCH-1896 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.17.0 > > > When a HTTP2 server sends a GOAWAY frame to the router, the router is > supposed to propagate that back to the client. Instead the client just hangs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1242: DISPATCH-1896 - Propagate the GOAWAY frame received from the http2 se…
ganeshmurthy opened a new pull request #1242: URL: https://github.com/apache/qpid-dispatch/pull/1242 …rver all the way back to the client -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1865) [http2] curl client hangs when running multiple clients against HTTP2 adaptor
[
https://issues.apache.org/jira/browse/DISPATCH-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356514#comment-17356514
]
ASF GitHub Bot commented on DISPATCH-1865:
--
ganeshmurthy closed pull request #1241:
URL: https://github.com/apache/qpid-dispatch/pull/1241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http2] curl client hangs when running multiple clients against HTTP2 adaptor
> --
>
> Key: DISPATCH-1865
> URL: https://issues.apache.org/jira/browse/DISPATCH-1865
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
> Attachments: qdrouterd.conf
>
>
> {noformat}
> while : ; do
> STR=$(curl -i 127.0.0.1:9000/goaway_test_1 --http2-prior-knowledge)
> SUB='HTTP/2 503'
> echo $STR
> if [[ "$STR" == *"$SUB"* ]]; then
> exit 1
> fi
> echo
> "**"
> done{noformat}
> Start three clients that run the above script repeatedly against a router
> (router config file attached) with nginx as the server that the router is
> connecting to on port 80.
> You will notice that one of the client hangs but the rest of them keep going.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1241: DISPATCH-1865 - Propagate the GOAWAY frame received from the http2 se…
ganeshmurthy closed pull request #1241: URL: https://github.com/apache/qpid-dispatch/pull/1241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1865) [http2] curl client hangs when running multiple clients against HTTP2 adaptor
[
https://issues.apache.org/jira/browse/DISPATCH-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356506#comment-17356506
]
ASF GitHub Bot commented on DISPATCH-1865:
--
ganeshmurthy opened a new pull request #1241:
URL: https://github.com/apache/qpid-dispatch/pull/1241
…rver all the way back to the client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http2] curl client hangs when running multiple clients against HTTP2 adaptor
> --
>
> Key: DISPATCH-1865
> URL: https://issues.apache.org/jira/browse/DISPATCH-1865
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
> Attachments: qdrouterd.conf
>
>
> {noformat}
> while : ; do
> STR=$(curl -i 127.0.0.1:9000/goaway_test_1 --http2-prior-knowledge)
> SUB='HTTP/2 503'
> echo $STR
> if [[ "$STR" == *"$SUB"* ]]; then
> exit 1
> fi
> echo
> "**"
> done{noformat}
> Start three clients that run the above script repeatedly against a router
> (router config file attached) with nginx as the server that the router is
> connecting to on port 80.
> You will notice that one of the client hangs but the rest of them keep going.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (DISPATCH-1878) Client app not getting a response through tcpListener
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke reopened DISPATCH-1878: Rerunning this test in a two-router or four-router linear setup fails intermittently. * Code: Proton git branch main @ 4c466d1eb. Dispatch git branch main @ 5399d277 * Host Fedora 32 x64 The ncat command line returns to the prompt without typing any echoed text. > Client app not getting a response through tcpListener > - > > Key: DISPATCH-1878 > URL: https://issues.apache.org/jira/browse/DISPATCH-1878 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 2.0.0 >Reporter: Fernando Giorgetti >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.16.0 > > Attachments: D-1878 @e148c.svg, > DISPATCH-1878_fail-pn-raw-closed-before-ingress-stream-set-up.svg, > dispatch-1878-trace.html > > > I have a tcp-echo server running locally through: > podman run -d --rm --name tcpecho -p 9090:9090 quay.io/skupper/tcp-go-echo > And I have a router configured with a tcpConnector to localhost at port 9090 > and a tcpListener at port . > I am able to use nc (netcat) to send data to the tcp-echo directly (port > 9090) or through > the router (port ), if I run "nc 127.0.0.1 " and the send the data. > But if I run it as: "echo abcd | nc 127.0.0.1 " I am not seeing a > response, but if > I use port 9090 (original port) instead of (router tcpListener), then I > get the > response correctly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1241: DISPATCH-1865 - Propagate the GOAWAY frame received from the http2 se…
ganeshmurthy opened a new pull request #1241: URL: https://github.com/apache/qpid-dispatch/pull/1241 …rver all the way back to the client -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2115) Leak of qdr_link_route_t in system_tests_edge_router
[
https://issues.apache.org/jira/browse/DISPATCH-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356442#comment-17356442
]
ASF GitHub Bot commented on DISPATCH-2115:
--
asfgit closed pull request #1236:
URL: https://github.com/apache/qpid-dispatch/pull/1236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Leak of qdr_link_route_t in system_tests_edge_router
>
>
> Key: DISPATCH-2115
> URL: https://issues.apache.org/jira/browse/DISPATCH-2115
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/504616325#L5769
> {noformat}
> 55: alloc.c: Items of type 'qdr_link_route_t' remain allocated at shutdown: 2
> 55: Leak: 2021-05-11 13:52:29.073364 + type: qdr_link_route_t address:
> 0x61336a10
> 55: /lib/s390x-linux-gnu/libasan.so.5(+0x87550) [0x3ff89d87550]
> 55:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x3e2)
> [0x3ff8951af22]
> 55:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qdr_route_add_conn_route_CT+0x4e)
> [0x3ff89667b9e]
> 55:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qdra_conn_link_route_create_CT+0x7c6)
> [0x3ff89600926]
> 55:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x5e44ee)
> [0x3ff895e44ee]
> 55:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(router_core_thread+0xa28)
> [0x3ff896842d8]
> 55: /lib/s390x-linux-gnu/libpthread.so.0(+0x99f6) [0x3ff88f899f6]
> 55: /lib/s390x-linux-gnu/libc.so.6(+0x1067e6) [0x3ff884867e6]
> 55: [(nil)]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2158) AddressSanitizer: use-after-poison in qdr_core_delete_link_route during system_tests_edge_router
[
https://issues.apache.org/jira/browse/DISPATCH-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2158.
-
Fix Version/s: 1.17.0
Resolution: Fixed
> AddressSanitizer: use-after-poison in qdr_core_delete_link_route during
> system_tests_edge_router
> -
>
> Key: DISPATCH-2158
> URL: https://issues.apache.org/jira/browse/DISPATCH-2158
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
> Labels: asan, memory-bug
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/508201388#L7343
> {noformat}
> 55: ==15370==ERROR: AddressSanitizer: use-after-poison on address
> 0x6160001042e8 at pc 0x7f63a25b1959 bp 0x7ffc39441730 sp 0x7ffc39441720
> 55: READ of size 4 at 0x6160001042e8 thread T0
> 55: #0 0x7f63a25b1958 in qdr_core_delete_link_route
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:565
> 55: #1 0x7f63a25ac33c in qdr_core_free
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:286
> 55: #2 0x7f63a26236ae in qd_router_free
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
> 55: #3 0x7f63a24b07b8 in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
> 55: #4 0x401de2 in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:119
> 55: #5 0x403927 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> 55: #6 0x7f63a0e1082f in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
> 55: #7 0x401ad8 in _start
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x401ad8)
> 55:
> 55: 0x6160001042e8 is located 360 bytes inside of 576-byte region
> [0x616000104180,0x6160001043c0)
> 55: allocated by thread T1 here:
> 55: #0 0x7f63a2d53076 in __interceptor_posix_memalign
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x99076)
> 55: #1 0x7f63a247d369 in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396
> 55: #2 0x7f63a25a583f in new_qdr_address_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:31
> 55: #3 0x7f63a25af82b in qdr_address_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:461
> 55: #4 0x7f63a25c9b28 in qdr_subscribe_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:643
> 55: #5 0x7f63a25c0ff1 in router_core_thread
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239
> 55: #6 0x7f63a25112b4 in _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> 55: #7 0x7f63a1ece6b9 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9)
> 55:
> 55: Thread T1 created by T0 here:
> 55: #0 0x7f63a2cf0253 in pthread_create
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x36253)
> 55: #1 0x7f63a25113b8 in sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
> 55: #2 0x7f63a25a6e27 in qdr_core
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124
> 55: #3 0x7f63a2623281 in qd_router_setup_late
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2123
> 55: #4 0x7f639aa58e3f in ffi_call_unix64
> (/usr/lib/x86_64-linux-gnu/libffi.so.6+0x5e3f)
> 55: #5 0x7ffc394411cf ()
> 55:
> 55: SUMMARY: AddressSanitizer: use-after-poison
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:565
> qdr_core_delete_link_route
> 55: Shadow bytes around the buggy address:
> 55: 0x0c2c80018800: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 55: 0x0c2c80018810: f7 f7 f7 f7 f7 f7 00 00 fa fa fa fa fa fa fa fa
> 55: 0x0c2c80018820: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 55: 0x0c2c80018830: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 55: 0x0c2c80018840: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 55: =>0x0c2c80018850: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7[f7]f7 f7
> 55: 0x0c2c80018860: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 55: 0x0c2c80018870: f7 f7 f7 f7 f7 f7 00 00 fa fa fa fa fa fa fa fa
> 55: 0x0c2c80018880: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 55: 0x0c2c80018890: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 55: 0x0c2c800188a0: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 55: Shadow byte legend (one shadow byte represents 8 application bytes):
> 55: Addressable: 00
> 55: Partially addressable: 01 02 03 04 05 06 07
> 55: Heap left redzone: fa
> 55: Heap right redzone: fb
> 55: Freed heap region: fd
> 55: Stack left redzone: f1
> 55: Stack mid redzone: f
[GitHub] [qpid-dispatch] asfgit closed pull request #1236: DISPATCH-2115: Move the removal of connection based link routes befor…
asfgit closed pull request #1236: URL: https://github.com/apache/qpid-dispatch/pull/1236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2158) AddressSanitizer: use-after-poison in qdr_core_delete_link_route during system_tests_edge_router
[
https://issues.apache.org/jira/browse/DISPATCH-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356441#comment-17356441
]
ASF subversion and git services commented on DISPATCH-2158:
---
Commit 5399d27776807de6071976394cecf9c1e411fd6e in qpid-dispatch's branch
refs/heads/main from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=5399d27 ]
DISPATCH-2158: Move the removal of connection based link routes before a call
to qdr_core_remove_address. This closes #1236
> AddressSanitizer: use-after-poison in qdr_core_delete_link_route during
> system_tests_edge_router
> -
>
> Key: DISPATCH-2158
> URL: https://issues.apache.org/jira/browse/DISPATCH-2158
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
> Labels: asan, memory-bug
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/508201388#L7343
> {noformat}
> 55: ==15370==ERROR: AddressSanitizer: use-after-poison on address
> 0x6160001042e8 at pc 0x7f63a25b1959 bp 0x7ffc39441730 sp 0x7ffc39441720
> 55: READ of size 4 at 0x6160001042e8 thread T0
> 55: #0 0x7f63a25b1958 in qdr_core_delete_link_route
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:565
> 55: #1 0x7f63a25ac33c in qdr_core_free
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:286
> 55: #2 0x7f63a26236ae in qd_router_free
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
> 55: #3 0x7f63a24b07b8 in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
> 55: #4 0x401de2 in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:119
> 55: #5 0x403927 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> 55: #6 0x7f63a0e1082f in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
> 55: #7 0x401ad8 in _start
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x401ad8)
> 55:
> 55: 0x6160001042e8 is located 360 bytes inside of 576-byte region
> [0x616000104180,0x6160001043c0)
> 55: allocated by thread T1 here:
> 55: #0 0x7f63a2d53076 in __interceptor_posix_memalign
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x99076)
> 55: #1 0x7f63a247d369 in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396
> 55: #2 0x7f63a25a583f in new_qdr_address_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:31
> 55: #3 0x7f63a25af82b in qdr_address_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:461
> 55: #4 0x7f63a25c9b28 in qdr_subscribe_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:643
> 55: #5 0x7f63a25c0ff1 in router_core_thread
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239
> 55: #6 0x7f63a25112b4 in _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> 55: #7 0x7f63a1ece6b9 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9)
> 55:
> 55: Thread T1 created by T0 here:
> 55: #0 0x7f63a2cf0253 in pthread_create
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x36253)
> 55: #1 0x7f63a25113b8 in sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
> 55: #2 0x7f63a25a6e27 in qdr_core
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124
> 55: #3 0x7f63a2623281 in qd_router_setup_late
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2123
> 55: #4 0x7f639aa58e3f in ffi_call_unix64
> (/usr/lib/x86_64-linux-gnu/libffi.so.6+0x5e3f)
> 55: #5 0x7ffc394411cf ()
> 55:
> 55: SUMMARY: AddressSanitizer: use-after-poison
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:565
> qdr_core_delete_link_route
> 55: Shadow bytes around the buggy address:
> 55: 0x0c2c80018800: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 55: 0x0c2c80018810: f7 f7 f7 f7 f7 f7 00 00 fa fa fa fa fa fa fa fa
> 55: 0x0c2c80018820: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 55: 0x0c2c80018830: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 55: 0x0c2c80018840: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 55: =>0x0c2c80018850: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7[f7]f7 f7
> 55: 0x0c2c80018860: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 55: 0x0c2c80018870: f7 f7 f7 f7 f7 f7 00 00 fa fa fa fa fa fa fa fa
> 55: 0x0c2c80018880: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 55: 0x0c2c80018890: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 55: 0x0c2c800188a0: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 55: Shadow byte legend
[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers
deepyaraj commented on a change in pull request #88:
URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r644778648
##
File path:
broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java
##
@@ -359,16 +364,21 @@ protected void onOpen()
if (childClass == GroupMember.class)
{
String memberName = (String) attributes.get(GroupMember.NAME);
-
-_groupDatabase.addUserToGroup(memberName, getName());
-UUID id = UUID.randomUUID();
-Map attrMap = new HashMap();
-attrMap.put(GroupMember.ID,id);
-attrMap.put(GroupMember.NAME, memberName);
-GroupMemberAdapter groupMemberAdapter = new
GroupMemberAdapter(attrMap);
-groupMemberAdapter.create();
-return Futures.immediateFuture((C) groupMemberAdapter);
-
+Set users = _groupDatabase.getUsersInGroup(getName());
+if(!users.contains(memberName))
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers
deepyaraj commented on a change in pull request #88:
URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r644691027
##
File path:
broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java
##
@@ -205,17 +205,22 @@ public String getPath()
{
throw new IllegalConfigurationException(String.format("Group
provider '%s' is not activated. Cannot create a group.", getName()));
}
+Set availableGroups = _groupDatabase.getAllGroups();
+if(!availableGroups.contains(groupName))
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers
deepyaraj commented on a change in pull request #88:
URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r644690778
##
File path:
broker-core/src/main/java/org/apache/qpid/server/model/adapter/FileBasedGroupProviderImpl.java
##
@@ -205,17 +205,22 @@ public String getPath()
{
throw new IllegalConfigurationException(String.format("Group
provider '%s' is not activated. Cannot create a group.", getName()));
}
+Set availableGroups = _groupDatabase.getAllGroups();
+if(!availableGroups.contains(groupName))
+{
+_groupDatabase.createGroup(groupName);
-_groupDatabase.createGroup(groupName);
-
-Map attrMap = new HashMap();
-UUID id = UUID.randomUUID();
-attrMap.put(ConfiguredObject.ID, id);
-attrMap.put(ConfiguredObject.NAME, groupName);
-GroupAdapter groupAdapter = new GroupAdapter(attrMap);
-groupAdapter.create();
-return Futures.immediateFuture((C) groupAdapter);
-
+Map attrMap = new HashMap();
+UUID id = UUID.randomUUID();
+attrMap.put(ConfiguredObject.ID, id);
+attrMap.put(ConfiguredObject.NAME, groupName);
+GroupAdapter groupAdapter = new GroupAdapter(attrMap);
+groupAdapter.create();
+return Futures.immediateFuture((C) groupAdapter);
+}
+else{
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
