[GitHub] [qpid-proton] jiridanek commented on pull request #335: PROTON-2254 Generate correct relocatable pc files
jiridanek commented on pull request #335: URL: https://github.com/apache/qpid-proton/pull/335#issuecomment-972758163 I fixed the mistakes pointed out and I'm adding example Makefiles to demonstrate this now works for both the C and CPP proton. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2254) Relative paths in CMake share
[
https://issues.apache.org/jira/browse/PROTON-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445845#comment-17445845
]
ASF GitHub Bot commented on PROTON-2254:
jiridanek commented on pull request #335:
URL: https://github.com/apache/qpid-proton/pull/335#issuecomment-972758163
I fixed the mistakes pointed out and I'm adding example Makefiles to
demonstrate this now works for both the C and CPP proton.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative paths in CMake share
> -
>
> Key: PROTON-2254
> URL: https://issues.apache.org/jira/browse/PROTON-2254
> Project: Qpid Proton
> Issue Type: Improvement
> Components: build, cpp-binding, proton-c
>Affects Versions: proton-c-0.31.0
> Environment: Debian Linux; build Proton then Dispatch into each their
> own `DESTDIR`. This is done by our "layered build" system,
> https://gitlab.com/arpa2/mkhere/-/blob/master/qpid_proton.sh and
> https://gitlab.com/arpa2/mkhere/-/blob/master/qpid_dispatch.sh
>Reporter: Rick van Rein
>Assignee: Jiri Daněk
>Priority: Minor
> Labels: cmake, install, proton
> Fix For: proton-c-0.36.0
>
> Original Estimate: 0.25h
> Time Spent: 4h
> Remaining Estimate: 0h
>
> This sequency installs well:
> {noformat}
> cmake
> make
> make DESTDIR=/some/where install
> {noformat}
> However, further use of the installation fails, because of strict
> dependencies on the *installed* paths in files like `ProtonConfig.cmake`:
> {noformat}
> set_target_properties(Proton::core
> PROPERTIES
> IMPORTED_LOCATION "/usr/local/lib/libqpid-proton-core.so"
> IMPORTED_LOCATION_DEBUG "/usr/local/lib/libqpid-proton-core.so"
> INTERFACE_INCLUDE_DIRECTORIES "${Proton_Core_INCLUDE_DIRS}")
> {noformat}
> **What would work:** First switch to the `DESTDIR`, then continue building
> something like Qpid Dispatch Router.
> **Solution:** Use relative directories, like in:
> {noformat}
> # Compute the installation prefix relative to this file.
> get_filename_component(_IMPORT_PREFIX "${CMAKE_CURRENT_LIST_FILE}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> if(_IMPORT_PREFIX STREQUAL "/")
> set(_IMPORT_PREFIX "")
> endif()
> {noformat}
> **Work-around:** An unhappy quickfix is
> {noformat}
> find /some/where -name *.cmake -exec \
> sed -i "s+/usr/+/some/where/usr/+g" {} \;
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #335: PROTON-2254 Generate correct relocatable pc files
jiridanek commented on a change in pull request #335:
URL: https://github.com/apache/qpid-proton/pull/335#discussion_r752133906
##
File path: CMakeLists.txt
##
@@ -276,18 +276,18 @@ set (MAN_INSTALL_DIR share/man CACHE PATH "Manpage
directory")
mark_as_advanced (INCLUDE_INSTALL_DIR LIB_INSTALL_DIR SYSCONF_INSTALL_DIR
SHARE_INSTALL_DIR MAN_INSTALL_DIR)
-# ${PACKAGE_PREFIX_DIR} is expanded from @PACKAGE_INIT@
-# by configure_package_config_file(), and available in ProtonConfig.cmake
-macro (pn_relative_install_dir NAME VALUE)
+# Sets variable NAME to contain relative path from ROOT to VALUE
+# if VALUE is already relative, it does nothing
+macro (pn_relative_install_dir NAME ROOT VALUE)
if (IS_ABSOLUTE ${VALUE})
-message(WARNING "Build was given an absolute path '${VALUE}'. As a result,
`make DESTDIR=... install` will not work.")
-set (${NAME} "${VALUE}")
+file(RELATIVE_PATH "${NAME}" "${ROOT}" "${VALUE}")
else ()
-set (${NAME} "\${PACKAGE_PREFIX_DIR}/${VALUE}")
+set (${NAME} "${VALUE}")
endif ()
endmacro ()
-pn_relative_install_dir (INCLUDEDIR ${INCLUDE_INSTALL_DIR})
+pn_relative_install_dir (INCLUDEDIR "${CMAKE_INSTALL_PREFIX}"
"${INCLUDE_INSTALL_DIR}")
+pn_relative_install_dir (LIBDIR "${CMAKE_INSTALL_PREFIX}" "${LIB_INSTALL_DIR}")
Review comment:
When they are being set in the RPM build, they are set in the form of an
absolute path (that is not logic inherent in RPM build, it is what _our_ rpm
build for Fedora/CentOS/RHEL decides to do). If we don't want to have absolute
paths in pc files, then the paths have to be relativized.
`pn_relative_install_dir` passes relative paths unchanged, so when what's
given is already relative, it won't be touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2254) Relative paths in CMake share
[
https://issues.apache.org/jira/browse/PROTON-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445849#comment-17445849
]
ASF GitHub Bot commented on PROTON-2254:
jiridanek commented on a change in pull request #335:
URL: https://github.com/apache/qpid-proton/pull/335#discussion_r752133906
##
File path: CMakeLists.txt
##
@@ -276,18 +276,18 @@ set (MAN_INSTALL_DIR share/man CACHE PATH "Manpage
directory")
mark_as_advanced (INCLUDE_INSTALL_DIR LIB_INSTALL_DIR SYSCONF_INSTALL_DIR
SHARE_INSTALL_DIR MAN_INSTALL_DIR)
-# ${PACKAGE_PREFIX_DIR} is expanded from @PACKAGE_INIT@
-# by configure_package_config_file(), and available in ProtonConfig.cmake
-macro (pn_relative_install_dir NAME VALUE)
+# Sets variable NAME to contain relative path from ROOT to VALUE
+# if VALUE is already relative, it does nothing
+macro (pn_relative_install_dir NAME ROOT VALUE)
if (IS_ABSOLUTE ${VALUE})
-message(WARNING "Build was given an absolute path '${VALUE}'. As a result,
`make DESTDIR=... install` will not work.")
-set (${NAME} "${VALUE}")
+file(RELATIVE_PATH "${NAME}" "${ROOT}" "${VALUE}")
else ()
-set (${NAME} "\${PACKAGE_PREFIX_DIR}/${VALUE}")
+set (${NAME} "${VALUE}")
endif ()
endmacro ()
-pn_relative_install_dir (INCLUDEDIR ${INCLUDE_INSTALL_DIR})
+pn_relative_install_dir (INCLUDEDIR "${CMAKE_INSTALL_PREFIX}"
"${INCLUDE_INSTALL_DIR}")
+pn_relative_install_dir (LIBDIR "${CMAKE_INSTALL_PREFIX}" "${LIB_INSTALL_DIR}")
Review comment:
When they are being set in the RPM build, they are set in the form of an
absolute path (that is not logic inherent in RPM build, it is what _our_ rpm
build for Fedora/CentOS/RHEL decides to do). If we don't want to have absolute
paths in pc files, then the paths have to be relativized.
`pn_relative_install_dir` passes relative paths unchanged, so when what's
given is already relative, it won't be touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative paths in CMake share
> -
>
> Key: PROTON-2254
> URL: https://issues.apache.org/jira/browse/PROTON-2254
> Project: Qpid Proton
> Issue Type: Improvement
> Components: build, cpp-binding, proton-c
>Affects Versions: proton-c-0.31.0
> Environment: Debian Linux; build Proton then Dispatch into each their
> own `DESTDIR`. This is done by our "layered build" system,
> https://gitlab.com/arpa2/mkhere/-/blob/master/qpid_proton.sh and
> https://gitlab.com/arpa2/mkhere/-/blob/master/qpid_dispatch.sh
>Reporter: Rick van Rein
>Assignee: Jiri Daněk
>Priority: Minor
> Labels: cmake, install, proton
> Fix For: proton-c-0.36.0
>
> Original Estimate: 0.25h
> Time Spent: 4h
> Remaining Estimate: 0h
>
> This sequency installs well:
> {noformat}
> cmake
> make
> make DESTDIR=/some/where install
> {noformat}
> However, further use of the installation fails, because of strict
> dependencies on the *installed* paths in files like `ProtonConfig.cmake`:
> {noformat}
> set_target_properties(Proton::core
> PROPERTIES
> IMPORTED_LOCATION "/usr/local/lib/libqpid-proton-core.so"
> IMPORTED_LOCATION_DEBUG "/usr/local/lib/libqpid-proton-core.so"
> INTERFACE_INCLUDE_DIRECTORIES "${Proton_Core_INCLUDE_DIRS}")
> {noformat}
> **What would work:** First switch to the `DESTDIR`, then continue building
> something like Qpid Dispatch Router.
> **Solution:** Use relative directories, like in:
> {noformat}
> # Compute the installation prefix relative to this file.
> get_filename_component(_IMPORT_PREFIX "${CMAKE_CURRENT_LIST_FILE}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> if(_IMPORT_PREFIX STREQUAL "/")
> set(_IMPORT_PREFIX "")
> endif()
> {noformat}
> **Work-around:** An unhappy quickfix is
> {noformat}
> find /some/where -name *.cmake -exec \
> sed -i "s+/usr/+/some/where/usr/+g" {} \;
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2036) TCP adaptor deliveries reported as "stuck" by delayed delivery detection
[ https://issues.apache.org/jira/browse/DISPATCH-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2036. -- Resolution: Fixed > TCP adaptor deliveries reported as "stuck" by delayed delivery detection > > > Key: DISPATCH-2036 > URL: https://issues.apache.org/jira/browse/DISPATCH-2036 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Since TCP adaptor uses long lived deliveries the delayed delivery detection > logic flags these deliveries as stuck. This occurs on each intermediate > router as well. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2290) Use of uninitialized data
Jiri Daněk created DISPATCH-2290:
Summary: Use of uninitialized data
Key: DISPATCH-2290
URL: https://issues.apache.org/jira/browse/DISPATCH-2290
Project: Qpid Dispatch
Issue Type: Bug
Affects Versions: 1.18.0
Reporter: Jiri Daněk
https://github.com/jiridanek/qpid-dispatch/runs/4253734843?check_suite_focus=true#step:28:10895
{noformat}
==2028==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x56b3c3 in qd_dispatch
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
#1 0x4c2346 in main_process
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92:16
#2 0x4c05d8 in main
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369:9
#3 0x7f398fd39b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
#4 0x43fdbd in _start
(/__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/router/qdrouterd+0x43fdbd)
Uninitialized value was created by an allocation of 'st' in the stack frame
of function 'qd_dispatch'
#0 0x56ab90 in qd_dispatch
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:77
SUMMARY: MemorySanitizer: use-of-uninitialized-value
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
in qd_dispatch
{noformat}
{code}
struct stat st;
if (stat(python_pkgdir, &st)) {
qd_error_errno(errno, "Cannot find Python library path '%s'",
python_pkgdir);
return NULL;
} else if (!S_ISDIR(st.st_mode)) {
qd_error(QD_ERROR_RUNTIME, "Python library path '%s' not a
directory", python_pkgdir);
return NULL;
}
{code}
The problem looks obvious. If {{stat}} function fails, dispatch tries to
examine {{st.st_mode}}. Looks like a trivial coding mistake.
This issue highlights that we don't currently regularly run undefined-memory
checker with qdrouterd.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1406: Bump @patternfly/patternfly from 4.125.3 to 4.151.4 in /console/react
dependabot[bot] commented on pull request #1406: URL: https://github.com/apache/qpid-dispatch/pull/1406#issuecomment-973061518 Superseded by #1442. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1442: Bump @patternfly/patternfly from 4.125.3 to 4.159.1 in /console/react
dependabot[bot] opened a new pull request #1442: URL: https://github.com/apache/qpid-dispatch/pull/1442 Bumps [@patternfly/patternfly](https://github.com/patternfly/patternfly) from 4.125.3 to 4.159.1. Release notes Sourced from https://github.com/patternfly/patternfly/releases";>@patternfly/patternfly's releases. prerelease-v4.159.1 https://github.com/patternfly/patternfly/compare/prerelease-v4.159.0...prerelease-v4.159.1";>4.159.1 (2021-11-12) Bug Fixes release-notes: added release notes for 2021.15 (https://github-redirect.dependabot.com/patternfly/patternfly/issues/4516";>#4516) (https://github.com/patternfly/patternfly/commit/a67b16945bec19cae3916d9688fe1e9c6cba2576";>a67b169) prerelease-v4.159.0 https://github.com/patternfly/patternfly/compare/prerelease-v4.158.0...prerelease-v4.159.0";>4.159.0 (2021-11-12) Features menu: added nav variant (https://github-redirect.dependabot.com/patternfly/patternfly/issues/4513";>#4513) (https://github.com/patternfly/patternfly/commit/75fec93d23587b7221498bcd3c71afb3a27cacf1";>75fec93) prerelease-v4.158.0 https://github.com/patternfly/patternfly/compare/prerelease-v4.157.1...prerelease-v4.158.0";>4.158.0 (2021-11-12) Features dropdown: added secondary variant to dropdown (https://github-redirect.dependabot.com/patternfly/patternfly/issues/4498";>#4498) (https://github.com/patternfly/patternfly/commit/ce6f4371d3a9e5d38a1e0ff3c47517ce5e3021d8";>ce6f437) prerelease-v4.157.1 https://github.com/patternfly/patternfly/compare/prerelease-v4.157.0...prerelease-v4.157.1";>4.157.1 (2021-11-11) Bug Fixes dropdown: applied primary styling to split (https://github-redirect.dependabot.com/patternfly/patternfly/issues/4508";>#4508) (https://github.com/patternfly/patternfly/commit/16e3b2655defa57784fdc4324db6ec81320f03c6";>16e3b26) prerelease-v4.157.0 https://github.com/patternfly/patternfly/compare/prerelease-v4.156.3...prerelease-v4.157.0";>4.157.0 (2021-11-11) Features nav: added drilldown menu to nav (https://github-redirect.dependabot.com/patternfly/patternfly/issues/4458";>#4458) (https://github.com/patternfly/patternfly/commit/2e3ac12be06c575a00a3d1f06afe5fae2c2f07b5";>2e3ac12) prerelease-v4.156.3 https://github.com/patternfly/patternfly/compare/prerelease-v4.156.2...prerelease-v4.156.3";>4.156.3 (2021-11-11) Bug Fixes dual-list-selector: aligned a11y with react (https://github-redirect.dependabot.com/patternfly/patternfly/issues/4499";>#4499) (https://github.com/patternfly/patternfly/commit/9ec09cf4d98bce4f8d91e631179bb1fb31c80e45";>9ec09cf) prerelease-v4.156.2 https://github.com/patternfly/patternfly/compare/prerelease-v4.156.1...prerelease-v4.156.2";>4.156.2 (2021-11-10) ... (truncated) Changelog Sourced from https://github.com/patternfly/patternfly/blob/main/RELEASE-NOTES.md";>@patternfly/patternfly's changelog. id: Release notes section: developer-resources releaseNoteTOC: true 2021.15 release notes (2021-11-16) Packages released: https://www.npmjs.com/package/@patternfly/patternfly/v/4.159.1";>@patternfly/patternfly@v4.159.1 Components Card: Added non-selectable card, updated card view demo (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4500";>#4500) Dropdown: Added secondary variant to dropdown (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4498";>#4498) Applied primary styling to split (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4508";>#4508) Dual list selector: Aligned html/a11y with react (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4499";>#4499) Form select: Matched padding with select (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4490";>#4490) Log viewer: Added nowrap variation (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4455";>#4455) Updated the way dark theme is applied (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4506";>#4506) Menu toggle: Added plain w/text variant (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4491";>#4491) Added rounded corners to primary (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4494";>#4494) Menu: Added nav variant (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4513";>#4513) Nav: Added drilldown menu to nav (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4458";>#4458) Fixed toggle icon rotation (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4486";>#4486) Options menu: Moved text into button in plain text variant (https://github-redirect.dependabot.com/patternfly/patternfly/pull/4492";>#4492) Table: Fixed pf-m-truncate alignment (https://github-redirect.depend
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1406: Bump @patternfly/patternfly from 4.125.3 to 4.151.4 in /console/react
dependabot[bot] closed pull request #1406: URL: https://github.com/apache/qpid-dispatch/pull/1406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1404: Bump @patternfly/react-styles from 4.11.8 to 4.18.8 in /console/react
dependabot[bot] commented on pull request #1404: URL: https://github.com/apache/qpid-dispatch/pull/1404#issuecomment-973062016 Superseded by #1443. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1443: Bump @patternfly/react-styles from 4.11.8 to 4.25.4 in /console/react
dependabot[bot] opened a new pull request #1443: URL: https://github.com/apache/qpid-dispatch/pull/1443 Bumps @patternfly/react-styles from 4.11.8 to 4.25.4. Maintainer changes This version was pushed to npm by https://www.npmjs.com/~patternfly-build";>patternfly-build, a new releaser for @patternfly/react-styles since your current version. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1404: Bump @patternfly/react-styles from 4.11.8 to 4.18.8 in /console/react
dependabot[bot] closed pull request #1404: URL: https://github.com/apache/qpid-dispatch/pull/1404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1405: Bump @patternfly/react-icons from 4.11.8 to 4.19.8 in /console/react
dependabot[bot] closed pull request #1405: URL: https://github.com/apache/qpid-dispatch/pull/1405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1444: Bump @patternfly/react-icons from 4.11.8 to 4.26.4 in /console/react
dependabot[bot] opened a new pull request #1444: URL: https://github.com/apache/qpid-dispatch/pull/1444 Bumps [@patternfly/react-icons](https://github.com/patternfly/patternfly-react) from 4.11.8 to 4.26.4. Release notes Sourced from https://github.com/patternfly/patternfly-react/releases";>@patternfly/react-icons's releases. @patternfly/react-iconshttps://github.com/4";>@4.26.4 4.26.4 (2021-11-15) Bug Fixes FileUpload: Downgrade react-dropzone back to 9.0.0 to avoid a breaking type change, fix behavior regressions (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6610";>#6610) (https://github.com/patternfly/patternfly-react/commit/574bf4ff3ccf7f67ce750bc48067eaf826e0";>574bf4f) @patternfly/react-iconshttps://github.com/4";>@4.26.3 4.26.3 (2021-11-15) Bug Fixes Menu: allow maxMenuHeight with Scrollabe (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6608";>#6608) (https://github.com/patternfly/patternfly-react/commit/8c1f12c2b0e86bbc5ba1071db3ebf29fee7421a0";>8c1f12c) Commits https://github.com/patternfly/patternfly-react/commit/f6c85091da9f26a75bd7a063d8ee99a2b80dd64f";>f6c8509 chore(release): releasing packages [ci skip] https://github.com/patternfly/patternfly-react/commit/574bf4ff3ccf7f67ce750bc48067eaf826e0";>574bf4f fix(FileUpload): Downgrade react-dropzone back to 9.0.0 to avoid a breaking t... https://github.com/patternfly/patternfly-react/commit/bee987d557bc8027afeb222e2d0df84796c119ba";>bee987d chore(release): releasing packages [ci skip] https://github.com/patternfly/patternfly-react/commit/8c1f12c2b0e86bbc5ba1071db3ebf29fee7421a0";>8c1f12c fix(Menu): allow maxMenuHeight with Scrollabe (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6608";>#6608) https://github.com/patternfly/patternfly-react/commit/77f760305bd6eb6415fd27be973783cca4f0d97a";>77f7603 chore(release): releasing packages [ci skip] https://github.com/patternfly/patternfly-react/commit/752fffd1cf963004ff318cf46833b213df635e55";>752fffd Page nav flyout bug (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6562";>#6562) https://github.com/patternfly/patternfly-react/commit/bdc63f6a091228f1c3a77726c3cfae7a5fb46d8b";>bdc63f6 chore(release): releasing packages [ci skip] https://github.com/patternfly/patternfly-react/commit/db67a489b13d88c8715a42e7a30621104db3f8b0";>db67a48 chore(deps): update dependency @patternfly/patternfly to v4.159.1 (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6599";>#6599) https://github.com/patternfly/patternfly-react/commit/b72bb1b70233499abc5af4e35ab3ea72b7049f7f";>b72bb1b Dynamic tooltip content (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6598";>#6598) https://github.com/patternfly/patternfly-react/commit/031e0e31853e92aae5dc072a24fdea96403f0472";>031e0e3 chore(release): releasing packages [ci skip] Additional commits viewable in https://github.com/patternfly/patternfly-react/compare/@patternfly/react-icons@4.11.8...@patternfly/react-icons@4.26.4";>compare view Maintainer changes This version was pushed to npm by https://www.npmjs.com/~patternfly-build";>patternfly-build, a new releaser for @patternfly/react-icons since your current version. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you re
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1405: Bump @patternfly/react-icons from 4.11.8 to 4.19.8 in /console/react
dependabot[bot] commented on pull request #1405: URL: https://github.com/apache/qpid-dispatch/pull/1405#issuecomment-973064746 Superseded by #1444. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1445: Bump @patternfly/react-topology from 4.9.42 to 4.22.4 in /console/react
dependabot[bot] opened a new pull request #1445: URL: https://github.com/apache/qpid-dispatch/pull/1445 Bumps [@patternfly/react-topology](https://github.com/patternfly/patternfly-react) from 4.9.42 to 4.22.4. Release notes Sourced from https://github.com/patternfly/patternfly-react/releases";>@patternfly/react-topology's releases. @patternfly/react-topologyhttps://github.com/4";>@4.22.4 4.22.4 (2021-11-15) Bug Fixes FileUpload: Downgrade react-dropzone back to 9.0.0 to avoid a breaking type change, fix behavior regressions (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6610";>#6610) (https://github.com/patternfly/patternfly-react/commit/574bf4ff3ccf7f67ce750bc48067eaf826e0";>574bf4f) @patternfly/react-topologyhttps://github.com/4";>@4.22.3 4.22.3 (2021-11-15) Bug Fixes Menu: allow maxMenuHeight with Scrollabe (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6608";>#6608) (https://github.com/patternfly/patternfly-react/commit/8c1f12c2b0e86bbc5ba1071db3ebf29fee7421a0";>8c1f12c) @patternfly/react-topologyhttps://github.com/4";>@4.22.2 4.22.2 (2021-11-15) Note: Version bump only for package @patternfly/react-topology Commits https://github.com/patternfly/patternfly-react/commit/f6c85091da9f26a75bd7a063d8ee99a2b80dd64f";>f6c8509 chore(release): releasing packages [ci skip] https://github.com/patternfly/patternfly-react/commit/574bf4ff3ccf7f67ce750bc48067eaf826e0";>574bf4f fix(FileUpload): Downgrade react-dropzone back to 9.0.0 to avoid a breaking t... https://github.com/patternfly/patternfly-react/commit/bee987d557bc8027afeb222e2d0df84796c119ba";>bee987d chore(release): releasing packages [ci skip] https://github.com/patternfly/patternfly-react/commit/8c1f12c2b0e86bbc5ba1071db3ebf29fee7421a0";>8c1f12c fix(Menu): allow maxMenuHeight with Scrollabe (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6608";>#6608) https://github.com/patternfly/patternfly-react/commit/77f760305bd6eb6415fd27be973783cca4f0d97a";>77f7603 chore(release): releasing packages [ci skip] https://github.com/patternfly/patternfly-react/commit/752fffd1cf963004ff318cf46833b213df635e55";>752fffd Page nav flyout bug (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6562";>#6562) https://github.com/patternfly/patternfly-react/commit/bdc63f6a091228f1c3a77726c3cfae7a5fb46d8b";>bdc63f6 chore(release): releasing packages [ci skip] https://github.com/patternfly/patternfly-react/commit/db67a489b13d88c8715a42e7a30621104db3f8b0";>db67a48 chore(deps): update dependency @patternfly/patternfly to v4.159.1 (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6599";>#6599) https://github.com/patternfly/patternfly-react/commit/b72bb1b70233499abc5af4e35ab3ea72b7049f7f";>b72bb1b Dynamic tooltip content (https://github-redirect.dependabot.com/patternfly/patternfly-react/issues/6598";>#6598) https://github.com/patternfly/patternfly-react/commit/031e0e31853e92aae5dc072a24fdea96403f0472";>031e0e3 chore(release): releasing packages [ci skip] Additional commits viewable in https://github.com/patternfly/patternfly-react/compare/@patternfly/react-topology@4.9.42...@patternfly/react-topology@4.22.4";>compare view Maintainer changes This version was pushed to npm by https://www.npmjs.com/~patternfly-build";>patternfly-build, a new releaser for @patternfly/react-topology since your current version. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reope
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1403: Bump @patternfly/react-topology from 4.9.42 to 4.15.8 in /console/react
dependabot[bot] closed pull request #1403: URL: https://github.com/apache/qpid-dispatch/pull/1403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1403: Bump @patternfly/react-topology from 4.9.42 to 4.15.8 in /console/react
dependabot[bot] commented on pull request #1403: URL: https://github.com/apache/qpid-dispatch/pull/1403#issuecomment-973065930 Superseded by #1445. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2290) Use of uninitialized data
[
https://issues.apache.org/jira/browse/DISPATCH-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-2290:
-
Description:
https://github.com/jiridanek/qpid-dispatch/runs/4253734843?check_suite_focus=true#step:28:10895
{noformat}
==2028==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x56b3c3 in qd_dispatch
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
#1 0x4c2346 in main_process
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92:16
#2 0x4c05d8 in main
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369:9
#3 0x7f398fd39b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
#4 0x43fdbd in _start
(/__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/router/qdrouterd+0x43fdbd)
Uninitialized value was created by an allocation of 'st' in the stack frame
of function 'qd_dispatch'
#0 0x56ab90 in qd_dispatch
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:77
SUMMARY: MemorySanitizer: use-of-uninitialized-value
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
in qd_dispatch
{noformat}
{code}
struct stat st;
if (stat(python_pkgdir, &st)) {
qd_error_errno(errno, "Cannot find Python library path '%s'",
python_pkgdir);
return NULL;
} else if (!S_ISDIR(st.st_mode)) {
qd_error(QD_ERROR_RUNTIME, "Python library path '%s' not a
directory", python_pkgdir);
return NULL;
}
{code}
-The problem looks obvious. If {{stat}} function fails, dispatch tries to
examine {{st.st_mode}}. Looks like a trivial coding mistake.-
This issue highlights that we don't currently regularly run undefined-memory
checker with qdrouterd.
was:
https://github.com/jiridanek/qpid-dispatch/runs/4253734843?check_suite_focus=true#step:28:10895
{noformat}
==2028==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x56b3c3 in qd_dispatch
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
#1 0x4c2346 in main_process
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92:16
#2 0x4c05d8 in main
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369:9
#3 0x7f398fd39b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
#4 0x43fdbd in _start
(/__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/router/qdrouterd+0x43fdbd)
Uninitialized value was created by an allocation of 'st' in the stack frame
of function 'qd_dispatch'
#0 0x56ab90 in qd_dispatch
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:77
SUMMARY: MemorySanitizer: use-of-uninitialized-value
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
in qd_dispatch
{noformat}
{code}
struct stat st;
if (stat(python_pkgdir, &st)) {
qd_error_errno(errno, "Cannot find Python library path '%s'",
python_pkgdir);
return NULL;
} else if (!S_ISDIR(st.st_mode)) {
qd_error(QD_ERROR_RUNTIME, "Python library path '%s' not a
directory", python_pkgdir);
return NULL;
}
{code}
The problem looks obvious. If {{stat}} function fails, dispatch tries to
examine {{st.st_mode}}. Looks like a trivial coding mistake.
This issue highlights that we don't currently regularly run undefined-memory
checker with qdrouterd.
> Use of uninitialized data
> -
>
> Key: DISPATCH-2290
> URL: https://issues.apache.org/jira/browse/DISPATCH-2290
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Jiri Daněk
>Priority: Major
>
> https://github.com/jiridanek/qpid-dispatch/runs/4253734843?check_suite_focus=true#step:28:10895
> {noformat}
> ==2028==WARNING: MemorySanitizer: use-of-uninitialized-value
> #0 0x56b3c3 in qd_dispatch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
> #1 0x4c2346 in main_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92:16
> #2 0x4c05d8 in main
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369:9
> #3 0x7f398fd39b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
> #4 0x43fdbd in _start
> (/__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/router/qdrouterd+0x43fdbd)
> Uninitialized value was created by an allocation of 'st' in the stack frame
> of function 'qd_dispatch'
> #0 0x56ab90 in qd_dispatch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:77
> SUMMARY: MemorySanitizer: use-of-uninitialized-value
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
> in qd_dispat
[jira] [Commented] (DISPATCH-2290) Use of uninitialized data
[
https://issues.apache.org/jira/browse/DISPATCH-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446063#comment-17446063
]
Jiri Daněk commented on DISPATCH-2290:
--
Actually, the code looks correct to me.
> Use of uninitialized data
> -
>
> Key: DISPATCH-2290
> URL: https://issues.apache.org/jira/browse/DISPATCH-2290
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Jiri Daněk
>Priority: Major
>
> https://github.com/jiridanek/qpid-dispatch/runs/4253734843?check_suite_focus=true#step:28:10895
> {noformat}
> ==2028==WARNING: MemorySanitizer: use-of-uninitialized-value
> #0 0x56b3c3 in qd_dispatch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
> #1 0x4c2346 in main_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92:16
> #2 0x4c05d8 in main
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369:9
> #3 0x7f398fd39b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
> #4 0x43fdbd in _start
> (/__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/router/qdrouterd+0x43fdbd)
> Uninitialized value was created by an allocation of 'st' in the stack frame
> of function 'qd_dispatch'
> #0 0x56ab90 in qd_dispatch
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:77
> SUMMARY: MemorySanitizer: use-of-uninitialized-value
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:99:20
> in qd_dispatch
> {noformat}
> {code}
> struct stat st;
> if (stat(python_pkgdir, &st)) {
> qd_error_errno(errno, "Cannot find Python library path '%s'",
> python_pkgdir);
> return NULL;
> } else if (!S_ISDIR(st.st_mode)) {
> qd_error(QD_ERROR_RUNTIME, "Python library path '%s' not a
> directory", python_pkgdir);
> return NULL;
> }
> {code}
> -The problem looks obvious. If {{stat}} function fails, dispatch tries to
> examine {{st.st_mode}}. Looks like a trivial coding mistake.-
> This issue highlights that we don't currently regularly run undefined-memory
> checker with qdrouterd.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1442: Bump @patternfly/patternfly from 4.125.3 to 4.159.1 in /console/react
codecov-commenter commented on pull request #1442: URL: https://github.com/apache/qpid-dispatch/pull/1442#issuecomment-973194207 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1442?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1442](https://codecov.io/gh/apache/qpid-dispatch/pull/1442?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d35c42f) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/210571f9c354961fdc636dedc9e440b877047afa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (210571f) will **increase** coverage by `0.12%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1442?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1442 +/- ## == + Coverage 84.71% 84.83% +0.12% == Files 116 116 Lines 2861928619 == + Hits2424424280 +36 + Misses 4375 4339 -36 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1442?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1442/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1442/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.90% <0.00%> (+0.55%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1442/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1442/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.81% <0.00%> (+1.07%)` | :arrow_up: | | [...odules/stuck\_delivery\_detection/delivery\_tracker.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1442/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvc3R1Y2tfZGVsaXZlcnlfZGV0ZWN0aW9uL2RlbGl2ZXJ5X3RyYWNrZXIuYw==) | `98.48% <0.00%> (+1.51%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1442/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `79.19% <0.00%> (+1.79%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1442/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1442?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1443: Bump @patternfly/react-styles from 4.11.8 to 4.25.4 in /console/react
codecov-commenter commented on pull request #1443: URL: https://github.com/apache/qpid-dispatch/pull/1443#issuecomment-973205447 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1443](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f77cfd4) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/210571f9c354961fdc636dedc9e440b877047afa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (210571f) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1443 +/- ## == + Coverage 84.71% 84.75% +0.03% == Files 116 116 Lines 2861928619 == + Hits2424424255 +11 + Misses 4375 4364 -11 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.73% <0.00%> (ø)` | | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.21% <0.00%> (+0.09%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (+0.09%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.53% <0.00%> (+0.18%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [210571f...f77cfd4](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr&el=lastupdated&utm_medium=referral&ut
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1445: Bump @patternfly/react-topology from 4.9.42 to 4.22.4 in /console/react
codecov-commenter commented on pull request #1445: URL: https://github.com/apache/qpid-dispatch/pull/1445#issuecomment-973241869 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1445?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1445](https://codecov.io/gh/apache/qpid-dispatch/pull/1445?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c3b1721) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/210571f9c354961fdc636dedc9e440b877047afa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (210571f) will **increase** coverage by `0.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1445 +/- ## == + Coverage 84.71% 84.77% +0.05% == Files 116 116 Lines 2861928619 == + Hits2424424261 +17 + Misses 4375 4358 -17 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1445/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.35% <0.00%> (-0.14%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1445/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (+0.09%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1445/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1445/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.90% <0.00%> (+0.55%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1445/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1445/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.81% <0.00%> (+1.07%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1445/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1445?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apa
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1441: DISPATCH-2258: Cleaned up log messages, created senders after receive…
ganeshmurthy commented on a change in pull request #1441: URL: https://github.com/apache/qpid-dispatch/pull/1441#discussion_r752641101 ## File path: tests/system_tests_distribution.py ## @@ -3826,6 +3823,7 @@ def __init__(self, self.error= None self.messages_per_sender = 100 Review comment: I am curious to find out why this test is failing. I am sure the failure has nothing to do with the number of messages sent. I want to push this logging change to main and analyze the debug output when the test fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2258) test_25_parallel_waypoint_test failing in system_tests_distribution
[
https://issues.apache.org/jira/browse/DISPATCH-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446153#comment-17446153
]
ASF GitHub Bot commented on DISPATCH-2258:
--
ganeshmurthy commented on a change in pull request #1441:
URL: https://github.com/apache/qpid-dispatch/pull/1441#discussion_r752641101
##
File path: tests/system_tests_distribution.py
##
@@ -3826,6 +3823,7 @@ def __init__(self,
self.error= None
self.messages_per_sender = 100
Review comment:
I am curious to find out why this test is failing. I am sure the failure
has nothing to do with the number of messages sent. I want to push this logging
change to main and analyze the debug output when the test fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> test_25_parallel_waypoint_test failing in system_tests_distribution
> ---
>
> Key: DISPATCH-2258
> URL: https://issues.apache.org/jira/browse/DISPATCH-2258
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
>
> {noformat}
> 37: ==
> 37: FAIL: test_25_parallel_waypoint_test
> (system_tests_distribution.DistributionTests)
> 37: --
> 37: Traceback (most recent call last):
> 37: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_distribution.py",
> line 1641, in test_25_parallel_waypoint_test
> 37: self.assertIsNone(test.error)
> 37: AssertionError: 'Timeout Expired: n_sent=200 n_rcvd=194 n_thru=198' is
> not None
> 37:
> 37: --
> 37: Ran 25 tests in 344.700s
> 37:
> 37: FAILED (failures=1, skipped=7)
> 37/73 Test #37: system_tests_distribution .***Failed
> 344.85 sec {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1441: DISPATCH-2258: Cleaned up log messages, created senders after receive…
ganeshmurthy commented on a change in pull request #1441:
URL: https://github.com/apache/qpid-dispatch/pull/1441#discussion_r752662207
##
File path: tests/system_tests_distribution.py
##
@@ -3910,11 +3908,9 @@ def send_from_client(self, sender, n_messages,
sender_index):
n_sent += 1
self.n_sent+= 1
self.n_transitions += 1
-self.debug_print("send_from_client -- sender: %d n_sent: %d" %
(sender_index, n_sent))
+self.debug_print("send_from_client -- sender: %d n_sent: %d" %
(sender_index, n_sent))
Review comment:
Actually, no. The loop in send_from_waypoint prints the
message_content_number, so I want to keep the print inside the loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2258) test_25_parallel_waypoint_test failing in system_tests_distribution
[
https://issues.apache.org/jira/browse/DISPATCH-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446164#comment-17446164
]
ASF GitHub Bot commented on DISPATCH-2258:
--
ganeshmurthy commented on a change in pull request #1441:
URL: https://github.com/apache/qpid-dispatch/pull/1441#discussion_r752662207
##
File path: tests/system_tests_distribution.py
##
@@ -3910,11 +3908,9 @@ def send_from_client(self, sender, n_messages,
sender_index):
n_sent += 1
self.n_sent+= 1
self.n_transitions += 1
-self.debug_print("send_from_client -- sender: %d n_sent: %d" %
(sender_index, n_sent))
+self.debug_print("send_from_client -- sender: %d n_sent: %d" %
(sender_index, n_sent))
Review comment:
Actually, no. The loop in send_from_waypoint prints the
message_content_number, so I want to keep the print inside the loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> test_25_parallel_waypoint_test failing in system_tests_distribution
> ---
>
> Key: DISPATCH-2258
> URL: https://issues.apache.org/jira/browse/DISPATCH-2258
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
>
> {noformat}
> 37: ==
> 37: FAIL: test_25_parallel_waypoint_test
> (system_tests_distribution.DistributionTests)
> 37: --
> 37: Traceback (most recent call last):
> 37: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_distribution.py",
> line 1641, in test_25_parallel_waypoint_test
> 37: self.assertIsNone(test.error)
> 37: AssertionError: 'Timeout Expired: n_sent=200 n_rcvd=194 n_thru=198' is
> not None
> 37:
> 37: --
> 37: Ran 25 tests in 344.700s
> 37:
> 37: FAILED (failures=1, skipped=7)
> 37/73 Test #37: system_tests_distribution .***Failed
> 344.85 sec {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2467) Tidy up C++ reconnect test
[ https://issues.apache.org/jira/browse/PROTON-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2467. - Resolution: Fixed > Tidy up C++ reconnect test > -- > > Key: PROTON-2467 > URL: https://issues.apache.org/jira/browse/PROTON-2467 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > * Make code a bit simpler by extracting some common code out from duplicted > tests > * More use of C++11 to make the code a bit easier to read. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2441) [cpp] Crash upon reconnect when user passed empty vector to connection_options::failover_urls
[
https://issues.apache.org/jira/browse/PROTON-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved PROTON-2441.
-
Resolution: Fixed
> [cpp] Crash upon reconnect when user passed empty vector to
> connection_options::failover_urls
> -
>
> Key: PROTON-2441
> URL: https://issues.apache.org/jira/browse/PROTON-2441
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
>Affects Versions: proton-c-0.36.0
> Environment: Linux fedora 5.11.12-300.fc34.x86_64 #1 SMP Wed Apr 7
> 16:31:13 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
> NAME=Fedora
> VERSION="34 (Workstation Edition)"
> ID=fedora
> VERSION_ID=34
> VERSION_CODENAME=""
> PLATFORM_ID="platform:f34"
>Reporter: Rakhi Kumari
>Assignee: Rakhi Kumari
>Priority: Major
> Fix For: proton-c-0.37.0
>
>
> {noformat}
> $ gdb ./reconnect_client
> (gdb) run amqp://127.0.0.1 examples 1
> Starting program:
> /home/rkumari/repos/qpid-proton/build/cpp/examples/reconnect_client
> amqp://127.0.0.1 examples 1
> Missing separate debuginfos, use: dnf debuginfo-install
> glibc-2.33-5.fc34.x86_64
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib64/libthread_db.so.1".
> Retries: 0 Delay: 0 Trying: NO URL@0 SZ: 0
> *Program received signal SIGSEGV, Segmentation fault.*
> 0x77cf1104 in std::basic_ostream >&
> std::operator<< , std::allocator
> >(std::basic_ostream >&,
> std::__cxx11::basic_string, std::allocator
> > const&) () from /lib64/libstdc++.so.6
> (gdb) backtrace
> #0 0x77cf1104 in std::basic_ostream >&
> std::operator<< , std::allocator
> >(std::basic_ostream >&,
> std::__cxx11::basic_string, std::allocator
> > const&) () from /lib64/libstdc++.so.6
> #1 0x77e984b5 in proton::container::impl::reconnect (this=0x43c640,
> pnc=0x43df10) at
> /home/rkumari/repos/qpid-proton/cpp/src/proactor_container_impl.cpp:241
> #2 0x77ead66d in std::__invoke_impl (proton::container::impl::*&)(pn_connection_t*), proton::container::impl*&,
> pn_connection_t*&> (__f=
> @0x446060: (void (proton::container::impl::*)(proton::container::impl *
> const, pn_connection_t *)) 0x77e97ed4
> , __t=@0x446078:
> 0x43c640)
> at /usr/include/c++/11/bits/invoke.h:74
> #3 0x77ead1d6 in std::__invoke (proton::container::impl::*&)(pn_connection_t*), proton::container::impl*&,
> pn_connection_t*&> (__fn=
> @0x446060: (void (proton::container::impl::*)(proton::container::impl *
> const, pn_connection_t *)) 0x77e97ed4
> ) at
> /usr/include/c++/11/bits/invoke.h:96
> #4 0x77eacd73 in std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>::__call 1ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) (this=0x446060, __args=...)
> at /usr/include/c++/11/functional:420
> #5 0x77eac7a6 in std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>::operator()<, void>() (this=0x446060)
> at /usr/include/c++/11/functional:503
> #6 0x77eaba21 in std::__invoke_impl (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&>(std::__invoke_other, std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&) (__f=...) at
> /usr/include/c++/11/bits/invoke.h:61
> #7 0x77eaa497 in std::__invoke_r (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&>(std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&) (__fn=...) at
> /usr/include/c++/11/bits/invoke.h:154
> #8 0x77ea8cdf in std::_Function_handler (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)> >::_M_invoke(std::_Any_data const&)
> (__functor=...)
> at /usr/include/c++/11/bits/std_function.h:291
> #9 0x77e9f12e in std::function::operator()() const
> (this=0x445fa8) at /usr/include/c++/11/bits/std_function.h:560
> #10 0x77e96050 in proton::internal::v11::work::operator()
> (this=0x445fa8) at
> /home/rkumari/repos/qpid-proton/cpp/include/proton/work_queue.hpp:283
> #11 0x77e9ba47 in proton::container::impl::run_timer_jobs
> (this=0x43c640) at
> /home/rkumari/repos/qpid-proton/cpp/src/proactor_container_impl.cpp:536
> #12 0x77e9be69 in proton::container::impl::dispatch (this=0x43c640,
> event=0x43f160) at
> /home/rkumari/repos/qpid-proton/cpp/src/proactor_container_impl.cpp:567
> #13 0x77e9db82 in proton::container::impl::thread (this=0x43c640) at
> /home/rkumari/repos/qpid-proton/cpp/src/proactor_container_impl.cpp:755
> #14 0x77e9e8c
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1420: DISPATCH-2065: Added timer to check for deleted connection
codecov-commenter commented on pull request #1420: URL: https://github.com/apache/qpid-dispatch/pull/1420#issuecomment-973583309 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1420](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c40b2fd) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/210571f9c354961fdc636dedc9e440b877047afa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (210571f) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main#1420 +/- ## === Coverage 84.71% 84.71% === Files 116 116 Lines 2861928617-2 === - Hits2424424243-1 + Misses 4375 4374-1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.44% <0.00%> (-0.68%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.55% <0.00%> (+0.05%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.63% <0.00%> (+0.16%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `86.01% <0.00%> (+0.27%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.16% <0.00%> (+0.43%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [210571f...c40b2fd](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.i
[jira] [Commented] (DISPATCH-2065) AttributeError: 'DeleteConnectionWithReceiver' object has no attribute 'n_sent'
[ https://issues.apache.org/jira/browse/DISPATCH-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446221#comment-17446221 ] ASF GitHub Bot commented on DISPATCH-2065: -- codecov-commenter commented on pull request #1420: URL: https://github.com/apache/qpid-dispatch/pull/1420#issuecomment-973583309 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1420](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c40b2fd) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/210571f9c354961fdc636dedc9e440b877047afa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (210571f) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main#1420 +/- ## === Coverage 84.71% 84.71% === Files 116 116 Lines 2861928617-2 === - Hits2424424243-1 + Misses 4375 4374-1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.44% <0.00%> (-0.68%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.55% <0.00%> (+0.05%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.63% <0.00%> (+0.16%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `86.01% <0.00%> (+0.27%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.16% <0.00%> (+0.43%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1420?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [210
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1441: DISPATCH-2258: Cleaned up log messages, created senders after receive…
codecov-commenter commented on pull request #1441: URL: https://github.com/apache/qpid-dispatch/pull/1441#issuecomment-973675453 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1441](https://codecov.io/gh/apache/qpid-dispatch/pull/1441?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60f2763) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/210571f9c354961fdc636dedc9e440b877047afa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (210571f) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1441?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1441 +/- ## == - Coverage 84.71% 84.69% -0.03% == Files 116 116 Lines 2861928619 == - Hits2424424238 -6 - Misses 4375 4381 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1441?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.05% <0.00%> (-1.06%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.57% <0.00%> (-0.48%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.25% <0.00%> (-0.20%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.42% <0.00%> (-0.07%)` | :arrow_down: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/hash.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2hhc2guYw==) | `80.00% <0.00%> (+0.46%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1441?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to
[jira] [Commented] (DISPATCH-2258) test_25_parallel_waypoint_test failing in system_tests_distribution
[ https://issues.apache.org/jira/browse/DISPATCH-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446250#comment-17446250 ] ASF GitHub Bot commented on DISPATCH-2258: -- codecov-commenter commented on pull request #1441: URL: https://github.com/apache/qpid-dispatch/pull/1441#issuecomment-973675453 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1441](https://codecov.io/gh/apache/qpid-dispatch/pull/1441?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60f2763) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/210571f9c354961fdc636dedc9e440b877047afa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (210571f) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1441?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1441 +/- ## == - Coverage 84.71% 84.69% -0.03% == Files 116 116 Lines 2861928619 == - Hits2424424238 -6 - Misses 4375 4381 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1441?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.05% <0.00%> (-1.06%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.57% <0.00%> (-0.48%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.25% <0.00%> (-0.20%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.42% <0.00%> (-0.07%)` | :arrow_down: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/hash.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2hhc2guYw==) | `80.00% <0.00%> (+0.46%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1441/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | -- [Continue
[jira] [Created] (PROTON-2468) Fix some undefined behaviour found by ubsan
Andrew Stitcher created PROTON-2468: --- Summary: Fix some undefined behaviour found by ubsan Key: PROTON-2468 URL: https://issues.apache.org/jira/browse/PROTON-2468 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: proton-c-0.37.0 Reporter: Andrew Stitcher Assignee: Andrew Stitcher Fix For: proton-c-0.37.0 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2468) Fix some undefined behaviour found by ubsan
[ https://issues.apache.org/jira/browse/PROTON-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2468. - Resolution: Fixed > Fix some undefined behaviour found by ubsan > --- > > Key: PROTON-2468 > URL: https://issues.apache.org/jira/browse/PROTON-2468 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.37.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.37.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2468) Fix some undefined behaviour found by ubsan
[GitHub] [qpid-proton] astitcher commented on a change in pull request #340: PROTON-2396: Use random_device for seed initialization in uuid.cpp
astitcher commented on a change in pull request #340:
URL: https://github.com/apache/qpid-proton/pull/340#discussion_r752828384
##
File path: cpp/include/proton/uuid.hpp
##
@@ -35,13 +38,20 @@ namespace proton {
/// A 16-byte universally unique identifier.
class uuid : public byte_array<16> {
+
+ private:
+thread_local static std::independent_bits_engine
+engine;
+thread_local static std::seed_seq seed;
+
Review comment:
Actually thinking a bit more. It probably doesn't actually change the
ABI. But it does unnecessarily leak implementation details of the uuid class.
IMO it's better to just make these static thread_local in the implementation
file without putting them in the class at all. This will generate pretty much
exactly the same code but is better encapsulated (again IMO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2396) [cpp] Seed in uuid.cpp can lead to duplicates
[
https://issues.apache.org/jira/browse/PROTON-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446254#comment-17446254
]
ASF GitHub Bot commented on PROTON-2396:
astitcher commented on a change in pull request #340:
URL: https://github.com/apache/qpid-proton/pull/340#discussion_r752828384
##
File path: cpp/include/proton/uuid.hpp
##
@@ -35,13 +38,20 @@ namespace proton {
/// A 16-byte universally unique identifier.
class uuid : public byte_array<16> {
+
+ private:
+thread_local static std::independent_bits_engine
+engine;
+thread_local static std::seed_seq seed;
+
Review comment:
Actually thinking a bit more. It probably doesn't actually change the
ABI. But it does unnecessarily leak implementation details of the uuid class.
IMO it's better to just make these static thread_local in the implementation
file without putting them in the class at all. This will generate pretty much
exactly the same code but is better encapsulated (again IMO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Seed in uuid.cpp can lead to duplicates
> -
>
> Key: PROTON-2396
> URL: https://issues.apache.org/jira/browse/PROTON-2396
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
> Environment: RHEL7 running in OpenStack
> docker-ce 19.03.5
> qpid-proton 0.28.0
> qpid-cpp 1.37.0
>Reporter: Ryan Herbert
>Assignee: Rakhi Kumari
>Priority: Major
>
> The random number seed used in qpid-proton/cpp/src/uuid.cpp is based on the
> current time and the PID of the running process. When starting multiple
> proton instances simultaneously in Docker containers via automated
> deployment, there is a high probability that multiple instances will get the
> same seed since the PID within the Docker container is consistent and the
> same across multiple copies of the same Docker container.
> This results in duplicate link names when binding to exchanges. When this
> happens, the queue gets bound to two different exchanges, and requests sent
> to one exchange will get responses from both services.
> To work around this error, we are specifying the link name via
> sender_options/receiver_options every time we open a new sender/receiver, and
> we also specify the container_id in connection_options. We are using
> std::mt19937_64 seeded with
> std::chrono::system_clock::now().time_since_epoch().count() to generate the
> random part of our link names, which seems to have enough randomness that it
> has eliminated the problem for us.
> As pointed out in the Proton user forum, std::random_device is probably a
> better choice for initializing the seed.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
