[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1443: Bump @patternfly/react-styles from 4.11.8 to 4.25.4 in /console/react
codecov-commenter edited a comment on pull request #1443: URL: https://github.com/apache/qpid-dispatch/pull/1443#issuecomment-973205447 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1443](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f77cfd4) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/210571f9c354961fdc636dedc9e440b877047afa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (210571f) will **increase** coverage by `0.10%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1443 +/- ## == + Coverage 84.71% 84.81% +0.10% == Files 116 116 Lines 2861928695 +76 == + Hits2424424339 +95 + Misses 4375 4356 -19 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.21% <0.00%> (+0.09%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.53% <0.00%> (+0.18%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.65% <0.00%> (+0.19%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.95% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.38% <0.00%> (+1.15%)` | :arrow_up: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2Rpc3BhdGNoLmM=) | `88.23% <0.00%> (+1.38%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | | [src/http-none.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1443/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2h0dHAtbm9uZS5j) | `62.50% <0.00%> (+12.50%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1443?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn
[jira] [Commented] (DISPATCH-2270) Do not rely on long type being large enough to transfer C pointer values from C to Python
[
https://issues.apache.org/jira/browse/DISPATCH-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446883#comment-17446883
]
ASF GitHub Bot commented on DISPATCH-2270:
--
jiridanek merged pull request #1409:
URL: https://github.com/apache/qpid-dispatch/pull/1409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Do not rely on long type being large enough to transfer C pointer values from
> C to Python
> -
>
> Key: DISPATCH-2270
> URL: https://issues.apache.org/jira/browse/DISPATCH-2270
> Project: Qpid Dispatch
> Issue Type: Sub-task
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {code}
> // We pass pointers as longs via the python interface, make sure this is safe.
> STATIC_ASSERT(sizeof(long) >= sizeof(void*), pointer_is_bigger_than_long);
> {code}
> This is wrong on Win64, where long is 4 bytes. There is multiple possible
> solutions:
> # use {{long long}}, trivial workaround
> ** https://docs.python.org/3/c-api/arg.html#c.Py_BuildValue
> # construct the python value explicitly, probably the nicest solution, and
> should not even add extra overhead
> ** https://docs.python.org/3/c-api/long.html#c.PyLong_FromVoidPtr
> # use PyCapsules, not a good fit for existing code, requires changing
> signature in C on the callee side
> ** https://docs.python.org/3/c-api/capsule.html
> **
> https://docs.python.org/3/extending/extending.html?highlight=capsule#providing-a-c-api-for-an-extension-module
> and maybe even more possibilities. I am inclined to go with the
> PyLong_FromVoidPtr value constructor.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2270) Do not rely on long type being large enough to transfer C pointer values from C to Python
[
https://issues.apache.org/jira/browse/DISPATCH-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446882#comment-17446882
]
ASF subversion and git services commented on DISPATCH-2270:
---
Commit 906b9314fc5e1d4f3286cc7de81a97cd18c56198 in qpid-dispatch's branch
refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=906b931 ]
DISPATCH-2270 Use PyLong_FromVoidPtr to reliably pass void* values into Python
regardless of platform type sizes (#1409)
> Do not rely on long type being large enough to transfer C pointer values from
> C to Python
> -
>
> Key: DISPATCH-2270
> URL: https://issues.apache.org/jira/browse/DISPATCH-2270
> Project: Qpid Dispatch
> Issue Type: Sub-task
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {code}
> // We pass pointers as longs via the python interface, make sure this is safe.
> STATIC_ASSERT(sizeof(long) >= sizeof(void*), pointer_is_bigger_than_long);
> {code}
> This is wrong on Win64, where long is 4 bytes. There is multiple possible
> solutions:
> # use {{long long}}, trivial workaround
> ** https://docs.python.org/3/c-api/arg.html#c.Py_BuildValue
> # construct the python value explicitly, probably the nicest solution, and
> should not even add extra overhead
> ** https://docs.python.org/3/c-api/long.html#c.PyLong_FromVoidPtr
> # use PyCapsules, not a good fit for existing code, requires changing
> signature in C on the callee side
> ** https://docs.python.org/3/c-api/capsule.html
> **
> https://docs.python.org/3/extending/extending.html?highlight=capsule#providing-a-c-api-for-an-extension-module
> and maybe even more possibilities. I am inclined to go with the
> PyLong_FromVoidPtr value constructor.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1409: DISPATCH-2270 Use PyLong_FromVoidPtr to reliably pass void* values into Python regardless of platform type sizes
jiridanek merged pull request #1409: URL: https://github.com/apache/qpid-dispatch/pull/1409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2270) Do not rely on long type being large enough to transfer C pointer values from C to Python
[
https://issues.apache.org/jira/browse/DISPATCH-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446881#comment-17446881
]
ASF GitHub Bot commented on DISPATCH-2270:
--
jiridanek commented on pull request #1409:
URL: https://github.com/apache/qpid-dispatch/pull/1409#issuecomment-974717940
This is IMO useful on all platforms, so it can be merged even if Windows is
to remain unsupported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Do not rely on long type being large enough to transfer C pointer values from
> C to Python
> -
>
> Key: DISPATCH-2270
> URL: https://issues.apache.org/jira/browse/DISPATCH-2270
> Project: Qpid Dispatch
> Issue Type: Sub-task
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {code}
> // We pass pointers as longs via the python interface, make sure this is safe.
> STATIC_ASSERT(sizeof(long) >= sizeof(void*), pointer_is_bigger_than_long);
> {code}
> This is wrong on Win64, where long is 4 bytes. There is multiple possible
> solutions:
> # use {{long long}}, trivial workaround
> ** https://docs.python.org/3/c-api/arg.html#c.Py_BuildValue
> # construct the python value explicitly, probably the nicest solution, and
> should not even add extra overhead
> ** https://docs.python.org/3/c-api/long.html#c.PyLong_FromVoidPtr
> # use PyCapsules, not a good fit for existing code, requires changing
> signature in C on the callee side
> ** https://docs.python.org/3/c-api/capsule.html
> **
> https://docs.python.org/3/extending/extending.html?highlight=capsule#providing-a-c-api-for-an-extension-module
> and maybe even more possibilities. I am inclined to go with the
> PyLong_FromVoidPtr value constructor.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1409: DISPATCH-2270 Use PyLong_FromVoidPtr to reliably pass void* values into Python regardless of platform type sizes
jiridanek commented on pull request #1409: URL: https://github.com/apache/qpid-dispatch/pull/1409#issuecomment-974717940 This is IMO useful on all platforms, so it can be merged even if Windows is to remain unsupported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1449: NO-JIRA Consistently use Python 3 in all Travis CI jobs
jiridanek merged pull request #1449: URL: https://github.com/apache/qpid-dispatch/pull/1449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1449: NO-JIRA Consistently use Python 3 in all Travis CI jobs
jiridanek commented on pull request #1449: URL: https://github.com/apache/qpid-dispatch/pull/1449#issuecomment-974715611 Travis issue reported in https://issues.apache.org/jira/browse/DISPATCH-2292. Let's see how frequent it is going to be. PR only fixes Travis CI, so it couldn't be responsible for the fail. Will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2292) [http2] system_tests_grpc failed with qd_http2_buffer_t leak
Jiri Daněk created DISPATCH-2292:
Summary: [http2] system_tests_grpc failed with qd_http2_buffer_t
leak
Key: DISPATCH-2292
URL: https://issues.apache.org/jira/browse/DISPATCH-2292
Project: Qpid Dispatch
Issue Type: Bug
Affects Versions: 1.19.0
Reporter: Jiri Daněk
https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/549003884#L10696
{noformat}
70: ERROR: Aborted due to unexpected alloc pool leak of type 'qd_http2_buffer_t'
{noformat}
{noformat}
70: alloc.c: Items of type 'qd_http2_buffer_t' remain allocated at shutdown: 1
70: Leak: 2021-11-20 21:14:56.179730 + type: qd_http2_buffer_t address:
0x629000163290
70: qdrouterd(backtrace+0x5b) [0x47884b]
70: qdrouterd(qd_alloc+0x918) [0x572738]
70: qdrouterd(qd_http2_buffer+0x24) [0x786874]
70: qdrouterd(qd_http2_buffer_list_append+0x81) [0x786a71]
70: qdrouterd() [0x7b9b21]
70: /lib/x86_64-linux-gnu/libnghttp2.so.14(nghttp2_session_send+0x49)
[0x7f5f3a894c89]
70: qdrouterd() [0x7aa9f0]
70: qdrouterd() [0x791536]
70: qdrouterd() [0x777830]
70: qdrouterd() [0x771dd0]
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1449: NO-JIRA Consistently use Python 3 in all Travis CI jobs
codecov-commenter edited a comment on pull request #1449: URL: https://github.com/apache/qpid-dispatch/pull/1449#issuecomment-974699520 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1449](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bff61e1) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/f909ffb13349faff99802f0d18b7740008775292?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f909ffb) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1449 +/- ## == - Coverage 84.80% 84.76% -0.04% == Files 116 116 Lines 2861928619 == - Hits2426924259 -10 - Misses 4350 4360 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.40% <0.00%> (-1.27%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.95% <0.00%> (-0.65%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.73% <0.00%> (-0.28%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.47% <0.00%> (-0.19%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (+0.09%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.90% <0.00%> (+0.55%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.11% <0.00%> (+0.57%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `87.04%
[jira] [Commented] (DISPATCH-2103) Log the actual HTTP websocket listener port when 0 was specified in config
[
https://issues.apache.org/jira/browse/DISPATCH-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446864#comment-17446864
]
ASF GitHub Bot commented on DISPATCH-2103:
--
jiridanek merged pull request #1425:
URL: https://github.com/apache/qpid-dispatch/pull/1425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log the actual HTTP websocket listener port when 0 was specified in config
> --
>
> Key: DISPATCH-2103
> URL: https://issues.apache.org/jira/browse/DISPATCH-2103
> Project: Qpid Dispatch
> Issue Type: New Feature
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> {code}
> if (hl->vhost) {
> /* Store hl pointer in vhost */
> void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, [0],
> sizeof(hl));
> memcpy(vp, , sizeof(hl));
> qd_log(hs->log, QD_LOG_NOTICE, "Listening for HTTP on %s",
> config->host_port);
> return;
> } else {
> qd_log(hs->log, QD_LOG_NOTICE, "Error listening for HTTP on %s",
> config->host_port);
> goto error;
> }
> return;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2103) Log the actual HTTP websocket listener port when 0 was specified in config
[
https://issues.apache.org/jira/browse/DISPATCH-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446862#comment-17446862
]
ASF GitHub Bot commented on DISPATCH-2103:
--
jiridanek commented on pull request #1425:
URL: https://github.com/apache/qpid-dispatch/pull/1425#issuecomment-974704700
Tsan failure in GHA is known issue
https://issues.apache.org/jira/browse/PROTON-2436. Next, on Travis the known
issue https://issues.apache.org/jira/browse/DISPATCH-1689 is manifesting in
VhostPolicyConfigHashPattern test. Also, there are failing `pip install`
commands on Travis, probably due to 3rd party dependencies not installing
correctly. Finally, the AMQP listener port 0 test is failing on macOS.
I'm going to merge this PR despite all that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log the actual HTTP websocket listener port when 0 was specified in config
> --
>
> Key: DISPATCH-2103
> URL: https://issues.apache.org/jira/browse/DISPATCH-2103
> Project: Qpid Dispatch
> Issue Type: New Feature
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> {code}
> if (hl->vhost) {
> /* Store hl pointer in vhost */
> void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, [0],
> sizeof(hl));
> memcpy(vp, , sizeof(hl));
> qd_log(hs->log, QD_LOG_NOTICE, "Listening for HTTP on %s",
> config->host_port);
> return;
> } else {
> qd_log(hs->log, QD_LOG_NOTICE, "Error listening for HTTP on %s",
> config->host_port);
> goto error;
> }
> return;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2103) Log the actual HTTP websocket listener port when 0 was specified in config
[
https://issues.apache.org/jira/browse/DISPATCH-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446863#comment-17446863
]
ASF subversion and git services commented on DISPATCH-2103:
---
Commit f909ffb13349faff99802f0d18b7740008775292 in qpid-dispatch's branch
refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=f909ffb ]
DISPATCH-2103 Log actual HTTP listener port number when 0 is configured (#1425)
Unit tests and related changes for the log message amount to much of the bulk
of this commit.
* Old g++ (RHEL 7) does not properly implement regexes
* On Ubuntu and rarely Fedora, and all other modern Linuxes, the
qd_lws_listener_free is sometimes not called in my test. This is resolved with
the .finalize, available only in LibWebSockets 3.1 (RHEL 7 has version 3.0.1)
> Log the actual HTTP websocket listener port when 0 was specified in config
> --
>
> Key: DISPATCH-2103
> URL: https://issues.apache.org/jira/browse/DISPATCH-2103
> Project: Qpid Dispatch
> Issue Type: New Feature
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> {code}
> if (hl->vhost) {
> /* Store hl pointer in vhost */
> void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, [0],
> sizeof(hl));
> memcpy(vp, , sizeof(hl));
> qd_log(hs->log, QD_LOG_NOTICE, "Listening for HTTP on %s",
> config->host_port);
> return;
> } else {
> qd_log(hs->log, QD_LOG_NOTICE, "Error listening for HTTP on %s",
> config->host_port);
> goto error;
> }
> return;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1425: DISPATCH-2103 Log actual HTTP listener port number when 0 is configured
jiridanek merged pull request #1425: URL: https://github.com/apache/qpid-dispatch/pull/1425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1425: DISPATCH-2103 Log actual HTTP listener port number when 0 is configured
jiridanek commented on pull request #1425: URL: https://github.com/apache/qpid-dispatch/pull/1425#issuecomment-974704700 Tsan failure in GHA is known issue https://issues.apache.org/jira/browse/PROTON-2436. Next, on Travis the known issue https://issues.apache.org/jira/browse/DISPATCH-1689 is manifesting in VhostPolicyConfigHashPattern test. Also, there are failing `pip install` commands on Travis, probably due to 3rd party dependencies not installing correctly. Finally, the AMQP listener port 0 test is failing on macOS. I'm going to merge this PR despite all that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1449: NO-JIRA Consistently use Python 3 in all Travis CI jobs
codecov-commenter commented on pull request #1449: URL: https://github.com/apache/qpid-dispatch/pull/1449#issuecomment-974699520 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1449](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (298d685) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/ef3e34cfa9b4a8ffbbd513a22bd5f70cac2fab89?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ef3e34c) will **decrease** coverage by `0.00%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1449 +/- ## == - Coverage 84.77% 84.76% -0.01% == Files 116 116 Lines 2861928618 -1 == - Hits2426224259 -3 - Misses 4357 4359 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.34% <0.00%> (-0.56%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.34% <0.00%> (-0.15%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.11% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.38% <0.00%> (+0.21%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.18% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1449/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `82.17% <0.00%> (+0.55%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [ef3e34c...298d685](https://codecov.io/gh/apache/qpid-dispatch/pull/1449?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
[jira] [Commented] (DISPATCH-2103) Log the actual HTTP websocket listener port when 0 was specified in config
[ https://issues.apache.org/jira/browse/DISPATCH-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446857#comment-17446857 ] ASF GitHub Bot commented on DISPATCH-2103: -- codecov-commenter edited a comment on pull request #1425: URL: https://github.com/apache/qpid-dispatch/pull/1425#issuecomment-962281395 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1425](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (611a8c0) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/ef3e34cfa9b4a8ffbbd513a22bd5f70cac2fab89?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ef3e34c) will **decrease** coverage by `0.03%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1425 +/- ## == - Coverage 84.77% 84.73% -0.04% == Files 116 116 Lines 2861928618 -1 == - Hits2426224250 -12 - Misses 4357 4368 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.38% <100.00%> (+1.15%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `88.96% <0.00%> (-1.25%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.08% <0.00%> (-0.32%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.73% <0.00%> (-0.28%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.49% <0.00%> (ø)` | | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (+0.09%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.15% <0.00%> (+0.19%)` | :arrow_up: | |
[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1425: DISPATCH-2103 Log actual HTTP listener port number when 0 is configured
codecov-commenter edited a comment on pull request #1425: URL: https://github.com/apache/qpid-dispatch/pull/1425#issuecomment-962281395 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1425](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (611a8c0) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/ef3e34cfa9b4a8ffbbd513a22bd5f70cac2fab89?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ef3e34c) will **decrease** coverage by `0.03%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1425 +/- ## == - Coverage 84.77% 84.73% -0.04% == Files 116 116 Lines 2861928618 -1 == - Hits2426224250 -12 - Misses 4357 4368 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.38% <100.00%> (+1.15%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `88.96% <0.00%> (-1.25%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.08% <0.00%> (-0.32%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.73% <0.00%> (-0.28%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.49% <0.00%> (ø)` | | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (+0.09%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.15% <0.00%> (+0.19%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.38% <0.00%> (+0.21%)` | :arrow_up: | | ... and [2
[jira] [Commented] (DISPATCH-2103) Log the actual HTTP websocket listener port when 0 was specified in config
[ https://issues.apache.org/jira/browse/DISPATCH-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446854#comment-17446854 ] ASF GitHub Bot commented on DISPATCH-2103: -- codecov-commenter edited a comment on pull request #1425: URL: https://github.com/apache/qpid-dispatch/pull/1425#issuecomment-962281395 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1425](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (63c60ec) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/ef3e34cfa9b4a8ffbbd513a22bd5f70cac2fab89?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ef3e34c) will **decrease** coverage by `0.03%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1425 +/- ## == - Coverage 84.77% 84.74% -0.04% == Files 116 116 Lines 2861928619 == - Hits2426224252 -10 - Misses 4357 4367 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.38% <100.00%> (+1.15%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.15% <0.00%> (-1.06%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.73% <0.00%> (-0.44%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.73% <0.00%> (-0.28%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.35% <0.00%> (-0.14%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `94.08% <0.00%> (+0.18%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.18% <0.00%> (+0.21%)` | :arrow_up: | | ... and [2
[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1425: DISPATCH-2103 Log actual HTTP listener port number when 0 is configured
codecov-commenter edited a comment on pull request #1425: URL: https://github.com/apache/qpid-dispatch/pull/1425#issuecomment-962281395 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1425](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (63c60ec) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/ef3e34cfa9b4a8ffbbd513a22bd5f70cac2fab89?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ef3e34c) will **decrease** coverage by `0.03%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1425 +/- ## == - Coverage 84.77% 84.74% -0.04% == Files 116 116 Lines 2861928619 == - Hits2426224252 -10 - Misses 4357 4367 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1425?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `87.38% <100.00%> (+1.15%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.15% <0.00%> (-1.06%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.73% <0.00%> (-0.44%)` | :arrow_down: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.73% <0.00%> (-0.28%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.35% <0.00%> (-0.14%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `94.08% <0.00%> (+0.18%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.18% <0.00%> (+0.21%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1425/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report at
[jira] [Commented] (DISPATCH-2103) Log the actual HTTP websocket listener port when 0 was specified in config
[
https://issues.apache.org/jira/browse/DISPATCH-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446845#comment-17446845
]
ASF GitHub Bot commented on DISPATCH-2103:
--
jiridanek commented on a change in pull request #1425:
URL: https://github.com/apache/qpid-dispatch/pull/1425#discussion_r753696907
##
File path: src/http-libwebsockets.c
##
@@ -374,25 +380,38 @@ static void listener_start(qd_lws_listener_t *hl,
qd_http_server_t *hs) {
info.options |=
LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
-#if LWS_LIBRARY_VERSION_MAJOR > 3 || (LWS_LIBRARY_VERSION_MAJOR == 3 &&
LWS_LIBRARY_VERSION_MINOR >= 2)
+#ifdef QD_HAVE_MODERN_LIBWEBSOCKETS
(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT |
LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER) |
#else
(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT) |
#endif
((config->requireAuthentication && info.ssl_ca_filepath) ?
LWS_SERVER_OPTION_REQUIRE_VALID_OPENSSL_CLIENT_CERT : 0);
}
info.vhost_name = hl->listener->config.host_port;
+#ifdef QD_HAVE_MODERN_LIBWEBSOCKETS
+info.finalize = finalize_http;
+info.finalize_arg = hl;
+#endif
hl->vhost = lws_create_vhost(hs->context, );
-if (hl->vhost) {
-/* Store hl pointer in vhost */
-void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, [0],
sizeof(hl));
-memcpy(vp, , sizeof(hl));
-qd_log(hs->log, QD_LOG_NOTICE, "Listening for HTTP on %s",
config->host_port);
-return;
-} else {
+if (!hl->vhost) {
qd_log(hs->log, QD_LOG_NOTICE, "Error listening for HTTP on %s",
config->host_port);
goto error;
}
+
+/* Store hl pointer in vhost */
+void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, [0],
sizeof(hl));
+memcpy(vp, , sizeof(hl));
+
+if (port == 0) {
+// If a 0 (zero) is specified for a port, get the actual listening
port from the listener.
+const int resolved_port = lws_get_vhost_port(hl->vhost);
Review comment:
The vhost is started successfully at this point, so there had to be an
actual port number assigned to it at some point. I'm adding the assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log the actual HTTP websocket listener port when 0 was specified in config
> --
>
> Key: DISPATCH-2103
> URL: https://issues.apache.org/jira/browse/DISPATCH-2103
> Project: Qpid Dispatch
> Issue Type: New Feature
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> {code}
> if (hl->vhost) {
> /* Store hl pointer in vhost */
> void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, [0],
> sizeof(hl));
> memcpy(vp, , sizeof(hl));
> qd_log(hs->log, QD_LOG_NOTICE, "Listening for HTTP on %s",
> config->host_port);
> return;
> } else {
> qd_log(hs->log, QD_LOG_NOTICE, "Error listening for HTTP on %s",
> config->host_port);
> goto error;
> }
> return;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1425: DISPATCH-2103 Log actual HTTP listener port number when 0 is configured
jiridanek commented on a change in pull request #1425:
URL: https://github.com/apache/qpid-dispatch/pull/1425#discussion_r753696907
##
File path: src/http-libwebsockets.c
##
@@ -374,25 +380,38 @@ static void listener_start(qd_lws_listener_t *hl,
qd_http_server_t *hs) {
info.options |=
LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
-#if LWS_LIBRARY_VERSION_MAJOR > 3 || (LWS_LIBRARY_VERSION_MAJOR == 3 &&
LWS_LIBRARY_VERSION_MINOR >= 2)
+#ifdef QD_HAVE_MODERN_LIBWEBSOCKETS
(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT |
LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER) |
#else
(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT) |
#endif
((config->requireAuthentication && info.ssl_ca_filepath) ?
LWS_SERVER_OPTION_REQUIRE_VALID_OPENSSL_CLIENT_CERT : 0);
}
info.vhost_name = hl->listener->config.host_port;
+#ifdef QD_HAVE_MODERN_LIBWEBSOCKETS
+info.finalize = finalize_http;
+info.finalize_arg = hl;
+#endif
hl->vhost = lws_create_vhost(hs->context, );
-if (hl->vhost) {
-/* Store hl pointer in vhost */
-void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, [0],
sizeof(hl));
-memcpy(vp, , sizeof(hl));
-qd_log(hs->log, QD_LOG_NOTICE, "Listening for HTTP on %s",
config->host_port);
-return;
-} else {
+if (!hl->vhost) {
qd_log(hs->log, QD_LOG_NOTICE, "Error listening for HTTP on %s",
config->host_port);
goto error;
}
+
+/* Store hl pointer in vhost */
+void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, [0],
sizeof(hl));
+memcpy(vp, , sizeof(hl));
+
+if (port == 0) {
+// If a 0 (zero) is specified for a port, get the actual listening
port from the listener.
+const int resolved_port = lws_get_vhost_port(hl->vhost);
Review comment:
The vhost is started successfully at this point, so there had to be an
actual port number assigned to it at some point. I'm adding the assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
