[jira] [Commented] (PROTON-2593) [protonj2] Add additional tests for split frame decoding
[ https://issues.apache.org/jira/browse/PROTON-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583852#comment-17583852 ] ASF subversion and git services commented on PROTON-2593: - Commit 7c4ebc8602e2a16c2c0c9267f44a044e97de7029 in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=7c4ebc86 ] PROTON-2593 Add frame decode handler tests for split frames > [protonj2] Add additional tests for split frame decoding > > > Key: PROTON-2593 > URL: https://issues.apache.org/jira/browse/PROTON-2593 > Project: Qpid Proton > Issue Type: Improvement > Components: protonj2 >Affects Versions: protonj2-1.0.0-M8 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2593) [protonj2] Add additional tests for split frame decoding
[ https://issues.apache.org/jira/browse/PROTON-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy A. Bish updated PROTON-2593: Fix Version/s: protonj2-1.0.0-M9 > [protonj2] Add additional tests for split frame decoding > > > Key: PROTON-2593 > URL: https://issues.apache.org/jira/browse/PROTON-2593 > Project: Qpid Proton > Issue Type: Improvement > Components: protonj2 >Affects Versions: protonj2-1.0.0-M8 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2593) [protonj2] Add additional tests for split frame decoding
Timothy A. Bish created PROTON-2593: --- Summary: [protonj2] Add additional tests for split frame decoding Key: PROTON-2593 URL: https://issues.apache.org/jira/browse/PROTON-2593 Project: Qpid Proton Issue Type: Improvement Components: protonj2 Affects Versions: protonj2-1.0.0-M8 Reporter: Timothy A. Bish Assignee: Timothy A. Bish -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583838#comment-17583838 ] ASF GitHub Bot commented on PROTON-2347: BenD10 commented on PR #43: URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1224830720 Hi @gemmellr, I'm hopeful you can take a look at this whenever you have a chance. Thanks in advance! > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.8 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Priority: Minor > Fix For: proton-j-future > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton-j] BenD10 commented on pull request #43: PROTON-2347 Prevent leak when IOException is encountered
BenD10 commented on PR #43: URL: https://github.com/apache/qpid-proton-j/pull/43#issuecomment-1224830720 Hi @gemmellr, I'm hopeful you can take a look at this whenever you have a chance. Thanks in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2347) Reactor leaks file handles when an IO Exception is encountered
[ https://issues.apache.org/jira/browse/PROTON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583822#comment-17583822 ] ASF GitHub Bot commented on PROTON-2347: BenD10 opened a new pull request, #43: URL: https://github.com/apache/qpid-proton-j/pull/43 https://issues.apache.org/jira/browse/PROTON-2347 When an IOException is thrown, the SocketChannel was not properly cleaned up which caused a file descriptor leak. To confirm the fix, I used the reproducer available in the above JIRA and monitored open file handles. Using 0.33.10: ``` ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:14 PM EDT 60086 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:17 PM EDT 85005 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:21 PM EDT 116822 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:27 PM EDT 155766 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:33 PM EDT 209201 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:41 PM EDT 275748 ``` With the fix on 0.34.0-SNAPSHOT ``` ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:23 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:26 PM EDT 40 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:32 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:47 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:54 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:41:01 PM EDT 44 ``` > Reactor leaks file handles when an IO Exception is encountered > -- > > Key: PROTON-2347 > URL: https://issues.apache.org/jira/browse/PROTON-2347 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.8 > Environment: Windows 10 desktop >Reporter: Tim Taylor >Priority: Minor > Fix For: proton-j-future > > Attachments: repro.txt > > > When I try to open a connection using proton-j while my machine doesn't have > internet access, I see that proton-j leaks file descriptors. Attached is the > sample I wrote that repro's this issue. I'm looking either for guidance on > how to handle IOExceptions in the onTransportError callback, or for a > confirmation that what I'm doing to handle them is correct, and that there is > a bug in proton-j around this scenario. > > If you need help viewing the file descriptor count growing over time, the > [process explorer > tool|https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer] > is what I've been using. Running the sample in a loop will make this leak > more obvious, but it isn't required to leak the file descriptors. This same > bug seems to happen in Linux and MacOS as well. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton-j] BenD10 opened a new pull request, #43: PROTON-2347 Prevent leak when IOException is encountered
BenD10 opened a new pull request, #43: URL: https://github.com/apache/qpid-proton-j/pull/43 https://issues.apache.org/jira/browse/PROTON-2347 When an IOException is thrown, the SocketChannel was not properly cleaned up which caused a file descriptor leak. To confirm the fix, I used the reproducer available in the above JIRA and monitored open file handles. Using 0.33.10: ``` ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:14 PM EDT 60086 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:17 PM EDT 85005 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:21 PM EDT 116822 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:27 PM EDT 155766 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:33 PM EDT 209201 ben@ubuntu:~$ date && lsof -p 34755 | wc -l Tue 23 Aug 2022 03:24:41 PM EDT 275748 ``` With the fix on 0.34.0-SNAPSHOT ``` ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:23 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:26 PM EDT 40 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:32 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:47 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:40:54 PM EDT 44 ben@ubuntu:~/git/qpid-proton-j$ date && lsof -p 36940 | wc -l Tue 23 Aug 2022 03:41:01 PM EDT 44 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
