[GitHub] [qpid-proton] astitcher merged pull request #376: NO-JIRA: Fix type of `bytes` test data for message id in python tests
astitcher merged PR #376: URL: https://github.com/apache/qpid-proton/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2401) on_link_closed is not called when remote detaches link and locally link is also closed.
[ https://issues.apache.org/jira/browse/PROTON-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709116#comment-17709116 ] ASF GitHub Bot commented on PROTON-2401: astitcher commented on PR #391: URL: https://github.com/apache/qpid-proton/pull/391#issuecomment-1498188256 I've modified the original PR: * The same logic should apply to the connection and session events too * No need to call xxx_close as you'll only get the _close event after the xxx_xlose API is called already I'd like to add some use of these event/some tests to be sure this change is good before merging it. > on_link_closed is not called when remote detaches link and locally link is > also closed. > --- > > Key: PROTON-2401 > URL: https://issues.apache.org/jira/browse/PROTON-2401 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.34.0 >Reporter: NS-SlaFleur >Assignee: Andrew Stitcher >Priority: Minor > > The on_link_closed for the MessagingHandler is not called when the link is > first detached by the remote and then locally. This is due to a missing > on_link_local_close in the EndpointStateHandler in _handlers.py. > > Pull Request: https://github.com/apache/qpid-proton/pull/323 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #391: PROTON-2401: [Python] on_xxx_closed should be called on locally closed after remote close
astitcher commented on PR #391: URL: https://github.com/apache/qpid-proton/pull/391#issuecomment-1498188256 I've modified the original PR: * The same logic should apply to the connection and session events too * No need to call xxx_close as you'll only get the _close event after the xxx_xlose API is called already I'd like to add some use of these event/some tests to be sure this change is good before merging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2401) on_link_closed is not called when remote detaches link and locally link is also closed.
[ https://issues.apache.org/jira/browse/PROTON-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709114#comment-17709114 ] ASF GitHub Bot commented on PROTON-2401: astitcher opened a new pull request, #391: URL: https://github.com/apache/qpid-proton/pull/391 When links/sessions/connections are remotely closed then locally closed the on_xxx_closed event should still fire. The existing code only fires this event for local then remote close. This is the continuation of #323 > on_link_closed is not called when remote detaches link and locally link is > also closed. > --- > > Key: PROTON-2401 > URL: https://issues.apache.org/jira/browse/PROTON-2401 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.34.0 >Reporter: NS-SlaFleur >Assignee: Andrew Stitcher >Priority: Minor > > The on_link_closed for the MessagingHandler is not called when the link is > first detached by the remote and then locally. This is due to a missing > on_link_local_close in the EndpointStateHandler in _handlers.py. > > Pull Request: https://github.com/apache/qpid-proton/pull/323 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher opened a new pull request, #391: PROTON-2401: [Python] on_xxx_closed should be called on locally closed after remote close
astitcher opened a new pull request, #391: URL: https://github.com/apache/qpid-proton/pull/391 When links/sessions/connections are remotely closed then locally closed the on_xxx_closed event should still fire. The existing code only fires this event for local then remote close. This is the continuation of #323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-2401) on_link_closed is not called when remote detaches link and locally link is also closed.
[ https://issues.apache.org/jira/browse/PROTON-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reassigned PROTON-2401: --- Assignee: Andrew Stitcher > on_link_closed is not called when remote detaches link and locally link is > also closed. > --- > > Key: PROTON-2401 > URL: https://issues.apache.org/jira/browse/PROTON-2401 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.34.0 >Reporter: NS-SlaFleur >Assignee: Andrew Stitcher >Priority: Minor > > The on_link_closed for the MessagingHandler is not called when the link is > first detached by the remote and then locally. This is due to a missing > on_link_local_close in the EndpointStateHandler in _handlers.py. > > Pull Request: https://github.com/apache/qpid-proton/pull/323 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] Jmennius commented on pull request #388: NO-JIRA: [Python] Allow configuration of container ID
Jmennius commented on PR #388: URL: https://github.com/apache/qpid-proton/pull/388#issuecomment-1497843962 > @Jmennius I've merged a neater version of this change with a test to make sure it works. Note you'll likely get a faster response at least from me) if you include a test or two for your changes. Thanks! will consider fort the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #388: NO-JIRA: [Python] Allow configuration of container ID
astitcher commented on PR #388: URL: https://github.com/apache/qpid-proton/pull/388#issuecomment-1497829984 @Jmennius I've merged a neater version of this change with a test to make sure it works. Note you'll likely get a faster response at least from me) if you include a test or two for your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2706) [Python] Allow setting the container id for containers/connections
[ https://issues.apache.org/jira/browse/PROTON-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709016#comment-17709016 ] ASF subversion and git services commented on PROTON-2706: - Commit c4f7ee4636ccb9574edb7ed13cb004d3589153db in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=c4f7ee463 ] PROTON-2706: [Python] Allow setting the container id You can set the container id either on the Container class or using the connect call. This closes #388 > [Python] Allow setting the container id for containers/connections > -- > > Key: PROTON-2706 > URL: https://issues.apache.org/jira/browse/PROTON-2706 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > This is an improvement suggested by [~jmennius] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] asfgit closed pull request #388: NO-JIRA: [Python] Allow configuration of container ID
asfgit closed pull request #388: NO-JIRA: [Python] Allow configuration of container ID URL: https://github.com/apache/qpid-proton/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2706) [Python] Allow setting the container id for containers/connections
Andrew Stitcher created PROTON-2706: --- Summary: [Python] Allow setting the container id for containers/connections Key: PROTON-2706 URL: https://issues.apache.org/jira/browse/PROTON-2706 Project: Qpid Proton Issue Type: Improvement Reporter: Andrew Stitcher Assignee: Andrew Stitcher This is an improvement suggested by [~jmennius] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2183) [cpp client] No messaging_handler callback for aborted messages
[
https://issues.apache.org/jira/browse/PROTON-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708821#comment-17708821
]
ASF GitHub Bot commented on PROTON-2183:
DreamPearl commented on PR #387:
URL: https://github.com/apache/qpid-proton/pull/387#issuecomment-1497338754
PR merged as
https://github.com/apache/qpid-proton/commit/058e2928dad9d016fe14a8b6690547e39cdfd0fd.
TODO: Add test (in-progress)
> [cpp client] No messaging_handler callback for aborted messages
> ---
>
> Key: PROTON-2183
> URL: https://issues.apache.org/jira/browse/PROTON-2183
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
>Affects Versions: proton-c-0.30.0
>Reporter: Charles E. Rolke
>Assignee: Rakhi Kumari
>Priority: Major
> Attachments: PROTON-2183-send-receive-console.log
>
>
> A cpp receiver throws "receiver read failure" when an aborted message is
> received.
> A client based on:
> {{ class simple_recv : public proton::messaging_handler}}
> does not get called at (on_transport_error, on_connection_error,
> on_session_error, on_sender_error, on_receiver_error, on_error). The
> exception is thrown back to main() and the client application has no way to
> intercept it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2183) [cpp client] No messaging_handler callback for aborted messages
[
https://issues.apache.org/jira/browse/PROTON-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708822#comment-17708822
]
ASF GitHub Bot commented on PROTON-2183:
DreamPearl closed pull request #387: PROTON-2183: [cpp] Fix aborted messages
exception.
URL: https://github.com/apache/qpid-proton/pull/387
> [cpp client] No messaging_handler callback for aborted messages
> ---
>
> Key: PROTON-2183
> URL: https://issues.apache.org/jira/browse/PROTON-2183
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
>Affects Versions: proton-c-0.30.0
>Reporter: Charles E. Rolke
>Assignee: Rakhi Kumari
>Priority: Major
> Attachments: PROTON-2183-send-receive-console.log
>
>
> A cpp receiver throws "receiver read failure" when an aborted message is
> received.
> A client based on:
> {{ class simple_recv : public proton::messaging_handler}}
> does not get called at (on_transport_error, on_connection_error,
> on_session_error, on_sender_error, on_receiver_error, on_error). The
> exception is thrown back to main() and the client application has no way to
> intercept it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on pull request #387: PROTON-2183: [cpp] Fix aborted messages exception.
DreamPearl commented on PR #387: URL: https://github.com/apache/qpid-proton/pull/387#issuecomment-1497338754 PR merged as https://github.com/apache/qpid-proton/commit/058e2928dad9d016fe14a8b6690547e39cdfd0fd. TODO: Add test (in-progress) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl closed pull request #387: PROTON-2183: [cpp] Fix aborted messages exception.
DreamPearl closed pull request #387: PROTON-2183: [cpp] Fix aborted messages exception. URL: https://github.com/apache/qpid-proton/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
