[jira] [Resolved] (PROTON-2751) Reduce use of pn_buffer_t when not needed
[ https://issues.apache.org/jira/browse/PROTON-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2751. - Fix Version/s: proton-c-0.40.0 Resolution: Fixed > Reduce use of pn_buffer_t when not needed > - > > Key: PROTON-2751 > URL: https://issues.apache.org/jira/browse/PROTON-2751 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.40.0 > > > pn_buffer_t has complex logic to hold and manage a ring buffer. But is being > used just to manage a resizeable bytes buffer. And in most of those places > the buffer doesn't really nned to be resized either! > So it can be replaced in many places with much simpler code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2753) Split util.h to separate the C++ safe parts out of the C99 but not C++ parts
[ https://issues.apache.org/jira/browse/PROTON-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2753. - Fix Version/s: proton-c-0.40.0 Resolution: Fixed > Split util.h to separate the C++ safe parts out of the C99 but not C++ parts > > > Key: PROTON-2753 > URL: https://issues.apache.org/jira/browse/PROTON-2753 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.40.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2752) Use pn_string_t/pn_bytes_t instead of raw char*
[ https://issues.apache.org/jira/browse/PROTON-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2752. - Fix Version/s: proton-c-0.40.0 Resolution: Fixed > Use pn_string_t/pn_bytes_t instead of raw char* > --- > > Key: PROTON-2752 > URL: https://issues.apache.org/jira/browse/PROTON-2752 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.40.0 > > > There are a few places where we hold a pn_string_t convert it to char* then > convert it to pn_bytes_t. We can "cut out the middleman"! and be more > efficient and have less code overall! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2750) [protonj2] Add some additional functionality to the AMQP test peer
[ https://issues.apache.org/jira/browse/PROTON-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742163#comment-17742163 ] ASF subversion and git services commented on PROTON-2750: - Commit 19e48d4fa31e67fd8a70746f081906b39083d959 in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=19e48d4f ] PROTON-2750 Ensure the frame parser is ready for AMQP header on connect Always reset the frame parser to expect AMQP headers on a new connection > [protonj2] Add some additional functionality to the AMQP test peer > -- > > Key: PROTON-2750 > URL: https://issues.apache.org/jira/browse/PROTON-2750 > Project: Qpid Proton > Issue Type: Task > Components: protonj2 >Affects Versions: protonj2-1.0.0-M16 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: protonj2-1.0.0-M17 > > > Add some additional testing APIs to the test peer. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2750) [protonj2] Add some additional functionality to the AMQP test peer
[ https://issues.apache.org/jira/browse/PROTON-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742164#comment-17742164 ] ASF subversion and git services commented on PROTON-2750: - Commit 06341414b44ca796cd7d4fa09da83bc66920be26 in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=06341414 ] PROTON-2750 Add API for expecting null source or target in Attach Allows easier scripting of expecting null source or target in Attach response which would inidcate incoming detach from remote. > [protonj2] Add some additional functionality to the AMQP test peer > -- > > Key: PROTON-2750 > URL: https://issues.apache.org/jira/browse/PROTON-2750 > Project: Qpid Proton > Issue Type: Task > Components: protonj2 >Affects Versions: protonj2-1.0.0-M16 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: protonj2-1.0.0-M17 > > > Add some additional testing APIs to the test peer. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2751) Reduce use of pn_buffer_t when not needed
[ https://issues.apache.org/jira/browse/PROTON-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742157#comment-17742157 ] ASF subversion and git services commented on PROTON-2751: - Commit a2c54b3a245356b734e22bbdd5f732ed00d44398 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=a2c54b3a2 ] PROTON-2751: Use pn_rwbytes_t not pn_buffer_t for scratch space > Reduce use of pn_buffer_t when not needed > - > > Key: PROTON-2751 > URL: https://issues.apache.org/jira/browse/PROTON-2751 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_buffer_t has complex logic to hold and manage a ring buffer. But is being > used just to manage a resizeable bytes buffer. And in most of those places > the buffer doesn't really nned to be resized either! > So it can be replaced in many places with much simpler code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2752) Use pn_string_t/pn_bytes_t instead of raw char*
[ https://issues.apache.org/jira/browse/PROTON-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742160#comment-17742160 ] ASF subversion and git services commented on PROTON-2752: - Commit 97fcd648fd826a68b3e0d681d054c11031e6b06a in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=97fcd648f ] PROTON-2752: Make more use of pn_string_t instead of char* > Use pn_string_t/pn_bytes_t instead of raw char* > --- > > Key: PROTON-2752 > URL: https://issues.apache.org/jira/browse/PROTON-2752 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > There are a few places where we hold a pn_string_t convert it to char* then > convert it to pn_bytes_t. We can "cut out the middleman"! and be more > efficient and have less code overall! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2751) Reduce use of pn_buffer_t when not needed
[ https://issues.apache.org/jira/browse/PROTON-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742158#comment-17742158 ] ASF subversion and git services commented on PROTON-2751: - Commit f2693f29d1226b224477c3eab62654c49499ec6b in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=f2693f29d ] PROTON-2751: Don't use pn_buffer for delivery tag > Reduce use of pn_buffer_t when not needed > - > > Key: PROTON-2751 > URL: https://issues.apache.org/jira/browse/PROTON-2751 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_buffer_t has complex logic to hold and manage a ring buffer. But is being > used just to manage a resizeable bytes buffer. And in most of those places > the buffer doesn't really nned to be resized either! > So it can be replaced in many places with much simpler code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2751) Reduce use of pn_buffer_t when not needed
[ https://issues.apache.org/jira/browse/PROTON-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742159#comment-17742159 ] ASF subversion and git services commented on PROTON-2751: - Commit 31e25638ea74551465f1331c41bdfaced5438b69 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=31e25638e ] PROTON-2751: Remove unused functionality of pn_buffer_t Also rearrange implementation struct to be more efficient > Reduce use of pn_buffer_t when not needed > - > > Key: PROTON-2751 > URL: https://issues.apache.org/jira/browse/PROTON-2751 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > pn_buffer_t has complex logic to hold and manage a ring buffer. But is being > used just to manage a resizeable bytes buffer. And in most of those places > the buffer doesn't really nned to be resized either! > So it can be replaced in many places with much simpler code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2753) Split util.h to separate the C++ safe parts out of the C99 but not C++ parts
[ https://issues.apache.org/jira/browse/PROTON-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742156#comment-17742156 ] ASF subversion and git services commented on PROTON-2753: - Commit 0545b51c234260fe6977e8545c785a442732950d in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=0545b51c2 ] PROTON-2753: Split util.h so that we can keep the C++ in the schannel impl happy > Split util.h to separate the C++ safe parts out of the C99 but not C++ parts > > > Key: PROTON-2753 > URL: https://issues.apache.org/jira/browse/PROTON-2753 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2753) Split util.h to separate the C++ safe parts out of the C99 but not C++ parts
Andrew Stitcher created PROTON-2753: --- Summary: Split util.h to separate the C++ safe parts out of the C99 but not C++ parts Key: PROTON-2753 URL: https://issues.apache.org/jira/browse/PROTON-2753 Project: Qpid Proton Issue Type: Improvement Components: proton-c Reporter: Andrew Stitcher Assignee: Andrew Stitcher -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2752) Use pn_string_t/pn_bytes_t instead of raw char*
Andrew Stitcher created PROTON-2752: --- Summary: Use pn_string_t/pn_bytes_t instead of raw char* Key: PROTON-2752 URL: https://issues.apache.org/jira/browse/PROTON-2752 Project: Qpid Proton Issue Type: Improvement Components: proton-c Reporter: Andrew Stitcher Assignee: Andrew Stitcher There are a few places where we hold a pn_string_t convert it to char* then convert it to pn_bytes_t. We can "cut out the middleman"! and be more efficient and have less code overall! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2751) Reduce use of pn_buffer_t when not needed
Andrew Stitcher created PROTON-2751: --- Summary: Reduce use of pn_buffer_t when not needed Key: PROTON-2751 URL: https://issues.apache.org/jira/browse/PROTON-2751 Project: Qpid Proton Issue Type: Improvement Components: proton-c Reporter: Andrew Stitcher Assignee: Andrew Stitcher pn_buffer_t has complex logic to hold and manage a ring buffer. But is being used just to manage a resizeable bytes buffer. And in most of those places the buffer doesn't really nned to be resized either! So it can be replaced in many places with much simpler code. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
