[jira] [Closed] (PROTON-2545) raw connection: client disconnect is ignored if no read buffers are available.

2023-10-02 Thread Clifford Jansen (Jira)


 [ 
https://issues.apache.org/jira/browse/PROTON-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clifford Jansen closed PROTON-2545.
---
Resolution: Won't Fix

Opposite approach taken.  See 2748.  If there is a need to revisit, it would be 
best to open a new Jira with reference to these older issues with new info on 
why the decision needs refining.

> raw connection: client disconnect is ignored if no read buffers are available.
> --
>
> Key: PROTON-2545
> URL: https://issues.apache.org/jira/browse/PROTON-2545
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.37.0
>Reporter: Ken Giusti
>Assignee: Clifford Jansen
>Priority: Major
>
> Refer to [https://github.com/skupperproject/skupper-router/issues/477]
> TL;DR - if a client closes its TCP connection (full drop - not half close), 
> the proactor cannot post a PN_RAW_CONNECTION_DISCONNECTED event unless read 
> buffers have been provided to the raw connection.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-2763) Two final disconnect events possible from a raw connection

2023-10-02 Thread Clifford Jansen (Jira)


 [ 
https://issues.apache.org/jira/browse/PROTON-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clifford Jansen resolved PROTON-2763.
-
Fix Version/s: proton-c-0.40.0
   Resolution: Fixed

> Two final disconnect events possible from a raw connection
> --
>
> Key: PROTON-2763
> URL: https://issues.apache.org/jira/browse/PROTON-2763
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.39.0
>Reporter: Clifford Jansen
>Assignee: Clifford Jansen
>Priority: Major
> Fix For: proton-c-0.40.0
>
>
> In writing a new threaderciser for raw connections the following scenario can 
> result in a state machine mixup and second disconnect.
> If a pn_raw_connection_wake() occurs around the time that the first 
> disconnect event is being consumed the task may be added to the global ready 
> list for processing.  The batch done() processing will (correctly) defer the 
> task cleanup until the task is next scheduled via the ready list.  However 
> the raw connection forgets that it has already done the disconnect and 
> restarts the state machine at the first disconnect stage, resulting in the 
> second disconnect event.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-2764) Zombie raw connections

2023-10-02 Thread Clifford Jansen (Jira)


 [ 
https://issues.apache.org/jira/browse/PROTON-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clifford Jansen resolved PROTON-2764.
-
Fix Version/s: proton-c-0.40.0
   Resolution: Fixed

> Zombie raw connections
> --
>
> Key: PROTON-2764
> URL: https://issues.apache.org/jira/browse/PROTON-2764
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.39.0
>Reporter: Clifford Jansen
>Assignee: Clifford Jansen
>Priority: Major
> Fix For: proton-c-0.40.0
>
>
> In writing a new threaderciser for raw connections the following scenario can 
> result in raw connections that are never scheduled.
> If a pn_listener_raw_accept() fails due to a temporary fdlimit shortage or 
> simultaneous close of the listener by another thread, the new raw connection 
> is correctly set to an error state but is never scheduled for processing.  
> The state machine is never advanced and the raw connection resources are not 
> cleaned up.  This also causes the PN_PROACTOR_INACTIVE event to be blocked.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org