[jira] [Commented] (QPID-8352) Official Docker image for Broker-J
[ https://issues.apache.org/jira/browse/QPID-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784896#comment-17784896 ] ASF GitHub Bot commented on QPID-8352: -- gemmellr commented on code in PR #225: URL: https://github.com/apache/qpid-broker-j/pull/225#discussion_r1389259459 ## qpid-docker/docker-build.sh: ## @@ -0,0 +1,181 @@ +#!/bin/sh +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from_local_dist= +from_release= +local_dist_path= +qpid_version= +MY_NAME=$(basename "$0") + +print_help() +{ + cat << END_OF_HELP +Usage: $MY_NAME [OPTION]... + + options: + + --release Apache Qpid Broker-J release version to build with + --local-dist-path Path to the local Apache Qpid Broker-J distribution to build with + --help, -h, -? Print this help and exit + +END_OF_HELP +} + +parse_parameters() +{ + while [ $# -gt 0 ]; do +case $1 in + --local-dist-path) + from_local_dist=true + local_dist_path=$2 + shift;; + --release) + from_release=true + qpid_version=$2 + shift;; + --help | -h | -?) + print_help; exit 0;; + *) + echo "Unknown parameter '$1'" + exit 2;; +esac + shift + done + + if [ -n "${local_dist_path}" ] && [ -n "${qpid_version}" ]; then +echo "Please specify either building image from local installation or from a particular release version, but not both" +exit 2 + fi + + if [ -z "${local_dist_path}" ] && [ -z "${qpid_version}" ]; then +print_help +echo "Please specify either building image from local installation or from a particular release version" +exit 2 + fi + + if [ -n "${local_dist_path}" ]; then + +if [ ! -f "${local_dist_path}" ]; then + echo "Local distribution file ${local_dist_path} not found" + exit 1 +fi + +if [ "$(echo ${local_dist_path} | tail -c 7)" != "tar.gz" ]; then + echo "Local distribution file ${local_dist_path} should be a tar.gz archive" + exit 1 +fi + fi +} + +install() +{ + qpid_dist_dir="./qpid-broker-j" + qpid_dist_file_name= + + # Prepare directory + if [ ! -d "${qpid_dist_dir}" ]; then +echo "Creating directory ${qpid_dist_dir}" +mkdir -p "${qpid_dist_dir}" + elif [ ! -z "$(find "${temp_dir}" -name "${qpid_version}" -type d -mmin +60)" ]; then +echo "Cleaning up directory ${qpid_dist_dir}" +rm -rf ${qpid_dist_dir}/* + else +echo "Using directory ${qpid_dist_dir}" + fi + + if [ -n "${from_release}" ]; then + +qpid_dist_file_name="apache-qpid-broker-j-${qpid_version}-bin.tar.gz" + +# Check if the release is already available locally, if not try to download it +if [ -z "$(ls -A ${qpid_dist_dir})" ]; then + cdn="$(curl -s https://www.apache.org/dyn/closer.cgi\?preferred=true)/qpid/broker-j/${qpid_version}/binaries/" + archive="https://archive.apache.org/dist/qpid/broker-j/${qpid_version}/binaries/"; + qpid_base_url=${cdn} + curl_output="${qpid_dist_dir}/${qpid_dist_file_name}" + + # Fallback to the apache archive if the version doesn't exist on the CDN anymore + if [ -z "$(curl -Is ${qpid_base_url}${qpid_dist_file_name} | head -n 1 | grep 200)" ]; then +qpid_base_url=${archive} + +# If the archive also doesn't work then report the failure and abort +if [ -z "$(curl -Is ${qpid_base_url}${qpid_dist_file_name} | head -n 1 | grep 200)" ]; then + echo "Failed to find ${qpid_dist_file_name}. Tried both ${cdn} and ${archive}." + exit 1 +fi + fi + + echo "Downloading ${qpid_dist_file_name} from ${qpid_base_url}..." + curl --progress-bar "${qpid_base_url}${qpid_dist_file_name}" --output "${curl_output}" + +fi + + elif [ -n "${from_local_dist}" ]; then + +qpid_dist_file_name=$(basename ${local_dist_path}) +qpid_version=$(echo "$qpid_dist_file_name" | sed -e 's/apache-qpid-broker-j-\(.*\)-bin.tar.gz/\1/') + +echo "Broker-J distribution file is $qpid_dist_file_name" +echo "Broker-J version is $qpid_version" + +echo "Copying ${local_dist_path} to ${qpid_dist_dir}..." +cp "$loca
Re: [PR] QPID-8352: [Broker-J] Official Docker image for Broker-J [qpid-broker-j]
gemmellr commented on code in PR #225: URL: https://github.com/apache/qpid-broker-j/pull/225#discussion_r1389259459 ## qpid-docker/docker-build.sh: ## @@ -0,0 +1,181 @@ +#!/bin/sh +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from_local_dist= +from_release= +local_dist_path= +qpid_version= +MY_NAME=$(basename "$0") + +print_help() +{ + cat << END_OF_HELP +Usage: $MY_NAME [OPTION]... + + options: + + --release Apache Qpid Broker-J release version to build with + --local-dist-path Path to the local Apache Qpid Broker-J distribution to build with + --help, -h, -? Print this help and exit + +END_OF_HELP +} + +parse_parameters() +{ + while [ $# -gt 0 ]; do +case $1 in + --local-dist-path) + from_local_dist=true + local_dist_path=$2 + shift;; + --release) + from_release=true + qpid_version=$2 + shift;; + --help | -h | -?) + print_help; exit 0;; + *) + echo "Unknown parameter '$1'" + exit 2;; +esac + shift + done + + if [ -n "${local_dist_path}" ] && [ -n "${qpid_version}" ]; then +echo "Please specify either building image from local installation or from a particular release version, but not both" +exit 2 + fi + + if [ -z "${local_dist_path}" ] && [ -z "${qpid_version}" ]; then +print_help +echo "Please specify either building image from local installation or from a particular release version" +exit 2 + fi + + if [ -n "${local_dist_path}" ]; then + +if [ ! -f "${local_dist_path}" ]; then + echo "Local distribution file ${local_dist_path} not found" + exit 1 +fi + +if [ "$(echo ${local_dist_path} | tail -c 7)" != "tar.gz" ]; then + echo "Local distribution file ${local_dist_path} should be a tar.gz archive" + exit 1 +fi + fi +} + +install() +{ + qpid_dist_dir="./qpid-broker-j" + qpid_dist_file_name= + + # Prepare directory + if [ ! -d "${qpid_dist_dir}" ]; then +echo "Creating directory ${qpid_dist_dir}" +mkdir -p "${qpid_dist_dir}" + elif [ ! -z "$(find "${temp_dir}" -name "${qpid_version}" -type d -mmin +60)" ]; then +echo "Cleaning up directory ${qpid_dist_dir}" +rm -rf ${qpid_dist_dir}/* + else +echo "Using directory ${qpid_dist_dir}" + fi + + if [ -n "${from_release}" ]; then + +qpid_dist_file_name="apache-qpid-broker-j-${qpid_version}-bin.tar.gz" + +# Check if the release is already available locally, if not try to download it +if [ -z "$(ls -A ${qpid_dist_dir})" ]; then + cdn="$(curl -s https://www.apache.org/dyn/closer.cgi\?preferred=true)/qpid/broker-j/${qpid_version}/binaries/" + archive="https://archive.apache.org/dist/qpid/broker-j/${qpid_version}/binaries/"; + qpid_base_url=${cdn} + curl_output="${qpid_dist_dir}/${qpid_dist_file_name}" + + # Fallback to the apache archive if the version doesn't exist on the CDN anymore + if [ -z "$(curl -Is ${qpid_base_url}${qpid_dist_file_name} | head -n 1 | grep 200)" ]; then +qpid_base_url=${archive} + +# If the archive also doesn't work then report the failure and abort +if [ -z "$(curl -Is ${qpid_base_url}${qpid_dist_file_name} | head -n 1 | grep 200)" ]; then + echo "Failed to find ${qpid_dist_file_name}. Tried both ${cdn} and ${archive}." + exit 1 +fi + fi + + echo "Downloading ${qpid_dist_file_name} from ${qpid_base_url}..." + curl --progress-bar "${qpid_base_url}${qpid_dist_file_name}" --output "${curl_output}" + +fi + + elif [ -n "${from_local_dist}" ]; then + +qpid_dist_file_name=$(basename ${local_dist_path}) +qpid_version=$(echo "$qpid_dist_file_name" | sed -e 's/apache-qpid-broker-j-\(.*\)-bin.tar.gz/\1/') + +echo "Broker-J distribution file is $qpid_dist_file_name" +echo "Broker-J version is $qpid_version" + +echo "Copying ${local_dist_path} to ${qpid_dist_dir}..." +cp "$local_dist_path" "$qpid_dist_dir" + + else +exit 2 + fi + + echo "Expanding ${qpid_dist_dir}/${qpid_dist_file_name}..." + tar xzf "${qpid_dist_dir}"/"${qpid_dist_file_name}" --directory "${qpid_dist_dir}" --strip 1 + + echo "Removing ${qpid_dist_
Re: [PR] QPID-8661: [Broker-J] Apache Directory dependencies update [qpid-broker-j]
vavrtom merged PR #227: URL: https://github.com/apache/qpid-broker-j/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8661) [Broker-J] Apache Directory dependencies update
[ https://issues.apache.org/jira/browse/QPID-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784949#comment-17784949 ] ASF GitHub Bot commented on QPID-8661: -- vavrtom merged PR #227: URL: https://github.com/apache/qpid-broker-j/pull/227 > [Broker-J] Apache Directory dependencies update > --- > > Key: QPID-8661 > URL: https://issues.apache.org/jira/browse/QPID-8661 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-9.1.0 >Reporter: Daniil Kirilyuk >Priority: Minor > Fix For: qpid-java-broker-9.1.1 > > > New version of Apache Directory (2.0.0.AM27) was released, which is used in > broker tests with LDAP. This version removed some kerberos functionality, and > when updating the dependency version refactoring of the affected unit tests > will be needed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8661) [Broker-J] Apache Directory dependencies update
[ https://issues.apache.org/jira/browse/QPID-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784950#comment-17784950 ] ASF subversion and git services commented on QPID-8661: --- Commit 622671cd4ad78f53ac2c6c60280f4afcf187 in qpid-broker-j's branch refs/heads/main from Daniil Kirilyuk [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=622671cd4a ] QPID-8661: [Broker-J] Apache Directory dependencies update (#227) Co-authored-by: vavrtom > [Broker-J] Apache Directory dependencies update > --- > > Key: QPID-8661 > URL: https://issues.apache.org/jira/browse/QPID-8661 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-9.1.0 >Reporter: Daniil Kirilyuk >Priority: Minor > Fix For: qpid-java-broker-9.1.1 > > > New version of Apache Directory (2.0.0.AM27) was released, which is used in > broker tests with LDAP. This version removed some kerberos functionality, and > when updating the dependency version refactoring of the affected unit tests > will be needed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [PR] QPID-8352: [Broker-J] Official Docker image for Broker-J [qpid-broker-j]
dakirily commented on PR #225: URL: https://github.com/apache/qpid-broker-j/pull/225#issuecomment-1805868471 Hi Robbie, Thank you for the remarks, the scripts and the documentation were updated. We were thinking about starting with the ubuntu images - apache/qpid-broker-j:{version} and apache/qpid-broker-j:latest. Alpine based images could be added later if there will be a demand for it. Best regards, Daniil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8352) Official Docker image for Broker-J
[ https://issues.apache.org/jira/browse/QPID-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784974#comment-17784974 ] ASF GitHub Bot commented on QPID-8352: -- dakirily commented on PR #225: URL: https://github.com/apache/qpid-broker-j/pull/225#issuecomment-1805868471 Hi Robbie, Thank you for the remarks, the scripts and the documentation were updated. We were thinking about starting with the ubuntu images - apache/qpid-broker-j:{version} and apache/qpid-broker-j:latest. Alpine based images could be added later if there will be a demand for it. Best regards, Daniil > Official Docker image for Broker-J > -- > > Key: QPID-8352 > URL: https://issues.apache.org/jira/browse/QPID-8352 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Chris O'Brien >Priority: Minor > > Currently there is no official Docker image for Broker-J. > It would be great if one was provided, as there are more than a few people > interested in running Broker-J in a container, shown by the handful of > inflexible and un-maintained Dockerfiles/images for Broker-J floating around > GitHub/Docker Hub. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org