[PR] QPID-8657: [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal state [qpid-broker-j]
dakirily opened a new pull request, #229: URL: https://github.com/apache/qpid-broker-j/pull/229 This PR addresses [QPID-8657](https://issues.apache.org/jira/browse/QPID-8657), fixing an issue with missing validation of ACL attributes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8657) [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal state
[ https://issues.apache.org/jira/browse/QPID-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793279#comment-17793279 ] ASF GitHub Bot commented on QPID-8657: -- dakirily opened a new pull request, #229: URL: https://github.com/apache/qpid-broker-j/pull/229 This PR addresses [QPID-8657](https://issues.apache.org/jira/browse/QPID-8657), fixing an issue with missing validation of ACL attributes > [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal > state > --- > > Key: QPID-8657 > URL: https://issues.apache.org/jira/browse/QPID-8657 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-9.0.0 >Reporter: Kyrre >Priority: Minor > Attachments: aclRequest.json, qpidErrorLog.txt, resultingAcl.json > > > When POSTing an ACL rule with unknown attributes to the Qpid HTTP management > API, the server responds with HTTP 422, Unprocessable Entity. This is > somewhat OK, however, I think maybe a 400 Bad Request would be more > appropriate. > But after the post, the broker is somehow left in a bad internal state, as > the returned Json is incomplete and unparseable. > Example POST in [^aclRequest.json] > Qpid log from the incident [^qpidErrorLog.txt] > Returned Json from subsequent GET [^resultingAcl.json] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[PR] QPID-8656: [Broker-J] Selector parsing logic error when combining NOT and LIKE [qpid-broker-j]
dakirily opened a new pull request, #230: URL: https://github.com/apache/qpid-broker-j/pull/230 This PR addresses [QPID-8656](https://issues.apache.org/jira/browse/QPID-8656), fixing parsing logic when combining NOT and LIKE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8656) [Broker-J] Selector parsing logic error when combining NOT and LIKE
[ https://issues.apache.org/jira/browse/QPID-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793294#comment-17793294 ] ASF GitHub Bot commented on QPID-8656: -- dakirily opened a new pull request, #230: URL: https://github.com/apache/qpid-broker-j/pull/230 This PR addresses [QPID-8656](https://issues.apache.org/jira/browse/QPID-8656), fixing parsing logic when combining NOT and LIKE > [Broker-J] Selector parsing logic error when combining NOT and LIKE > --- > > Key: QPID-8656 > URL: https://issues.apache.org/jira/browse/QPID-8656 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-9.0.0 >Reporter: Kyrre >Priority: Minor > Fix For: qpid-java-broker-9.1.1 > > > The JMSSelectorFilter.match() gives unexpected results when combining the > LIKE and NOT operators. > The selector "NOT (entry LIKE '%aaa%')" and value "" returns true, as > expected, > The selector "NOT entry LIKE '%aaa%'" and value "" returns false, whcih > is a bug. > In both cases the method retuns true when the value is "" > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
