[jira] [Resolved] (PROTON-2810) C++ compile standard needs to be advanced to c++14 or later
[ https://issues.apache.org/jira/browse/PROTON-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2810. - Fix Version/s: proton-c-0.40.0 Resolution: Fixed > C++ compile standard needs to be advanced to c++14 or later > --- > > Key: PROTON-2810 > URL: https://issues.apache.org/jira/browse/PROTON-2810 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding, examples >Reporter: Kim van der Riet >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.40.0 > > > The use of opentelemetry-cpp API in qpid-proton is forcing the C++ compile > standard to be c++14 or later. The support for c++11 (which qpid-proton is > currently using) in opentelemetry-cpp was removed in v 1.12.0 (we are > currently at version 1.14.2), and the use of its APIs is causing compile > errors. > Consideration should be given to moving the compiler C++ standard to 14, 17 > or even 20. > I have tested the compile using c++17, and this does not create any compile > errors, and solves the opentelemetry-cpp API error too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2831) Mistaken use of logical-or operator instead of bitwise-or operator
[ https://issues.apache.org/jira/browse/PROTON-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2831. - Fix Version/s: proton-c-0.40.0 Resolution: Fixed > Mistaken use of logical-or operator instead of bitwise-or operator > -- > > Key: PROTON-2831 > URL: https://issues.apache.org/jira/browse/PROTON-2831 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.39.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.40.0 > > > This was picked up by tighter warnings in the latest Visual C++ compiler. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2835) [Win TLS] Incorrect certificate checking - not checking time validity
[
https://issues.apache.org/jira/browse/PROTON-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved PROTON-2835.
-
Fix Version/s: proton-c-0.40.0
Resolution: Fixed
> [Win TLS] Incorrect certificate checking - not checking time validity
> -
>
> Key: PROTON-2835
> URL: https://issues.apache.org/jira/browse/PROTON-2835
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: proton-c-0.40.0
>
>
> Due to PROTON-2831 the certificate check flags to
> {{CertGetIssuerCertificateFromStore}} were incorrect and effectively set to 1
> which is just the flag for "Check certificate signature". Additionally an
> extra seemingly invalid flag was set - {{CERT_STORE_NO_ISSUER_FLAG}}. It
> seems that this is purely an _output_ flag and is invalid to set on input.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2835) [Win TLS] Incorrect certificate checking - not checking time validity
[
https://issues.apache.org/jira/browse/PROTON-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862550#comment-17862550
]
ASF subversion and git services commented on PROTON-2835:
-
Commit 9e329f67624b68c89a5ab33c49e6db1385593ec5 in qpid-proton's branch
refs/heads/main from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=9e329f676 ]
PROTON-2831: [Win] Change mistaken use of logical-or to bitwise-or
PROTON-2835: [Win TLS] Incorrect flags set for CertGetIssuerCertificateFromStore
> [Win TLS] Incorrect certificate checking - not checking time validity
> -
>
> Key: PROTON-2835
> URL: https://issues.apache.org/jira/browse/PROTON-2835
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>
> Due to PROTON-2831 the certificate check flags to
> {{CertGetIssuerCertificateFromStore}} were incorrect and effectively set to 1
> which is just the flag for "Check certificate signature". Additionally an
> extra seemingly invalid flag was set - {{CERT_STORE_NO_ISSUER_FLAG}}. It
> seems that this is purely an _output_ flag and is invalid to set on input.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2831) Mistaken use of logical-or operator instead of bitwise-or operator
[ https://issues.apache.org/jira/browse/PROTON-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862549#comment-17862549 ] ASF subversion and git services commented on PROTON-2831: - Commit 9e329f67624b68c89a5ab33c49e6db1385593ec5 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=9e329f676 ] PROTON-2831: [Win] Change mistaken use of logical-or to bitwise-or PROTON-2835: [Win TLS] Incorrect flags set for CertGetIssuerCertificateFromStore > Mistaken use of logical-or operator instead of bitwise-or operator > -- > > Key: PROTON-2831 > URL: https://issues.apache.org/jira/browse/PROTON-2831 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.39.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > This was picked up by tighter warnings in the latest Visual C++ compiler. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2810) C++ compile standard needs to be advanced to c++14 or later
[ https://issues.apache.org/jira/browse/PROTON-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862551#comment-17862551 ] ASF subversion and git services commented on PROTON-2810: - Commit 549808718b52f4951863d306c810b52a8b10b9aa in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=549808718 ] PROTON-2810: Change C++ language version to C++17 Change documented requirements; Stop linking C++ code with threads library as this is now in C++ 17 standard library (everywhere except FrewBSD with clang) > C++ compile standard needs to be advanced to c++14 or later > --- > > Key: PROTON-2810 > URL: https://issues.apache.org/jira/browse/PROTON-2810 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding, examples >Reporter: Kim van der Riet >Assignee: Andrew Stitcher >Priority: Major > > The use of opentelemetry-cpp API in qpid-proton is forcing the C++ compile > standard to be c++14 or later. The support for c++11 (which qpid-proton is > currently using) in opentelemetry-cpp was removed in v 1.12.0 (we are > currently at version 1.14.2), and the use of its APIs is causing compile > errors. > Consideration should be given to moving the compiler C++ standard to 14, 17 > or even 20. > I have tested the compile using c++17, and this does not create any compile > errors, and solves the opentelemetry-cpp API error too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [PR] Proton 2810 [qpid-proton]
asfgit merged PR #428: URL: https://github.com/apache/qpid-proton/pull/428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
