[jira] [Created] (QPID-3489) The Exchange plugin examples do not work and are not tested
The Exchange plugin examples do not work and are not tested --- Key: QPID-3489 URL: https://issues.apache.org/jira/browse/QPID-3489 Project: Qpid Issue Type: Bug Components: Qpid Examples Affects Versions: 0.13 Reporter: Andrew Kennedy Assignee: Andrew Kennedy The Diagnostics and Example Exchange plugins for the Java broker are not currently working. The tests only check that they are loaded by Felix, they do not attempt to exercise any functionality. Additionally, the Diagnostic exchange is a bad example, as it contains (commented out) code that would modify a message, which is forbidden by AMQP. A more useful (working) example is required, along with working tests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3459) Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099673#comment-13099673 ] Andrew Kennedy commented on QPID-3459: -- Agree with Robbie here. FYI, when implementing, I deliberated between full-on synchronisation and using atomic counters, eventually settling for the synchronisation as seen. In testing there was no performance difference between the two mechanisms at any statistically significant level. Adding more synchronisation would cause serialisation of message processing, since the statistics generation happens on the delivery path, which is inadvisable. > Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest > sporadically fails on 0.10 profiles > - > > Key: QPID-3459 > URL: https://issues.apache.org/jira/browse/QPID-3459 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Minor > Attachments: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch > > > The stack trace from failed test is provided below: > Message 3 was not received > junit.framework.AssertionFailedError: Message 3 was not received > at > org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107) > at > org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72) > at > org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3213) enable publishing of Maven artifacts for the client to the ASF Nexus instance
[ https://issues.apache.org/jira/browse/QPID-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021812#comment-13021812 ] Andrew Kennedy commented on QPID-3213: -- Emmanuel, that is what I thought as well, and I have implemented things this way in a fully Maven-ized build system I created for Qpid, which I would like to propose as an enhancement for the 0.12+ release. > enable publishing of Maven artifacts for the client to the ASF Nexus instance > - > > Key: QPID-3213 > URL: https://issues.apache.org/jira/browse/QPID-3213 > Project: Qpid > Issue Type: Task > Components: Ant Build System >Reporter: Robbie Gemmell >Assignee: Keith Wall > Fix For: 0.11 > > > Maven artifacts have been produced for the client as part of the 0.10 > release. These need to be published to the ASF's Nexus instance, so support > should be added for uploading the files to a staging repository so that the > artifacts can be released. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Assigned] (QPID-3177) JMS Failover Not Working
[
https://issues.apache.org/jira/browse/QPID-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy reassigned QPID-3177:
Assignee: Robbie Gemmell (was: Rajith Attapattu)
Can you review this fix, for potential inclusion in the 0.10 releaase, please?
> JMS Failover Not Working
>
>
> Key: QPID-3177
> URL: https://issues.apache.org/jira/browse/QPID-3177
> Project: Qpid
> Issue Type: Bug
>Affects Versions: 0.10
>Reporter: Rajith Attapattu
>Assignee: Robbie Gemmell
>Priority: Blocker
> Fix For: 0.11
>
>
> The JMS failover is not working due to a regression introduced in rev 1071631.
> More specifically the reason is the following line being removed.
> @@ -257,12 +256,14 @@
> ConnectionClose close = exc.getClose();
> if (close == null)
> {
> +_conn.getProtocolHandler().setFailoverLatch(new
> CountDownLatch(1));
> +
> try
> {
> if (_conn.firePreFailover(false) &&
> _conn.attemptReconnection())
> {
> _conn.failoverPrep();
> -_qpidConnection.resume(); > This line is removed
> in this comment.
> +_conn.resubscribeSessions();
> _conn.fireFailoverComplete();
> return;
> }
> On the surface this seems like a unintended omission. However I'd like to
> investigate it further and find out if this was intentional.
> It if it was, then what was the reason behind it?
> The obvious fix is to re-introduce this line. I have done so and preliminary
> tests indicates that it will resolve the issue. I haven't seen any other
> issues.
> However I'd like to look at more information regarding the context of the
> above change before making a final decision.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3177) JMS Failover Not Working
[
https://issues.apache.org/jira/browse/QPID-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014840#comment-13014840
]
Andrew Kennedy commented on QPID-3177:
--
I thought Rajith was responsible for the broker component changes?
> JMS Failover Not Working
>
>
> Key: QPID-3177
> URL: https://issues.apache.org/jira/browse/QPID-3177
> Project: Qpid
> Issue Type: Bug
>Affects Versions: 0.10
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Blocker
> Fix For: 0.11
>
>
> The JMS failover is not working due to a regression introduced in rev 1071631.
> More specifically the reason is the following line being removed.
> @@ -257,12 +256,14 @@
> ConnectionClose close = exc.getClose();
> if (close == null)
> {
> +_conn.getProtocolHandler().setFailoverLatch(new
> CountDownLatch(1));
> +
> try
> {
> if (_conn.firePreFailover(false) &&
> _conn.attemptReconnection())
> {
> _conn.failoverPrep();
> -_qpidConnection.resume(); > This line is removed
> in this comment.
> +_conn.resubscribeSessions();
> _conn.fireFailoverComplete();
> return;
> }
> On the surface this seems like a unintended omission. However I'd like to
> investigate it further and find out if this was intentional.
> It if it was, then what was the reason behind it?
> The obvious fix is to re-introduce this line. I have done so and preliminary
> tests indicates that it will resolve the issue. I haven't seen any other
> issues.
> However I'd like to look at more information regarding the context of the
> above change before making a final decision.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-3177) JMS Failover Not Working
[
https://issues.apache.org/jira/browse/QPID-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy resolved QPID-3177.
--
Resolution: Fixed
Fix Version/s: (was: 0.10)
0.11
Fixed on trunk. As this is a regression, it should be ported to the 0.10 branch
as well.
> JMS Failover Not Working
>
>
> Key: QPID-3177
> URL: https://issues.apache.org/jira/browse/QPID-3177
> Project: Qpid
> Issue Type: Bug
>Affects Versions: 0.10
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Blocker
> Fix For: 0.11
>
>
> The JMS failover is not working due to a regression introduced in rev 1071631.
> More specifically the reason is the following line being removed.
> @@ -257,12 +256,14 @@
> ConnectionClose close = exc.getClose();
> if (close == null)
> {
> +_conn.getProtocolHandler().setFailoverLatch(new
> CountDownLatch(1));
> +
> try
> {
> if (_conn.firePreFailover(false) &&
> _conn.attemptReconnection())
> {
> _conn.failoverPrep();
> -_qpidConnection.resume(); > This line is removed
> in this comment.
> +_conn.resubscribeSessions();
> _conn.fireFailoverComplete();
> return;
> }
> On the surface this seems like a unintended omission. However I'd like to
> investigate it further and find out if this was intentional.
> It if it was, then what was the reason behind it?
> The obvious fix is to re-introduce this line. I have done so and preliminary
> tests indicates that it will resolve the issue. I haven't seen any other
> issues.
> However I'd like to look at more information regarding the context of the
> above change before making a final decision.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3177) JMS Failover Not Working
[
https://issues.apache.org/jira/browse/QPID-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014817#comment-13014817
]
Andrew Kennedy commented on QPID-3177:
--
Yes, this is accidental. Thank's for spotting it. I had intended to refactor
this more completely, and part of that involved moving the connection resume to
resubscribeSessions, which is called indirectly. I have replaced this call.
> JMS Failover Not Working
>
>
> Key: QPID-3177
> URL: https://issues.apache.org/jira/browse/QPID-3177
> Project: Qpid
> Issue Type: Bug
>Affects Versions: 0.10
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Blocker
> Fix For: 0.10
>
>
> The JMS failover is not working due to a regression introduced in rev 1071631.
> More specifically the reason is the following line being removed.
> @@ -257,12 +256,14 @@
> ConnectionClose close = exc.getClose();
> if (close == null)
> {
> +_conn.getProtocolHandler().setFailoverLatch(new
> CountDownLatch(1));
> +
> try
> {
> if (_conn.firePreFailover(false) &&
> _conn.attemptReconnection())
> {
> _conn.failoverPrep();
> -_qpidConnection.resume(); > This line is removed
> in this comment.
> +_conn.resubscribeSessions();
> _conn.fireFailoverComplete();
> return;
> }
> On the surface this seems like a unintended omission. However I'd like to
> investigate it further and find out if this was intentional.
> It if it was, then what was the reason behind it?
> The obvious fix is to re-introduce this line. I have done so and preliminary
> tests indicates that it will resolve the issue. I haven't seen any other
> issues.
> However I'd like to look at more information regarding the context of the
> above change before making a final decision.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-3164) Occasional test failures from SimpleAMQQueueTest.testSubscriptionSpecificRequeueForQueueWithMultipleSubscriptions
[ https://issues.apache.org/jira/browse/QPID-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012220#comment-13012220 ] Andrew Kennedy commented on QPID-3164: -- See also this other test in the same class: https://hudson.apache.org/hudson/job/qpid-java-build/14/testReport/org.apache.qpid.server.queue/SimpleAMQQueueTest/testRequeueForQueueWithMultipleSubscriptions/ > Occasional test failures from > SimpleAMQQueueTest.testSubscriptionSpecificRequeueForQueueWithMultipleSubscriptions > - > > Key: QPID-3164 > URL: https://issues.apache.org/jira/browse/QPID-3164 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.10, 0.11 >Reporter: Keith Wall >Assignee: Keith Wall > > QPID-2900 added a new test case > SimpleAMQQueueTest.testSubscriptionSpecificRequeueForQueueWithMultipleSubscriptions > which aims to verify that the method SimpleAMQQueue.requeue(QueueEntry, > Subscription) behaves correctly and correctly requeues a entry for a specific > subscription. The test is showing sporadic test failures. > junit.framework.AssertionFailedError: Unexpected total number of messages > sent to subscription1 after enqueue expected:<1> but was:<0> > at > org.apache.qpid.server.queue.SimpleAMQQueueTest.testSubscriptionSpecificRequeueForQueueWithMultipleSubscriptions(SimpleAMQQueueTest.java:453) > at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:120) > I notice that the test case has even failed on the new Jenkins instance: > https://builds.apache.org/hudson/pview/job/qpid-java-build/7/testReport/junit/org.apache.qpid.server.queue/SimpleAMQQueueTest/testSubscriptionSpecificRequeueForQueueWithMultipleSubscriptions/ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Resolved] (QPID-3162) closed ServerConnections are held in memory due to being left in the ConnectionRegistry
[ https://issues.apache.org/jira/browse/QPID-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3162. -- Resolution: Fixed Review OK > closed ServerConnections are held in memory due to being left in the > ConnectionRegistry > --- > > Key: QPID-3162 > URL: https://issues.apache.org/jira/browse/QPID-3162 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.11 >Reporter: Danushka Menikkumbura >Assignee: Andrew Kennedy >Priority: Critical > Fix For: 0.11 > > Attachments: QPID-3162-v2.patch, QPID-3162.patch > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Updated] (QPID-3156) Java client implementation of the Address syntax for Destinations throws a ClassCastException when used with the documented 'True' or 'False' values for node durability
[
https://issues.apache.org/jira/browse/QPID-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy updated QPID-3156:
-
Attachment: 0001-QPID-3156-Use-MapAccessor-to-retrieve-Boolean-proper.patch
Use existing MapAccessor code to retreive the Boolean property, as in the rest
of AddressHelper, rather than duplicating the logic.
If this is to be included in 0.10, I suggest we use this patch instead.
> Java client implementation of the Address syntax for Destinations throws a
> ClassCastException when used with the documented 'True' or 'False' values for
> node durability
>
>
> Key: QPID-3156
> URL: https://issues.apache.org/jira/browse/QPID-3156
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
>Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10
>Reporter: Robbie Gemmell
> Fix For: 0.11
>
> Attachments:
> 0001-QPID-3156-Use-MapAccessor-to-retrieve-Boolean-proper.patch
>
>
> The Java client implementation of the Address syntax for destinations throws
> a ClassCastException when used with the documented
> (http://qpid.apache.org/books/0.8/Programming-In-Apache-Qpid/html/ch02s04.html#section-address-string-bnf)
> 'True' or 'False' values for node durability, instead requiring that users
> specify 'true' or 'false' as the value to achieve the desired effect. The
> former is parsed as a boolean value by the AddressParser whereas the later is
> parsed as a String, but the AddressHelper implementation expects the durable
> property to be defined as a String and casts the value as such without doing
> an instanceof check after retrieving it from an untyped Map, thus leading to
> the ClassCastException observed.
> Ideally I would suggest the parser/helper should accept both variations going
> forward, thus preserving compatibility for anyone with already functional
> code and also making it possible for users to use whichever variant they
> prefer because e.g. it is best suited to a particular implementation language
> idiom.
> Reported by a user via the dev list:
> I tried to create a durable queue like this
> queue = queueSession.createQueue("myQueue;{create:always, node:{durable:
> True}}");
> QueueSender queueSender = queueSession.createSender(queue);
> queueSender.send(textMessage);
> and getting this exception.
> Caused by: java.lang.ClassCastException: java.lang.Boolean cannot be cast to
> java.lang.String
> at
> org.apache.qpid.client.messaging.address.AddressHelper.getDurability(AddressHelper.java:237)
> at
> org.apache.qpid.client.messaging.address.AddressHelper.fillInCommonNodeArgs(AddressHelper.java:222)
> at
> org.apache.qpid.client.messaging.address.AddressHelper.createQueueNode(AddressHelper.java:215)
> at
> org.apache.qpid.client.messaging.address.AddressHelper.getSourceNode(AddressHelper.java:254)
> at
> org.apache.qpid.client.AMQDestination.rebuildTargetAndSourceNodes(AMQDestination.java:888)
> at
> org.apache.qpid.client.AMQSession_0_10.resolveAddressType(AMQSession_0_10.java:1272)
> thanks,
> Amila.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Created] (QPID-3161) All tests using JMX fail on Solaris
All tests using JMX fail on Solaris --- Key: QPID-3161 URL: https://issues.apache.org/jira/browse/QPID-3161 Project: Qpid Issue Type: Bug Components: Java Broker, Java Tests Affects Versions: 0.10, 0.11 Environment: Solaris 10 Reporter: Andrew Kennedy Assignee: Robbie Gemmell All tests that use JMX fail on Solaris 10 under the default profile. See results here: https://builds.apache.org/hudson/view/M-R/view/Qpid/job/qpid-java-build/3/#showFailuresLink The stack trace is as follows: java.rmi.server.ExportException: internal error: ObjID already in use at sun.rmi.transport.ObjectTable.putTarget(ObjectTable.java:169) at sun.rmi.transport.Transport.exportObject(Transport.java:74) at sun.rmi.transport.tcp.TCPTransport.exportObject(TCPTransport.java:229) at sun.rmi.transport.tcp.TCPEndpoint.exportObject(TCPEndpoint.java:393) at sun.rmi.transport.LiveRef.exportObject(LiveRef.java:129) at sun.rmi.server.UnicastServerRef.exportObject(UnicastServerRef.java:190) at sun.rmi.registry.RegistryImpl.setup(RegistryImpl.java:92) at sun.rmi.registry.RegistryImpl.(RegistryImpl.java:68) at java.rmi.registry.LocateRegistry.createRegistry(LocateRegistry.java:222) at org.apache.qpid.server.management.JMXManagedObjectRegistry.start(JMXManagedObjectRegistry.java:218) at org.apache.qpid.server.registry.ApplicationRegistry.initialise(ApplicationRegistry.java:294) at org.apache.qpid.server.registry.ApplicationRegistry.initialise(ApplicationRegistry.java:154) at org.apache.qpid.test.utils.QpidBrokerTestCase.startBroker(QpidBrokerTestCase.java:472) at org.apache.qpid.test.utils.QpidBrokerTestCase.startBroker(QpidBrokerTestCase.java:403) at org.apache.qpid.test.utils.QpidBrokerTestCase.setUp(QpidBrokerTestCase.java:301) at org.apache.qpid.server.security.acl.AbstractACLTestCase.setUp(AbstractACLTestCase.java:120) at org.apache.qpid.server.security.acl.ExternalACLJMXTest.setUp(ExternalACLJMXTest.java:57) at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:234) at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:120) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3149) Set up Hudson Continuous Integration
[ https://issues.apache.org/jira/browse/QPID-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008783#comment-13008783 ] Andrew Kennedy commented on QPID-3149: -- Documentation started: https://cwiki.apache.org/confluence/display/qpid/Continuous+Integration > Set up Hudson Continuous Integration > > > Key: QPID-3149 > URL: https://issues.apache.org/jira/browse/QPID-3149 > Project: Qpid > Issue Type: Task > Components: Build Tools >Affects Versions: 0.11 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Labels: build, hudson, qpid > Fix For: 0.11 > > > Set up a Continuous Integration build environment for Java and C++ with full > unit, system and integration test suites being run, as well as the Python > test kit. This will use the ASF Hudson infrastructure, and will build on both > Unix and Windows environments. See here for details: > http://wiki.apache.org/general/Hudson -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Issue Comment Edited: (QPID-3149) Set up Hudson Continuous Integration
[ https://issues.apache.org/jira/browse/QPID-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008773#comment-13008773 ] Andrew Kennedy edited comment on QPID-3149 at 3/19/11 2:02 PM: --- https://builds.apache.org/hudson/view/M-R/view/Qpid/ was (Author: andrew.kennedy): https://builds.apache.org/hudson/pview/job/Qpid%20Java%20Build/ > Set up Hudson Continuous Integration > > > Key: QPID-3149 > URL: https://issues.apache.org/jira/browse/QPID-3149 > Project: Qpid > Issue Type: Task > Components: Build Tools >Affects Versions: 0.11 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Labels: build, hudson, qpid > Fix For: 0.11 > > > Set up a Continuous Integration build environment for Java and C++ with full > unit, system and integration test suites being run, as well as the Python > test kit. This will use the ASF Hudson infrastructure, and will build on both > Unix and Windows environments. See here for details: > http://wiki.apache.org/general/Hudson -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3149) Set up Hudson Continuous Integration
[ https://issues.apache.org/jira/browse/QPID-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008773#comment-13008773 ] Andrew Kennedy commented on QPID-3149: -- https://builds.apache.org/hudson/pview/job/Qpid%20Java%20Build/ > Set up Hudson Continuous Integration > > > Key: QPID-3149 > URL: https://issues.apache.org/jira/browse/QPID-3149 > Project: Qpid > Issue Type: Task > Components: Build Tools >Affects Versions: 0.11 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Labels: build, hudson, qpid > Fix For: 0.11 > > > Set up a Continuous Integration build environment for Java and C++ with full > unit, system and integration test suites being run, as well as the Python > test kit. This will use the ASF Hudson infrastructure, and will build on both > Unix and Windows environments. See here for details: > http://wiki.apache.org/general/Hudson -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3149) Set up Hudson Continuous Integration
[ https://issues.apache.org/jira/browse/QPID-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008772#comment-13008772 ] Andrew Kennedy commented on QPID-3149: -- Proposed builds on CI are: Qpid Java Build, Qpid Cpp Build, Qpid Java System Tests > Set up Hudson Continuous Integration > > > Key: QPID-3149 > URL: https://issues.apache.org/jira/browse/QPID-3149 > Project: Qpid > Issue Type: Task > Components: Build Tools >Affects Versions: 0.11 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Labels: build, hudson, qpid > Fix For: 0.11 > > > Set up a Continuous Integration build environment for Java and C++ with full > unit, system and integration test suites being run, as well as the Python > test kit. This will use the ASF Hudson infrastructure, and will build on both > Unix and Windows environments. See here for details: > http://wiki.apache.org/general/Hudson -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Closed: (QPID-2656) Verify/correct error handling on 0-10 broker codepath
[ https://issues.apache.org/jira/browse/QPID-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy closed QPID-2656. Resolution: Fixed Fix Version/s: (was: 0.9) 0.8 Sub tasks resolved for 0.8 release. Closing this issue, as more specific bugs were raised for other cases. > Verify/correct error handling on 0-10 broker codepath > - > > Key: QPID-2656 > URL: https://issues.apache.org/jira/browse/QPID-2656 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.7 >Reporter: Andrew Kennedy > Fix For: 0.8 > > > Verify existing error handling on 0-10 BROKER codepath and how it compares > with the 0-9 codepath. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2930) JMS msg.getPropertyNames() method should not return x-amqp-0-10.routing-key
[
https://issues.apache.org/jira/browse/QPID-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008768#comment-13008768
]
Andrew Kennedy commented on QPID-2930:
--
Re: using set/getObjectProperty as an extension point, is this documented
behaviour, somewhere?
> JMS msg.getPropertyNames() method should not return x-amqp-0-10.routing-key
>
>
> Key: QPID-2930
> URL: https://issues.apache.org/jira/browse/QPID-2930
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Minor
> Fix For: 0.10
>
>
> Description of problem:
> JMS msg.getPropertyNames() method should not return x-amqp-0-10.routing-key,
> x-amqp-0-10.routing-key is internal property. It cause exception if loop via
> ProertyName enumeration.
> Code:
> ===
> Enumeration enu = msg.getPropertyNames();
> while (enu.hasMoreElements()) {
> String name = (String) enu.nextElement();
> String value = msg.getStringProperty(name);
> }
> Exception
> =
> Caused by: javax.jms.MessageFormatException:
> getString("x-amqp-0-10.routing-key") failed as value of type class [B is an
> array.
> at
> org.apache.qpid.client.message.AMQMessageDelegate_0_10.getStringProperty(AMQMessageDelegate_0_10.java:639)
>
> at
> org.apache.qpid.client.message.AbstractJMSMessage.getStringProperty(AbstractJMSMessage.java:254)
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2930) JMS msg.getPropertyNames() method should not return x-amqp-0-10.routing-key
[
https://issues.apache.org/jira/browse/QPID-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008767#comment-13008767
]
Andrew Kennedy commented on QPID-2930:
--
While I approve of adding tests, in this case the only assertion is that a sent
message (with no properties set) is received, so this issue is never tested. I
think the test case should set some properties, of varying allowed and
non-allowed types, and then assert that the returned message still provides an
enumeration with a list of those, and only those, properties.
Since x-amqp-0-10.routing-key is internal, maybe it should be filtered out,
along with all other x-amqp-* and x-qpid-* properties?
> JMS msg.getPropertyNames() method should not return x-amqp-0-10.routing-key
>
>
> Key: QPID-2930
> URL: https://issues.apache.org/jira/browse/QPID-2930
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Minor
> Fix For: 0.10
>
>
> Description of problem:
> JMS msg.getPropertyNames() method should not return x-amqp-0-10.routing-key,
> x-amqp-0-10.routing-key is internal property. It cause exception if loop via
> ProertyName enumeration.
> Code:
> ===
> Enumeration enu = msg.getPropertyNames();
> while (enu.hasMoreElements()) {
> String name = (String) enu.nextElement();
> String value = msg.getStringProperty(name);
> }
> Exception
> =
> Caused by: javax.jms.MessageFormatException:
> getString("x-amqp-0-10.routing-key") failed as value of type class [B is an
> array.
> at
> org.apache.qpid.client.message.AMQMessageDelegate_0_10.getStringProperty(AMQMessageDelegate_0_10.java:639)
>
> at
> org.apache.qpid.client.message.AbstractJMSMessage.getStringProperty(AbstractJMSMessage.java:254)
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3149) Set up Hudson Continuous Integration
Set up Hudson Continuous Integration Key: QPID-3149 URL: https://issues.apache.org/jira/browse/QPID-3149 Project: Qpid Issue Type: Task Components: Build Tools Affects Versions: 0.11 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Fix For: 0.11 Set up a Continuous Integration build environment for Java and C++ with full unit, system and integration test suites being run, as well as the Python test kit. This will use the ASF Hudson infrastructure, and will build on both Unix and Windows environments. See here for details: http://wiki.apache.org/general/Hudson -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2985) Add producer configurable transaction timeouts
[ https://issues.apache.org/jira/browse/QPID-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004813#comment-13004813 ] Andrew Kennedy commented on QPID-2985: -- Documented here: https://cwiki.apache.org/confluence/display/qpid/Qpid+Java+Broker+Transaction+Timeouts > Add producer configurable transaction timeouts > -- > > Key: QPID-2985 > URL: https://issues.apache.org/jira/browse/QPID-2985 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.11 > > > Port changes from QPID-2864 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2984) Add statistics generation for broker message delivery
[ https://issues.apache.org/jira/browse/QPID-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004814#comment-13004814 ] Andrew Kennedy commented on QPID-2984: -- Documented here: https://cwiki.apache.org/confluence/display/qpid/Qpid+Java+Broker+Statistics > Add statistics generation for broker message delivery > - > > Key: QPID-2984 > URL: https://issues.apache.org/jira/browse/QPID-2984 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.11 > > > Port changes from QPID-2932 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3134) Exceptions thrown during synchronous operations should be caught and wrapped appropriately
Exceptions thrown during synchronous operations should be caught and wrapped appropriately -- Key: QPID-3134 URL: https://issues.apache.org/jira/browse/QPID-3134 Project: Qpid Issue Type: Bug Reporter: Andrew Kennedy The 0-10 txCommit is a synchronous operation, and may time out or throw other SessionExceptions. These should be caught -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3133) Failover tests do not pass on 0-10 profiles
Failover tests do not pass on 0-10 profiles --- Key: QPID-3133 URL: https://issues.apache.org/jira/browse/QPID-3133 Project: Qpid Issue Type: Bug Components: Java Broker, Java Client Affects Versions: 0.11 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Fix For: 0.11 The Failover test cases do not work correctly or pass on 0-10 test profiles -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3127) Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
[ https://issues.apache.org/jira/browse/QPID-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3127: - Fix Version/s: 0.10 Assignee: Rajith Attapattu (was: Andrew Kennedy) Rajith, can you check if this can be pushed to 0.10 please? > Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions > > > Key: QPID-3127 > URL: https://issues.apache.org/jira/browse/QPID-3127 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.10 >Reporter: Andrew Kennedy >Assignee: Rajith Attapattu >Priority: Minor > Fix For: 0.10, 0.11 > > > When creating a subscription for a consumer in a 0-10 session, the accept > mode is always set to EXPLICIT unless an unreliable connection is specified > using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept > mode should also be NONE. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3127) Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
[ https://issues.apache.org/jira/browse/QPID-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003999#comment-13003999 ] Andrew Kennedy commented on QPID-3127: -- Thanks, although I have made the change already and am testing it just now, and will commit it as soon as all the test profiles are passing etc. > Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions > > > Key: QPID-3127 > URL: https://issues.apache.org/jira/browse/QPID-3127 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.10 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.11 > > > When creating a subscription for a consumer in a 0-10 session, the accept > mode is always set to EXPLICIT unless an unreliable connection is specified > using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept > mode should also be NONE. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3127) Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions Key: QPID-3127 URL: https://issues.apache.org/jira/browse/QPID-3127 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.10 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Fix For: 0.11 When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2985) Add producer configurable transaction timeouts
[ https://issues.apache.org/jira/browse/QPID-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2985: - Fix Version/s: (was: 0.9) 0.11 > Add producer configurable transaction timeouts > -- > > Key: QPID-2985 > URL: https://issues.apache.org/jira/browse/QPID-2985 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.11 > > > Port changes from QPID-2864 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-3070) SessionComplete command sent for empty range
[ https://issues.apache.org/jira/browse/QPID-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy reassigned QPID-3070: Assignee: Rafael H. Schloming (was: Andrew Kennedy) Rafi, can you confirm this is OK, please? > SessionComplete command sent for empty range > > > Key: QPID-3070 > URL: https://issues.apache.org/jira/browse/QPID-3070 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Client >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Rafael H. Schloming > Fix For: 0.11 > > > The 0-10 AMQP protocol implementation sends a SessionComplete command with an > empty RangeSet, which will be replied to with a SessionKnownComplete and a > similar empty or null RangeSet (these are equivalent on the wire) iff the > TimelyReply field is set to true in the request. > I think that the initial empty SessionComplete (caused by a call to > flushProcessed normally) should never be sent, so adding a check for > range.size() > 0 before sending should do this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3070) SessionComplete command sent for empty range
[ https://issues.apache.org/jira/browse/QPID-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3070: - Status: Ready To Review (was: In Progress) > SessionComplete command sent for empty range > > > Key: QPID-3070 > URL: https://issues.apache.org/jira/browse/QPID-3070 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Client >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > > The 0-10 AMQP protocol implementation sends a SessionComplete command with an > empty RangeSet, which will be replied to with a SessionKnownComplete and a > similar empty or null RangeSet (these are equivalent on the wire) iff the > TimelyReply field is set to true in the request. > I think that the initial empty SessionComplete (caused by a call to > flushProcessed normally) should never be sent, so adding a check for > range.size() > 0 before sending should do this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2984) Add statistics generation for broker message delivery
[ https://issues.apache.org/jira/browse/QPID-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2984: - Status: Ready To Review (was: In Progress) > Add statistics generation for broker message delivery > - > > Key: QPID-2984 > URL: https://issues.apache.org/jira/browse/QPID-2984 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > > Port changes from QPID-2932 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2984) Add statistics generation for broker message delivery
[ https://issues.apache.org/jira/browse/QPID-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2984: - Fix Version/s: (was: 0.9) 0.11 > Add statistics generation for broker message delivery > - > > Key: QPID-2984 > URL: https://issues.apache.org/jira/browse/QPID-2984 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.11 > > > Port changes from QPID-2932 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2985) Add producer configurable transaction timeouts
[ https://issues.apache.org/jira/browse/QPID-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2985: - Status: Ready To Review (was: In Progress) > Add producer configurable transaction timeouts > -- > > Key: QPID-2985 > URL: https://issues.apache.org/jira/browse/QPID-2985 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.9 > > > Port changes from QPID-2864 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-2984) Add statistics generation for broker message delivery
[ https://issues.apache.org/jira/browse/QPID-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy reassigned QPID-2984: Assignee: Robbie Gemmell (was: Andrew Kennedy) Robbie, can you review please? > Add statistics generation for broker message delivery > - > > Key: QPID-2984 > URL: https://issues.apache.org/jira/browse/QPID-2984 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.11 > > > Port changes from QPID-2932 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-2985) Add producer configurable transaction timeouts
[ https://issues.apache.org/jira/browse/QPID-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy reassigned QPID-2985: Assignee: Robbie Gemmell (was: Andrew Kennedy) Robbie, can you review please? > Add producer configurable transaction timeouts > -- > > Key: QPID-2985 > URL: https://issues.apache.org/jira/browse/QPID-2985 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.9 > > > Port changes from QPID-2864 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3109) Java client needs to implement the Delete option in address string
[
https://issues.apache.org/jira/browse/QPID-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003415#comment-13003415
]
Andrew Kennedy commented on QPID-3109:
--
Tests in SimpleACLTest and subclasses are also failing, again in the java.0.10
profile, due to the use of the following JMS idiom, which resultrs in
_destination not being set in a producer:
MessageProducer sender = ((AMQSession)
sess).createProducer(null);
> Java client needs to implement the Delete option in address string
> --
>
> Key: QPID-3109
> URL: https://issues.apache.org/jira/browse/QPID-3109
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
>Affects Versions: 0.8
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Minor
> Fix For: 0.9
>
>
> The address syntax defines a delete option with 4 possible values - {always,
> receiver, sender, never}.
> The default value is 'never'.
> if delete = 'always' or delete = 'sender', then when a sender is closed it
> should delete the queue.
> if delete = 'always' or delete = 'receiver', then when a receiver is closed
> it should delete the queue.
> Please note that the client will delete the queue irrespective of whether
> there are consumers on the queue or not.
> Also it will not take into account whether the queue is empty or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Issue Comment Edited: (QPID-3109) Java client needs to implement the Delete option in address string
[
https://issues.apache.org/jira/browse/QPID-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003413#comment-13003413
]
Andrew Kennedy edited comment on QPID-3109 at 3/7/11 4:18 PM:
--
Rajith,
In BasicMessageProducer_0_10#close() you make the assumption that _destination
will hold a valid (non-null) destination. This is not always the case, as can
be seen from the following code sample (taken from InvalidDestinationTest,
which is currently failing in the java.0.10 profile):
sender = queueSession.createSender(null);
// ... try to send to invalid destination first
sender.send(validDestination, msg);
sender.close();
Obviously, the close call will now fail with a NullPointerException. I have not
seen any other tests failing because of this, but this is most likely due to
lack of coverage, since other methods in this commit assume a non-null
_destination field also.
I believe the code sample above to be a valid JMS idiom.
Andrew.
was (Author: andrew.kennedy):
Rajith,
In BasicMessageProducer_0_10#close() you make the assumption that _destination
will hold a valid (non-null) destination. This is not always the case, as can
be seen from the following code sample (taken from InvaliDestinationTest, which
is currently failing in the java.0.10 profile):
{code}
sender = queueSession.createSender(null);
// ... try to send to invalid destination first
sender.send(validDestination, msg);
sender.close();
{code}
Obviously, the close call will now fail with a NullPointerException. I have not
seen any other tests failing because of this, but this is most likely due to
lack of coverage, since other methods in this commit assume a non-null
_destination field also.
I believe the code sample above to be a valid JMS idiom.
Andrew.
> Java client needs to implement the Delete option in address string
> --
>
> Key: QPID-3109
> URL: https://issues.apache.org/jira/browse/QPID-3109
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
>Affects Versions: 0.8
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Minor
> Fix For: 0.9
>
>
> The address syntax defines a delete option with 4 possible values - {always,
> receiver, sender, never}.
> The default value is 'never'.
> if delete = 'always' or delete = 'sender', then when a sender is closed it
> should delete the queue.
> if delete = 'always' or delete = 'receiver', then when a receiver is closed
> it should delete the queue.
> Please note that the client will delete the queue irrespective of whether
> there are consumers on the queue or not.
> Also it will not take into account whether the queue is empty or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3109) Java client needs to implement the Delete option in address string
[
https://issues.apache.org/jira/browse/QPID-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003413#comment-13003413
]
Andrew Kennedy commented on QPID-3109:
--
Rajith,
In BasicMessageProducer_0_10#close() you make the assumption that _destination
will hold a valid (non-null) destination. This is not always the case, as can
be seen from the following code sample (taken from InvaliDestinationTest, which
is currently failing in the java.0.10 profile):
{code}
sender = queueSession.createSender(null);
// ... try to send to invalid destination first
sender.send(validDestination, msg);
sender.close();
{code}
Obviously, the close call will now fail with a NullPointerException. I have not
seen any other tests failing because of this, but this is most likely due to
lack of coverage, since other methods in this commit assume a non-null
_destination field also.
I believe the code sample above to be a valid JMS idiom.
Andrew.
> Java client needs to implement the Delete option in address string
> --
>
> Key: QPID-3109
> URL: https://issues.apache.org/jira/browse/QPID-3109
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
>Affects Versions: 0.8
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Minor
> Fix For: 0.9
>
>
> The address syntax defines a delete option with 4 possible values - {always,
> receiver, sender, never}.
> The default value is 'never'.
> if delete = 'always' or delete = 'sender', then when a sender is closed it
> should delete the queue.
> if delete = 'always' or delete = 'receiver', then when a receiver is closed
> it should delete the queue.
> Please note that the client will delete the queue irrespective of whether
> there are consumers on the queue or not.
> Also it will not take into account whether the queue is empty or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2811) Rationalise 0-10 Transport Interface
[ https://issues.apache.org/jira/browse/QPID-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2811: - Fix Version/s: (was: 0.9) 0.11 > Rationalise 0-10 Transport Interface > > > Key: QPID-2811 > URL: https://issues.apache.org/jira/browse/QPID-2811 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client, Java Common >Affects Versions: 0.7 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > Attachments: transport-layer.ppt > > > Create or modify current transport mechanism classes and interfaces to make > them more generic and allow for other mechanisms and protocols to be added in > a modular way. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2815) Make InVM broker startup protocol independent
[ https://issues.apache.org/jira/browse/QPID-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2815: - Fix Version/s: (was: 0.9) 0.11 > Make InVM broker startup protocol independent > - > > Key: QPID-2815 > URL: https://issues.apache.org/jira/browse/QPID-2815 > Project: Qpid > Issue Type: Improvement >Affects Versions: 0.7 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > > Update the way the InVm broker is started to decouple it from any particular > protocol version -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3026) The ApplicationRegistry object should be a singleton
[ https://issues.apache.org/jira/browse/QPID-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3026: - Fix Version/s: 0.11 > The ApplicationRegistry object should be a singleton > > > Key: QPID-3026 > URL: https://issues.apache.org/jira/browse/QPID-3026 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.11 > > > The ApplicationRegistry can currently have multiple instances, in order to > cater for multiple brokers in the same VM. However, *many* parts of the code > simply call ApplcationRegistry.getInstance() to obtain a reference, meaning > multiple instances are ignored. The only time this is ever useful is for > certain types of tests, therefore the capability to have multiple broker > instances should be removed. > Any tests that require multiple brokers can start a VM broker and an > external, or two external brokers. In general, test-only code should not be > made available to the rest of the application. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2814) Create MINA InVM 0-10 Transport
[ https://issues.apache.org/jira/browse/QPID-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2814: - Fix Version/s: (was: 0.9) 0.11 > Create MINA InVM 0-10 Transport > --- > > Key: QPID-2814 > URL: https://issues.apache.org/jira/browse/QPID-2814 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.7 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > > Create a MINA transport that implements the vm:// VmPipe protocol, to allow > for inVM communication with the 0-10 protocol -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3052) Java test profiles do not effectively test all AMQP protocol versions
[ https://issues.apache.org/jira/browse/QPID-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3052: - Fix Version/s: (was: 0.9) 0.11 > Java test profiles do not effectively test all AMQP protocol versions > - > > Key: QPID-3052 > URL: https://issues.apache.org/jira/browse/QPID-3052 > Project: Qpid > Issue Type: Bug > Components: Java Tests >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.11 > > > The Java test profiles assume that, particularly default one for InVm > transports, the 0-10 protocol will fail, causing renegotiation. If 0-10 InVm > support is added then the default protocol will use this. It seems to make > more sense to specify exactly the version the client and the broker should > announce, and force renegotiation explicitly by disabling various protocol > versions on the command line when starting an external Java broker. Note that > this is not possible to specify for the InVm profiles anyway. Also, the only > protocol that is ever tested will be the highest supported by both broker and > client, therefore this is AMQP 0-9-1. In order for the tests not to do > surprising things when new protocol versions are added, I think that setting > versions explicitly is the best idea. I woulsd also like to add an explicit > 0-8 test profile for both InVM and external Java brokers, in order to > exercise and get coverage on this code. > In future, I recommend that some form of combinatorial profile system be > investigated for the test subsystem, allowing the required protocol, broker > type and so on to be specified separately. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2813) Update current 0-10 socket connection to conform to new mechanism
[ https://issues.apache.org/jira/browse/QPID-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2813: - Fix Version/s: (was: 0.9) 0.11 > Update current 0-10 socket connection to conform to new mechanism > - > > Key: QPID-2813 > URL: https://issues.apache.org/jira/browse/QPID-2813 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.7 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > > Make any additonal changes to the existing transport to allow it to conform > fully to the changes made in QPID-2811 and QPID-2812 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3114) Exclusive queues do not record their owning session in 0-10
[ https://issues.apache.org/jira/browse/QPID-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3114: - Fix Version/s: (was: Future) 0.11 > Exclusive queues do not record their owning session in 0-10 > --- > > Key: QPID-3114 > URL: https://issues.apache.org/jira/browse/QPID-3114 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > > When using 0-10 sessions to create exclusive queues they should have the > owning server session recorded on the broker. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3066) UTF8Test does not run under non VM 0-10 profiles
[ https://issues.apache.org/jira/browse/QPID-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3066: - Fix Version/s: (was: 0.9) 0.11 > UTF8Test does not run under non VM 0-10 profiles > > > Key: QPID-3066 > URL: https://issues.apache.org/jira/browse/QPID-3066 > Project: Qpid > Issue Type: Bug > Components: Java Tests >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.11 > > > The UTF8Test uses the 'isBrokerExternal' and 'isBroker010' methods to check > whether it should run, rather than relying on the Excludes files. The checks > wrongly cause an exception to be thrown on the java.0.10 test profile. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3111) DynamicQueueExchangeCreateTest should check for 404 error code explicitly
[ https://issues.apache.org/jira/browse/QPID-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3111: - Fix Version/s: (was: Future) 0.11 > DynamicQueueExchangeCreateTest should check for 404 error code explicitly > - > > Key: QPID-3111 > URL: https://issues.apache.org/jira/browse/QPID-3111 > Project: Qpid > Issue Type: Bug > Components: Java Tests >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.11 > > > DynamicQueueExchangeCreateTest checks for a tect string in the message > property of a thrown exception. This is brittle and should be replaced with a > check for the AMQConstant#NOT_FOUND (404) error code instead. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2720) Qpid broker can not run inside an OSGi container
[ https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2720: - Fix Version/s: 0.11 > Qpid broker can not run inside an OSGi container > > > Key: QPID-2720 > URL: https://issues.apache.org/jira/browse/QPID-2720 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Reporter: Danushka Menikkumbura >Assignee: Andrew Kennedy > Fix For: 0.11 > > Attachments: QPID-2720-V2.patch, QPID-2720.patch > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3070) SessionComplete command sent for empty range
[ https://issues.apache.org/jira/browse/QPID-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3070: - Fix Version/s: (was: 0.9) 0.11 > SessionComplete command sent for empty range > > > Key: QPID-3070 > URL: https://issues.apache.org/jira/browse/QPID-3070 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Client >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > > The 0-10 AMQP protocol implementation sends a SessionComplete command with an > empty RangeSet, which will be replied to with a SessionKnownComplete and a > similar empty or null RangeSet (these are equivalent on the wire) iff the > TimelyReply field is set to true in the request. > I think that the initial empty SessionComplete (caused by a call to > flushProcessed normally) should never be sent, so adding a check for > range.size() > 0 before sending should do this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3113) ChannelCloseTest should be excluded from test profiles properly
[ https://issues.apache.org/jira/browse/QPID-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3113: - Fix Version/s: (was: Future) 0.11 > ChannelCloseTest should be excluded from test profiles properly > --- > > Key: QPID-3113 > URL: https://issues.apache.org/jira/browse/QPID-3113 > Project: Qpid > Issue Type: Bug > Components: Java Tests >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.11 > > > ChannelCloseTest should use the Excludes file mechanism to ensure it is not > run for 0-10 profiles, and should also not be restricted to VM broker profiles -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2816) Create TCP based 0-10 MINA transport
[ https://issues.apache.org/jira/browse/QPID-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2816: - Fix Version/s: (was: 0.9) 0.11 > Create TCP based 0-10 MINA transport > > > Key: QPID-2816 > URL: https://issues.apache.org/jira/browse/QPID-2816 > Project: Qpid > Issue Type: Improvement >Affects Versions: 0.7 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > > Create a 0-10 MINA transport that implements the tcp:// protocol for broker > communication -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-2812) Update 0-10 connection configuration mechanism and properties
[ https://issues.apache.org/jira/browse/QPID-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2812: - Fix Version/s: (was: 0.9) 0.11 > Update 0-10 connection configuration mechanism and properties > - > > Key: QPID-2812 > URL: https://issues.apache.org/jira/browse/QPID-2812 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.7 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.11 > > > Update the 0-10 connection settings and system properties to rationalise the > configuration of the connection mechanism/transport/protocol. This may depend > on how different transport mechanisms are loaded, e.g. if we use OSGi plugins > or not. It would be nice to make things consistent across all protocols, so > that broker addressing does not change. Note that some transports may not > support all types of broker addressing,and this has to fail gracefully. > This will also include removal of some classes and options, such as the > _IoTransport_ configuration property. This property is present as an > apperntly untested 0-9 protocol *only* option, and uses an entirely new > mechanism to connect the transport layer to the MINA mechanism. Since the > intent of the preceding JIRA is to harmonise the transport layer binterfaces > between protocols, I believe this is an unnescessary complication. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3111) DynamicQueueExchangeCreateTest should check for 404 error code explicitly
[ https://issues.apache.org/jira/browse/QPID-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3111: - Summary: DynamicQueueExchangeCreateTest should check for 404 error code explicitly (was: DynamicQueueExchangeCreateTest shuld check for 404 error code explicitly) > DynamicQueueExchangeCreateTest should check for 404 error code explicitly > - > > Key: QPID-3111 > URL: https://issues.apache.org/jira/browse/QPID-3111 > Project: Qpid > Issue Type: Bug > Components: Java Tests >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: Future > > > DynamicQueueExchangeCreateTest checks for a tect string in the message > property of a thrown exception. This is brittle and should be replaced with a > check for the AMQConstant#NOT_FOUND (404) error code instead. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2084) 0-10 code path does not appear to throw exception on consume from non-existent queue
[
https://issues.apache.org/jira/browse/QPID-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002646#comment-13002646
]
Andrew Kennedy commented on QPID-2084:
--
This issue appears to have been res9olved by other changes made to exception
handling in the 0-10 code
> 0-10 code path does not appear to throw exception on consume from
> non-existent queue
>
>
> Key: QPID-2084
> URL: https://issues.apache.org/jira/browse/QPID-2084
> Project: Qpid
> Issue Type: Bug
>Reporter: Martin Ritchie
>Assignee: Andrew Kennedy
> Fix For: Future
>
>
> Running the new DynamicQueueExchangeCreateTest, the test appears to throw the
> exception on close rather than the consume.
> ch=0 id=0 ExecutionException(errorCode=NOT_FOUND, commandId=2, classCode=7,
> commandCode=4, fieldIndex=0, description=not-found:
> Queue not found: DynamicQueueExchangeCreateTest-testQueueDeclare
> (qpid/broker/SessionAdapter.cpp:743), errorInfo={})
> org.apache.qpid.transport.SessionException: ch=0 id=0
> ExecutionException(errorCode=NOT_FOUND, commandId=2, classCode=7,
> commandCode=4, fieldIndex=0, description=not-found: Queue not found:
> DynamicQueueExchangeCreateTest-testQueueDeclare
> (qpid/broker/SessionAdapter.cpp:743), errorInfo={})
> at org.apache.qpid.transport.Session.sync(Session.java:701)
> at org.apache.qpid.transport.Session.sync(Session.java:674)
> at
> org.apache.qpid.client.AMQSession_0_10.sendClose(AMQSession_0_10.java:342)
> at org.apache.qpid.client.AMQSession.close(AMQSession.java:667)
> at org.apache.qpid.client.AMQSession.close(AMQSession.java:633)
> at
> org.apache.qpid.client.AMQConnection.closeAllSessions(AMQConnection.java:1113)
> at
> org.apache.qpid.client.AMQConnection.doClose(AMQConnection.java:1008)
> at
> org.apache.qpid.client.AMQConnection.doClose(AMQConnection.java:997)
> at org.apache.qpid.client.AMQConnection.close(AMQConnection.java:981)
> at org.apache.qpid.client.AMQConnection.close(AMQConnection.java:972)
> at org.apache.qpid.client.AMQConnection.close(AMQConnection.java:967)
> at
> org.apache.qpid.test.utils.QpidTestCase.tearDown(QpidTestCase.java:875)
> at
> org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:224)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:270)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2084) 0-10 code path does not appear to throw exception on consume from non-existent queue
[
https://issues.apache.org/jira/browse/QPID-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy resolved QPID-2084.
--
Resolution: Fixed
Fix Version/s: Future
Issue no longer exists
> 0-10 code path does not appear to throw exception on consume from
> non-existent queue
>
>
> Key: QPID-2084
> URL: https://issues.apache.org/jira/browse/QPID-2084
> Project: Qpid
> Issue Type: Bug
>Reporter: Martin Ritchie
>Assignee: Andrew Kennedy
> Fix For: Future
>
>
> Running the new DynamicQueueExchangeCreateTest, the test appears to throw the
> exception on close rather than the consume.
> ch=0 id=0 ExecutionException(errorCode=NOT_FOUND, commandId=2, classCode=7,
> commandCode=4, fieldIndex=0, description=not-found:
> Queue not found: DynamicQueueExchangeCreateTest-testQueueDeclare
> (qpid/broker/SessionAdapter.cpp:743), errorInfo={})
> org.apache.qpid.transport.SessionException: ch=0 id=0
> ExecutionException(errorCode=NOT_FOUND, commandId=2, classCode=7,
> commandCode=4, fieldIndex=0, description=not-found: Queue not found:
> DynamicQueueExchangeCreateTest-testQueueDeclare
> (qpid/broker/SessionAdapter.cpp:743), errorInfo={})
> at org.apache.qpid.transport.Session.sync(Session.java:701)
> at org.apache.qpid.transport.Session.sync(Session.java:674)
> at
> org.apache.qpid.client.AMQSession_0_10.sendClose(AMQSession_0_10.java:342)
> at org.apache.qpid.client.AMQSession.close(AMQSession.java:667)
> at org.apache.qpid.client.AMQSession.close(AMQSession.java:633)
> at
> org.apache.qpid.client.AMQConnection.closeAllSessions(AMQConnection.java:1113)
> at
> org.apache.qpid.client.AMQConnection.doClose(AMQConnection.java:1008)
> at
> org.apache.qpid.client.AMQConnection.doClose(AMQConnection.java:997)
> at org.apache.qpid.client.AMQConnection.close(AMQConnection.java:981)
> at org.apache.qpid.client.AMQConnection.close(AMQConnection.java:972)
> at org.apache.qpid.client.AMQConnection.close(AMQConnection.java:967)
> at
> org.apache.qpid.test.utils.QpidTestCase.tearDown(QpidTestCase.java:875)
> at
> org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:224)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:270)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3111) DynamicQueueExchangeCreateTest shuld check for 404 error code explicitly
[ https://issues.apache.org/jira/browse/QPID-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3111: - Status: Ready To Review (was: In Progress) > DynamicQueueExchangeCreateTest shuld check for 404 error code explicitly > > > Key: QPID-3111 > URL: https://issues.apache.org/jira/browse/QPID-3111 > Project: Qpid > Issue Type: Bug > Components: Java Tests >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: Future > > > DynamicQueueExchangeCreateTest checks for a tect string in the message > property of a thrown exception. This is brittle and should be replaced with a > check for the AMQConstant#NOT_FOUND (404) error code instead. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-2084) 0-10 code path does not appear to throw exception on consume from non-existent queue
[
https://issues.apache.org/jira/browse/QPID-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy reassigned QPID-2084:
Assignee: Andrew Kennedy
> 0-10 code path does not appear to throw exception on consume from
> non-existent queue
>
>
> Key: QPID-2084
> URL: https://issues.apache.org/jira/browse/QPID-2084
> Project: Qpid
> Issue Type: Bug
>Reporter: Martin Ritchie
>Assignee: Andrew Kennedy
>
> Running the new DynamicQueueExchangeCreateTest, the test appears to throw the
> exception on close rather than the consume.
> ch=0 id=0 ExecutionException(errorCode=NOT_FOUND, commandId=2, classCode=7,
> commandCode=4, fieldIndex=0, description=not-found:
> Queue not found: DynamicQueueExchangeCreateTest-testQueueDeclare
> (qpid/broker/SessionAdapter.cpp:743), errorInfo={})
> org.apache.qpid.transport.SessionException: ch=0 id=0
> ExecutionException(errorCode=NOT_FOUND, commandId=2, classCode=7,
> commandCode=4, fieldIndex=0, description=not-found: Queue not found:
> DynamicQueueExchangeCreateTest-testQueueDeclare
> (qpid/broker/SessionAdapter.cpp:743), errorInfo={})
> at org.apache.qpid.transport.Session.sync(Session.java:701)
> at org.apache.qpid.transport.Session.sync(Session.java:674)
> at
> org.apache.qpid.client.AMQSession_0_10.sendClose(AMQSession_0_10.java:342)
> at org.apache.qpid.client.AMQSession.close(AMQSession.java:667)
> at org.apache.qpid.client.AMQSession.close(AMQSession.java:633)
> at
> org.apache.qpid.client.AMQConnection.closeAllSessions(AMQConnection.java:1113)
> at
> org.apache.qpid.client.AMQConnection.doClose(AMQConnection.java:1008)
> at
> org.apache.qpid.client.AMQConnection.doClose(AMQConnection.java:997)
> at org.apache.qpid.client.AMQConnection.close(AMQConnection.java:981)
> at org.apache.qpid.client.AMQConnection.close(AMQConnection.java:972)
> at org.apache.qpid.client.AMQConnection.close(AMQConnection.java:967)
> at
> org.apache.qpid.test.utils.QpidTestCase.tearDown(QpidTestCase.java:875)
> at
> org.apache.qpid.test.utils.QpidTestCase.runBare(QpidTestCase.java:224)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:270)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3114) Exclusive queues do not record their owning session in 0-10
Exclusive queues do not record their owning session in 0-10 --- Key: QPID-3114 URL: https://issues.apache.org/jira/browse/QPID-3114 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Fix For: Future When using 0-10 sessions to create exclusive queues they should have the owning server session recorded on the broker. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Closed: (QPID-3112) ChannelCloseTest should be excluded from test profiles properly
[ https://issues.apache.org/jira/browse/QPID-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy closed QPID-3112. Resolution: Duplicate Duplicate of QPID-3113 > ChannelCloseTest should be excluded from test profiles properly > --- > > Key: QPID-3112 > URL: https://issues.apache.org/jira/browse/QPID-3112 > Project: Qpid > Issue Type: Bug > Components: Java Tests >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: Future > > > ChannelCloseTest should use the Excludes file mechanism to ensure it is not > run for 0-10 profiles, and should also not be restricted to VM broker profiles -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3113) ChannelCloseTest should be excluded from test profiles properly
ChannelCloseTest should be excluded from test profiles properly --- Key: QPID-3113 URL: https://issues.apache.org/jira/browse/QPID-3113 Project: Qpid Issue Type: Bug Components: Java Tests Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Fix For: Future ChannelCloseTest should use the Excludes file mechanism to ensure it is not run for 0-10 profiles, and should also not be restricted to VM broker profiles -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3112) ChannelCloseTest should be excluded from test profiles properly
ChannelCloseTest should be excluded from test profiles properly --- Key: QPID-3112 URL: https://issues.apache.org/jira/browse/QPID-3112 Project: Qpid Issue Type: Bug Components: Java Tests Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Fix For: Future ChannelCloseTest should use the Excludes file mechanism to ensure it is not run for 0-10 profiles, and should also not be restricted to VM broker profiles -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3111) DynamicQueueExchangeCreateTest shuld check for 404 error code explicitly
DynamicQueueExchangeCreateTest shuld check for 404 error code explicitly Key: QPID-3111 URL: https://issues.apache.org/jira/browse/QPID-3111 Project: Qpid Issue Type: Bug Components: Java Tests Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Fix For: Future DynamicQueueExchangeCreateTest checks for a tect string in the message property of a thrown exception. This is brittle and should be replaced with a check for the AMQConstant#NOT_FOUND (404) error code instead. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3110) JMX Management console does not show aggregate virtual host notifications
[ https://issues.apache.org/jira/browse/QPID-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3110. -- Resolution: Fixed Review OK > JMX Management console does not show aggregate virtual host notifications > - > > Key: QPID-3110 > URL: https://issues.apache.org/jira/browse/QPID-3110 > Project: Qpid > Issue Type: Bug > Components: Java Management : JMX Console >Affects Versions: 0.9 >Reporter: Alex Rudyy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.9 > > > JMX Management console does not show aggregate virtual host notifications. > Notifications are shown for individual queues but not shown on virtual host > notifications UI. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-2974) broker configuration for enabling/disabling dead letter queues
[ https://issues.apache.org/jira/browse/QPID-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy reassigned QPID-2974: Assignee: Robbie Gemmell (was: Andrew Kennedy) Reassigning for review > broker configuration for enabling/disabling dead letter queues > -- > > Key: QPID-2974 > URL: https://issues.apache.org/jira/browse/QPID-2974 > Project: Qpid > Issue Type: Sub-task > Components: Java Broker >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Attachments: QPID-2974.patch > > -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3094) unable to delete durable subscription backing queues using the JMX Management Console
[ https://issues.apache.org/jira/browse/QPID-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3094. -- Resolution: Fixed > unable to delete durable subscription backing queues using the JMX Management > Console > - > > Key: QPID-3094 > URL: https://issues.apache.org/jira/browse/QPID-3094 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Management : JMX Console >Affects Versions: 0.5, 0.6, 0.7, 0.8 >Reporter: Robbie Gemmell >Assignee: Andrew Kennedy > Fix For: 0.9 > > > Users have previously been unable to delete durable subscription backing > queues using the JMX Management Console, due to the broker mis-advertising > the queue name in the JMX ObjectName. > This issue is resolved by the changes in QPID-3090. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3028) Java broker uses excessive amounts of memory to service 0-10 connections
[ https://issues.apache.org/jira/browse/QPID-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3028. -- Resolution: Fixed Review OK > Java broker uses excessive amounts of memory to service 0-10 connections > > > Key: QPID-3028 > URL: https://issues.apache.org/jira/browse/QPID-3028 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.6, 0.8 >Reporter: Robbie Gemmell >Assignee: Andrew Kennedy >Priority: Critical > Fix For: 0.9 > > > The Java broker uses excessive amounts of memory to service 0-10 connections. > There are a number of reasons for this, such as: > - Use of an arbitrary 64000 element array in the Assembler to store > incomplete incoming per-channel data. > - Use of per-connection ThreadLocals for the BBDecoder in the Assembler > interacting with the thread pool threads moving between connections, leading > to an NxM number of BBDecoders in use. > - Use of per-connection ThreadLocals for the BBEncoder in the Disassembler > interacting with the thread pool threads moving between connections, leading > to an NxM number of BBEncoders in use. > - BBDecoder maintaining a hard reference to the last ByteBuffer it used. > - The binary->String cache within BBDecoder maintaining a hard reference to > the entire backing array for the network read buffer which contained the > cached binary, rather than just the bit being cached. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3092) JMX Management Console does not expose VirtualHost attributes
[ https://issues.apache.org/jira/browse/QPID-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3092. -- Resolution: Fixed > JMX Management Console does not expose VirtualHost attributes > - > > Key: QPID-3092 > URL: https://issues.apache.org/jira/browse/QPID-3092 > Project: Qpid > Issue Type: Bug > Components: Java Management : JMX Console >Affects Versions: 0.6, 0.7, 0.8 >Reporter: Robbie Gemmell >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.9 > > > JMX Management Console does not expose VirtualHost attributes -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2486) cannot move messages onto a durable subscription backing queue using the JMX Management Console
[ https://issues.apache.org/jira/browse/QPID-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-2486. -- Resolution: Fixed > cannot move messages onto a durable subscription backing queue using the JMX > Management Console > --- > > Key: QPID-2486 > URL: https://issues.apache.org/jira/browse/QPID-2486 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Management : JMX Console >Affects Versions: M2.1, M3, M4, 0.5, 0.6, 0.7, 0.8 >Reporter: Robbie Gemmell >Assignee: Andrew Kennedy > Fix For: 0.9 > > > The backing queue created for durable subscriptions contains a colon in the > name, :, which cannot be used in unquoted form > within a JMX ObjectName. The broker does not quote the queue name in the > ObjectName and instead encodes the name by substituting a - for the colon. As > a result, when attempt is made to move messages onto the backing queue of a > durable subscription using the management console, it sends the ObjectName > interpretation of the queue name to the broker and not the actual name, > leading to a NullPointerException being genereated within the mesage store > when trying to store the message on the new queue, because the queue does not > actually exist as specified. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3090) JMX ObjectName name may not match the underlying managed object
[ https://issues.apache.org/jira/browse/QPID-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3090. -- Resolution: Fixed Review OK > JMX ObjectName name may not match the underlying managed object > --- > > Key: QPID-3090 > URL: https://issues.apache.org/jira/browse/QPID-3090 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.5, 0.6, 0.7, 0.8 >Reporter: Robbie Gemmell >Assignee: Andrew Kennedy >Priority: Critical > Fix For: 0.9 > > > Because certain characters cannot be contained in an unquoted JMX ObjectName, > the broker is currently remapping these characters (in some but not all > cases) to different values to avoid trying to create an MBean with an illegal > ObjectName. However, this can lead to situations where the broker considered > an entity (eg a queue) to have one name, but users consider it to have > another because that is what is displayed as the name of its MBean. > This disconnect in naming is the cause of various issues, such as QPID-2486 > and QPID-3094 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3095) AMQBrokerDetails equals() and hashCode() methods do adhere to contract
AMQBrokerDetails equals() and hashCode() methods do adhere to contract -- Key: QPID-3095 URL: https://issues.apache.org/jira/browse/QPID-3095 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.9 Reporter: Andrew Kennedy Priority: Minor The AMQBrokerDetails object has an equals and a hashCode implementation that are not compatible. Equality uses case-insensitive comparisons and also compares SSL status, whereas the hashCode is calculated using the provided values and does not include SSL details. The contract for hashCode is given here: http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3095) AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
[ https://issues.apache.org/jira/browse/QPID-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3095: - Summary: AMQBrokerDetails equals() and hashCode() methods do not adhere to contract (was: AMQBrokerDetails equals() and hashCode() methods do adhere to contract) > AMQBrokerDetails equals() and hashCode() methods do not adhere to contract > -- > > Key: QPID-3095 > URL: https://issues.apache.org/jira/browse/QPID-3095 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Priority: Minor > > The AMQBrokerDetails object has an equals and a hashCode implementation that > are not compatible. Equality uses case-insensitive comparisons and also > compares SSL status, whereas the hashCode is calculated using the provided > values and does not include SSL details. The contract for hashCode is given > here: > http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-3093) BytesMessage is not readable after creation
[ https://issues.apache.org/jira/browse/QPID-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy reassigned QPID-3093: Assignee: Robbie Gemmell (was: Andrew Kennedy) Robbie, can you review this please > BytesMessage is not readable after creation > --- > > Key: QPID-3093 > URL: https://issues.apache.org/jira/browse/QPID-3093 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.5 >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.5 > > > When Mule (however this could apply to any JMS application) creates an > AbstractBytesMessage from a byte[] during message processing, it attempts to > print the contents of the message. This cauxses a > javax.jms.MessageNotReadableException to be thrown with the message"You need > to call reset() to make the message readable". The issue has been fixed in > the trunk code as QPID-1830 by removing the checkReadable() method from the > toBodyString() and porting this fix to the 0.5 branch solves the issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3093) BytesMessage is not readable after creation
[ https://issues.apache.org/jira/browse/QPID-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3093: - Summary: BytesMessage is not readable after creation (was: BytesMessage is not readable after createion) > BytesMessage is not readable after creation > --- > > Key: QPID-3093 > URL: https://issues.apache.org/jira/browse/QPID-3093 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.5 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.5 > > > When Mule (however this could apply to any JMS application) creates an > AbstractBytesMessage from a byte[] during message processing, it attempts to > print the contents of the message. This cauxses a > javax.jms.MessageNotReadableException to be thrown with the message"You need > to call reset() to make the message readable". The issue has been fixed in > the trunk code as QPID-1830 by removing the checkReadable() method from the > toBodyString() and porting this fix to the 0.5 branch solves the issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3093) BytesMessage is not readable after createion
[ https://issues.apache.org/jira/browse/QPID-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3093: - Status: Ready To Review (was: In Progress) > BytesMessage is not readable after createion > > > Key: QPID-3093 > URL: https://issues.apache.org/jira/browse/QPID-3093 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.5 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.5 > > > When Mule (however this could apply to any JMS application) creates an > AbstractBytesMessage from a byte[] during message processing, it attempts to > print the contents of the message. This cauxses a > javax.jms.MessageNotReadableException to be thrown with the message"You need > to call reset() to make the message readable". The issue has been fixed in > the trunk code as QPID-1830 by removing the checkReadable() method from the > toBodyString() and porting this fix to the 0.5 branch solves the issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3093) BytesMessage is not readable after createion
[ https://issues.apache.org/jira/browse/QPID-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000836#comment-13000836 ] Andrew Kennedy commented on QPID-3093: -- The backported fix was committed to the 0.5.x-dev branch as revision 1069472 on 10 February 2011 http://svn.apache.org/viewvc?view=rev&rev=1069472 > BytesMessage is not readable after createion > > > Key: QPID-3093 > URL: https://issues.apache.org/jira/browse/QPID-3093 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.5 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.5 > > > When Mule (however this could apply to any JMS application) creates an > AbstractBytesMessage from a byte[] during message processing, it attempts to > print the contents of the message. This cauxses a > javax.jms.MessageNotReadableException to be thrown with the message"You need > to call reset() to make the message readable". The issue has been fixed in > the trunk code as QPID-1830 by removing the checkReadable() method from the > toBodyString() and porting this fix to the 0.5 branch solves the issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3093) BytesMessage is not readable after createion
BytesMessage is not readable after createion Key: QPID-3093 URL: https://issues.apache.org/jira/browse/QPID-3093 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.5 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Fix For: 0.5 When Mule (however this could apply to any JMS application) creates an AbstractBytesMessage from a byte[] during message processing, it attempts to print the contents of the message. This cauxses a javax.jms.MessageNotReadableException to be thrown with the message"You need to call reset() to make the message readable". The issue has been fixed in the trunk code as QPID-1830 by removing the checkReadable() method from the toBodyString() and porting this fix to the 0.5 branch solves the issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-3065) Send header and frame data as single buffer
[ https://issues.apache.org/jira/browse/QPID-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy reassigned QPID-3065: Assignee: Robbie Gemmell (was: Andrew Kennedy) Robbie, please review > Send header and frame data as single buffer > --- > > Key: QPID-3065 > URL: https://issues.apache.org/jira/browse/QPID-3065 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.9 > > > The Disassembler class for the AMQP 0-10 protocol version sends the 12 byte > frame header to the network layer in a separate call from the rest of the > frame data. This can cause frame header data to be received out-of-order or > corrupted frame bodies, particularly with VM transports. The entire frame, > including the header, should be written into a single ByteBuffer which should > be sent using a single call to the network layer, eliminating this issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-1916) Maven artifacts for the client
[ https://issues.apache.org/jira/browse/QPID-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-1916. -- Resolution: Fixed Review OK > Maven artifacts for the client > -- > > Key: QPID-1916 > URL: https://issues.apache.org/jira/browse/QPID-1916 > Project: Qpid > Issue Type: New Feature > Components: Ant Build System, Build Tools, Java Client, Java Common, > Java Tools, Maven build system, Qpid Managment Framework >Affects Versions: M3, M4, 0.5, 0.6, 0.7, 0.8 >Reporter: Bryan Kearney >Assignee: Andrew Kennedy > Fix For: 0.9 > > Attachments: genpom.patch, maven.patch, mavenize3.patch > > > The attached patch files adds the maven ant tasks to the build system. It > allows, on a per-module basis, to support creating a pom file and exporting > the jars to a maven repository. This is not a very DRY solution, as it > requires copying the dependency information from the build.deps file. I have > only added the pom files for the client bits, since i believe these are the > most likely to be required by folks using QMF. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3065) Send header and frame data as single buffer
[ https://issues.apache.org/jira/browse/QPID-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3065: - Status: Ready To Review (was: In Progress) > Send header and frame data as single buffer > --- > > Key: QPID-3065 > URL: https://issues.apache.org/jira/browse/QPID-3065 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.9 > > > The Disassembler class for the AMQP 0-10 protocol version sends the 12 byte > frame header to the network layer in a separate call from the rest of the > frame data. This can cause frame header data to be received out-of-order or > corrupted frame bodies, particularly with VM transports. The entire frame, > including the header, should be written into a single ByteBuffer which should > be sent using a single call to the network layer, eliminating this issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2977) Updated pom files for slf4j
[ https://issues.apache.org/jira/browse/QPID-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-2977. -- Resolution: Fixed Review OK > Updated pom files for slf4j > --- > > Key: QPID-2977 > URL: https://issues.apache.org/jira/browse/QPID-2977 > Project: Qpid > Issue Type: Bug > Components: Java Common >Affects Versions: 0.8 >Reporter: Emmanuel Bourg >Assignee: Andrew Kennedy >Priority: Trivial > Fix For: 0.9 > > > slf4j has been updated to the version 1.6.1 recently, but the corresponding > pom files were not updated in qpid/java/lib/poms. The 1.4.0 poms should be > removed and replaced by these: > http://repo1.maven.org/maven2/org/slf4j/slf4j-api/1.6.1/slf4j-api-1.6.1.pom > http://repo1.maven.org/maven2/org/slf4j/slf4j-log4j12/1.6.1/slf4j-log4j12-1.6.1.pom -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3021) the Session and Connector actors should be set for events occurring on 0-10 connections
[ https://issues.apache.org/jira/browse/QPID-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3021. -- Resolution: Fixed Review OK > the Session and Connector actors should be set for events occurring on 0-10 > connections > --- > > Key: QPID-3021 > URL: https://issues.apache.org/jira/browse/QPID-3021 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.8, 0.9 >Reporter: Robbie Gemmell >Assignee: Andrew Kennedy > Fix For: 0.9 > > > When addressing QPID-3014 it was noticed that the Session and Connector > actors were not being set appropriately when processing events arriving on > 0-10 connections. As a result, logging such as session close and connection > close do not properly convey the associated LogActor, and instead reported > either the actor for the wrong connection that was previously left on the > CurrentAActor stack, or jsut the default Broker actor supplied when the stack > is empty. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3070) SessionComplete command sent for empty range
[ https://issues.apache.org/jira/browse/QPID-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996787#comment-12996787 ] Andrew Kennedy commented on QPID-3070: -- Ok, I will await further comments. > SessionComplete command sent for empty range > > > Key: QPID-3070 > URL: https://issues.apache.org/jira/browse/QPID-3070 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Client >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.9 > > > The 0-10 AMQP protocol implementation sends a SessionComplete command with an > empty RangeSet, which will be replied to with a SessionKnownComplete and a > similar empty or null RangeSet (these are equivalent on the wire) iff the > TimelyReply field is set to true in the request. > I think that the initial empty SessionComplete (caused by a call to > flushProcessed normally) should never be sent, so adding a check for > range.size() > 0 before sending should do this. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3070) SessionComplete command sent for empty range
SessionComplete command sent for empty range Key: QPID-3070 URL: https://issues.apache.org/jira/browse/QPID-3070 Project: Qpid Issue Type: Bug Components: Java Broker, Java Client Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Fix For: 0.9 The 0-10 AMQP protocol implementation sends a SessionComplete command with an empty RangeSet, which will be replied to with a SessionKnownComplete and a similar empty or null RangeSet (these are equivalent on the wire) iff the TimelyReply field is set to true in the request. I think that the initial empty SessionComplete (caused by a call to flushProcessed normally) should never be sent, so adding a check for range.size() > 0 before sending should do this. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3029) Java broker claims to support 2^16 channels per connection when it doesn't
[ https://issues.apache.org/jira/browse/QPID-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996342#comment-12996342 ] Andrew Kennedy commented on QPID-3029: -- In AMQP connections, the maximum number of channels is a two octet field. In ServerDelegate#getChannelMax() the number of channels should be 0x, not Integer.MAX_VALUE. Also, in Connection#map(Session) the loop through the channels map should start at Connection#MIN_USABLE_CHANNEL_NUM rather than explicitly using zero. These are not very important, and are trivial changes in any case. > Java broker claims to support 2^16 channels per connection when it doesn't > -- > > Key: QPID-3029 > URL: https://issues.apache.org/jira/browse/QPID-3029 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Client >Affects Versions: 0.6, 0.7, 0.8 >Reporter: Robbie Gemmell >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.9 > > > The Java broker claims to support 2^16 channels per connection when it > doesn't. It should negotiate the supported channel limit to the client during > the protocol handshake. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3029) Java broker claims to support 2^16 channels per connection when it doesn't
[ https://issues.apache.org/jira/browse/QPID-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3029. -- Resolution: Fixed Accepted changes > Java broker claims to support 2^16 channels per connection when it doesn't > -- > > Key: QPID-3029 > URL: https://issues.apache.org/jira/browse/QPID-3029 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Client >Affects Versions: 0.6, 0.7, 0.8 >Reporter: Robbie Gemmell >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.9 > > > The Java broker claims to support 2^16 channels per connection when it > doesn't. It should negotiate the supported channel limit to the client during > the protocol handshake. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-3066) UTF8Test does not run under non VM 0-10 profiles
[ https://issues.apache.org/jira/browse/QPID-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy reassigned QPID-3066: Assignee: Andrew Kennedy > UTF8Test does not run under non VM 0-10 profiles > > > Key: QPID-3066 > URL: https://issues.apache.org/jira/browse/QPID-3066 > Project: Qpid > Issue Type: Bug > Components: Java Tests >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.9 > > > The UTF8Test uses the 'isBrokerExternal' and 'isBroker010' methods to check > whether it should run, rather than relying on the Excludes files. The checks > wrongly cause an exception to be thrown on the java.0.10 test profile. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3066) UTF8Test does not run under non VM 0-10 profiles
UTF8Test does not run under non VM 0-10 profiles Key: QPID-3066 URL: https://issues.apache.org/jira/browse/QPID-3066 Project: Qpid Issue Type: Bug Components: Java Tests Affects Versions: 0.9 Reporter: Andrew Kennedy Priority: Minor Fix For: 0.9 The UTF8Test uses the 'isBrokerExternal' and 'isBroker010' methods to check whether it should run, rather than relying on the Excludes files. The checks wrongly cause an exception to be thrown on the java.0.10 test profile. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3065) Send header and frame data as single buffer
Send header and frame data as single buffer --- Key: QPID-3065 URL: https://issues.apache.org/jira/browse/QPID-3065 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Fix For: 0.9 The Disassembler class for the AMQP 0-10 protocol version sends the 12 byte frame header to the network layer in a separate call from the rest of the frame data. This can cause frame header data to be received out-of-order or corrupted frame bodies, particularly with VM transports. The entire frame, including the header, should be written into a single ByteBuffer which should be sent using a single call to the network layer, eliminating this issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-3008) QueueBrowserAutoAckTest#testFailoverWithQueueBrowser fails with the 0-10 Java client
[ https://issues.apache.org/jira/browse/QPID-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy reassigned QPID-3008: Assignee: Robbie Gemmell (was: Andrew Kennedy) Ready for review > QueueBrowserAutoAckTest#testFailoverWithQueueBrowser fails with the 0-10 Java > client > > > Key: QPID-3008 > URL: https://issues.apache.org/jira/browse/QPID-3008 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.8 >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > > In the 0-10 Java client when a QueueBrowser returns an Enumeration, and it is > being enumerated over while the connection fails over, the consumer cannot > tell that failover is ocurring and sends messages with incorrect subscriber > tag numbers to the broker. The BasicMessageConsumer_0_10 uses the shared > BasicMessageConsumer#acquireReceiving(boolean) method which tries to call > AMQConnection#isFailingOver() and #blockUntilNotFailingOver() and receives > incorrect results. This is because AMQConnectionDelegate_0_10 does not start > a FailoverHandler continuation and therefore the > AMQProtocolHandler#setFailoverLatch(CountdownLatch) and associated methods > are never called. > To correct this behaviour update the connection close method of the 0-10 > delegate to create the latch, attempt failover and then decrement and remove > the latch on success. > QueueBrowserAutoAckTest#testFailoverWithQueueBrowser() is excluded from the > cpp.noprefetch profile. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3047) The QueueDepthWithSelectorTest fails on 0-10 profiles
[ https://issues.apache.org/jira/browse/QPID-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-3047: - Status: Ready To Review (was: In Progress) > The QueueDepthWithSelectorTest fails on 0-10 profiles > - > > Key: QPID-3047 > URL: https://issues.apache.org/jira/browse/QPID-3047 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.9 > > > The QueueDepthWithSelector needs refactored to use QpidBrokerTestCase rather > than being hardcoded simply the 0-8 iVM broker. Once this is done, the test > fails on 0-10 profiles, as the session is not flushing acks correctly. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Assigned: (QPID-3047) The QueueDepthWithSelectorTest fails on 0-10 profiles
[ https://issues.apache.org/jira/browse/QPID-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy reassigned QPID-3047: Assignee: Robbie Gemmell (was: Andrew Kennedy) Ready to review > The QueueDepthWithSelectorTest fails on 0-10 profiles > - > > Key: QPID-3047 > URL: https://issues.apache.org/jira/browse/QPID-3047 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.9 > > > The QueueDepthWithSelector needs refactored to use QpidBrokerTestCase rather > than being hardcoded simply the 0-8 iVM broker. Once this is done, the test > fails on 0-10 profiles, as the session is not flushing acks correctly. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Closed: (QPID-3048) InternalBrokerBasecase not removing all log actors
[ https://issues.apache.org/jira/browse/QPID-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy closed QPID-3048. Closing issue > InternalBrokerBasecase not removing all log actors > -- > > Key: QPID-3048 > URL: https://issues.apache.org/jira/browse/QPID-3048 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.9 > > > The InternalBrokerbaseCase checks if CurrentActor.get() returns null, however > in CurrentActor this can never happen, since we return a default if the stack > is empty. Adding a removeAll method to CurrentActor will allow test cases to > clean up properly. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3048) InternalBrokerBasecase not removing all log actors
[ https://issues.apache.org/jira/browse/QPID-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3048. -- Resolution: Fixed Committed changes > InternalBrokerBasecase not removing all log actors > -- > > Key: QPID-3048 > URL: https://issues.apache.org/jira/browse/QPID-3048 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.9 > > > The InternalBrokerbaseCase checks if CurrentActor.get() returns null, however > in CurrentActor this can never happen, since we return a default if the stack > is empty. Adding a removeAll method to CurrentActor will allow test cases to > clean up properly. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3016) Java JMS client ReplyTo memory leak
[
https://issues.apache.org/jira/browse/QPID-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy resolved QPID-3016.
--
Resolution: Fixed
Fix Version/s: 0.9
Ready for review
> Java JMS client ReplyTo memory leak
> ---
>
> Key: QPID-3016
> URL: https://issues.apache.org/jira/browse/QPID-3016
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
>Affects Versions: 0.8
> Environment: Fedora 14: 2.6.35.10-74.fc14.x86_64
> Broker: qpidd (qpidc) version 0.8
> Java Client 0.8
> OpenJDK Runtime Environment (IcedTea6 1.9.3) (fedora-49.1.9.3.fc14-x86_64)
> OpenJDK 64-Bit Server VM (build 19.0-b09, mixed mode)
>Reporter: David Kellum
>Assignee: Robbie Gemmell
> Fix For: 0.9
>
>
> I'm using the Java 0.8 client JMS interface. Relevant Client code is below.
> If I make async requests to a queue with setJMSReplyTo as temporary queue for
> responses, the client process will run out of memory after about 3.2M
> request/response message pairs. This is at 512MB max java heap, though growth
> appears to be consistently linear. Note that I use a semaphore between
> request and response to keep ~1000 unanswered requests open in the client and
> block before sending more. Thus this should not be a matter of simply
> saturating the client with unsent messages.
> Here is the top of the jhat histogram from jmap heap dump shortly before
> client runs out of memory:
> class org.apache.qpid.collections.ReferenceMap$SoftRef 3253120
> 143137280
> class org.apache.qpid.collections.ReferenceMap$Entry3253120
> 117112320
> class [Lorg.apache.qpid.collections.ReferenceMap$Entry; 1
> 67108880
> class org.apache.qpid.transport.ReplyTo 3253120
> 61809280
> Note that 3253120 appears to match the total number of request/replies
> successfully processed by the client up to this point. Or in other words, its
> leaking one ReplyTo object and associated (not so?) soft references per
> request/response.
> If instead I replace the temporary queue with a fixed response and drop use
> of setJMSReplyTo(), the client works fine, no memory leak.
> Below are more details when running with the temp response queue:
> % qpid-config queues
> Queue Name Attributes
> ==
> TempQueued4051d9d-37d3-4306-a1fc-91b93f7082c8 auto-del excl
> iudex-brutefuzzy-request --max-queue-size=10
> --limit-policy=reject
> Client startup Log:
> 635 [main] INFO o.a.q.j.PropertiesFileInitialContextFactory - No Provider
> URL specified.
> 726 [main] INFO o.a.qpid.client.AMQConnection -
> Connection:amqp://qpid:@default-client/default-vhost?brokerlist='tcp://localhost:5672'
> 973 [main] INFO o.a.q.c.p.AMQProtocolSession - Using ProtocolVersion for
> Session:0-10
> 990 [main] INFO o.a.q.c.h.ClientMethodDispatcherImpl - New Method
> Dispatcher:AMQProtocolSession[null]
> 1002 [main] INFO o.a.qpid.client.AMQConnection - Connecting with
> ProtocolHandler Version:0-10
> 1150 [main] INFO o.a.qpid.client.AMQConnection - Connected with
> ProtocolHandler Version:0-10
> 1192 [main] INFO o.a.qpid.client.AMQSession - Created
> session:org.apache.qpid.client.AMQSession_0_10@1b7c63f
> 1280 [main] INFO o.a.q.c.BasicMessageProducer_0_10 - MessageProducer
> org.apache.qpid.client.BasicMessageProducer_0_10@1727745 using publish mode :
> ASYNC_PUBLISH_ALL
> 1503 [main] INFO o.a.qpid.client.AMQSession - Prefetching delayed existing
> messages will not flow until requested via receive*() or setML().
> 1586 [main] INFO o.a.q.c.AMQSession.Dispatcher - Dispatcher-Channel-1 created
> 1586 [Dispatcher-Channel-1] INFO o.a.q.c.AMQSession.Dispatcher -
> Dispatcher-Channel-1 started
> Relevent client code:
> public class Client
> implements MessageListener, Closeable, ExceptionListener
> {
> public Client( JMSContext context )
> throws JMSException, NamingException
> {
> _connection = context.createConnection();
> _session = context.createSession( _connection );
> Destination requestQueue =
> context.lookupDestination( "iudex-brutefuzzy-request" );
> _producer = _session.createProducer( requestQueue );
> context.close();
> _responseQueue = _session.createTemporaryQueue();
> _session.createConsumer( _responseQueue ).setMessageListener(this);
> _connection.start();
> }
> public void sendRequest( long simhash, boolean doAdd )
> throws JMSException, InterruptedException
> {
> Builder bldr = Request.newBuilder();
> bldr.setSimhash( simhash );
> bldr.setAction( doAdd ? RequestAction.ADD : RequestAction.CHECK_ONLY
>
[jira] Assigned: (QPID-3016) Java JMS client ReplyTo memory leak
[
https://issues.apache.org/jira/browse/QPID-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy reassigned QPID-3016:
Assignee: Robbie Gemmell (was: Andrew Kennedy)
Please review
> Java JMS client ReplyTo memory leak
> ---
>
> Key: QPID-3016
> URL: https://issues.apache.org/jira/browse/QPID-3016
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
>Affects Versions: 0.8
> Environment: Fedora 14: 2.6.35.10-74.fc14.x86_64
> Broker: qpidd (qpidc) version 0.8
> Java Client 0.8
> OpenJDK Runtime Environment (IcedTea6 1.9.3) (fedora-49.1.9.3.fc14-x86_64)
> OpenJDK 64-Bit Server VM (build 19.0-b09, mixed mode)
>Reporter: David Kellum
>Assignee: Robbie Gemmell
>
> I'm using the Java 0.8 client JMS interface. Relevant Client code is below.
> If I make async requests to a queue with setJMSReplyTo as temporary queue for
> responses, the client process will run out of memory after about 3.2M
> request/response message pairs. This is at 512MB max java heap, though growth
> appears to be consistently linear. Note that I use a semaphore between
> request and response to keep ~1000 unanswered requests open in the client and
> block before sending more. Thus this should not be a matter of simply
> saturating the client with unsent messages.
> Here is the top of the jhat histogram from jmap heap dump shortly before
> client runs out of memory:
> class org.apache.qpid.collections.ReferenceMap$SoftRef 3253120
> 143137280
> class org.apache.qpid.collections.ReferenceMap$Entry3253120
> 117112320
> class [Lorg.apache.qpid.collections.ReferenceMap$Entry; 1
> 67108880
> class org.apache.qpid.transport.ReplyTo 3253120
> 61809280
> Note that 3253120 appears to match the total number of request/replies
> successfully processed by the client up to this point. Or in other words, its
> leaking one ReplyTo object and associated (not so?) soft references per
> request/response.
> If instead I replace the temporary queue with a fixed response and drop use
> of setJMSReplyTo(), the client works fine, no memory leak.
> Below are more details when running with the temp response queue:
> % qpid-config queues
> Queue Name Attributes
> ==
> TempQueued4051d9d-37d3-4306-a1fc-91b93f7082c8 auto-del excl
> iudex-brutefuzzy-request --max-queue-size=10
> --limit-policy=reject
> Client startup Log:
> 635 [main] INFO o.a.q.j.PropertiesFileInitialContextFactory - No Provider
> URL specified.
> 726 [main] INFO o.a.qpid.client.AMQConnection -
> Connection:amqp://qpid:@default-client/default-vhost?brokerlist='tcp://localhost:5672'
> 973 [main] INFO o.a.q.c.p.AMQProtocolSession - Using ProtocolVersion for
> Session:0-10
> 990 [main] INFO o.a.q.c.h.ClientMethodDispatcherImpl - New Method
> Dispatcher:AMQProtocolSession[null]
> 1002 [main] INFO o.a.qpid.client.AMQConnection - Connecting with
> ProtocolHandler Version:0-10
> 1150 [main] INFO o.a.qpid.client.AMQConnection - Connected with
> ProtocolHandler Version:0-10
> 1192 [main] INFO o.a.qpid.client.AMQSession - Created
> session:org.apache.qpid.client.AMQSession_0_10@1b7c63f
> 1280 [main] INFO o.a.q.c.BasicMessageProducer_0_10 - MessageProducer
> org.apache.qpid.client.BasicMessageProducer_0_10@1727745 using publish mode :
> ASYNC_PUBLISH_ALL
> 1503 [main] INFO o.a.qpid.client.AMQSession - Prefetching delayed existing
> messages will not flow until requested via receive*() or setML().
> 1586 [main] INFO o.a.q.c.AMQSession.Dispatcher - Dispatcher-Channel-1 created
> 1586 [Dispatcher-Channel-1] INFO o.a.q.c.AMQSession.Dispatcher -
> Dispatcher-Channel-1 started
> Relevent client code:
> public class Client
> implements MessageListener, Closeable, ExceptionListener
> {
> public Client( JMSContext context )
> throws JMSException, NamingException
> {
> _connection = context.createConnection();
> _session = context.createSession( _connection );
> Destination requestQueue =
> context.lookupDestination( "iudex-brutefuzzy-request" );
> _producer = _session.createProducer( requestQueue );
> context.close();
> _responseQueue = _session.createTemporaryQueue();
> _session.createConsumer( _responseQueue ).setMessageListener(this);
> _connection.start();
> }
> public void sendRequest( long simhash, boolean doAdd )
> throws JMSException, InterruptedException
> {
> Builder bldr = Request.newBuilder();
> bldr.setSimhash( simhash );
> bldr.setAction( doAdd ? RequestAction.ADD : RequestAction.CHECK_ONLY
> );
> BytesMessag
[jira] Created: (QPID-3052) Java test profiles do not effectively test all AMQP protocol versions
Java test profiles do not effectively test all AMQP protocol versions - Key: QPID-3052 URL: https://issues.apache.org/jira/browse/QPID-3052 Project: Qpid Issue Type: Bug Components: Java Tests Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Fix For: 0.9 The Java test profiles assume that, particularly default one for InVm transports, the 0-10 protocol will fail, causing renegotiation. If 0-10 InVm support is added then the default protocol will use this. It seems to make more sense to specify exactly the version the client and the broker should announce, and force renegotiation explicitly by disabling various protocol versions on the command line when starting an external Java broker. Note that this is not possible to specify for the InVm profiles anyway. Also, the only protocol that is ever tested will be the highest supported by both broker and client, therefore this is AMQP 0-9-1. In order for the tests not to do surprising things when new protocol versions are added, I think that setting versions explicitly is the best idea. I woulsd also like to add an explicit 0-8 test profile for both InVM and external Java brokers, in order to exercise and get coverage on this code. In future, I recommend that some form of combinatorial profile system be investigated for the test subsystem, allowing the required protocol, broker type and so on to be specified separately. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3043) If a new session is created during failover, but before 'resume' is completed, the new session gets reattached again.
[ https://issues.apache.org/jira/browse/QPID-3043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993550#comment-12993550 ] Andrew Kennedy commented on QPID-3043: -- The " connectionLost" field is scoped as "private static", so it is shared among all connections on the same JVM. This will lead to undesirable behaviour if only one of those connections is lost, and should probably be instance local. instead. > If a new session is created during failover, but before 'resume' is > completed, the new session gets reattached again. > - > > Key: QPID-3043 > URL: https://issues.apache.org/jira/browse/QPID-3043 > Project: Qpid > Issue Type: Bug >Affects Versions: 0.6, 0.7, 0.8 >Reporter: Rajith Attapattu >Assignee: Rajith Attapattu > Fix For: Future > > > This bug was discovered while investigating QPID-2994 > There exists a race condition, where if a session is created (after the > connection is setup and is marked OPEN) but before the resume method (in > Connection.java) is called, it results in the new session being reattached > again. This could result in unnecessary duplication of messages. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3047) The QueueDepthWithSelectorTest fails on 0-10 profiles
[ https://issues.apache.org/jira/browse/QPID-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992529#comment-12992529 ] Andrew Kennedy commented on QPID-3047: -- Understood. This fixes the situation where the client is requesting the queue depth, and there are queued up unsent acks because neither 1 or 2 has happenend yet. In this case, the reported queue depth will be wrong, so sending any unflushed acks beforehand is the correct thing to do for this type of synchronous operation. > The QueueDepthWithSelectorTest fails on 0-10 profiles > - > > Key: QPID-3047 > URL: https://issues.apache.org/jira/browse/QPID-3047 > Project: Qpid > Issue Type: Bug > Components: Java Client >Affects Versions: 0.9 >Reporter: Andrew Kennedy >Assignee: Andrew Kennedy > Fix For: 0.9 > > > The QueueDepthWithSelector needs refactored to use QpidBrokerTestCase rather > than being hardcoded simply the 0-8 iVM broker. Once this is done, the test > fails on 0-10 profiles, as the session is not flushing acks correctly. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3048) InternalBrokerBasecase not removing all log actors
InternalBrokerBasecase not removing all log actors -- Key: QPID-3048 URL: https://issues.apache.org/jira/browse/QPID-3048 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Priority: Minor Fix For: 0.9 The InternalBrokerbaseCase checks if CurrentActor.get() returns null, however in CurrentActor this can never happen, since we return a default if the stack is empty. Adding a removeAll method to CurrentActor will allow test cases to clean up properly. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3047) The QueueDepthWithSelectorTest fails on 0-10 profiles
The QueueDepthWithSelectorTest fails on 0-10 profiles - Key: QPID-3047 URL: https://issues.apache.org/jira/browse/QPID-3047 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.9 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Fix For: 0.9 The QueueDepthWithSelector needs refactored to use QpidBrokerTestCase rather than being hardcoded simply the 0-8 iVM broker. Once this is done, the test fails on 0-10 profiles, as the session is not flushing acks correctly. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3023) logging tests unnecessarily use an InternalBrokerBaseCase to load configuration for test comparison
[ https://issues.apache.org/jira/browse/QPID-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-3023. -- Resolution: Fixed > logging tests unnecessarily use an InternalBrokerBaseCase to load > configuration for test comparison > --- > > Key: QPID-3023 > URL: https://issues.apache.org/jira/browse/QPID-3023 > Project: Qpid > Issue Type: Test > Components: Java Tests >Affects Versions: 0.7, 0.8 >Reporter: Robbie Gemmell >Assignee: Andrew Kennedy >Priority: Minor > Fix For: 0.9 > > > The status logging tests use an InternalBrokerBaseCase to simply load > virtualhost configuration. It should be possible to use a ServerConfiguration > for this directly without actually using an IBBC. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
