[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...
Github user ErnieAllen commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/415#discussion_r232223312
--- Diff: src/router_core/router_core_private.h ---
@@ -321,7 +321,8 @@ ALLOC_DECLARE(qdr_router_ref_t);
DEQ_DECLARE(qdr_router_ref_t, qdr_router_ref_list_t);
typedef enum {
-QDR_DELIVERY_NOWHERE = 0,
+QDR_DELIVERY_UNINITIALIZED = 0,
+QDR_DELIVERY_NOWHERE,
--- End diff --
New commit just uses QDR_DELIVERY_NOWHERE as the test in
transfer.c::qdr_deliver_continue_CT to reject the delivery.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/415 DISPATCH-1176 Prevent uninitialized delivery from crashing router This prevents the crash but... I'm concerned about router inter-operability between different versions of the router. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-1176 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/415.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #415 commit 51a02e6a5de6907c14df24db7cd51475e45f2ea6 Author: Ernest Allen Date: 2018-11-08T12:40:53Z DISPATCH-1176 Prevent uninitialized delivery from crashing router --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #408: ernie-DISPATCH-1158 Add background map to c...
Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/408 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #408: ernie-DISPATCH-1158 Add background map to c...
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/408 ernie-DISPATCH-1158 Add background map to console's topology page New feature for demos: optional background map on topology page. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-1158 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/408.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #408 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #395: DISPATCH-1147 Expose address priority to ma...
Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/395 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #395: DISPATCH-1147 Expose address priority to ma...
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/395 DISPATCH-1147 Expose address priority to management and qdstat Exposes router.address.priority to management qdstat --address now lists priority Added test to system_tests_qdstat to check if priority column is present and contains valid priority (-1 | 0-9) You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-1147 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/395.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #395 commit 046c1a890292421b37f5f50a5749d0f7efcf8d76 Author: Ernest Allen Date: 2018-10-24T21:25:46Z DISPATCH-1147 Expose address priority to management and qdstat --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #389: DISPATCH-1130 Expose link priority
Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/389 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #389: DISPATCH-1130 Expose link priority
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/389 DISPATCH-1130 Expose link priority Adds priority to router.link management entity in the schema. Connects link.priority to schema attribute. Adds priority column to qdstat -l You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-1130 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/389.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #389 commit a81784b9bcb98c9c46795bff8055ccb73b5fc4d1 Author: Ernest Allen Date: 2018-10-10T11:16:00Z DISPATCH-1130 Expose link priority --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #333: DISPATCH-1054 add console tests to cmake
Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/333 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #332: Dispatch 1049 console tests
Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/332 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #332: Dispatch 1049 console tests
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/332 Dispatch 1049 console tests Console unit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch DISPATCH-1049-console-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/332.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #332 commit 0d4d233a9f9c8d7bbc451f6d50213fb99a35e688 Author: Ernest Allen Date: 2018-06-25T12:56:46Z DISPATCH-1049 Add console tests commit 0c51c78f2e33978e28a99b6fda391e0dc7c0de1d Author: Ernest Allen Date: 2018-06-25T13:12:39Z DISPATCH-1049 Added license headers --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #331: Test new CMakeLists.txt
Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/331 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #331: Test new CMakeLists.txt
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/331 Test new CMakeLists.txt Testing if npm exists before npx. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-console-build Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #331 commit 4764c92959e934829f3fafcd8ce9c5f1934e5cc3 Author: Ernest Allen Date: 2018-06-25T20:40:28Z Test new CMakeLists.txt --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #312: DISPATCH-1017 Add console to build
Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/312 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #312: Add console to build
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/312 Add console to build Please review the CMakeLists.txt The console build will: - run lint on javascript and typescript files - convert typescript files to javascript - run babel so I can use modern javascript syntax and still run on older browsers - concat all 3rd party .css files into a single file - concat all 3rd party .js files into a single file - concat all console .js files into a single file - minimize all .css and .js files - copy build artefacts into dist/ folder for installing Running make install will copy all built and static files to the console install dir. Notes: - I'm using file (GLOB ...) to get a list of the files to be built. If new files are added later, cmake won't know about them and may skip building the console. This shouldn't be a problem for production builds, but for day to day development builds it may be necessary to run cmake . or touch CMakeLists.txt before running make. This is not a problem specific to the console build. - To build the console, npm must be installed. Should I move the line that adds the cmake 'option' to build the console inside the check if npm is installed? - To build the console, gulp-cli has to be install globally. This is done with the 'sudo npm install -g gulp-cli' command. This can't be put into the build script since I can't assume sudo permissions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/312.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #312 commit b622fa8f07cbd354424c5db474844513d7e6df97 Author: Ernest Allen Date: 2018-06-02T17:09:29Z DISPATCH-1017 Add console to make build commit dcea91d2cd3c65416a9f0f40092b55999bfbba4e Author: Ernest Allen Date: 2018-06-02T17:10:38Z DISPATCH-1017 Add new typescript lint files for building console --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #305: Dispatch 965 - Port to Python 3.x
Github user ErnieAllen commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/305#discussion_r188746296 --- Diff: console/config/mock/section.py --- @@ -17,6 +17,11 @@ # under the License. # +from __future__ import print_function +from __future__ import unicode_literals +from __future__ import division +from __future__ import absolute_import + import json import re from schema import Schema --- End diff -- I think this needs to be: from .schema import Schema since the schema.py is in the same directory as the section.py file. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #253: Enhanced link-statistics
Github user ErnieAllen commented on the issue: https://github.com/apache/qpid-dispatch/pull/253  In a 5 router network, I'm seeing an ingressHistogram that is a large array. Shouldn't the histogram have one array element per router? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #249: DISPATCH-921 Run npm install after stand-al...
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/249 DISPATCH-921 Run npm install after stand-alone console install Checks to make sure npm is installed and runs npm install after console file have been copied. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-921 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit 9a0626878ea3f35e3a082f9591616e8b31380e13 Author: Ernest Allen <eallen@...> Date: 2018-01-29T16:53:49Z DISPATCH-921 Run npm install after stand-alone console install --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #210: DISPATCH-580 Adding graph=true for logStats...
Github user ErnieAllen closed the pull request at: https://github.com/apache/qpid-dispatch/pull/210 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #210: DISPATCH-580 Adding graph=true for logStats...
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/210 DISPATCH-580 Adding graph=true for logStats statistics Added graph=true so logStats can be graphed by the console You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-dispatch-580 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #210 commit f9144afda3e056ac2d66afa5b25f5442517f0888 Author: Ernest Allen <eal...@redhat.com> Date: 2017-10-16T12:55:52Z DISPATCH-580 Adding graph=true for logStats statistics --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #209: DISPATCH-856 Add hostName to router entity
GitHub user ErnieAllen opened a pull request: https://github.com/apache/qpid-dispatch/pull/209 DISPATCH-856 Add hostName to router entity The router.hostName will be used by the console to visually group routers that are deployed on the same machine. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-dispatch-856 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #209 commit 45daf229475d4059c8e128a09397d0b426bef932 Author: Ernest Allen <eal...@redhat.com> Date: 2017-10-16T12:41:49Z DISPATCH-856 Add hostName to router entity --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
