[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL
Github user gberginc commented on the issue: https://github.com/apache/qpid-proton/pull/116 @alanconway Sorry for asking as part of this PR, but I wonder if you are aware of any update on the release of qpid_proton gem? I've asked in the users mailing list with no response, however I somewhat depend on this bug being resolved for further integration. Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #116: PROTON-1532: Allow insecure mechanism in SASL
Github user gberginc closed the pull request at: https://github.com/apache/qpid-proton/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL
Github user gberginc commented on the issue: https://github.com/apache/qpid-proton/pull/116 Great, thanks! I am now closing this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL
Github user gberginc commented on the issue: https://github.com/apache/qpid-proton/pull/116 @alanconway initially, I was using the gem from the rubygems link you mentioned, yes. I am looking forward to the new published version. Until then, I will host the gem at https://github.com/gberginc/qpid_proton_gem for I need to be able to deploy it from another app. I have tested your change and it almost worked for me. I only had to apply the following patch: ``` diff --git a/proton-c/bindings/ruby/lib/core/url.rb b/proton-c/bindings/ruby/lib/core/url.rb index 39b64650..195567f2 100644 --- a/proton-c/bindings/ruby/lib/core/url.rb +++ b/proton-c/bindings/ruby/lib/core/url.rb @@ -84,6 +84,6 @@ end class String # Convert this string to a URL def to_url() -return URL.new(self) +return Qpid::Proton::URL.new(self) end end ``` Not sure if this is because I am using the code from outside of the gem itself, though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL
Github user gberginc commented on the issue: https://github.com/apache/qpid-proton/pull/116 @alanconway I will review and test your update, thank you very much! I will report back and then also close this PR. The documentation in the readme is correct as I followed those steps to create a gem for my experiments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL
Github user gberginc commented on the issue: https://github.com/apache/qpid-proton/pull/116 @alanconway do you perhaps have a timeline for this to be released as a Gem? For the development I am able to use my own branch of this gem, but will need a published gem in the end. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #116: PROTON-1532: Allow insecure mechanism in SASL
GitHub user gberginc opened a pull request: https://github.com/apache/qpid-proton/pull/116 PROTON-1532: Allow insecure mechanism in SASL This commit extends SASL with the additional allow_insecure_mechs allowing users to override the defailt (false) authentication and use the plain mechanism. It also extends the Connection class to expose user and password that is used by the plain mechanism. Finally, this patch modifies the connect method which now avoids the use of the plain method which is not defined on SASL. The code now more resembles the Python version. This addresses the issue reported in [PROTON-1532](https://issues.apache.org/jira/browse/PROTON-1532) where I was trying to connect to an ActiveMQ using plain username/password authentication. Previous code used method `plain` which does not exist. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gberginc/qpid-proton sasl_allow_insecure Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #116 commit e218be1f128f1c7452ca19626577043c46e53651 Author: Gregor Berginc <gregor.berg...@gmail.com> Date: 2017-08-11T12:00:34Z PROTON-1532: Allow insecure mechanism in SASL This commit extends SASL with the additional allow_insecure_mechs allowing users to override the defailt (false) authentication and use the plain mechanism. It also extends the Connection class to expose user and password that is used by the plain mechanism. Finally, this patch modifies the connect method which now avoids the use of the plain method which is not defined on SASL. The code now more resembles the Python version. Signed-off-by: Gregor Berginc <gregor.berg...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
