[GitHub] qpid-proton-j pull request #13: Added API to Transport interface to allow cu...

2018-01-08 Thread timtay-microsoft
Github user timtay-microsoft closed the pull request at:

https://github.com/apache/qpid-proton-j/pull/13


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-proton-j issue #13: Added API to Transport interface to allow custom sa...

2017-12-13 Thread timtay-microsoft
Github user timtay-microsoft commented on the issue:

https://github.com/apache/qpid-proton-j/pull/13
  
https://issues.apache.org/jira/browse/PROTON-1718


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-proton-j pull request #13: Added API to Transport interface to allow cu...

2017-12-13 Thread timtay-microsoft
GitHub user timtay-microsoft opened a pull request:

https://github.com/apache/qpid-proton-j/pull/13

Added API to Transport interface to allow custom sasl implementations…

… to be provided

Fixed relationship between Sasl interface and SaslImpl such that SaslImpl 
does not implement more than the interface it should derive from. Made 
transport layer treat Sasl as an interface instead of the concrete SaslImpl 
instance

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/timtay-microsoft/qpid-proton-j master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton-j/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit 22a016300b40b85c705b31fd23c0900744a7468c
Author: timtay-microsoft 
Date:   2017-12-13T18:59:22Z

Added api to Transport interface to allow custom sasl implementations to be 
provided

Fixed relationship between Sasl interface and SaslImpl such that SaslImpl 
does not implement more than the interface it should derive from. Made 
transport layer treat Sasl as an interface instead of the concrete SaslImpl 
instance




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-proton-j pull request #11: PROTON-1606: Added ability to make SASL comm...

2017-10-05 Thread timtay-microsoft
GitHub user timtay-microsoft opened a pull request:

https://github.com/apache/qpid-proton-j/pull/11

PROTON-1606: Added ability to make SASL communication optional

Previously, the IOhandler created to be the global handler automatically 
created the SASL layer whether a user of the library wanted it or not. This 
commit exposes an option when creating the reactor to disable creating the SASL 
layer at all.

https://issues.apache.org/jira/browse/PROTON-1606

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/timtay-microsoft/qpid-proton-j 
clientSaslOptionality

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton-j/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11


commit 965bc73893f887a15b1558891039d0a5cb7556eb
Author: timtay-microsoft 
Date:   2017-10-05T18:40:28Z

PROTON-1606: Added ability to make SASL communication optional for CLIENT 
role

Previously, the IOhandler created to be the global handler automatically 
created the SASL layer whether a user of the library wanted it or not. This 
commit exposes an option when creating the reactor to disable creating the SASL 
layer at all.

https://issues.apache.org/jira/browse/PROTON-1606




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org