[GitHub] [qpid-dispatch] ErnieAllen commented on a change in pull request #783: DISPATCH-1725 Fix some Jest Web Console unittests

[GitBox]

ErnieAllen commented on a change in pull request #783:
URL: https://github.com/apache/qpid-dispatch/pull/783#discussion_r460829583



##
File path: console/react/test_data/qdrService.mock.js
##
@@ -60,17 +62,13 @@ export const mockService = ({ onSendMethod }) => {
 resolve();
   });
 },
-startUpdating: () => {
-  return new Promise(resolve => {
-resolve();
-  });
-},

Review comment:
   return resolve() is odd, but it should still work.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] ErnieAllen commented on a change in pull request #783: DISPATCH-1725 Fix some Jest Web Console unittests

[GitBox]

ErnieAllen commented on a change in pull request #783:
URL: https://github.com/apache/qpid-dispatch/pull/783#discussion_r460825284



##
File path: console/react/test_data/qdrService.mock.js
##
@@ -60,17 +62,13 @@ export const mockService = ({ onSendMethod }) => {
 resolve();
   });
 },
-startUpdating: () => {
-  return new Promise(resolve => {
-resolve();
-  });
-},

Review comment:
   It's probably better to remove the startUpdating on line 52 and leave 
this one here. By returning a promise and then calling resolve(), this will 
allow the code that calls startUpdating().then(...) to run the code contained 
in the then(...).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org