[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)
jiridanek commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r805143945 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/559393998 ``` 18: ==13747==ERROR: LeakSanitizer: detected memory leaks 18: 18: Direct leak of 13 byte(s) in 1 object(s) allocated from: 18: #0 0x7f0b79f4730f in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x6230f) 18: #1 0x6260c6 in qd_strdup /home/travis/build/apache/qpid-dispatch/include/qpid/dispatch/ctools.h:266 18: #2 0x62b336 in AMQP_rx_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:829 18: #3 0x4bbb76 in do_receive /home/travis/build/apache/qpid-dispatch/src/container.c:219 18: #4 0x4c05fd in qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:734 18: #5 0x6444cf in handle /home/travis/build/apache/qpid-dispatch/src/server.c:1116 18: #6 0x644697 in thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1141 18: #7 0x524da1 in _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 18: #8 0x7f0b798586b9 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9) 18: 18: - 18: Suppressions used: 18: count bytes template 18: 1 56 ^IoAdapter_init$ 18: 2128 sys_mutex 18: 561 859612 /libpython3.*.so 18: - 18: 18: SUMMARY: AddressSanitizer: 13 byte(s) leaked in 1 allocation(s). 18: 18: 18: -- 18: Ran 15 tests in 22.665s 18: 18: FAILED (errors=1) ``` Some trace also https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/559394005#L4544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)
jiridanek commented on a change in pull request #1515:
URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r805144183
##
File path: include/qpid/dispatch/amqp.h
##
@@ -19,6 +19,8 @@
* under the License.
Review comment:
This Arm64 fail. I am not sure if that is new, but I don't remember
seeing it before
https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/559394005#L4289
```
25: ==
25: ERROR: test_forbid_fallback
(system_tests_policy.PolicyTerminusCapabilities)
25: --
25: Traceback (most recent call last):
25: File
"/home/travis/build/apache/qpid-dispatch/tests/system_tests_policy.py", line
496, in test_forbid_fallback
25: br1 = BlockingConnection(self.router.addresses[0])
25: File
"/home/travis/build/apache/qpid-dispatch/qpid-proton/python/proton/_utils.py",
line 394, in __init__
25: self.wait(lambda: not (self.conn.state & Endpoint.REMOTE_UNINIT),
25: File
"/home/travis/build/apache/qpid-dispatch/qpid-proton/python/proton/_utils.py",
line 533, in wait
25: raise ConnectionException(
25: proton._exceptions.ConnectionException: Connection amqp://0.0.0.0:21926
disconnected: Condition('amqp:connection:framing-error', 'Expected SASL
protocol header: no protocol header found (connection aborted)')
25:
25: --
25: Ran 27 tests in 106.160s
25:
25: FAILED (errors=1)
25/76 Test #25: system_tests_policy ...***Failed
106.29 sec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)
jiridanek commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r805144335 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: This does not seem to be Jira'd yet, assuming it is not covered by https://issues.apache.org/jira/browse/DISPATCH-830. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)
jiridanek commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r807646524 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: Router seems to be exiting cleanly, the log says ``` 25: Router QDR.Policy output file: 25: 25: - 25: Suppressions used: 25: count bytes template 25: 1 56 ^IoAdapter_init$ 25: 2 46 ^load_server_config$ 25: 6192 ^qd_policy_c_counts_alloc$ 25: 591 901140 /libpython3.*.so 25: - ``` That to me suggest the exit code of the router was also checked. I think it could be a case of the stalls/freezes as in https://issues.apache.org/jira/browse/DISPATCH-2094, except there a timeout in the tests allows to fail a single test and carry on. So, quite possibly this is not new problem introduced by PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
