[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1512: DISPATCH-2327: clean up link routes at end of tests

[GitBox]

kgiusti commented on a change in pull request #1512:
URL: https://github.com/apache/qpid-dispatch/pull/1512#discussion_r804016751



##
File path: tests/system_tests_multi_tenancy.py
##
@@ -683,12 +704,8 @@ def __init__(self, first_host, second_host, first_address, 
second_address, dynam
 self.n_settled = 0
 
 def timeout(self):
-self.error = "Timeout Expired: n_sent=%d n_rcvd=%d n_settled=%d" % 
(self.n_sent, self.n_rcvd, self.n_settled)
-self.first_conn.close()
-self.second_conn.close()
-self.lookup_conn.close()
-if self.poll_timer:
-self.poll_timer.cancel()
+self.fail("Timeout Expired: n_sent=%d n_rcvd=%d n_settled=%d" %
+  (self.n_sent, self.n_rcvd, self.n_settled))

Review comment:
   Yeah - not the best choice of method name, but it's local to the 
LinkRouteTest class itself.  I've changed it from "fail" to "done" so it won't 
be as confusing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1512: DISPATCH-2327: clean up link routes at end of tests

[GitBox]

kgiusti commented on a change in pull request #1512:
URL: https://github.com/apache/qpid-dispatch/pull/1512#discussion_r804015741



##
File path: tests/system_tests_multi_tenancy.py
##
@@ -229,6 +231,17 @@ def 
test_16_two_router_anonymous_sender_tenant_on_both(self):
 test.run()
 self.assertIsNone(test.error)
 
+def _cleanup_link_routes(func):

Review comment:
   If I had unlimited time, enthusiasm and money... well.. perhaps that's a 
topic left discussed.
   Yeah in the end I'm punting on the decorator approach: too many issues with 
the python linters.
   The LinkRouteTest now waits for the routes to expire directly from the test 
itself.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org