[GitHub] [qpid-proton] astitcher commented on pull request #338: PROTON-2441: [cpp] Fix connection_options failover urls segfault
astitcher commented on pull request #338: URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-972459810 @DreamPearl also note that I subsequently modified your new test in commit 56520fbaa00ab1d64b9672b072f7b8b2e88c1916 to deduplicate the code and also to use more C++11 there now that we can. If you have questions about any of this just ask. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #338: PROTON-2441: [cpp] Fix connection_options failover urls segfault
astitcher commented on pull request #338: URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-972457403 I've merged this PR with a bug fix to an connection leak in the new reconnect test - this leak can be seen in the failing Travis CI job - I think it's unfortunate that the github actions didn't pick this up as well - are they running without valgrind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
