[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-27 Thread mgoulish 
Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/384
  
I yanked that exit(1).
I thought I needed that to detect failure in my python test, but that is 
not true.
Tests all still did the right thing, in 10 trials each (40 total) in the 
set:{should_fail, should_succeed} *  { DEBUG, RelWithDebInfo}



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread ted-ross 
Github user ted-ross commented on the issue:

https://github.com/apache/qpid-dispatch/pull/384
  
> > This patch clears up the too-many-links for sheaf error and improves my 
router network stability. FOr this I approve the patch.
> > But in tests before and after this patch my throughput went from 2600 
msg/S to 200-300 msg/S. The performance drop needs to be addressed as a 
separate issue.
> 
> I don't see any changes in this PR that should affect throughput 
performance.

I withdraw the above statement.  There appears to be a memory leak that is 
causing performance (and other) problems.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread ted-ross 
Github user ted-ross commented on the issue:

https://github.com/apache/qpid-dispatch/pull/384
  
> This patch clears up the too-many-links for sheaf error and improves my 
router network stability. FOr this I approve the patch.
> 
> But in tests before and after this patch my throughput went from 2600 
msg/S to 200-300 msg/S. The performance drop needs to be addressed as a 
separate issue.

I don't see any changes in this PR that should affect throughput 
performance.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread ChugR 
Github user ChugR commented on the issue:

https://github.com/apache/qpid-dispatch/pull/384
  
This patch clears up the too-many-links for sheaf error and improves my 
router network stability. FOr this I approve the patch.

But in tests before and after this patch my throughput went from 2600 msg/S 
to 200-300 msg/S. The performance drop needs to be addressed as a separate 
issue.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/qpid-dispatch/pull/384
  
# 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/384?src=pr&el=h1) 
Report
> Merging 
[#384](https://codecov.io/gh/apache/qpid-dispatch/pull/384?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/fa03ea4008524ca7eb5ba4c6409ec0328eca2e87?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `75%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/384/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/384?src=pr&el=tree)

```diff
@@Coverage Diff @@
##   master #384  +/-   ##
==
- Coverage84.8%   84.79%   -0.01% 
==
  Files  73   73  
  Lines   1646216467   +5 
==
+ Hits1396013964   +4 
- Misses   2502 2503   +1
```


| [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/384?src=pr&el=tree) | 
Coverage Δ | |
|---|---|---|
| 
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/384/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
 | `92.18% <100%> (-0.23%)` | :arrow_down: |
| 
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/384/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
 | `93.08% <50%> (-0.21%)` | :arrow_down: |
| 
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/384/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
 | `63.21% <0%> (-0.58%)` | :arrow_down: |
| 
[src/router\_core/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/384/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGVzdF9ob29rcy5j)
 | `88.06% <0%> (+1.7%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/384?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/384?src=pr&el=footer).
 Last update 
[fa03ea4...f25b806](https://codecov.io/gh/apache/qpid-dispatch/pull/384?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org