[GitHub] qpid-dispatch pull request #326: Logging
Github user alanconway closed the pull request at: https://github.com/apache/qpid-dispatch/pull/326 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #326: Logging
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/326#discussion_r198583346
--- Diff: src/server.c ---
@@ -651,8 +651,9 @@ static void on_connection_bound(qd_server_t *server,
pn_event_t *e) {
pn_sasl_set_allow_insecure_mechs(sasl,
config->allowInsecureAuthentication);
sys_mutex_unlock(ctx->server->lock);
-qd_log(ctx->server->log_source, QD_LOG_INFO, "Accepted connection
to %s from %s",
- name, ctx->rhost_port);
+qd_log(ctx->server->log_source, QD_LOG_INFO,
--- End diff --
There appear to be more arguments than format directives in this call.
Why did you remove the information about the remote host?
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #326: Logging
GitHub user alanconway opened a pull request: https://github.com/apache/qpid-dispatch/pull/326 Logging Some minor changes to dispatch logging based on experience debugging the HTTP Envoy bridge. See the commit comments for explanation. One additional question: I was confused by the new messageLoggingComponents config, when I set MESSAGE enable trace+ I saw nothing at all, which was surprising. Perhaps the default should be "all" so that enabling MESSAGE trace does what folks expect and they can turn the logging down per connector/listener if they wish. Since trace logging will be off in production (I hope!) this won't have any effect except on users that are deliberately debugging AND have turned on trace logging for at least the MESSAGE module, so are expecting a lot of log data. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alanconway/dispatch logging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #326 commit c2be6c7ec46567675a036c7c77ec840d3c2a4982 Author: Alan Conway Date: 2018-06-20T17:27:23Z NO-JIRA: Adjust log levels. - upgrade connection failure INFO messages to WARNING - downgrade incref/decref messages to TRACE Personally I think the incref/decref messages should not be in user-facing logs at all, but if they must be they should be TRACE as they occur at a per-delivery (i.e. per-message) volume. commit d02442ec6422bbdb2cb505345eaa4afa2691068e Author: Alan Conway Date: 2018-06-20T17:52:09Z NO-JIRA: Removed redundant "accepted" log message, added missing connection_id commit d92719aad8f3be6ace7fb10dbadb9dcd4f1776b7 Author: Alan Conway Date: 2018-06-21T13:19:23Z NO-JIRA: symmetric logging for incoming/outgoing establish/close connection Incoming connection establishment was being logged at info. Added info logs for outgoing connection establishment and any connection close. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
