[GitHub] qpid-dispatch pull request #376: DISPATCH-1081 - Update doc for multicast de...
Github user bhardesty closed the pull request at: https://github.com/apache/qpid-dispatch/pull/376 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #376: DISPATCH-1081 - Update doc for multicast de...
Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/376#discussion_r217501003 --- Diff: docs/books/user-guide/theory_of_operation.adoc --- @@ -260,26 +260,25 @@ Anycast distribution delivers each message to one consumer whereas multicast distribution delivers each message to all consumers. Anycast delivery is reliable when the message deliveries are -unsettled. There is a reliability contract that the router network +unsettled. There is a reliability contract that the router network abides by when delivering unsettled messages to anycast addresses. For every such delivery sent by a producer, the router network guarantees that one of the following outcomes will occur: -* The delivery shall be settled with ACCEPTED or REJECTED disposition - where the disposition is supplied by the consumer. -* The delivery shall be settled with RELEASED disposition, meaning - that the message was not delivered to any consumer. -* The delivery shall be settled with MODIFIED disposition, meaning - that the message may have been delivered to a consumer but should be - considered in-doubt and re-sent. -* The connection to the producer shall be dropped, signifying that all - unsettled deliveries should now be considered in-doubt by the - producer and later re-sent. - -Multicast delivery is not reliable. If a producer sends an unsettled -delivery, the ingress router shall settle the delivery with ACCEPTED -disposition regardless of whether the message was delivered to any -consumers. +* The delivery shall be settled with ACCEPTED or REJECTED disposition where the disposition is supplied by the consumer. + +* The delivery shall be settled with RELEASED disposition, meaning that the message was not delivered to any consumer. + +* The delivery shall be settled with MODIFIED disposition, meaning that the message may have been delivered to a consumer but should be considered in-doubt and re-sent. + +* The connection to the producer shall be dropped, signifying that all unsettled deliveries should now be considered in-doubt by the producer and later re-sent. + +Multicast delivery is not reliable. If a producer sends an unsettled +delivery, one of the following outcomes will occur: + +* If the address has no consumers, the router sends back a disposition of RELEASED. + +* If the address has one or more consumers, the router sends back a disposition of SETTLED. --- End diff -- I think this change loses the idea that the delivery may be ACCEPTED and settled even though it was not delivered to any consumers. Perhaps a more general statement should be used: If a producer sends an unsettled delivery, the disposition may be ACCEPTED or RELEASED. If ACCEPTED, there is no guarantee that the message was delivered to any consumer. If RELEASED, the messages was definitely not delivered to any consumer. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #376: DISPATCH-1081 - Update doc for multicast de...
Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/376#discussion_r217501588 --- Diff: docs/books/user-guide/theory_of_operation.adoc --- @@ -260,26 +260,25 @@ Anycast distribution delivers each message to one consumer whereas multicast distribution delivers each message to all consumers. Anycast delivery is reliable when the message deliveries are -unsettled. There is a reliability contract that the router network +unsettled. There is a reliability contract that the router network abides by when delivering unsettled messages to anycast addresses. For every such delivery sent by a producer, the router network guarantees that one of the following outcomes will occur: -* The delivery shall be settled with ACCEPTED or REJECTED disposition - where the disposition is supplied by the consumer. -* The delivery shall be settled with RELEASED disposition, meaning - that the message was not delivered to any consumer. -* The delivery shall be settled with MODIFIED disposition, meaning - that the message may have been delivered to a consumer but should be - considered in-doubt and re-sent. -* The connection to the producer shall be dropped, signifying that all - unsettled deliveries should now be considered in-doubt by the - producer and later re-sent. - -Multicast delivery is not reliable. If a producer sends an unsettled -delivery, the ingress router shall settle the delivery with ACCEPTED -disposition regardless of whether the message was delivered to any -consumers. +* The delivery shall be settled with ACCEPTED or REJECTED disposition where the disposition is supplied by the consumer. + +* The delivery shall be settled with RELEASED disposition, meaning that the message was not delivered to any consumer. + +* The delivery shall be settled with MODIFIED disposition, meaning that the message may have been delivered to a consumer but should be considered in-doubt and re-sent. + +* The connection to the producer shall be dropped, signifying that all unsettled deliveries should now be considered in-doubt by the producer and later re-sent. + +Multicast delivery is not reliable. If a producer sends an unsettled +delivery, one of the following outcomes will occur: + +* If the address has no consumers, the router sends back a disposition of RELEASED. + +* If the address has one or more consumers, the router sends back a disposition of SETTLED. --- End diff -- SETTLED is not a disposition. A delivery may be settled or unsettled, regardless of disposition. The possible dispositions for a delivery are ACCEPTED, REJECTED, RELEASED, and MODIFIED. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #376: DISPATCH-1081 - Update doc for multicast de...
GitHub user bhardesty opened a pull request: https://github.com/apache/qpid-dispatch/pull/376 DISPATCH-1081 - Update doc for multicast delivery settlement You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhardesty/qpid-dispatch dispatch-1081 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #376 commit 5d98aa04b46a2bf35ad51abb9273b1d615cd9d6f Author: Ben Hardesty Date: 2018-09-13T15:12:14Z Update doc for multicast delivery settlement --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
