[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...

2018-11-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/415


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...

2018-11-09 Thread ErnieAllen 
Github user ErnieAllen commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/415#discussion_r232223312
  
--- Diff: src/router_core/router_core_private.h ---
@@ -321,7 +321,8 @@ ALLOC_DECLARE(qdr_router_ref_t);
 DEQ_DECLARE(qdr_router_ref_t, qdr_router_ref_list_t);
 
 typedef enum {
-QDR_DELIVERY_NOWHERE = 0,
+QDR_DELIVERY_UNINITIALIZED = 0,
+QDR_DELIVERY_NOWHERE,
--- End diff --

New commit just uses QDR_DELIVERY_NOWHERE as the test in 
transfer.c::qdr_deliver_continue_CT to reject the delivery.



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...

2018-11-08 Thread ted-ross 
Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/415#discussion_r232058603
  
--- Diff: src/router_core/router_core_private.h ---
@@ -321,7 +321,8 @@ ALLOC_DECLARE(qdr_router_ref_t);
 DEQ_DECLARE(qdr_router_ref_t, qdr_router_ref_list_t);
 
 typedef enum {
-QDR_DELIVERY_NOWHERE = 0,
+QDR_DELIVERY_UNINITIALIZED = 0,
+QDR_DELIVERY_NOWHERE,
--- End diff --

I claim that QDR_DELIVERY_NOWHERE is the proper default value for this 
type.  This type is used to indicate in which list a particular delivery is 
contained.  If it has never been inserted into a list, it should indicate 
NOWHERE.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...

2018-11-08 Thread ErnieAllen 
GitHub user ErnieAllen opened a pull request:

https://github.com/apache/qpid-dispatch/pull/415

DISPATCH-1176 Prevent uninitialized delivery from crashing router

This prevents the crash but... I'm concerned about router inter-operability 
between different versions of the router. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-1176

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #415


commit 51a02e6a5de6907c14df24db7cd51475e45f2ea6
Author: Ernest Allen 
Date:   2018-11-08T12:40:53Z

DISPATCH-1176 Prevent uninitialized delivery from crashing router




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org