[GitHub] qpid-jms issue #8: QPIDJMS-298 Add coverage report uploading to codecov.io i...
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-jms/pull/8 @ctron thanks, I haven't noticed that problem. New version of jacoco plugin has goal `jacoco:report-aggregate`, which should aggregate coverage across all modules. Using it * breaks the cyclometric complexity column in the codecov.io report, for some reason * causes jacoco to find more partially-covered files in package `qpid-jms-client/src/main/java/org/apache/qpid/jms/selector`, so the coverage ends up going down, not up, as I had expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-jms issue #8: QPIDJMS-298 Add coverage report uploading to codecov.io i...
Github user ctron commented on the issue: https://github.com/apache/qpid-jms/pull/8 It indeed works fine. There is one caveat when converting Jacoco exec files to XML. Only classes of the local module will be reported in the XML files. So when you have a module A which gets tested by module B, then classes from module A will be missing in the XML report of module B, although they are in the exec file of module B. However there is a maven plugin for fixing that: https://ctron.github.io/jacoco-extras/xml-mojo.html ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-jms issue #8: QPIDJMS-298 Add coverage report uploading to codecov.io i...
Github user codecov-io commented on the issue: https://github.com/apache/qpid-jms/pull/8 # [Codecov](https://codecov.io/gh/apache/qpid-jms/pull/8?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@ef7241e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-jms/pull/8?src=pr&el=tree) ```diff @@ Coverage Diff@@ ## master #8 +/- ## Coverage ? 83.4% Complexity?4173 Files ? 204 Lines ? 13208 Branches ?1738 Hits ? 11016 Misses?1643 Partials ? 549 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-jms/pull/8?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-jms/pull/8?src=pr&el=footer). Last update [ef7241e...031420f](https://codecov.io/gh/apache/qpid-jms/pull/8?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
