[GitHub] qpid-proton issue #132: PROTON-1728: WIP: Reorganize the source tree and rem...

2018-01-12 Thread astitcher 
Github user astitcher commented on the issue:

https://github.com/apache/qpid-proton/pull/132
  
Can I suggest breaking this down into 3 separate changes (PRs branches 
etc.):
* Removal of deprecated bindings
* Removal of obsolete doc
* Moving the remainder to new locations and fixing up build

I think it'll be easier to see what's going on in the important part (the 
third) if there were fewer individual commits to look at. This would be easier 
I think if you just remove all the stuff from the tree.

In any case the removals are much easier to review/test individually.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #132: PROTON-1728: WIP: Reorganize the source tree and rem...

2018-01-11 Thread ssorj 
Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/132
  
One more change I'd like to consider making is moving the language-specific 
examples with their binding code.  That's consistent with how we currently 
handle docs, and it will make the cmake logic a bit more natural.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #132: PROTON-1728: WIP: Reorganize the source tree and rem...

2018-01-11 Thread ChugR 
Github user ChugR commented on the issue:

https://github.com/apache/qpid-proton/pull/132
  
* This seems like a great improvement overall. It's easier to find stuff 
without needing the folklore to locate it.
* The presentation of the source tree gives the project a mature look and 
feel.
* Compiled on windows VS2012 x64 and ran tests OK.

A few observations:
* Why is there a directory src/extra? This seems odd after such a massive 
cleanup.
* As a downstream consumer of the binary artifacts the minor reorganization 
is acceptable.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #132: PROTON-1728: WIP: Reorganize the source tree and rem...

2017-12-21 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/qpid-proton/pull/132
  
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr&el=h1) 
Report
> Merging 
[#132](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-proton/commit/b462433e375258167caea81e617f437ce512b12f?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-proton/pull/132/graphs/tree.svg?src=pr&token=UKKzV9XnFF&width=650&height=150)](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr&el=tree)

```diff
@@Coverage Diff@@
##   master#132  +/-   ##
=
- Coverage   83.91%   83.9%   -0.01% 
=
  Files 232 232  
  Lines   30765   30765  
=
- Hits25817   25814   -3 
- Misses   49484951   +3
```


| [Impacted 
Files](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr&el=tree) | 
Coverage Δ | |
|---|---|---|
| 
[bindings/cpp/include/proton/codec/decoder.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL2RlY29kZXIuaHBw)
 | `100% <ø> (ø)` | |
| 
[bindings/cpp/src/decimal.cpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvY3BwL3NyYy9kZWNpbWFsLmNwcA==)
 | `100% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/codec/list.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL2xpc3QuaHBw)
 | `100% <ø> (ø)` | |
| 
[bindings/python/proton/reactor.py](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvcHl0aG9uL3Byb3Rvbi9yZWFjdG9yLnB5)
 | `70.71% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/endpoint.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL2VuZHBvaW50LmhwcA==)
 | `57.14% <ø> (ø)` | |
| 
[bindings/cpp/src/types\_internal.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvY3BwL3NyYy90eXBlc19pbnRlcm5hbC5ocHA=)
 | `100% <ø> (ø)` | |
| 
[bindings/python/proton/handlers.py](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvcHl0aG9uL3Byb3Rvbi9oYW5kbGVycy5weQ==)
 | `58.12% <ø> (ø)` | |
| 
[bindings/cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvY3BwL3NyYy9zZW5kZXIuY3Bw)
 | `61.11% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/transfer.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL3RyYW5zZmVyLmhwcA==)
 | `100% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/ssl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL3NzbC5ocHA=)
 | `100% <ø> (ø)` | |
| ... and [252 
more](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr&el=tree-more)
 | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr&el=footer). 
Last update 
[b462433...e397ef2](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org