[GitHub] qpid-proton pull request #137: [cpp] Fix update method missing 'name' variab...

2018-03-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/137


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-proton pull request #137: [cpp] Fix update method missing 'name' variab...

2018-03-01 Thread p32blo
GitHub user p32blo opened a pull request:

https://github.com/apache/qpid-proton/pull/137

[cpp] Fix update method missing 'name' variable

The `name` property in the sender and receiver is not being updated 
correctly when passed to the `open_sender` and `open_receiver`.

Here is a simple example demonstrating the problem:
```cpp
#include 
#include 
#include 

#include 

int main()
{
proton::container c;

proton::sender_options so;
proton::receiver_options ro;

so.name("qpid");
ro.name("qpid");

proton::sender sender = c.open_sender("", so);
proton::receiver receiver = c.open_receiver("", ro);

std::cout << sender.name() << std::endl;
std::cout << receiver.name() << std::endl;
}
```
The output is currently a random uuid, but it should be "qpid" in both 
cases.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/p32blo/qpid-proton master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #137


commit 69a9f91627ccc997337cab5f191f2d1c80ca10f3
Author: André Oliveira 
Date:   2018-03-01T10:15:30Z

[cpp] Fix update method missing 'name' variable




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org