[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[
https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627930#comment-16627930
]
ASF subversion and git services commented on DISPATCH-1129:
---
Commit fa03ea4008524ca7eb5ba4c6409ec0328eca2e87 in qpid-dispatch's branch
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=fa03ea4 ]
DISPATCH-1129 - Moved call to forwarding multicast messages to end of forwarder
function. Also modified qd_message_check_LH to not validate the message if
bufferes have already been freed. This closes #383.
> Receiver crash due to data corruption on multicast streamed messages
>
>
> Key: DISPATCH-1129
> URL: https://issues.apache.org/jira/browse/DISPATCH-1129
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.3.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: blue.conf, collectd.conf, datafile.txt, green.conf,
> simple_recv.py, simple_send_datafile.py
>
>
> Create a 3 router network using the attached router config files. It forms a
> linear network
>
> Router -> Router B -> Router C
> Attach one receiver on Router B and another one on Router C. Send a 50k
> streaming message using a sender connected to Router A.
>
> One of the receivers will crash with the following error
>
> {noformat}
> Traceback (most recent call last):
> File "simple_recv.py", line 55, in
> Container(Recv(opts.address, opts.messages)).run()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 175, in run
> while self.process(): pass
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 201, in process
> self._check_errors()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 197, in _check_errors
> _compat.raise_(exc, value, tb)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py",
> line 133, in dispatch
> ev.dispatch(self.handler)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 254, in dispatch
> self.dispatch(h, type)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 251, in dispatch
> result = dispatch(handler, type.method, self)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 113, in dispatch
> return m(*args)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 178, in on_delivery
> event.message = recv_msg(dlv)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 107, in recv_msg
> msg.decode(delivery.link.recv(delivery.pending))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 398, in decode
> self._check(pn_message_decode(self._msg, data))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 94, in _check
> raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg
> proton._exceptions.MessageException: [-6]: data error: (null)
> [gmurthy@localhost examples]$
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[
https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627931#comment-16627931
]
ASF GitHub Bot commented on DISPATCH-1129:
--
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/383
> Receiver crash due to data corruption on multicast streamed messages
>
>
> Key: DISPATCH-1129
> URL: https://issues.apache.org/jira/browse/DISPATCH-1129
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.3.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: blue.conf, collectd.conf, datafile.txt, green.conf,
> simple_recv.py, simple_send_datafile.py
>
>
> Create a 3 router network using the attached router config files. It forms a
> linear network
>
> Router -> Router B -> Router C
> Attach one receiver on Router B and another one on Router C. Send a 50k
> streaming message using a sender connected to Router A.
>
> One of the receivers will crash with the following error
>
> {noformat}
> Traceback (most recent call last):
> File "simple_recv.py", line 55, in
> Container(Recv(opts.address, opts.messages)).run()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 175, in run
> while self.process(): pass
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 201, in process
> self._check_errors()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 197, in _check_errors
> _compat.raise_(exc, value, tb)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py",
> line 133, in dispatch
> ev.dispatch(self.handler)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 254, in dispatch
> self.dispatch(h, type)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 251, in dispatch
> result = dispatch(handler, type.method, self)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 113, in dispatch
> return m(*args)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 178, in on_delivery
> event.message = recv_msg(dlv)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 107, in recv_msg
> msg.decode(delivery.link.recv(delivery.pending))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 398, in decode
> self._check(pn_message_decode(self._msg, data))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 94, in _check
> raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg
> proton._exceptions.MessageException: [-6]: data error: (null)
> [gmurthy@localhost examples]$
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[
https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627886#comment-16627886
]
ASF GitHub Bot commented on DISPATCH-1129:
--
Github user ChugR commented on the issue:
https://github.com/apache/qpid-dispatch/pull/383
+1 Ship It
Looks good and works. Failing tests could never get beyond a few hundred
messages. With this patch I'm past 100 million messages.
> Receiver crash due to data corruption on multicast streamed messages
>
>
> Key: DISPATCH-1129
> URL: https://issues.apache.org/jira/browse/DISPATCH-1129
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.3.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: blue.conf, collectd.conf, datafile.txt, green.conf,
> simple_recv.py, simple_send_datafile.py
>
>
> Create a 3 router network using the attached router config files. It forms a
> linear network
>
> Router -> Router B -> Router C
> Attach one receiver on Router B and another one on Router C. Send a 50k
> streaming message using a sender connected to Router A.
>
> One of the receivers will crash with the following error
>
> {noformat}
> Traceback (most recent call last):
> File "simple_recv.py", line 55, in
> Container(Recv(opts.address, opts.messages)).run()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 175, in run
> while self.process(): pass
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 201, in process
> self._check_errors()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 197, in _check_errors
> _compat.raise_(exc, value, tb)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py",
> line 133, in dispatch
> ev.dispatch(self.handler)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 254, in dispatch
> self.dispatch(h, type)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 251, in dispatch
> result = dispatch(handler, type.method, self)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 113, in dispatch
> return m(*args)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 178, in on_delivery
> event.message = recv_msg(dlv)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 107, in recv_msg
> msg.decode(delivery.link.recv(delivery.pending))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 398, in decode
> self._check(pn_message_decode(self._msg, data))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 94, in _check
> raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg
> proton._exceptions.MessageException: [-6]: data error: (null)
> [gmurthy@localhost examples]$
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[
https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627838#comment-16627838
]
ASF GitHub Bot commented on DISPATCH-1129:
--
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/383
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr=h1)
Report
> Merging
[#383](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/15c46db55bed4d5d7e88bd24fd1ccf255453e629?src=pr=desc)
will **increase** coverage by `0.02%`.
> The diff coverage is `96.96%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr=tree)
```diff
@@Coverage Diff @@
## master #383 +/- ##
==
+ Coverage 84.75% 84.77% +0.02%
==
Files 73 73
Lines 1643716463 +26
==
+ Hits1393113957 +26
Misses 2506 2506
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/383/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.9% <100%> (+0.24%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/383/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.75% <100%> (+0.13%)` | :arrow_up: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/383/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `88.1% <90%> (+0.1%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/383/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `63.21% <0%> (-0.58%)` | :arrow_down: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr=footer).
Last update
[15c46db...67a210c](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Receiver crash due to data corruption on multicast streamed messages
>
>
> Key: DISPATCH-1129
> URL: https://issues.apache.org/jira/browse/DISPATCH-1129
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.3.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: blue.conf, collectd.conf, datafile.txt, green.conf,
> simple_recv.py, simple_send_datafile.py
>
>
> Create a 3 router network using the attached router config files. It forms a
> linear network
>
> Router -> Router B -> Router C
> Attach one receiver on Router B and another one on Router C. Send a 50k
> streaming message using a sender connected to Router A.
>
> One of the receivers will crash with the following error
>
> {noformat}
> Traceback (most recent call last):
> File "simple_recv.py", line 55, in
> Container(Recv(opts.address, opts.messages)).run()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 175, in run
> while self.process(): pass
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 201, in process
> self._check_errors()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 197, in _check_errors
> _compat.raise_(exc, value, tb)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py",
> line 133, in dispatch
> ev.dispatch(self.handler)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 254, in dispatch
> self.dispatch(h, type)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 251, in dispatch
> result = dispatch(handler, type.method, self)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 113, in
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[
https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627828#comment-16627828
]
ASF GitHub Bot commented on DISPATCH-1129:
--
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/383
DISPATCH-1129 - Moved call to forwarding multicast messages to end of…
… forwarder function. Also modified qd_message_check_LH to not validate the
message if bufferes have already been freed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1129-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/383.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #383
commit 67a210c93d9097999158b06c5b61a8726a2bdd0d
Author: Ganesh Murthy
Date: 2018-09-24T17:06:47Z
DISPATCH-1129 - Moved call to forwarding multicast messages to end of
forwarder function. Also modified qd_message_check_LH to not validate the
message if bufferes have already been freed
> Receiver crash due to data corruption on multicast streamed messages
>
>
> Key: DISPATCH-1129
> URL: https://issues.apache.org/jira/browse/DISPATCH-1129
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.3.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: blue.conf, collectd.conf, datafile.txt, green.conf,
> simple_recv.py, simple_send_datafile.py
>
>
> Create a 3 router network using the attached router config files. It forms a
> linear network
>
> Router -> Router B -> Router C
> Attach one receiver on Router B and another one on Router C. Send a 50k
> streaming message using a sender connected to Router A.
>
> One of the receivers will crash with the following error
>
> {noformat}
> Traceback (most recent call last):
> File "simple_recv.py", line 55, in
> Container(Recv(opts.address, opts.messages)).run()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 175, in run
> while self.process(): pass
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 201, in process
> self._check_errors()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 197, in _check_errors
> _compat.raise_(exc, value, tb)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py",
> line 133, in dispatch
> ev.dispatch(self.handler)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 254, in dispatch
> self.dispatch(h, type)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 251, in dispatch
> result = dispatch(handler, type.method, self)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 113, in dispatch
> return m(*args)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 178, in on_delivery
> event.message = recv_msg(dlv)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 107, in recv_msg
> msg.decode(delivery.link.recv(delivery.pending))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 398, in decode
> self._check(pn_message_decode(self._msg, data))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 94, in _check
> raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg
> proton._exceptions.MessageException: [-6]: data error: (null)
> [gmurthy@localhost examples]$
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[
https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627379#comment-16627379
]
ASF GitHub Bot commented on DISPATCH-1129:
--
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/382
> Receiver crash due to data corruption on multicast streamed messages
>
>
> Key: DISPATCH-1129
> URL: https://issues.apache.org/jira/browse/DISPATCH-1129
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.3.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: blue.conf, collectd.conf, datafile.txt, green.conf,
> simple_recv.py, simple_send_datafile.py
>
>
> Create a 3 router network using the attached router config files. It forms a
> linear network
>
> Router -> Router B -> Router C
> Attach one receiver on Router B and another one on Router C. Send a 50k
> streaming message using a sender connected to Router A.
>
> One of the receivers will crash with the following error
>
> {noformat}
> Traceback (most recent call last):
> File "simple_recv.py", line 55, in
> Container(Recv(opts.address, opts.messages)).run()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 175, in run
> while self.process(): pass
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 201, in process
> self._check_errors()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 197, in _check_errors
> _compat.raise_(exc, value, tb)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py",
> line 133, in dispatch
> ev.dispatch(self.handler)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 254, in dispatch
> self.dispatch(h, type)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 251, in dispatch
> result = dispatch(handler, type.method, self)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 113, in dispatch
> return m(*args)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 178, in on_delivery
> event.message = recv_msg(dlv)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 107, in recv_msg
> msg.decode(delivery.link.recv(delivery.pending))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 398, in decode
> self._check(pn_message_decode(self._msg, data))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 94, in _check
> raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg
> proton._exceptions.MessageException: [-6]: data error: (null)
> [gmurthy@localhost examples]$
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[
https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626421#comment-16626421
]
ASF GitHub Bot commented on DISPATCH-1129:
--
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/382#discussion_r219978301
--- Diff: src/router_core/router_core_private.h ---
@@ -440,6 +440,17 @@ struct qdr_link_ref_t {
ALLOC_DECLARE(qdr_link_ref_t);
DEQ_DECLARE(qdr_link_ref_t, qdr_link_ref_list_t);
+
+typedef struct qdr_forward_deliver_info_t {
--- End diff --
This is only used in forwarder.c. Why not move all of this into that file?
> Receiver crash due to data corruption on multicast streamed messages
>
>
> Key: DISPATCH-1129
> URL: https://issues.apache.org/jira/browse/DISPATCH-1129
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.3.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: blue.conf, collectd.conf, datafile.txt, green.conf,
> simple_recv.py, simple_send_datafile.py
>
>
> Create a 3 router network using the attached router config files. It forms a
> linear network
>
> Router -> Router B -> Router C
> Attach one receiver on Router B and another one on Router C. Send a 50k
> streaming message using a sender connected to Router A.
>
> One of the receivers will crash with the following error
>
> {noformat}
> Traceback (most recent call last):
> File "simple_recv.py", line 55, in
> Container(Recv(opts.address, opts.messages)).run()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 175, in run
> while self.process(): pass
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 201, in process
> self._check_errors()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 197, in _check_errors
> _compat.raise_(exc, value, tb)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py",
> line 133, in dispatch
> ev.dispatch(self.handler)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 254, in dispatch
> self.dispatch(h, type)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 251, in dispatch
> result = dispatch(handler, type.method, self)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 113, in dispatch
> return m(*args)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 178, in on_delivery
> event.message = recv_msg(dlv)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 107, in recv_msg
> msg.decode(delivery.link.recv(delivery.pending))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 398, in decode
> self._check(pn_message_decode(self._msg, data))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 94, in _check
> raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg
> proton._exceptions.MessageException: [-6]: data error: (null)
> [gmurthy@localhost examples]$
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[
https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626302#comment-16626302
]
ASF GitHub Bot commented on DISPATCH-1129:
--
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/382
DISPATCH-1129 - Moved call to forwarding multicast messages to end of…
… forwarder function. Also modified qd_message_check_LH to not validate the
message if bufferes have already been freed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch AARON-PROBLEM
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #382
commit 00edc49fec82aaabcf4d3bfc65e24ed0b73d1d62
Author: Ganesh Murthy
Date: 2018-09-24T17:06:47Z
DISPATCH-1129 - Moved call to forwarding multicast messages to end of
forwarder function. Also modified qd_message_check_LH to not validate the
message if bufferes have already been freed
> Receiver crash due to data corruption on multicast streamed messages
>
>
> Key: DISPATCH-1129
> URL: https://issues.apache.org/jira/browse/DISPATCH-1129
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.3.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: blue.conf, collectd.conf, datafile.txt, green.conf,
> simple_recv.py, simple_send_datafile.py
>
>
> Create a 3 router network using the attached router config files. It forms a
> linear network
>
> Router -> Router B -> Router C
> Attach one receiver on Router B and another one on Router C. Send a 50k
> streaming message using a sender connected to Router A.
>
> One of the receivers will crash with the following error
>
> {noformat}
> Traceback (most recent call last):
> File "simple_recv.py", line 55, in
> Container(Recv(opts.address, opts.messages)).run()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 175, in run
> while self.process(): pass
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 201, in process
> self._check_errors()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 197, in _check_errors
> _compat.raise_(exc, value, tb)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py",
> line 133, in dispatch
> ev.dispatch(self.handler)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 254, in dispatch
> self.dispatch(h, type)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 251, in dispatch
> result = dispatch(handler, type.method, self)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 113, in dispatch
> return m(*args)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 178, in on_delivery
> event.message = recv_msg(dlv)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 107, in recv_msg
> msg.decode(delivery.link.recv(delivery.pending))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 398, in decode
> self._check(pn_message_decode(self._msg, data))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 94, in _check
> raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg
> proton._exceptions.MessageException: [-6]: data error: (null)
> [gmurthy@localhost examples]$
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1129) Receiver crash due to data corruption on multicast streamed messages
[
https://issues.apache.org/jira/browse/DISPATCH-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626291#comment-16626291
]
ASF subversion and git services commented on DISPATCH-1129:
---
Commit 00edc49fec82aaabcf4d3bfc65e24ed0b73d1d62 in qpid-dispatch's branch
refs/heads/AARON-PROBLEM from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=00edc49 ]
DISPATCH-1129 - Moved call to forwarding multicast messages to end of forwarder
function. Also modified qd_message_check_LH to not validate the message if
bufferes have already been freed
> Receiver crash due to data corruption on multicast streamed messages
>
>
> Key: DISPATCH-1129
> URL: https://issues.apache.org/jira/browse/DISPATCH-1129
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Affects Versions: 1.3.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: blue.conf, collectd.conf, datafile.txt, green.conf,
> simple_recv.py, simple_send_datafile.py
>
>
> Create a 3 router network using the attached router config files. It forms a
> linear network
>
> Router -> Router B -> Router C
> Attach one receiver on Router B and another one on Router C. Send a 50k
> streaming message using a sender connected to Router A.
>
> One of the receivers will crash with the following error
>
> {noformat}
> Traceback (most recent call last):
> File "simple_recv.py", line 55, in
> Container(Recv(opts.address, opts.messages)).run()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 175, in run
> while self.process(): pass
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 201, in process
> self._check_errors()
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/reactor.py",
> line 197, in _check_errors
> _compat.raise_(exc, value, tb)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor_impl.py",
> line 133, in dispatch
> ev.dispatch(self.handler)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 254, in dispatch
> self.dispatch(h, type)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 251, in dispatch
> result = dispatch(handler, type.method, self)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py",
> line 113, in dispatch
> return m(*args)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 178, in on_delivery
> event.message = recv_msg(dlv)
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/handlers.py",
> line 107, in recv_msg
> msg.decode(delivery.link.recv(delivery.pending))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 398, in decode
> self._check(pn_message_decode(self._msg, data))
> File
> "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_message.py",
> line 94, in _check
> raise exc("[%s]: %s" % (err, pn_error_text(pn_message_error(self._msg
> proton._exceptions.MessageException: [-6]: data error: (null)
> [gmurthy@localhost examples]$
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
