[jira] [Commented] (DISPATCH-1131) validate link route prefix field
[ https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643935#comment-16643935 ] ASF GitHub Bot commented on DISPATCH-1131: -- Github user kgiusti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/388 > validate link route prefix field > > > Key: DISPATCH-1131 > URL: https://issues.apache.org/jira/browse/DISPATCH-1131 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > Verify the link route prefix field contains a valid prefix -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1131) validate link route prefix field
[ https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641861#comment-16641861 ] ASF GitHub Bot commented on DISPATCH-1131: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/388 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/388?src=pr&el=h1) Report > Merging [#388](https://codecov.io/gh/apache/qpid-dispatch/pull/388?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/3f92be9015615d119cd4707e0ff63a2cf1a73a7c?src=pr&el=desc) will **increase** coverage by `0.11%`. > The diff coverage is `92.98%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/388?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #388 +/- ## == + Coverage 84.93% 85.05% +0.11% == Files 73 73 Lines 1649916523 +24 == + Hits1401414054 +40 + Misses 2485 2469 -16 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/388?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_config\_link\_route.c](https://codecov.io/gh/apache/qpid-dispatch/pull/388/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19saW5rX3JvdXRlLmM=) | `86.74% <100%> (+7.49%)` | :arrow_up: | | [src/router\_core/route\_control.c](https://codecov.io/gh/apache/qpid-dispatch/pull/388/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX2NvbnRyb2wuYw==) | `96.03% <100%> (-0.14%)` | :arrow_down: | | [src/router\_core/agent\_config\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/388/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19hZGRyZXNzLmM=) | `78.82% <91.48%> (+2.5%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/388/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `92.05% <0%> (-0.34%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/388/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.52% <0%> (-0.16%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/388/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `86.1% <0%> (+0.27%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/388?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/388?src=pr&el=footer). Last update [3f92be9...31bb414](https://codecov.io/gh/apache/qpid-dispatch/pull/388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > validate link route prefix field > > > Key: DISPATCH-1131 > URL: https://issues.apache.org/jira/browse/DISPATCH-1131 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > Verify the link route prefix field contains a valid prefix -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1131) validate link route prefix field
[ https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641826#comment-16641826 ] ASF GitHub Bot commented on DISPATCH-1131: -- GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-dispatch/pull/388 DISPATCH-1131: add better validation of address patterns and prefixes This moves the address pattern/prefix validation to a common function that can be share by both link routes add configured addresses. This closes #385 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kgiusti/dispatch DISPATCH-1131 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/388.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #388 commit c38dde95d5f32a743f41a8a8c728a8c554bf17ff Author: Kenneth Giusti Date: 2018-09-27T17:22:51Z DISPATCH-1131: add better validation of address patterns and prefixes This moves the address pattern/prefix validation to a common function that can be share by both link routes add configured addresses. This closes #385 > validate link route prefix field > > > Key: DISPATCH-1131 > URL: https://issues.apache.org/jira/browse/DISPATCH-1131 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > Verify the link route prefix field contains a valid prefix -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1131) validate link route prefix field
[ https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641823#comment-16641823 ] ASF GitHub Bot commented on DISPATCH-1131: -- Github user kgiusti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/387 > validate link route prefix field > > > Key: DISPATCH-1131 > URL: https://issues.apache.org/jira/browse/DISPATCH-1131 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > Verify the link route prefix field contains a valid prefix -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1131) validate link route prefix field
[ https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638742#comment-16638742 ] ASF GitHub Bot commented on DISPATCH-1131: -- GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-dispatch/pull/387 DISPATCH-1131: add better validation of address patterns and prefixes This moves the address pattern/prefix validation to a common function that can be share by both link routes add configured addresses. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kgiusti/dispatch DISPATCH-1131 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/387.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #387 commit a99de9a3cb5ad42d34f61b22be5e9e0aa25debc0 Author: Kenneth Giusti Date: 2018-09-27T17:22:51Z DISPATCH-1131: add better validation of address patterns and prefixes This moves the address pattern/prefix validation to a common function that can be share by both link routes add configured addresses. > validate link route prefix field > > > Key: DISPATCH-1131 > URL: https://issues.apache.org/jira/browse/DISPATCH-1131 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > Verify the link route prefix field contains a valid prefix -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1131) validate link route prefix field
[ https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638736#comment-16638736 ] ASF GitHub Bot commented on DISPATCH-1131: -- Github user kgiusti commented on the issue: https://github.com/apache/qpid-dispatch/pull/385 Oops left in an extraneous check.. > validate link route prefix field > > > Key: DISPATCH-1131 > URL: https://issues.apache.org/jira/browse/DISPATCH-1131 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > Verify the link route prefix field contains a valid prefix -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1131) validate link route prefix field
[ https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638737#comment-16638737 ] ASF GitHub Bot commented on DISPATCH-1131: -- Github user kgiusti closed the pull request at: https://github.com/apache/qpid-dispatch/pull/385 > validate link route prefix field > > > Key: DISPATCH-1131 > URL: https://issues.apache.org/jira/browse/DISPATCH-1131 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > Verify the link route prefix field contains a valid prefix -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1131) validate link route prefix field
[ https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630965#comment-16630965 ] ASF GitHub Bot commented on DISPATCH-1131: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/385 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=h1) Report > Merging [#385](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/e3e201652ca167e9a6cd3d12ff3106165f3bb89a?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `93.1%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #385 +/- ## == + Coverage84.8% 84.95% +0.14% == Files 73 73 Lines 1644816472 +24 == + Hits1394913993 +44 + Misses 2499 2479 -20 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_config\_link\_route.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19saW5rX3JvdXRlLmM=) | `86.95% <100%> (+7.36%)` | :arrow_up: | | [src/router\_core/route\_control.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX2NvbnRyb2wuYw==) | `96.1% <100%> (-0.14%)` | :arrow_down: | | [src/router\_core/agent\_config\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19hZGRyZXNzLmM=) | `78.82% <91.48%> (+2.5%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `85.83% <0%> (-0.28%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.75% <0%> (-0.14%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.74% <0%> (+0.19%)` | :arrow_up: | | [src/router\_core/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGVzdF9ob29rcy5j) | `88.06% <0%> (+1.7%)` | :arrow_up: | | [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/385/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==) | `96.42% <0%> (+1.78%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=footer). Last update [e3e2016...d7b8e8a](https://codecov.io/gh/apache/qpid-dispatch/pull/385?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > validate link route prefix field > > > Key: DISPATCH-1131 > URL: https://issues.apache.org/jira/browse/DISPATCH-1131 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > Verify the link route prefix field contains a valid prefix -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1131) validate link route prefix field
[ https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630946#comment-16630946 ] ASF GitHub Bot commented on DISPATCH-1131: -- GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-dispatch/pull/385 DISPATCH-1131: add better validation of address patterns and prefixes This moves the address pattern/prefix validation to a common function that can be share by both link routes add configured addresses. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kgiusti/dispatch DISPATCH-1131 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/385.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #385 commit d7b8e8a3289fd4c83dd733bfaa843956b5a38bcf Author: Kenneth Giusti Date: 2018-09-27T17:22:51Z DISPATCH-1131: add better validation of address patterns and prefixes This moves the address pattern/prefix validation to a common function that can be share by both link routes add configured addresses. > validate link route prefix field > > > Key: DISPATCH-1131 > URL: https://issues.apache.org/jira/browse/DISPATCH-1131 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > Verify the link route prefix field contains a valid prefix -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
