[jira] [Commented] (DISPATCH-1137) Connection info contains stale pointer to container id
[ https://issues.apache.org/jira/browse/DISPATCH-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638326#comment-16638326 ] ASF GitHub Bot commented on DISPATCH-1137: -- Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/386 > Connection info contains stale pointer to container id > -- > > Key: DISPATCH-1137 > URL: https://issues.apache.org/jira/browse/DISPATCH-1137 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0, 2.0.0 > > > On connection close the memory pointed to by the container name pointer in > the connection info structure has been freed (as found by valgrind). Need to > keep a copy of the name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1137) Connection info contains stale pointer to container id
[ https://issues.apache.org/jira/browse/DISPATCH-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638324#comment-16638324 ] ASF subversion and git services commented on DISPATCH-1137: --- Commit 3b1d84c969dad91d66641a719bc4374728902b58 in qpid-dispatch's branch refs/heads/master from Kenneth Giusti [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=3b1d84c ] DISPATCH-1137: fix stale container name pointer in connection info This closes #386 > Connection info contains stale pointer to container id > -- > > Key: DISPATCH-1137 > URL: https://issues.apache.org/jira/browse/DISPATCH-1137 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0, 2.0.0 > > > On connection close the memory pointed to by the container name pointer in > the connection info structure has been freed (as found by valgrind). Need to > keep a copy of the name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1137) Connection info contains stale pointer to container id
[ https://issues.apache.org/jira/browse/DISPATCH-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637210#comment-16637210 ] ASF GitHub Bot commented on DISPATCH-1137: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/386 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/386?src=pr&el=h1) Report > Merging [#386](https://codecov.io/gh/apache/qpid-dispatch/pull/386?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/6689d5f1d6dc343ab0482befcf3286479aef2e04?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/386?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #386 +/- ## == - Coverage 84.82% 84.79% -0.04% == Files 73 73 Lines 1647516477 +2 == - Hits1397513971 -4 - Misses 2500 2506 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/386?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/386/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.08% <100%> (+0.01%)` | :arrow_up: | | [src/router\_core/modules/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/386/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvY29yZV90ZXN0X2hvb2tzLmM=) | `87.02% <0%> (-1.63%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/386/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.06% <0%> (-0.21%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/386/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.55% <0%> (-0.2%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/386/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.61% <0%> (-0.14%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/386/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `92.4% <0%> (+0.33%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/386?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/386?src=pr&el=footer). Last update [6689d5f...91f16e6](https://codecov.io/gh/apache/qpid-dispatch/pull/386?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Connection info contains stale pointer to container id > -- > > Key: DISPATCH-1137 > URL: https://issues.apache.org/jira/browse/DISPATCH-1137 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0, 2.0.0 > > > On connection close the memory pointed to by the container name pointer in > the connection info structure has been freed (as found by valgrind). Need to > keep a copy of the name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1137) Connection info contains stale pointer to container id
[ https://issues.apache.org/jira/browse/DISPATCH-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637197#comment-16637197 ] ASF GitHub Bot commented on DISPATCH-1137: -- GitHub user kgiusti opened a pull request: https://github.com/apache/qpid-dispatch/pull/386 DISPATCH-1137: fix stale container name pointer in connection info You can merge this pull request into a Git repository by running: $ git pull https://github.com/kgiusti/dispatch DISPATCH-1137 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/386.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #386 commit 91f16e6f4ee5ea65181e4ed2c22f2d4f50cdbf06 Author: Kenneth Giusti Date: 2018-10-03T15:22:13Z DISPATCH-1137: fix stale container name pointer in connection info > Connection info contains stale pointer to container id > -- > > Key: DISPATCH-1137 > URL: https://issues.apache.org/jira/browse/DISPATCH-1137 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0, 2.0.0 > > > On connection close the memory pointed to by the container name pointer in > the connection info structure has been freed (as found by valgrind). Need to > keep a copy of the name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
