[jira] [Commented] (DISPATCH-1139) support prioritized addresses
[ https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657086#comment-16657086 ] ASF subversion and git services commented on DISPATCH-1139: --- Commit 2519b1ecabf9d03b4ef3caf86813726341d9cb7c in qpid-dispatch's branch refs/heads/master from Kenneth Giusti [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=2519b1e ] DISPATCH-1139: minor test fix - xrange() removed in python3+ > support prioritized addresses > - > > Key: DISPATCH-1139 > URL: https://issues.apache.org/jira/browse/DISPATCH-1139 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node, Routing Engine, Tests >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > Support a new field in the address descriptor in router configuration files > that will assign a priority to the address. > Any message that does not have an intrinsic priority already assigned will > inherit the priority of the address to which it is sent. If no priority is > explicitly assigned to an address, then it will be assigned the default > priority. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1139) support prioritized addresses
[ https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655649#comment-16655649 ] ASF subversion and git services commented on DISPATCH-1139: --- Commit 57347bea6e143a58209dcf90865888fd1989b6c0 in qpid-dispatch's branch refs/heads/master from mgoulish [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=57347be ] DISPATCH-1139 : no need for priority field in query struct. > support prioritized addresses > - > > Key: DISPATCH-1139 > URL: https://issues.apache.org/jira/browse/DISPATCH-1139 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node, Routing Engine, Tests >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > Support a new field in the address descriptor in router configuration files > that will assign a priority to the address. > Any message that does not have an intrinsic priority already assigned will > inherit the priority of the address to which it is sent. If no priority is > explicitly assigned to an address, then it will be assigned the default > priority. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1139) support prioritized addresses
[ https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1664#comment-1664 ] ASF GitHub Bot commented on DISPATCH-1139: -- Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/392 > support prioritized addresses > - > > Key: DISPATCH-1139 > URL: https://issues.apache.org/jira/browse/DISPATCH-1139 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node, Routing Engine, Tests >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > Support a new field in the address descriptor in router configuration files > that will assign a priority to the address. > Any message that does not have an intrinsic priority already assigned will > inherit the priority of the address to which it is sent. If no priority is > explicitly assigned to an address, then it will be assigned the default > priority. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1139) support prioritized addresses
[ https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1661#comment-1661 ] ASF subversion and git services commented on DISPATCH-1139: --- Commit bb4f3121989cb4b91d4e364287868da1594f3acf in qpid-dispatch's branch refs/heads/master from Michael Goulish [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=bb4f312 ] DISPATCH-1139 : address priority support and test > support prioritized addresses > - > > Key: DISPATCH-1139 > URL: https://issues.apache.org/jira/browse/DISPATCH-1139 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node, Routing Engine, Tests >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > Support a new field in the address descriptor in router configuration files > that will assign a priority to the address. > Any message that does not have an intrinsic priority already assigned will > inherit the priority of the address to which it is sent. If no priority is > explicitly assigned to an address, then it will be assigned the default > priority. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1139) support prioritized addresses
[ https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655415#comment-16655415 ] ASF GitHub Bot commented on DISPATCH-1139: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/392 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr&el=h1) Report > Merging [#392](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/9c5666f6d1e36979d6d4b3e657c5c5246ffbf5df?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `85.71%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #392 +/- ## == + Coverage 85% 85.04% +0.04% == Files 76 76 Lines 1677016783 +13 == + Hits1425514273 +18 + Misses 2515 2510 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.25% <100%> (-0.05%)` | :arrow_down: | | [src/router\_core/route\_control.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX2NvbnRyb2wuYw==) | `95.9% <100%> (ø)` | :arrow_up: | | [src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j) | `94.44% <100%> (ø)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.24% <100%> (+0.23%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `93.04% <100%> (-0.28%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.69% <100%> (+0.39%)` | :arrow_up: | | [src/router\_config.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb25maWcuYw==) | `96.32% <100%> (+0.04%)` | :arrow_up: | | [src/router\_core/agent\_config\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2NvbmZpZ19hZGRyZXNzLmM=) | `78.11% <60%> (-0.72%)` | :arrow_down: | | [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==) | `94.64% <0%> (-1.79%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/qpid-dispatch/pull/392/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr&el=footer). Last update [9c5666f...bb4f312](https://codecov.io/gh/apache/qpid-dispatch/pull/392?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > support prioritized addresses > - > > Key: DISPATCH-1139 > URL: https://issues.apache.org/jira/browse/DISPATCH-1139 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node, Routing Engine, Tests >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > Support a new field in the address descriptor in router configuration files > that will assign a priority to the address. > Any message that does not have an intrinsic priority already assigned will > inherit the priority of the address to which it is sent. If no priority is > explicitly assigned to an address, then it will be assigned the default > priority. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --
[jira] [Commented] (DISPATCH-1139) support prioritized addresses
[ https://issues.apache.org/jira/browse/DISPATCH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655385#comment-16655385 ] ASF GitHub Bot commented on DISPATCH-1139: -- GitHub user mgoulish opened a pull request: https://github.com/apache/qpid-dispatch/pull/392 DISPATCH-1139 : address priority support and test Code that implements address-priority. Also changes things so that address priority takes precedence if present, otherwise defaults to message priority -- and messages now always have priority, defaulting to 4 if not specified. (Same as Proton default.) Also a python test that tests both message and address priority. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-1139-B Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/392.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #392 commit bb4f3121989cb4b91d4e364287868da1594f3acf Author: Michael Goulish Date: 2018-10-18T15:07:45Z DISPATCH-1139 : address priority support and test > support prioritized addresses > - > > Key: DISPATCH-1139 > URL: https://issues.apache.org/jira/browse/DISPATCH-1139 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node, Routing Engine, Tests >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > Support a new field in the address descriptor in router configuration files > that will assign a priority to the address. > Any message that does not have an intrinsic priority already assigned will > inherit the priority of the address to which it is sent. If no priority is > explicitly assigned to an address, then it will be assigned the default > priority. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
