[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734239#comment-16734239 ] ASF GitHub Bot commented on DISPATCH-1234: -- asfgit commented on pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734237#comment-16734237 ] ASF subversion and git services commented on DISPATCH-1234: --- Commit 94bbe1603322e0a686533410d740a9b72740b852 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=94bbe16 ] DISPATCH-1234 - Zero out the edge context on the link before the edge context is freed. This closes #433. > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1673#comment-1673 ] ASF GitHub Bot commented on DISPATCH-1234: -- kgiusti commented on pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089295 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c ## @@ -308,13 +316,20 @@ static void on_link_event(void *context, qdrc_event_t event, qdr_link_t *link) if (addr && qdr_address_is_mobile_CT(addr)) { qdr_addr_endpoint_state_t *endpoint_state = qdrc_get_endpoint_state_for_connection(mc->endpoint_state_list, link->conn, link); link->edge_context = endpoint_state; +endpoint_state->link = link; if (qdrc_can_send_address(addr, link->conn) && endpoint_state) { qdrc_send_message(mc->core, addr, endpoint_state->endpoint, true); } } break; } +case QDRC_EVENT_LINK_EDGE_DATA_DETACHED : +{ +link->edge_context = 0; Review comment: should the corresponding endpoint_state->link be reset also? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1674#comment-1674 ] ASF GitHub Bot commented on DISPATCH-1234: -- kgiusti commented on pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089130 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c ## @@ -237,7 +243,9 @@ static void on_addr_event(void *context, qdrc_event_t event, qdr_address_t *addr if(inlink->link->edge_context != 0) { qdr_addr_endpoint_state_t *endpoint_state = (qdr_addr_endpoint_state_t *)inlink->link->edge_context; qdrc_endpoint_t *endpoint = endpoint_state->endpoint; -qdrc_send_message(addr_tracking->core, addr, endpoint, false); +assert(endpoint != (void *)0x); Review comment: nuke me This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1671#comment-1671 ] ASF GitHub Bot commented on DISPATCH-1234: -- kgiusti commented on pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089019 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c ## @@ -134,6 +135,10 @@ static void qdrc_address_endpoint_on_first_detach(void *link_context, qdrc_endpoint_detach_CT(endpoint_state->mc->core, endpoint_state->endpoint, 0); qdr_addr_tracking_module_context_t *mc = endpoint_state->mc; DEQ_REMOVE(mc->endpoint_state_list, endpoint_state); +endpoint_state->conn = 0; +endpoint_state->endpoint = 0; +endpoint_state->link->edge_context = 0; Review comment: Can (endpoint_state->link) be null? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733296#comment-16733296 ] ASF GitHub Bot commented on DISPATCH-1234: -- codecov-io commented on issue #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#issuecomment-451225511 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@e54e0f4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/433/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #433 +/- ## = Coverage ? 86.99% = Files ? 85 Lines ?18696 Branches ?0 = Hits ?16265 Misses? 2431 Partials ?0 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/433/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `89.88% <100%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr&el=footer). Last update [e54e0f4...57c84d2](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1234) Router crash when edge tracking address handler tries to access freed endpoint
[ https://issues.apache.org/jira/browse/DISPATCH-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733282#comment-16733282 ] ASF GitHub Bot commented on DISPATCH-1234: -- ganeshmurthy commented on pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433 … context is freed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Router crash when edge tracking address handler tries to access freed endpoint > -- > > Key: DISPATCH-1234 > URL: https://issues.apache.org/jira/browse/DISPATCH-1234 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.5.0 > > > {noformat} > (gdb) bt > #0 0x04e3d53f in raise () from /lib64/libc.so.6 > #1 0x04e27895 in abort () from /lib64/libc.so.6 > #2 0x04e27769 in __assert_fail_base.cold.0 () from /lib64/libc.so.6 > #3 0x04e359f6 in __assert_fail () from /lib64/libc.so.6 > #4 0x048bc8d1 in on_addr_event (context=0x153a5e20, event=524288, > addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c:242 > #5 0x0489cbf0 in qdrc_event_addr_raise (core=0x15395d30, > event=524288, addr=0x141158f0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/core_events.c:114 > #6 0x048ac5e3 in qdr_core_unbind_address_link_CT (core=0x15395d30, > addr=0x141158f0, link=0x1410fda0) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:504 > #7 0x0489c110 in qdr_link_inbound_detach_CT (core=0x15395d30, > action=0x13c411c0, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/connections.c:1642 > #8 0x048add55 in router_core_thread (arg=0x15395d30) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:124 > #9 0x0496458e in start_thread () from /lib64/libpthread.so.0 > #10 0x04f026a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org