[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784579#comment-16784579
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 4e8de69b6c3e69caa585c679de680d223bbbe90c in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4e8de69 ]
DISPATCH-1268 - Set cmake_minimum_required to VERSION 2.8.12
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784580#comment-16784580
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 7987437dbe321a0a604767d39e8c13b180278860 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7987437 ]
DISPATCH-1268 - Use a "Generator expression" to get .so file name
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784581#comment-16784581
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 04a3ffb36e984eb13a9638e7d05872350ee44a66 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=04a3ffb ]
DISPATCH-1268 - Use find_library wherever possible
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784578#comment-16784578
]
ASF GitHub Bot commented on DISPATCH-1268:
--
jdanekrh commented on pull request #449: DISPATCH-1268 - Set
cmake_minimum_required to VERSION 2.8.12
URL: https://github.com/apache/qpid-dispatch/pull/449
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784582#comment-16784582
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 8a47be06341624aeb8f98738e24c8cc9ef7f4481 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8a47be0 ]
DISPATCH-1268 - Create cmake/RuntimeChecks.cmake to separate this configuration
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784583#comment-16784583
]
ASF subversion and git services commented on DISPATCH-1268:
---
Commit 39c7fb3e5a99045fdce5c314bd44e37f9b265191 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=39c7fb3 ]
DISPATCH-1268 - Assorted small tweaks
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784341#comment-16784341
]
ASF GitHub Bot commented on DISPATCH-1268:
--
jdanekrh commented on issue #449: DISPATCH-1268 - Set cmake_minimum_required to
VERSION 2.8.12
URL: https://github.com/apache/qpid-dispatch/pull/449#issuecomment-469646008
I'll merge this later today if no one objects. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774194#comment-16774194
]
ASF GitHub Bot commented on DISPATCH-1268:
--
jdanekrh commented on issue #449: DISPATCH-1268 - Set cmake_minimum_required to
VERSION 2.8.12
URL: https://github.com/apache/qpid-dispatch/pull/449#issuecomment-466045879
I think this is as far as I am going to go at this point. There are still
some tweaks in the original PR which I did not do here, so I might open new PR
for that, but this PR seems to me has enough changes already.
I can squash the commits if you'd like.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771852#comment-16771852
]
ASF GitHub Bot commented on DISPATCH-1268:
--
jdanekrh commented on issue #449: DISPATCH-1268 - Set cmake_minimum_required to
VERSION 2.8.12
URL: https://github.com/apache/qpid-dispatch/pull/449#issuecomment-465100589
All right, I'll try to find more useful stuff to improve, given 2.8.12
features can be used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771403#comment-16771403
]
ASF GitHub Bot commented on DISPATCH-1268:
--
ted-ross commented on issue #449: DISPATCH-1268 - Set cmake_minimum_required to
VERSION 2.8.12
URL: https://github.com/apache/qpid-dispatch/pull/449#issuecomment-464895948
I think this update is OK. The oldest downstream environment that I'm aware
of is RHEL6, which appears to use cmake 2.8.12.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770102#comment-16770102
]
ASF GitHub Bot commented on DISPATCH-1268:
--
codecov-io commented on issue #449: DISPATCH-1268 - Set cmake_minimum_required
to VERSION 2.8.12
URL: https://github.com/apache/qpid-dispatch/pull/449#issuecomment-464342878
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/449?src=pr=h1)
Report
> Merging
[#449](https://codecov.io/gh/apache/qpid-dispatch/pull/449?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/9670ce2795b4607e78299050531cb4377c1cefe8?src=pr=desc)
will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/449?src=pr=tree)
```diff
@@Coverage Diff@@
## master#449 +/- ##
=
- Coverage 86.84% 86.8% -0.05%
=
Files 85 85
Lines 18746 18746
=
- Hits16280 16272 -8
- Misses 24662474 +8
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/449?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/449/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `77.4% <0%> (-0.76%)` | :arrow_down: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/449/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `63.84% <0%> (-0.57%)` | :arrow_down: |
|
[src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/449/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
| `91.57% <0%> (-0.37%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/449/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=)
| `88.29% <0%> (-0.26%)` | :arrow_down: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/449/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `76.67% <0%> (-0.25%)` | :arrow_down: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/449?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/449?src=pr=footer).
Last update
[9670ce2...7f41347](https://codecov.io/gh/apache/qpid-dispatch/pull/449?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional
[jira] [Commented] (DISPATCH-1268) Use more modern idiomatic cmake
[
https://issues.apache.org/jira/browse/DISPATCH-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770095#comment-16770095
]
ASF GitHub Bot commented on DISPATCH-1268:
--
jdanekrh commented on pull request #449: DISPATCH-1268 - Set
cmake_minimum_required to VERSION 2.8.12
URL: https://github.com/apache/qpid-dispatch/pull/449
A lot of changes from PR #288 is compatible with CMake 2.8.12 and can
therefore still be used by the project.
This PR contains only the first change, to `cmake_minimum_required` version,
to see if there is a chance to get it in.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use more modern idiomatic cmake
> ---
>
> Key: DISPATCH-1268
> URL: https://issues.apache.org/jira/browse/DISPATCH-1268
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Jiri Daněk
>Priority: Minor
>
> Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much
> modernization is possible, even if we maintain CMake 2.8 compatibility, and
> that modernization is beneficial for overall sanity of the build code, as the
> example of Qpid Proton project shows. [2], [3]
> RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake
> {{2.8.12.2}}. Therefore, the first step would be to change minimum required
> version from {{2.6.2}} to this.
> {code}
> cmake_minimum_required(VERSION 2.8.12)
> {code}
> The indentation changes are of course harmless in any case and easy to make.
> I am not eager to bundle the whitespace change, as it is disruptive to
> merging work in progress (if git not configured to ignore whitespace).
> [1] https://github.com/apache/qpid-dispatch/pull/288
> [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake
> modularity - split out library detection code
> [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it
> uses the easier to use imported target feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
