[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection
[ https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110349#comment-17110349 ] ASF subversion and git services commented on DISPATCH-1614: --- Commit fdbe7c9ab68492c6902b60959f31371c42258aa8 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=fdbe7c9 ] DISPATCH-1614 - Raised and handled QDRC_EVENT_LINK_IN_DETACHED and QDRC_EVENT_LINK_OUT_DETACHED events where the addr's edge_inlink and edge_outlink can be zeroed out. This closes #738. > Edge router crash when interior closes edge uplink connection > - > > Key: DISPATCH-1614 > URL: https://issues.apache.org/jira/browse/DISPATCH-1614 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.11.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.12.0 > > Attachments: DISPATCH-1614-edge-router-log.txt > > > When the connection to the interior router goes down then the > addr.edge_outlink link proper is freed but the pointer to the link is still > in the addr struct. > Later when the addr is unbound the link is dereferenced causing a segfault. > An attached log trace shows the events. Search for link _0x1c31210_ using > mobile address _M0e61_. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection
[ https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110350#comment-17110350 ] ASF GitHub Bot commented on DISPATCH-1614: -- asfgit closed pull request #738: URL: https://github.com/apache/qpid-dispatch/pull/738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Edge router crash when interior closes edge uplink connection > - > > Key: DISPATCH-1614 > URL: https://issues.apache.org/jira/browse/DISPATCH-1614 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.11.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.12.0 > > Attachments: DISPATCH-1614-edge-router-log.txt > > > When the connection to the interior router goes down then the > addr.edge_outlink link proper is freed but the pointer to the link is still > in the addr struct. > Later when the addr is unbound the link is dereferenced causing a segfault. > An attached log trace shows the events. Search for link _0x1c31210_ using > mobile address _M0e61_. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection
[
https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110285#comment-17110285
]
ASF GitHub Bot commented on DISPATCH-1614:
--
ted-ross commented on a change in pull request #738:
URL: https://github.com/apache/qpid-dispatch/pull/738#discussion_r426624937
##
File path: src/router_core/modules/edge_router/addr_proxy.c
##
@@ -215,6 +215,50 @@ static void del_outlink(qcm_edge_addr_proxy_t *ap,
qdr_address_t *addr)
}
}
+static void on_link_event(void *context, qdrc_event_t event, qdr_link_t *link)
+{
+if (!link || !link->conn)
+return;
+
+//
+// We only care if the link event is on an edge connection.
+//
+if (link->conn->role != QDR_ROLE_EDGE_CONNECTION)
+return;
+
+switch (event) {
+case QDRC_EVENT_LINK_OUT_DETACHED: {
+qdr_address_t *addr = link->owning_addr;
+if (addr && addr->edge_outlink && link == addr->edge_outlink) {
Review comment:
The second condition in the if is technically not necessary.
edge_outlink is never dereferenced, only compared.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Edge router crash when interior closes edge uplink connection
> -
>
> Key: DISPATCH-1614
> URL: https://issues.apache.org/jira/browse/DISPATCH-1614
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.11.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.12.0
>
> Attachments: DISPATCH-1614-edge-router-log.txt
>
>
> When the connection to the interior router goes down then the
> addr.edge_outlink link proper is freed but the pointer to the link is still
> in the addr struct.
> Later when the addr is unbound the link is dereferenced causing a segfault.
> An attached log trace shows the events. Search for link _0x1c31210_ using
> mobile address _M0e61_.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection
[ https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108650#comment-17108650 ] ASF GitHub Bot commented on DISPATCH-1614: -- ganeshmurthy opened a new pull request #738: URL: https://github.com/apache/qpid-dispatch/pull/738 …RC_EVENT_LINK_OUT_DETACHED events where the addr's edge_inlink and edge_outlink can be zeroed out This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Edge router crash when interior closes edge uplink connection > - > > Key: DISPATCH-1614 > URL: https://issues.apache.org/jira/browse/DISPATCH-1614 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.11.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.12.0 > > Attachments: DISPATCH-1614-edge-router-log.txt > > > When the connection to the interior router goes down then the > addr.edge_outlink link proper is freed but the pointer to the link is still > in the addr struct. > Later when the addr is unbound the link is dereferenced causing a segfault. > An attached log trace shows the events. Search for link _0x1c31210_ using > mobile address _M0e61_. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection
[ https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076661#comment-17076661 ] ASF GitHub Bot commented on DISPATCH-1614: -- asfgit commented on pull request #714: DISPATCH-1614: Nullify address inlink and outlink when connection lost URL: https://github.com/apache/qpid-dispatch/pull/714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Edge router crash when interior closes edge uplink connection > - > > Key: DISPATCH-1614 > URL: https://issues.apache.org/jira/browse/DISPATCH-1614 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.11.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Attachments: DISPATCH-1614-edge-router-log.txt > > > When the connection to the interior router goes down then the > addr.edge_outlink link proper is freed but the pointer to the link is still > in the addr struct. > Later when the addr is unbound the link is dereferenced causing a segfault. > An attached log trace shows the events. Search for link _0x1c31210_ using > mobile address _M0e61_. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection
[ https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076660#comment-17076660 ] ASF subversion and git services commented on DISPATCH-1614: --- Commit fbba3554db0a20e993865ba25a17ae0295cb3911 in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=fbba355 ] DISPATCH-1614: Nullify address inlink and outlink when connection lost Prevent segfault referencing deleted links when connection is lost. Assert that the pointers are null when a connection is created. This closes #714 > Edge router crash when interior closes edge uplink connection > - > > Key: DISPATCH-1614 > URL: https://issues.apache.org/jira/browse/DISPATCH-1614 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.11.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Attachments: DISPATCH-1614-edge-router-log.txt > > > When the connection to the interior router goes down then the > addr.edge_outlink link proper is freed but the pointer to the link is still > in the addr struct. > Later when the addr is unbound the link is dereferenced causing a segfault. > An attached log trace shows the events. Search for link _0x1c31210_ using > mobile address _M0e61_. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection
[ https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076591#comment-17076591 ] ASF GitHub Bot commented on DISPATCH-1614: -- ChugR commented on pull request #714: DISPATCH-1614: Nullify address inlink and outlink when connection lost URL: https://github.com/apache/qpid-dispatch/pull/714 Prevent segfault referencing deleted links when connection is lost. Assert that the pointers are null when a connection is created. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Edge router crash when interior closes edge uplink connection > - > > Key: DISPATCH-1614 > URL: https://issues.apache.org/jira/browse/DISPATCH-1614 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.11.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Attachments: DISPATCH-1614-edge-router-log.txt > > > When the connection to the interior router goes down then the > addr.edge_outlink link proper is freed but the pointer to the link is still > in the addr struct. > Later when the addr is unbound the link is dereferenced causing a segfault. > An attached log trace shows the events. Search for link _0x1c31210_ using > mobile address _M0e61_. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1614) Edge router crash when interior closes edge uplink connection
[
https://issues.apache.org/jira/browse/DISPATCH-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075830#comment-17075830
]
Charles E. Rolke commented on DISPATCH-1614:
The suspected root cause is having the addr_event (and the consequent
del_outlink) executing before the AMQP_close_handler executes. The close
handler has the opportunity to clean up the addr link pointers so that the
del_outlink won't try to use them.
{{08:54:47.628115 -0400 qdrc_event_addr_raise(): core:0x10e3db0,
event:0020, addr:0x1116990, address:M0e61 }}
{{08:54:47.628128 -0400 on_addr_event():
context-qcm_edge_addr_proxy:0x10f7a10, event:0020, addr:0x1116990,
address:M0e61 }}
{{08:54:47.628140 -0400 del_outlink(): ap:0x10f7a10, addr:0x1116990,
edge_outlink:0x11f7190, address:M0e61 }}
{{08:54:47.628152 -0400 qdr_core_unbind_address_link_CT(): core:0x10e3db0,
addr:0x1116990, link:0x11f7190, address:M0e61, direction:incoming }}
{{08:54:47.628218 -0400 AMQP_closed_handler: type_context:0x10c9350,
conn:0x1269ad0 context:0x13b3bd0, qdrc:0x13b3bd0}}
{{08:54:47.628285 -0400 qdr_del_link_ref(): ref_list:0x1116a08,
link:0x11f7190, cls:0}}
{{08:54:47.628327 -0400 [C5] Connection '127.0.0.1:58382' closed with
resources n_sessions=1, n_senders=0, n_receivers=0, sessions_denied=0,
senders_denied=0, receivers_denied=0. nConnections= 0.}}
> Edge router crash when interior closes edge uplink connection
> -
>
> Key: DISPATCH-1614
> URL: https://issues.apache.org/jira/browse/DISPATCH-1614
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.11.0
>Reporter: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1614-edge-router-log.txt
>
>
> When the connection to the interior router goes down then the
> addr.edge_outlink link proper is freed but the pointer to the link is still
> in the addr struct.
> Later when the addr is unbound the link is dereferenced causing a segfault.
> An attached log trace shows the events. Search for link _0x1c31210_ using
> mobile address _M0e61_.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
