[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[ https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474783#comment-17474783 ] ASF GitHub Bot commented on DISPATCH-2305: -- asfgit closed pull request #1475: URL: https://github.com/apache/qpid-dispatch/pull/1475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > policy code overrides configured connection settings by default > --- > > Key: DISPATCH-2305 > URL: https://issues.apache.org/jira/browse/DISPATCH-2305 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > The following connection/settings attributes may be configured via > management/configuration file: > * maxFrameSize > * maxSessions > * maxSessionFrames (session window). > These attributes may also be configured via policy. The policy configuration > takes precedence. > If a policy is configured but does *not specify* override values for any of > the above attributes, one would expect any existing configured values would > take effect. > However this is not the case. If you set values for the above attributes in > the router config file, and you define a matching policy that does not > override these values, the policy will overwrite your configured values with > what policy thinks is the default value -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[ https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474782#comment-17474782 ] ASF subversion and git services commented on DISPATCH-2305: --- Commit 759aa173e440b139a7b6e05314e37b7f39d24d69 in qpid-dispatch's branch refs/heads/main from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=759aa17 ] DISPATCH-2305: prevent policy defaults overriding configuration This closes #1475 > policy code overrides configured connection settings by default > --- > > Key: DISPATCH-2305 > URL: https://issues.apache.org/jira/browse/DISPATCH-2305 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > > The following connection/settings attributes may be configured via > management/configuration file: > * maxFrameSize > * maxSessions > * maxSessionFrames (session window). > These attributes may also be configured via policy. The policy configuration > takes precedence. > If a policy is configured but does *not specify* override values for any of > the above attributes, one would expect any existing configured values would > take effect. > However this is not the case. If you set values for the above attributes in > the router config file, and you define a matching policy that does not > override these values, the policy will overwrite your configured values with > what policy thinks is the default value -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[
https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472107#comment-17472107
]
ASF GitHub Bot commented on DISPATCH-2305:
--
ganeshmurthy commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781301201
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
-"default": 16384,
Review comment:
Good point. I did notice that maxSessionWindow is defaulted to 1638400
in vhostUserGroupSettings and is not "directly" specified anywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> policy code overrides configured connection settings by default
> ---
>
> Key: DISPATCH-2305
> URL: https://issues.apache.org/jira/browse/DISPATCH-2305
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.18.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>
> The following connection/settings attributes may be configured via
> management/configuration file:
> * maxFrameSize
> * maxSessions
> * maxSessionFrames (session window).
> These attributes may also be configured via policy. The policy configuration
> takes precedence.
> If a policy is configured but does *not specify* override values for any of
> the above attributes, one would expect any existing configured values would
> take effect.
> However this is not the case. If you set values for the above attributes in
> the router config file, and you define a matching policy that does not
> override these values, the policy will overwrite your configured values with
> what policy thinks is the default value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[
https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472100#comment-17472100
]
ASF GitHub Bot commented on DISPATCH-2305:
--
kgiusti commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781286944
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
-"default": 16384,
Review comment:
Why have two sets of defaults then (one in the entity's definition in
the schema [e.g. listener], and one in the policy)? My point is defining a
policy should not force another set of defaults when the entity itself defines
its defaults.
Otherwise we're maintaining two sets of defaults which need to be kept in
sync else we trigger this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> policy code overrides configured connection settings by default
> ---
>
> Key: DISPATCH-2305
> URL: https://issues.apache.org/jira/browse/DISPATCH-2305
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.18.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>
> The following connection/settings attributes may be configured via
> management/configuration file:
> * maxFrameSize
> * maxSessions
> * maxSessionFrames (session window).
> These attributes may also be configured via policy. The policy configuration
> takes precedence.
> If a policy is configured but does *not specify* override values for any of
> the above attributes, one would expect any existing configured values would
> take effect.
> However this is not the case. If you set values for the above attributes in
> the router config file, and you define a matching policy that does not
> override these values, the policy will overwrite your configured values with
> what policy thinks is the default value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[
https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472086#comment-17472086
]
ASF GitHub Bot commented on DISPATCH-2305:
--
ganeshmurthy commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781266132
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
-"default": 16384,
Review comment:
Bear with me here but when I look at this from a layman's perspective, I
like seeing the defaults in the json schema and this PR seems to remove the
defaults from the schema. Is there a way that these defaults can be still there
and if the policy does not overide these values, the defaults can be used? Is
that too much work from the policy side ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> policy code overrides configured connection settings by default
> ---
>
> Key: DISPATCH-2305
> URL: https://issues.apache.org/jira/browse/DISPATCH-2305
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.18.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>
> The following connection/settings attributes may be configured via
> management/configuration file:
> * maxFrameSize
> * maxSessions
> * maxSessionFrames (session window).
> These attributes may also be configured via policy. The policy configuration
> takes precedence.
> If a policy is configured but does *not specify* override values for any of
> the above attributes, one would expect any existing configured values would
> take effect.
> However this is not the case. If you set values for the above attributes in
> the router config file, and you define a matching policy that does not
> override these values, the policy will overwrite your configured values with
> what policy thinks is the default value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[ https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471073#comment-17471073 ] ASF GitHub Bot commented on DISPATCH-2305: -- codecov-commenter commented on pull request #1475: URL: https://github.com/apache/qpid-dispatch/pull/1475#issuecomment-1007866706 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1475?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1475](https://codecov.io/gh/apache/qpid-dispatch/pull/1475?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (130f4b6) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/6cb1fd4d783dcdb2841d81545cce421a1773ad81?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6cb1fd4) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1475 +/- ## == + Coverage 84.76% 84.79% +0.02% == Files 116 116 Lines 2863628635 -1 == + Hits2427424280 +6 + Misses 4362 4355 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.21% <0.00%> (-0.28%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.10% <0.00%> (-0.11%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.45% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.23% <0.00%> (+0.09%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.63% <0.00%> (+0.16%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `86.01% <0.00%> (+0.27%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.71% <0.00%> (+0.42%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_s
[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[ https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470976#comment-17470976 ] ASF GitHub Bot commented on DISPATCH-2305: -- codecov-commenter commented on pull request #1475: URL: https://github.com/apache/qpid-dispatch/pull/1475#issuecomment-1007866706 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1475?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1475](https://codecov.io/gh/apache/qpid-dispatch/pull/1475?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (130f4b6) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/6cb1fd4d783dcdb2841d81545cce421a1773ad81?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6cb1fd4) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1475 +/- ## == + Coverage 84.76% 84.79% +0.02% == Files 116 116 Lines 2863628635 -1 == + Hits2427424280 +6 + Misses 4362 4355 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.21% <0.00%> (-0.28%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.10% <0.00%> (-0.11%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.45% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.23% <0.00%> (+0.09%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.63% <0.00%> (+0.16%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `86.01% <0.00%> (+0.27%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.46% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.71% <0.00%> (+0.42%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1475/diff?src=pr&el=tree&utm_medium=referral&utm_s
