[jira] [Commented] (DISPATCH-977) Document transaction support

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538740#comment-16538740
 ] 

ASF subversion and git services commented on DISPATCH-977:
--

Commit 3938487f849d86bb0ac8250f0af9be9d1d95965c in qpid-dispatch's branch 
refs/heads/master from [~bhardest]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=3938487 ]

DISPATCH-977 - Add transaction coordinator step to link routing procedure. This 
closes #293


> Document transaction support
> 
>
> Key: DISPATCH-977
> URL: https://issues.apache.org/jira/browse/DISPATCH-977
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
> Fix For: 1.3.0
>
>
> Dispatch Router provides transaction support through link routes and 
> $coordinator. This capability should be documented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-977) Document transaction support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538742#comment-16538742
 ] 

ASF GitHub Bot commented on DISPATCH-977:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/293


> Document transaction support
> 
>
> Key: DISPATCH-977
> URL: https://issues.apache.org/jira/browse/DISPATCH-977
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
> Fix For: 1.3.0
>
>
> Dispatch Router provides transaction support through link routes and 
> $coordinator. This capability should be documented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-977) Document transaction support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469453#comment-16469453
 ] 

ASF GitHub Bot commented on DISPATCH-977:
-

Github user fgiorgetti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/293
  
Looks good to me. I have created a simple scenario to validate the 
coordinator, as described in the doc, and it worked just fine. The final doc 
looks good as well.


> Document transaction support
> 
>
> Key: DISPATCH-977
> URL: https://issues.apache.org/jira/browse/DISPATCH-977
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
>
> Dispatch Router provides transaction support through link routes and 
> $coordinator. This capability should be documented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-977) Document transaction support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452605#comment-16452605
 ] 

ASF GitHub Bot commented on DISPATCH-977:
-

Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/293#discussion_r184128463
  
--- Diff: doc/new-book/routing.adoc ---
@@ -575,6 +575,20 @@ connector {
 For information about additional attributes, see 
link:{qdrouterdConfManPageUrl}#_connector[connector] in the `qdrouterd.conf` 
man page.
 --
 
+. If you want clients to send local transactions to the broker, create a 
link route for the transaction coordinator:
--- End diff --

One thing I think needs to be clear is that routing the coordinator really 
only works if there is only one broker with which any transactional 
interactions are undertaken.


> Document transaction support
> 
>
> Key: DISPATCH-977
> URL: https://issues.apache.org/jira/browse/DISPATCH-977
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
>
> Dispatch Router provides transaction support through link routes and 
> $coordinator. This capability should be documented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-977) Document transaction support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452604#comment-16452604
 ] 

ASF GitHub Bot commented on DISPATCH-977:
-

Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/293#discussion_r184127780
  
--- Diff: doc/new-book/routing.adoc ---
@@ -575,6 +575,20 @@ connector {
 For information about additional attributes, see 
link:{qdrouterdConfManPageUrl}#_connector[connector] in the `qdrouterd.conf` 
man page.
 --
 
+. If you want clients to send local transactions to the broker, create a 
link route for the transaction coordinator:
++
+--
+[options="nowrap",subs="+quotes"]
+
+linkRoute {
+prefix: $coordinator  <1>
+connection: __CONNECTOR_NAME__
+direction: in
+}
+
+<1> The `$coordinator` prefix designates this link route as a transaction 
coordinator. When the client opens a transacted session, the transactional 
state is propagated along this link route to the broker.
--- End diff --

The coordinator link is used for declaring and completing (committing or 
rolling back) the transactions. In the AMQP spec, the term 'transactional 
state' is used to tie the publication and consumption of messages to a given 
transaction, and is part of the transfer or disposition - loosely the message 
or its acknowledgement - which do not go over the coordinator link.

Perhaps it would be less (potentially) confusing to change from 'the 
transactional state is propagated along this link route to the broker' to 
'requests to start or end a transaction are propagated along this link route to 
the broker.' ??


> Document transaction support
> 
>
> Key: DISPATCH-977
> URL: https://issues.apache.org/jira/browse/DISPATCH-977
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
>
> Dispatch Router provides transaction support through link routes and 
> $coordinator. This capability should be documented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-977) Document transaction support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452555#comment-16452555
 ] 

ASF GitHub Bot commented on DISPATCH-977:
-

Github user bhardesty commented on the issue:

https://github.com/apache/qpid-dispatch/pull/293
  
@grs could you please review this doc update for technical accuracy? This 
just adds an additional step to the procedure for creating a link route (to 
optionally configure the link route to support transacted messages).


> Document transaction support
> 
>
> Key: DISPATCH-977
> URL: https://issues.apache.org/jira/browse/DISPATCH-977
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
>
> Dispatch Router provides transaction support through link routes and 
> $coordinator. This capability should be documented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-977) Document transaction support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452529#comment-16452529
 ] 

ASF GitHub Bot commented on DISPATCH-977:
-

GitHub user bhardesty opened a pull request:

https://github.com/apache/qpid-dispatch/pull/293

DISPATCH-977: Add transaction coordinator step to link routing procedure

The Dispatch Router doc mentions that you can use link routing for 
transactions, but it didn't describe how to configure this. 

This doc update describes how to configure a link route that supports 
transactions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bhardesty/qpid-dispatch 
dispatch-977-doc-transaction-support

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #293


commit 3d20e9ed9cbf0011b24caabc74a24839613a47dc
Author: Ben Hardesty 
Date:   2018-04-24T21:18:58Z

Add transaction coordinator step to link routing procedure




> Document transaction support
> 
>
> Key: DISPATCH-977
> URL: https://issues.apache.org/jira/browse/DISPATCH-977
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
>
> Dispatch Router provides transaction support through link routes and 
> $coordinator. This capability should be documented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org