[jira] [Commented] (PROTON-1258) No transport_close event is generated on the listening side of the connection

2016-07-15 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380091#comment-15380091
 ] 

ASF subversion and git services commented on PROTON-1258:
-

Commit 35f425bc40b3e4ede43d65cd4d7e9ecd98b0a58a in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=35f425b ]

PROTON-1258: Make transport events more consistent on client and server
- This is almost the same as 4a601011 but with some review fixes from
  acon...@redhat.com


> No transport_close event is generated on the listening side of the connection
> -
>
> Key: PROTON-1258
> URL: https://issues.apache.org/jira/browse/PROTON-1258
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.13.0
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
> Fix For: 0.14.0
>
>
> Transport event handling is inconsistent between the listening and connecting 
> sides of an AMQP connection:
> On the client the transport events happen as they should - you always get 
> transport_open an optional transport_error and transport_close.
> On the server you get the transport_open, but no transport_close. However if 
> the connection is interrupted for some reason (say the socket disconnects) 
> then you will transport_error, followed by transport_close.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1258) No transport_close event is generated on the listening side of the connection

2016-07-15 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379855#comment-15379855
 ] 

ASF subversion and git services commented on PROTON-1258:
-

Commit 27f296ccdcbf720e03eee9e99ec88116887fc817 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=27f296c ]

Revert "PROTON-1258: Make transport events more consistent on client and server"

This reverts commit 4a6010110296846e3c77defc0558a45d8792d3b5.

This commit crashes the cpp_mt_example_test in a release build (but not in a
debug or reldbg build which is worth investigating separtely)

The connection engine relies on the events generated by correct use of
pn_transport_t. PROTON-1258 is a reactor bug: the reactor needs to be fixed to
close the transport correctly, before unbinding it, so that it can generate the
proper close events in the proper sequence. The handler should not be involved.


> No transport_close event is generated on the listening side of the connection
> -
>
> Key: PROTON-1258
> URL: https://issues.apache.org/jira/browse/PROTON-1258
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.13.0
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
> Fix For: 0.14.0
>
>
> Transport event handling is inconsistent between the listening and connecting 
> sides of an AMQP connection:
> On the client the transport events happen as they should - you always get 
> transport_open an optional transport_error and transport_close.
> On the server you get the transport_open, but no transport_close. However if 
> the connection is interrupted for some reason (say the socket disconnects) 
> then you will transport_error, followed by transport_close.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1258) No transport_close event is generated on the listening side of the connection

2016-07-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378222#comment-15378222
 ] 

ASF subversion and git services commented on PROTON-1258:
-

Commit 4a6010110296846e3c77defc0558a45d8792d3b5 in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4a60101 ]

PROTON-1258: Make transport events more consistent on client and server


> No transport_close event is generated on the listening side of the connection
> -
>
> Key: PROTON-1258
> URL: https://issues.apache.org/jira/browse/PROTON-1258
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.13.0
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>
> Transport event handling is inconsistent between the listening and connecting 
> sides of an AMQP connection:
> On the client the transport events happen as they should - you always get 
> transport_open an optional transport_error and transport_close.
> On the server you get the transport_open, but no transport_close. However if 
> the connection is interrupted for some reason (say the socket disconnects) 
> then you will transport_error, followed by transport_close.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org