[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[Jiri Danek (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139843#comment-16139843
 ] 

Jiri Danek commented on PROTON-1375:


The second problem was since removed in a commit related to PROTON-1288: c++ 
provide convenient access to message/filter maps. Compilation works for me, 
even with 6.0 snapshot. So I guess we are good on this front.

> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
> Fix For: proton-c-0.18.0
>
>
> The following warnings prevent me from compiling proton-c with clang 4.0 
> snaphot
> # (/) /qpid-proton-fuzz/proton-c/src/tests/object.c:60:16: error: passing an 
> object that undergoes default argument promotion to 'va_start' has undefined 
> behavior
> # (x) 
> /test/qpid-proton/proton-c/bindings/cpp/include/proton/message.hpp:51:11: 
> error: instantiation of function
>   'proton::internal::cached_map proton::scalar>::cached_map' required here, but no definition is
> see complete error messages in comments below



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796322#comment-15796322
 ] 

ASF subversion and git services commented on PROTON-1375:
-

Commit 79d06f0705a973a00fc66283462fa12ad729a708 in qpid-proton's branch 
refs/heads/go1 from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=79d06f0 ]

PROTON-1375: Don't use default promoted parameter to va_start


> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
> Fix For: 0.17.0
>
>
> The following warnings prevent me from compiling proton-c with clang 4.0 
> snaphot
> # (/) /qpid-proton-fuzz/proton-c/src/tests/object.c:60:16: error: passing an 
> object that undergoes default argument promotion to 'va_start' has undefined 
> behavior
> # (x) 
> /test/qpid-proton/proton-c/bindings/cpp/include/proton/message.hpp:51:11: 
> error: instantiation of function
>   'proton::internal::cached_map proton::scalar>::cached_map' required here, but no definition is
> see complete error messages in comments below



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[Jiri Danek (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15750892#comment-15750892
 ] 

Jiri Danek commented on PROTON-1375:


I reported this to Clang Bugzilla and I was told that the warning is correct. I 
do not understand the intricacies of C++ well enough to judge. Here is the 
Bugzilla link, https://llvm.org/bugs/show_bug.cgi?id=31379.

> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
>  Labels: patch
> Fix For: 0.17.0
>
>
> A new warning in clang is causing proton-c compilation to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[Jiri Danek (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15750889#comment-15750889
 ] 

Jiri Danek commented on PROTON-1375:


I consider this sub-issue closed. Thanks for fixing.

> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
>  Labels: patch
> Fix For: 0.17.0
>
>
> A new warning in clang is causing proton-c compilation to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749346#comment-15749346
 ] 

ASF subversion and git services commented on PROTON-1375:
-

Commit 79d06f0705a973a00fc66283462fa12ad729a708 in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=79d06f0 ]

PROTON-1375: Don't use default promoted parameter to va_start


> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
>  Labels: patch
> Fix For: 0.17.0
>
>
> A new warning in clang is causing proton-c compilation to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749355#comment-15749355
 ] 

ASF GitHub Bot commented on PROTON-1375:


Github user astitcher commented on the issue:

https://github.com/apache/qpid-proton/pull/91
  
This PR should be fixed by 79d06f07


> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
>  Labels: patch
> Fix For: 0.17.0
>
>
> A new warning in clang is causing proton-c compilation to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749350#comment-15749350
 ] 

ASF GitHub Bot commented on PROTON-1375:


Github user jdanekrh closed the pull request at:

https://github.com/apache/qpid-proton/pull/91


> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
>  Labels: patch
> Fix For: 0.17.0
>
>
> A new warning in clang is causing proton-c compilation to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[Andrew Stitcher (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749253#comment-15749253
 ] 

Andrew Stitcher commented on PROTON-1375:
-

This annoying, because your fix adds in a double -> float narrowing conversion.

I think a better fix is to swap the capacity and load_factor parameters and to 
fix up the callers (this is test only code so that's fine I think).

> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
>  Labels: patch
> Fix For: 0.17.0
>
>
> A new warning in clang is causing proton-c compilation to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[Andrew Stitcher (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749247#comment-15749247
 ] 

Andrew Stitcher commented on PROTON-1375:
-

Is clang-4.0 released yet? This looks like a compiler warning error:

- The line cached_map.hpp:59 is actually in the middle of the definition of 
cached_map. so there is a definition available as far as I can tell.

- There actually is a forward declaration in the file at cached_map.hpp:47 
(before the definition)

It is possible that there is a subtle problem with instantiating cached_map, 
but presently I think that gcc is correct.

> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
>  Labels: patch
> Fix For: 0.17.0
>
>
> A new warning in clang is causing proton-c compilation to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15738139#comment-15738139
 ] 

ASF GitHub Bot commented on PROTON-1375:


GitHub user jdanekrh opened a pull request:

https://github.com/apache/qpid-proton/pull/91

PROTON-1375: add explicit cast to avoid clang 4.0 warning



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rh-messaging-qe/qpid-proton PROTON-1375

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit 199fd64344d6253ea930f6fb236f29bde633014b
Author: Jiri Danek 
Date:   2016-12-10T16:31:54Z

PROTON-1375: add explicit cast to avoid clang 4.0 warning




> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
> Environment: Debian Jessie. Install latest clang 4.0 snapshot from 
> http://apt.llvm.org/.
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
>
> A new warning in clang is causing proton-c compilation to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1375) Compile without warnings under clang 4.0

[Jiri Danek (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15738101#comment-15738101
 ] 

Jiri Danek commented on PROTON-1375:


{noformat}
[ 93%] Building C object 
proton-c/src/tests/CMakeFiles/c-object-tests.dir/object.c.o
/qpid-proton-fuzz/proton-c/src/tests/object.c:60:16: error: passing an object 
that undergoes default argument promotion to 'va_start' has undefined behavior 
[-Werror,-Wvarargs]
  va_start(ap, load_factor);
   ^
/qpid-proton-fuzz/proton-c/src/tests/object.c:53:51: note: parameter of type 
'float' is declared here
static pn_map_t *build_map(size_t capacity, float load_factor, ...)
  ^
1 error generated.
{noformat}

> Compile without warnings under clang 4.0
> 
>
> Key: PROTON-1375
> URL: https://issues.apache.org/jira/browse/PROTON-1375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Reporter: Jiri Danek
>Assignee: Andrew Stitcher
>Priority: Minor
> Fix For: 0.14.0
>
>
> A new warning in clang "implicit conversion increases floating-point 
> precision: 'float' to 'double' [-Werror,-Wdouble-promotion]" trips up on some 
> c++ binding code. We should fix this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org