[jira] [Commented] (PROTON-1538) Epoll proactor unguarded memory access
[ https://issues.apache.org/jira/browse/PROTON-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137652#comment-16137652 ] Justin Ross commented on PROTON-1538: - [~cliffjansen], is this still open? > Epoll proactor unguarded memory access > -- > > Key: PROTON-1538 > URL: https://issues.apache.org/jira/browse/PROTON-1538 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.18.0 >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: proton-c-0.18.0 > > > ThreadSanitizer singled out the epoll_event for network sockets to be a risk > of out of order access by multiple threads. > On inspection it is possible that two threads could try rearming the socket > out of order, allowing the wrong events of interest to be registered. > Reusing the existing connection context mutex would be costly for > guarding this since the system call is frequent and relatively long > compared to other acquisitions of the mutex. Adding a new mutex that > guards this operation should fix things with negligible performance > cost. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1538) Epoll proactor unguarded memory access
[ https://issues.apache.org/jira/browse/PROTON-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123743#comment-16123743 ] ASF subversion and git services commented on PROTON-1538: - Commit 79309b030476f4957f7d8f360d2224ee0850e006 in qpid-proton's branch refs/heads/master from Clifford Jansen [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=79309b0 ] PROTON-1538: epoll proactor - prevent out of order rearming of connection file descriptor > Epoll proactor unguarded memory access > -- > > Key: PROTON-1538 > URL: https://issues.apache.org/jira/browse/PROTON-1538 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.18.0 >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: proton-j-0.18.0 > > > ThreadSanitizer singled out the epoll_event for network sockets to be a risk > of out of order access by multiple threads. > On inspection it is possible that two threads could try rearming the socket > out of order, allowing the wrong events of interest to be registered. > Reusing the existing connection context mutex would be costly for > guarding this since the system call is frequent and relatively long > compared to other acquisitions of the mutex. Adding a new mutex that > guards this operation should fix things with negligible performance > cost. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
